Re: [i-g-t,v3,1/5] lib/igt_sysfs: Usage of Original debug mask to read/reset

["Joshi, Kunal1" <kunal1.joshi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2155 bytes --]

Hello Pranay,

Please find comments inline,

On 01-04-2025 14:50, Pranay Samala wrote:
> Original debug mask holds the mask before the test and will be
> used to reset the debug mask post test.
>
> Fixes: 56b91193b825 ("lib/igt_sysfs: Implement dynamic adjustment of debug log level")
> Signed-off-by: Pranay Samala<pranay.samala@intel.com>
> ---
>   lib/igt_sysfs.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
> index 2e4c2ee63..9643aab43 100644
> --- a/lib/igt_sysfs.c
> +++ b/lib/igt_sysfs.c
> @@ -443,7 +443,7 @@ int igt_sysfs_drm_module_params_open(void)
>   	return open(path, O_RDONLY);
>   }
>   
> -static int log_level = -1;
> +static int original_debug_mask = -1;
>   
>   /**
>    * igt_drm_debug_level_get:
> @@ -458,8 +458,8 @@ int igt_drm_debug_level_get(int dir)
>   {
>   	char buf[20];
>   
> -	if (log_level >= 0)
> -		return log_level;
> +	if (original_debug_mask >= 0)
> +		return original_debug_mask;
Rename original_debug_mask to saved_drm_debug_mask for clarity that it's 
saved to be restored later.
>   
>   	if (igt_sysfs_read(dir, "debug", buf, sizeof(buf) - 1) < 0)
>   		return -1;
> @@ -479,15 +479,15 @@ void igt_drm_debug_level_reset(void)
>   	char buf[20];
>   	int dir;
>   
> -	if (log_level < 0)
> +	if (original_debug_mask < 0)
>   		return;
>   
>   	dir = igt_sysfs_drm_module_params_open();
>   	if (dir < 0)
>   		return;
>   
> -	igt_debug("Resetting DRM debug level to %d\n", log_level);
> -	snprintf(buf, sizeof(buf), "%d", log_level);
> +	igt_debug("Resetting DRM debug level to %d\n", original_debug_mask);

Change level to mask in igt_info


Thanks and Regards
Kunal Joshi

> +	snprintf(buf, sizeof(buf), "%d", original_debug_mask);
>   	igt_assert(igt_sysfs_set(dir, "debug", buf));
>   
>   	close(dir);
> @@ -513,8 +513,8 @@ void igt_drm_debug_level_update(unsigned int new_log_level)
>   	if (dir < 0)
>   		return;
>   
> -	log_level = igt_drm_debug_level_get(dir);
> -	if (log_level < 0) {
> +	original_debug_mask = igt_drm_debug_level_get(dir);
> +	if (original_debug_mask < 0) {
>   		close(dir);
>   		return;
>   	}

[-- Attachment #2: Type: text/html, Size: 2759 bytes --]