Re: [i-g-t,v3,2/5] lib/igt_sysfs: Rename debug level APIs/variables to debug mask

["Joshi, Kunal1" <kunal1.joshi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3995 bytes --]

Hello Pranay,

Please find comments inline,

On 01-04-2025 14:50, Pranay Samala wrote:
> The debug log mask is a mask rather than level. Rename each level
> occurance to mask.
>
> Fixes: 56b91193b825 ("lib/igt_sysfs: Implement dynamic adjustment of debug log level")
> Signed-off-by: Pranay Samala<pranay.samala@intel.com>
> ---
>   lib/igt_sysfs.c | 32 ++++++++++++++++----------------
>   lib/igt_sysfs.h |  6 +++---
>   2 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
> index 9643aab43..e6058a1dd 100644
> --- a/lib/igt_sysfs.c
> +++ b/lib/igt_sysfs.c
> @@ -446,15 +446,15 @@ int igt_sysfs_drm_module_params_open(void)
>   static int original_debug_mask = -1;
>   
>   /**
> - * igt_drm_debug_level_get:
> + * igt_drm_debug_mask_get:
>    *
> - * This reads the current debug log level of the machine on
> + * This reads the current debug mask of the machine on
>    * which the test is currently executing.
>    *
>    * Returns:
> - * The current log level, or -1 on error.
> + * The current debug mask, or -1 on error.
>    */
> -int igt_drm_debug_level_get(int dir)
> +int igt_drm_debug_mask_get(int dir)
>   {
>   	char buf[20];
>   
> @@ -468,13 +468,13 @@ int igt_drm_debug_level_get(int dir)
>   }
>   
>   /**
> - * igt_drm_debug_level_reset:
> + * igt_drm_debug_mask_reset:
>    *
> - * This modifies the current debug log level of the machine
> + * This modifies the current debug mask of the machine
>    * to the default value post-test.
>    *
>    */
> -void igt_drm_debug_level_reset(void)
> +void igt_drm_debug_mask_reset(void)
>   {
>   	char buf[20];
>   	int dir;
> @@ -486,25 +486,25 @@ void igt_drm_debug_level_reset(void)
>   	if (dir < 0)
>   		return;
>   
> -	igt_debug("Resetting DRM debug level to %d\n", original_debug_mask);
> +	igt_debug("Resetting DRM debug mask to %d\n", original_debug_mask);
>   	snprintf(buf, sizeof(buf), "%d", original_debug_mask);
>   	igt_assert(igt_sysfs_set(dir, "debug", buf));
>   
>   	close(dir);
>   }
>   
> -static void igt_drm_debug_level_reset_exit_handler(int sig)
> +static void igt_drm_debug_mask_reset_exit_handler(int sig)
>   {
> -	igt_drm_debug_level_reset();
> +	igt_drm_debug_mask_reset();
>   }
>   
>   /**
> - * igt_drm_debug_level_update:
> - * @debug_level: new debug level to set
> + * igt_drm_debug_mask_update:
> + * @debug_level: new debug mask to set
Rename to mask,
>    *
> - * This modifies the current drm debug log level to the new value.
> + * This modifies the current drm debug mask to the new value.
>    */
> -void igt_drm_debug_level_update(unsigned int new_log_level)
> +void igt_drm_debug_mask_update(unsigned int new_log_level)
Rename new_log_level to |new_debug_mask| or |requested_debug_mask|
>   {
>   	char buf[20];
>   	int dir;
> @@ -513,13 +513,13 @@ void igt_drm_debug_level_update(unsigned int new_log_level)
>   	if (dir < 0)
>   		return;
>   
> -	original_debug_mask = igt_drm_debug_level_get(dir);
> +	original_debug_mask = igt_drm_debug_mask_get(dir);
>   	if (original_debug_mask < 0) {
>   		close(dir);
>   		return;
>   	}
>   
> -	igt_debug("Setting DRM debug level to %d\n", new_log_level);
> +	igt_debug("Setting DRM debug mask to %d\n", new_log_level);
>   	snprintf(buf, sizeof(buf), "%d", new_log_level);
>   	igt_assert(igt_sysfs_set(dir, "debug", buf));
>   
> diff --git a/lib/igt_sysfs.h b/lib/igt_sysfs.h
> index 86345f3d1..2f4d25bf6 100644
> --- a/lib/igt_sysfs.h
> +++ b/lib/igt_sysfs.h
> @@ -143,9 +143,9 @@ void igt_sysfs_set_boolean(int dir, const char *attr, bool value);
>   void bind_fbcon(bool enable);
>   void fbcon_blink_enable(bool enable);
>   
> -void igt_drm_debug_level_update(unsigned int new_log_level);
> -void igt_drm_debug_level_reset(void);
> -int igt_drm_debug_level_get(int dir);
> +void igt_drm_debug_mask_update(unsigned int new_log_level);
> +void igt_drm_debug_mask_reset(void);
> +int igt_drm_debug_mask_get(int dir);
>   int igt_sysfs_drm_module_params_open(void);
>   
>   /**

[-- Attachment #2: Type: text/html, Size: 4421 bytes --]