Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	Francois Dugast <francois.dugast@intel.com>
Subject: [PATCH i-g-t 10/10] lib/igt_sysfs: Drop xe_sysfs_driver_do()
Date: Thu, 10 Apr 2025 15:49:00 -0700	[thread overview]
Message-ID: <20250410-lib-kmod-v1-10-84b1ad0b8075@intel.com> (raw)
In-Reply-To: <20250410-lib-kmod-v1-0-84b1ad0b8075@intel.com>

All users are converted to igt_kmod_{unbind,bind,rebind}, so drop this
implementation.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 lib/igt_sysfs.c | 50 --------------------------------------------------
 lib/igt_sysfs.h |  8 --------
 2 files changed, 58 deletions(-)

diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
index a76af54eb..bc68cf61b 100644
--- a/lib/igt_sysfs.c
+++ b/lib/igt_sysfs.c
@@ -1479,56 +1479,6 @@ int xe_sysfs_get_num_tiles(int xe_device)
 	return num_tiles;
 }
 
-/**
- * xe_sysfs_driver_do:
- * @xe_device: fd of the device
- * @pci_slot: PCI slot of the device
- * @action: the action to perform through sysfs on the driver
- *
- * Use sysfs to perform an action on the driver.
- *
- * Returns: fd of the device, which renewed if needed
- */
-int xe_sysfs_driver_do(int xe_device, char pci_slot[], enum xe_sysfs_driver_action action)
-{
-	int sysfs;
-
-	sysfs = open("/sys/bus/pci/drivers/xe", O_DIRECTORY);
-	igt_assert(sysfs);
-
-	switch(action) {
-	case XE_SYSFS_DRIVER_BIND:
-		igt_assert(igt_sysfs_set(sysfs, "bind", pci_slot));
-		close(sysfs);
-		break;
-	case XE_SYSFS_DRIVER_TRY_BIND:
-		igt_sysfs_set(sysfs, "bind", pci_slot);
-		close(sysfs);
-		break;
-	case XE_SYSFS_DRIVER_REBIND:
-		igt_assert(igt_sysfs_set(sysfs, "unbind", pci_slot));
-
-		/*
-		 * We need to close the client for a proper release, before
-		 * binding back again.
-		 */
-		close(xe_device);
-
-		igt_assert(igt_sysfs_set(sysfs, "bind", pci_slot));
-		close(sysfs);
-
-		/* Renew the client connection */
-		xe_device = drm_open_driver(DRIVER_XE);
-		igt_assert(xe_device);
-
-		break;
-	default:
-		igt_assert(!"missing");
-	}
-
-	return xe_device;
-}
-
 /**
  * xe_sysfs_engine_class_get_property
  * @xe_device: fd of the device
diff --git a/lib/igt_sysfs.h b/lib/igt_sysfs.h
index 5bc733168..265f77d4d 100644
--- a/lib/igt_sysfs.h
+++ b/lib/igt_sysfs.h
@@ -183,14 +183,6 @@ int xe_sysfs_get_num_tiles(int xe_device);
 char *xe_sysfs_engine_path(int xe_device, int gt, int class, char *path, int pathlen);
 int xe_sysfs_engine_open(int xe_device, int gt, int class);
 
-enum xe_sysfs_driver_action {
-	XE_SYSFS_DRIVER_BIND,
-	XE_SYSFS_DRIVER_TRY_BIND,
-	XE_SYSFS_DRIVER_REBIND,
-};
-
-int xe_sysfs_driver_do(int xe_device, char pci_slot[], enum xe_sysfs_driver_action action);
-
 bool xe_sysfs_engine_class_get_property(int xe_device, int gt, uint16_t class, const char *property,
 					uint32_t *value);
 bool xe_sysfs_engine_class_set_property(int xe_device, int gt, uint16_t class, const char *property,

-- 
2.49.0


  parent reply	other threads:[~2025-04-10 22:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10 22:47 [PATCH i-g-t 00/10] lib/kmod: unbind, bind, rebind Lucas De Marchi
2025-04-10 22:48 ` [PATCH i-g-t 01/10] lib/igt_kmod: Fix leaking dir Lucas De Marchi
2025-04-11  7:26   ` Riana Tauro
2025-04-10 22:48 ` [PATCH i-g-t 02/10] lib/igt_kmod: Fix comment about unbound devices Lucas De Marchi
2025-04-14 10:56   ` Francois Dugast
2025-04-10 22:48 ` [PATCH i-g-t 03/10] lib/igt_kmod: Simplify igt_kmod_unbind() Lucas De Marchi
2025-04-14 10:59   ` Francois Dugast
2025-04-10 22:48 ` [PATCH i-g-t 04/10] lib/igt_kmod: Use igt_kmod_unbind() to kick snd_hda_intel Lucas De Marchi
2025-04-14 18:04   ` Kamil Konieczny
2025-04-10 22:48 ` [PATCH i-g-t 05/10] lib/igt_kmod: Add igt_kmod_bind() Lucas De Marchi
2025-04-14 18:06   ` Kamil Konieczny
2025-04-15  5:34   ` Riana Tauro
2025-04-10 22:48 ` [PATCH i-g-t 06/10] tests/intel/xe_fault_injection: Use igt_kmod_bind() Lucas De Marchi
2025-04-14 11:00   ` Francois Dugast
2025-04-10 22:48 ` [PATCH i-g-t 07/10] lib/igt_kmod: Add rebind abstraction Lucas De Marchi
2025-04-14 18:07   ` Kamil Konieczny
2025-04-14 21:36     ` Lucas De Marchi
2025-04-28 11:27       ` Kamil Konieczny
2025-04-15  5:49   ` Riana Tauro
2025-04-17  3:38     ` Lucas De Marchi
2025-04-10 22:48 ` [PATCH i-g-t 08/10] tests/intel/xe_fault_injection: Drop XE_SYSFS_DRIVER_TRY_BIND usage Lucas De Marchi
2025-04-14 11:01   ` Francois Dugast
2025-04-10 22:48 ` [PATCH i-g-t 09/10] tests/intel/xe_wedged: Drop XE_SYSFS_DRIVER_REBIND usage Lucas De Marchi
2025-04-14 11:02   ` Francois Dugast
2025-04-10 22:49 ` Lucas De Marchi [this message]
2025-04-14 11:03   ` [PATCH i-g-t 10/10] lib/igt_sysfs: Drop xe_sysfs_driver_do() Francois Dugast
2025-04-10 23:59 ` ✓ i915.CI.BAT: success for lib/kmod: unbind, bind, rebind Patchwork
2025-04-11  0:18 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-11  4:34 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-11  5:09 ` ✓ Xe.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250410-lib-kmod-v1-10-84b1ad0b8075@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox