From: Lucas De Marchi <lucas.demarchi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
Francois Dugast <francois.dugast@intel.com>
Subject: [PATCH i-g-t 04/10] lib/igt_kmod: Use igt_kmod_unbind() to kick snd_hda_intel
Date: Thu, 10 Apr 2025 15:48:33 -0700 [thread overview]
Message-ID: <20250410-lib-kmod-v1-4-84b1ad0b8075@intel.com> (raw)
In-Reply-To: <20250410-lib-kmod-v1-0-84b1ad0b8075@intel.com>
No need for the extra function now that the generic igt_kmod_unbind()
can be used.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
lib/igt_kmod.c | 56 +++-----------------------------------------------------
1 file changed, 3 insertions(+), 53 deletions(-)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index a1e39a429..3f5f93f37 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -495,58 +495,6 @@ igt_intel_driver_load(const char *opts, const char *driver)
return 0;
}
-/**
- * kick_snd_hda_intel:
- *
- * This function unbinds the snd_hda_intel driver so the module can be
- * unloaded.
- *
- */
-static void kick_snd_hda_intel(void)
-{
- DIR *dir;
- struct dirent *snd_hda;
- int fd; size_t len;
-
- const char *dpath = "/sys/bus/pci/drivers/snd_hda_intel";
- const char *path = "/sys/bus/pci/drivers/snd_hda_intel/unbind";
- const char *devid = "0000:";
-
- fd = open(path, O_WRONLY);
- if (fd < 0) {
- return;
- }
-
- dir = opendir(dpath);
- if (!dir)
- goto out;
-
- len = strlen(devid);
- while ((snd_hda = readdir(dir))) {
- struct stat st;
- char fpath[PATH_MAX];
-
- if (*snd_hda->d_name == '.')
- continue;
-
- snprintf(fpath, sizeof(fpath), "%s/%s", dpath, snd_hda->d_name);
- if (lstat(fpath, &st))
- continue;
-
- if (!S_ISLNK(st.st_mode))
- continue;
-
- if (!strncmp(devid, snd_hda->d_name, len)) {
- igt_ignore_warn(write(fd, snd_hda->d_name,
- strlen(snd_hda->d_name)));
- }
- }
-
- closedir(dir);
-out:
- close(fd);
-}
-
static int igt_always_unload_audio_driver(char **who)
{
int ret;
@@ -579,7 +527,9 @@ static int igt_always_unload_audio_driver(char **who)
ret = pipewire_pulse_start_reserve();
if (ret)
igt_warn("Failed to notify pipewire_pulse\n");
- kick_snd_hda_intel();
+
+ igt_kmod_unbind("snd_hda_intel", NULL);
+
ret = igt_kmod_unload(*m);
pipewire_pulse_stop_reserve();
if (ret) {
--
2.49.0
next prev parent reply other threads:[~2025-04-10 22:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 22:47 [PATCH i-g-t 00/10] lib/kmod: unbind, bind, rebind Lucas De Marchi
2025-04-10 22:48 ` [PATCH i-g-t 01/10] lib/igt_kmod: Fix leaking dir Lucas De Marchi
2025-04-11 7:26 ` Riana Tauro
2025-04-10 22:48 ` [PATCH i-g-t 02/10] lib/igt_kmod: Fix comment about unbound devices Lucas De Marchi
2025-04-14 10:56 ` Francois Dugast
2025-04-10 22:48 ` [PATCH i-g-t 03/10] lib/igt_kmod: Simplify igt_kmod_unbind() Lucas De Marchi
2025-04-14 10:59 ` Francois Dugast
2025-04-10 22:48 ` Lucas De Marchi [this message]
2025-04-14 18:04 ` [PATCH i-g-t 04/10] lib/igt_kmod: Use igt_kmod_unbind() to kick snd_hda_intel Kamil Konieczny
2025-04-10 22:48 ` [PATCH i-g-t 05/10] lib/igt_kmod: Add igt_kmod_bind() Lucas De Marchi
2025-04-14 18:06 ` Kamil Konieczny
2025-04-15 5:34 ` Riana Tauro
2025-04-10 22:48 ` [PATCH i-g-t 06/10] tests/intel/xe_fault_injection: Use igt_kmod_bind() Lucas De Marchi
2025-04-14 11:00 ` Francois Dugast
2025-04-10 22:48 ` [PATCH i-g-t 07/10] lib/igt_kmod: Add rebind abstraction Lucas De Marchi
2025-04-14 18:07 ` Kamil Konieczny
2025-04-14 21:36 ` Lucas De Marchi
2025-04-28 11:27 ` Kamil Konieczny
2025-04-15 5:49 ` Riana Tauro
2025-04-17 3:38 ` Lucas De Marchi
2025-04-10 22:48 ` [PATCH i-g-t 08/10] tests/intel/xe_fault_injection: Drop XE_SYSFS_DRIVER_TRY_BIND usage Lucas De Marchi
2025-04-14 11:01 ` Francois Dugast
2025-04-10 22:48 ` [PATCH i-g-t 09/10] tests/intel/xe_wedged: Drop XE_SYSFS_DRIVER_REBIND usage Lucas De Marchi
2025-04-14 11:02 ` Francois Dugast
2025-04-10 22:49 ` [PATCH i-g-t 10/10] lib/igt_sysfs: Drop xe_sysfs_driver_do() Lucas De Marchi
2025-04-14 11:03 ` Francois Dugast
2025-04-10 23:59 ` ✓ i915.CI.BAT: success for lib/kmod: unbind, bind, rebind Patchwork
2025-04-11 0:18 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-11 4:34 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-11 5:09 ` ✓ Xe.CI.Full: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410-lib-kmod-v1-4-84b1ad0b8075@intel.com \
--to=lucas.demarchi@intel.com \
--cc=francois.dugast@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox