Re: [PATCH i-g-t 09/10] tests/intel/xe_wedged: Drop XE_SYSFS_DRIVER_REBIND usage

[Francois Dugast <francois.dugast@intel.com>]

On Thu, Apr 10, 2025 at 03:48:38PM -0700, Lucas De Marchi wrote:
> Replace with XE_SYSFS_DRIVER_REBIND with igt_kmod_rebind().
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Francois Dugast <francois.dugast@intel.com>

> ---
>  tests/intel/xe_wedged.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/intel/xe_wedged.c b/tests/intel/xe_wedged.c
> index 22ff75367..1d2c510b7 100644
> --- a/tests/intel/xe_wedged.c
> +++ b/tests/intel/xe_wedged.c
> @@ -228,7 +228,11 @@ igt_main
>  
>  		force_wedged(fd);
>  		igt_assert_neq(simple_ioctl(fd), 0);
> -		fd = xe_sysfs_driver_do(fd, pci_slot, XE_SYSFS_DRIVER_REBIND);
> +
> +		drm_close_driver(fd);
> +		igt_kmod_rebind("xe", pci_slot);
> +		fd = drm_open_driver(DRIVER_XE);
> +
>  		igt_assert_eq(simple_ioctl(fd), 0);
>  		xe_for_each_engine(fd, hwe)
>  			simple_exec(fd, hwe);
> @@ -266,7 +270,10 @@ igt_main
>  		 * Rebind the device and ensure proper operation is restored
>  		 * for all engines.
>  		 */
> -		fd = xe_sysfs_driver_do(fd, pci_slot, XE_SYSFS_DRIVER_REBIND);
> +		drm_close_driver(fd);
> +		igt_kmod_rebind("xe", pci_slot);
> +		fd = drm_open_driver(DRIVER_XE);
> +
>  		igt_assert_eq(simple_ioctl(fd), 0);
>  		xe_for_each_engine(fd, hwe)
>  			simple_exec(fd, hwe);
> @@ -299,8 +306,7 @@ igt_main
>  		}
>  
>  		/* Tests might have failed, force a rebind before exiting */
> -		fd = xe_sysfs_driver_do(fd, pci_slot, XE_SYSFS_DRIVER_REBIND);
> -
>  		drm_close_driver(fd);
> +		igt_kmod_rebind("xe", pci_slot);
>  	}
>  }
> 
> -- 
> 2.49.0
>