From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 12/25] lib/kms: Make igt_fill_display_format_mod() more flexible
Date: Tue, 12 May 2026 15:21:30 +0300 [thread overview]
Message-ID: <20260512122143.11013-13-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260512122143.11013-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Currently igt_fill_display_format_mod() is hardcoded to operate
on display->format_mods (and its plane counterparts). We may
also want an async flip counterpart of this. To make that
possible adjust the code so that it can operate on other
igt_format_mods structures.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_kms.c | 34 ++++++++++++++++++++++++----------
1 file changed, 24 insertions(+), 10 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 0d604bc76910..dc3486a795a4 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6327,7 +6327,8 @@ format_mods_union(struct igt_format_mods *format_mods_dst,
format_mods_src->modifiers[i]);
}
-static int display_format_mods_count(igt_display_t *display)
+static int display_format_mods_count(igt_display_t *display,
+ const struct igt_format_mods *(*plane_format_mods)(igt_plane_t *plane))
{
igt_crtc_t *crtc;
int count = 0;
@@ -6336,14 +6337,15 @@ static int display_format_mods_count(igt_display_t *display)
igt_plane_t *plane;
for_each_plane_on_crtc(crtc, plane)
- count += plane->format_mods.count;
+ count += plane_format_mods(plane)->count;
}
return count;
}
static void display_format_mods_union(igt_display_t *display,
- struct igt_format_mods *format_mods)
+ struct igt_format_mods *format_mods,
+ const struct igt_format_mods *(*plane_format_mods)(igt_plane_t *plane))
{
igt_crtc_t *crtc;
@@ -6351,29 +6353,41 @@ static void display_format_mods_union(igt_display_t *display,
igt_plane_t *plane;
for_each_plane_on_crtc(crtc, plane)
- format_mods_union(format_mods, &plane->format_mods);
+ format_mods_union(format_mods, plane_format_mods(plane));
}
}
-static void igt_fill_display_format_mod(igt_display_t *display)
+static void display_format_mods_fill(igt_display_t *display,
+ struct igt_format_mods *format_mods,
+ const struct igt_format_mods *(*plane_format_mods)(igt_plane_t *plane))
{
- int count = display_format_mods_count(display);
+ int count = display_format_mods_count(display, plane_format_mods);
if (!count)
return;
- format_mods_alloc(&display->format_mods, count);
+ format_mods_alloc(format_mods, count);
/*
* Initial count was an upper bound and may include
* duplicates. The final count, without duplicates,
* is determined while filling the arrays.
*/
- display->format_mods.count = 0;
+ format_mods->count = 0;
- display_format_mods_union(display, &display->format_mods);
+ display_format_mods_union(display, format_mods, plane_format_mods);
- igt_assert_lte(display->format_mods.count, count);
+ igt_assert_lte(format_mods->count, count);
+}
+
+static const struct igt_format_mods *plane_format_mods(igt_plane_t *plane)
+{
+ return &plane->format_mods;
+}
+
+static void igt_fill_display_format_mod(igt_display_t *display)
+{
+ display_format_mods_fill(display, &display->format_mods, plane_format_mods);
}
/**
--
2.52.0
next prev parent reply other threads:[~2026-05-12 12:27 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 12:21 [PATCH i-g-t 00/25] lib/kms: Clean up format+mod stuff Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 01/25] tests/kms_async_flips: Use correct format_mod list Ville Syrjala
2026-05-13 5:12 ` B, Jeevan
2026-05-12 12:21 ` [PATCH i-g-t 02/25] test/kms: Introduce a few extra format/modifier variables Ville Syrjala
2026-05-13 5:17 ` B, Jeevan
2026-05-12 12:21 ` [PATCH i-g-t 03/25] lib/kms: Introduce struct igt_format_mods Ville Syrjala
2026-05-13 5:23 ` B, Jeevan
2026-05-12 12:21 ` [PATCH i-g-t 04/25] lib/kms: Pass struct igt_format_mods to igt_parse_format_mod_blob() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 05/25] lib/kms: Extract format_mods_alloc() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 06/25] lib/kms: Extract fill_plane_default_format_mods() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 07/25] lib/kms: Extract igt_format_mods_has_format_with_modifier() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 08/25] lib/kms: Pass target format_mods to igt_add_display_format_mod() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 09/25] lib/kms: Extract format_mods_union() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 10/25] lib/kms: Extract display_format_mods_union() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 11/25] lib/kms: Move and rename igt_count_display_format_mod() Ville Syrjala
2026-05-12 12:21 ` Ville Syrjala [this message]
2026-05-12 12:21 ` [PATCH i-g-t 13/25] lib/kms: Add display->format_mods_async Ville Syrjala
2026-05-14 4:35 ` Reddy Guddati, Santhosh
2026-05-12 12:21 ` [PATCH i-g-t 14/25] lib/kms: Fill plane->format_mods_async for planes without IN_FORMATS Ville Syrjala
2026-05-14 4:59 ` Reddy Guddati, Santhosh
2026-05-12 12:21 ` [PATCH i-g-t 15/25] lib/kms: Encourage drivers to expose IN_FORMATS_ASYNC Ville Syrjala
2026-05-14 5:15 ` Reddy Guddati, Santhosh
2026-05-12 12:21 ` [PATCH i-g-t 16/25] lib/kms: Introduce igt_format_mods iterators Ville Syrjala
2026-05-13 3:17 ` [PATCH i-g-t v2 " Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 17/25] lib/kms: Add helpers to query igt_format_mods Ville Syrjala
2026-05-13 3:17 ` [PATCH i-g-t v2 " Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 18/25] tests/chamelium/kms_chamelium_frames: Use for_each_format_and_modifier() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 19/25] tests/kms_plane: Use igt_format_mods_has_modifier() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 20/25] tests/kms_plane: Use for_each_format_and_modifier() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 21/25] tests/kms_async_flips: Remove the IN_FORMAT_ASYNC check Ville Syrjala
2026-05-14 5:18 ` Reddy Guddati, Santhosh
2026-05-12 12:21 ` [PATCH i-g-t 22/25] tests/kms_async_flips: Use igt_format_mods_has_modifier() Ville Syrjala
2026-05-14 4:27 ` Reddy Guddati, Santhosh
2026-05-12 12:21 ` [PATCH i-g-t 23/25] tests/kms_async_flips: Use for_each_format_and_modifier() and for_each_modifier_with_format() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 24/25] tests/intel/kms_flip_tiling: Use for_each_modifier_with_format() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 25/25] tests/chamelium/kms_chamelium_frames: Use for_each_format_with_modifier() Ville Syrjala
2026-05-12 22:00 ` ✗ i915.CI.BAT: failure for lib/kms: Clean up format+mod stuff Patchwork
2026-05-13 0:10 ` ✗ Xe.CI.BAT: " Patchwork
2026-05-13 4:25 ` ✓ i915.CI.BAT: success for lib/kms: Clean up format+mod stuff (rev3) Patchwork
2026-05-13 4:34 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-13 17:00 ` ✗ Xe.CI.FULL: failure for lib/kms: Clean up format+mod stuff Patchwork
2026-05-14 0:12 ` ✗ Xe.CI.FULL: failure for lib/kms: Clean up format+mod stuff (rev3) Patchwork
2026-05-14 2:27 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512122143.11013-13-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox