From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 15/25] lib/kms: Encourage drivers to expose IN_FORMATS_ASYNC
Date: Tue, 12 May 2026 15:21:33 +0300 [thread overview]
Message-ID: <20260512122143.11013-16-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260512122143.11013-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Currently only i915/xe exposes the IN_FORMATS_ASYNC blob. Let's
try to encourage other drivers to join the party by issuing a
warning if we notice that the driver expose the normal
IN_FORMATS blob and claims to be async flip capable.
And in order to make tests less messy let's just assume that
all format+modifier combinations are async flip capable in this
case. Any driver that doesn't like it should just add support
for IN_FORMATS_ASYNC.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_kms.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index b81be73978a1..b90d34e61359 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6244,6 +6244,9 @@ static void igt_fill_plane_format_mod(igt_display_t *display, igt_plane_t *plane
uint64_t blob_id;
if (!igt_plane_has_prop(plane, IGT_PLANE_IN_FORMATS)) {
+ /* IN_FORMATS_ASYNC should never be present without IN_FORMATS */
+ igt_assert(!igt_plane_has_prop(plane, IGT_PLANE_IN_FORMATS_ASYNC));
+
fill_plane_default_format_mods(plane, &plane->format_mods);
if (igt_has_drm_cap(display->drm_fd, DRM_CAP_ASYNC_PAGE_FLIP))
@@ -6259,6 +6262,15 @@ static void igt_fill_plane_format_mod(igt_display_t *display, igt_plane_t *plane
blob_data = (const struct drm_format_modifier_blob *)blob->data;
igt_parse_format_mod_blob(blob_data, &plane->format_mods);
+
+ if (!igt_plane_has_prop(plane, IGT_PLANE_IN_FORMATS_ASYNC) &&
+ igt_has_drm_cap(display->drm_fd, DRM_CAP_ASYNC_PAGE_FLIP)) {
+ igt_warn("Driver has IN_FORMATS but no IN_FORMATS_ASYNC while supportiong async flips\n");
+
+ /* assume everything supports async flips */
+ igt_parse_format_mod_blob(blob_data, &plane->format_mods_async);
+ }
+
drmModeFreePropertyBlob(blob);
if (igt_plane_has_prop(plane, IGT_PLANE_IN_FORMATS_ASYNC)) {
--
2.52.0
next prev parent reply other threads:[~2026-05-12 12:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 12:21 [PATCH i-g-t 00/25] lib/kms: Clean up format+mod stuff Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 01/25] tests/kms_async_flips: Use correct format_mod list Ville Syrjala
2026-05-13 5:12 ` B, Jeevan
2026-05-12 12:21 ` [PATCH i-g-t 02/25] test/kms: Introduce a few extra format/modifier variables Ville Syrjala
2026-05-13 5:17 ` B, Jeevan
2026-05-12 12:21 ` [PATCH i-g-t 03/25] lib/kms: Introduce struct igt_format_mods Ville Syrjala
2026-05-13 5:23 ` B, Jeevan
2026-05-12 12:21 ` [PATCH i-g-t 04/25] lib/kms: Pass struct igt_format_mods to igt_parse_format_mod_blob() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 05/25] lib/kms: Extract format_mods_alloc() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 06/25] lib/kms: Extract fill_plane_default_format_mods() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 07/25] lib/kms: Extract igt_format_mods_has_format_with_modifier() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 08/25] lib/kms: Pass target format_mods to igt_add_display_format_mod() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 09/25] lib/kms: Extract format_mods_union() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 10/25] lib/kms: Extract display_format_mods_union() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 11/25] lib/kms: Move and rename igt_count_display_format_mod() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 12/25] lib/kms: Make igt_fill_display_format_mod() more flexible Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 13/25] lib/kms: Add display->format_mods_async Ville Syrjala
2026-05-14 4:35 ` Reddy Guddati, Santhosh
2026-05-12 12:21 ` [PATCH i-g-t 14/25] lib/kms: Fill plane->format_mods_async for planes without IN_FORMATS Ville Syrjala
2026-05-14 4:59 ` Reddy Guddati, Santhosh
2026-05-12 12:21 ` Ville Syrjala [this message]
2026-05-14 5:15 ` [PATCH i-g-t 15/25] lib/kms: Encourage drivers to expose IN_FORMATS_ASYNC Reddy Guddati, Santhosh
2026-05-12 12:21 ` [PATCH i-g-t 16/25] lib/kms: Introduce igt_format_mods iterators Ville Syrjala
2026-05-13 3:17 ` [PATCH i-g-t v2 " Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 17/25] lib/kms: Add helpers to query igt_format_mods Ville Syrjala
2026-05-13 3:17 ` [PATCH i-g-t v2 " Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 18/25] tests/chamelium/kms_chamelium_frames: Use for_each_format_and_modifier() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 19/25] tests/kms_plane: Use igt_format_mods_has_modifier() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 20/25] tests/kms_plane: Use for_each_format_and_modifier() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 21/25] tests/kms_async_flips: Remove the IN_FORMAT_ASYNC check Ville Syrjala
2026-05-14 5:18 ` Reddy Guddati, Santhosh
2026-05-12 12:21 ` [PATCH i-g-t 22/25] tests/kms_async_flips: Use igt_format_mods_has_modifier() Ville Syrjala
2026-05-14 4:27 ` Reddy Guddati, Santhosh
2026-05-12 12:21 ` [PATCH i-g-t 23/25] tests/kms_async_flips: Use for_each_format_and_modifier() and for_each_modifier_with_format() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 24/25] tests/intel/kms_flip_tiling: Use for_each_modifier_with_format() Ville Syrjala
2026-05-12 12:21 ` [PATCH i-g-t 25/25] tests/chamelium/kms_chamelium_frames: Use for_each_format_with_modifier() Ville Syrjala
2026-05-12 22:00 ` ✗ i915.CI.BAT: failure for lib/kms: Clean up format+mod stuff Patchwork
2026-05-13 0:10 ` ✗ Xe.CI.BAT: " Patchwork
2026-05-13 4:25 ` ✓ i915.CI.BAT: success for lib/kms: Clean up format+mod stuff (rev3) Patchwork
2026-05-13 4:34 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-13 17:00 ` ✗ Xe.CI.FULL: failure for lib/kms: Clean up format+mod stuff Patchwork
2026-05-14 0:12 ` ✗ Xe.CI.FULL: failure for lib/kms: Clean up format+mod stuff (rev3) Patchwork
2026-05-14 2:27 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512122143.11013-16-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox