Re: [PATCH i-g-t 15/25] lib/kms: Encourage drivers to expose IN_FORMATS_ASYNC

["Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>]

On 12-05-2026 17:51, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Currently only i915/xe exposes the IN_FORMATS_ASYNC blob. Let's
> try to encourage other drivers to join the party by issuing a
> warning if we notice that the driver expose the normal
> IN_FORMATS blob and claims to be async flip capable.
> 
> And in order to make tests less messy let's just assume that
> all format+modifier combinations are async flip capable in this
> case. Any driver that doesn't like it should just add support
> for IN_FORMATS_ASYNC.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

LGTM
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> ---
>   lib/igt_kms.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index b81be73978a1..b90d34e61359 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6244,6 +6244,9 @@ static void igt_fill_plane_format_mod(igt_display_t *display, igt_plane_t *plane
>   	uint64_t blob_id;
>   
>   	if (!igt_plane_has_prop(plane, IGT_PLANE_IN_FORMATS)) {
> +		/* IN_FORMATS_ASYNC should never be present without IN_FORMATS */
> +		igt_assert(!igt_plane_has_prop(plane, IGT_PLANE_IN_FORMATS_ASYNC));
> +
>   		fill_plane_default_format_mods(plane, &plane->format_mods);
>   
>   		if (igt_has_drm_cap(display->drm_fd, DRM_CAP_ASYNC_PAGE_FLIP))
> @@ -6259,6 +6262,15 @@ static void igt_fill_plane_format_mod(igt_display_t *display, igt_plane_t *plane
>   
>   	blob_data = (const struct drm_format_modifier_blob *)blob->data;
>   	igt_parse_format_mod_blob(blob_data, &plane->format_mods);
> +
> +	if (!igt_plane_has_prop(plane, IGT_PLANE_IN_FORMATS_ASYNC) &&
> +	    igt_has_drm_cap(display->drm_fd, DRM_CAP_ASYNC_PAGE_FLIP)) {
> +		igt_warn("Driver has IN_FORMATS but no IN_FORMATS_ASYNC while supportiong async flips\n");
> +
> +		/* assume everything supports async flips */
> +		igt_parse_format_mod_blob(blob_data, &plane->format_mods_async);
> +	}
> +
>   	drmModeFreePropertyBlob(blob);
>   
>   	if (igt_plane_has_prop(plane, IGT_PLANE_IN_FORMATS_ASYNC)) {