Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: juhapekka.heikkila@gmail.com,
	"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v1 3/3] tests/sharpness_filter: limit #crtcs tested during suspend
Date: Mon, 29 Jun 2026 11:07:40 +0200	[thread overview]
Message-ID: <20260629090740.2706320-4-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260629090740.2706320-1-michal.grzelak@intel.com>

We are iterating through each crtc while testing suspend. This results
in extended execution time, in turn leading to hitting CI enforced
timeout. Limit number of tested crtcs to first and last. Test each
crtc when passing dedicated commandline parameter.

Cc: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 tests/intel/kms_sharpness_filter.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
index fc7074b1c7..ae700cb5b3 100644
--- a/tests/intel/kms_sharpness_filter.c
+++ b/tests/intel/kms_sharpness_filter.c
@@ -231,6 +231,7 @@ static const struct subtest_entry {
 typedef struct {
 	int drm_fd;
 	bool limited;
+	bool all_crtcs;
 	bool all_outps;
 	struct igt_fb fb[4];
 	igt_crtc_t *crtc;
@@ -601,6 +602,7 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
 	igt_output_t *output;
 	igt_crtc_t *crtc;
 	int outp_cntr = 0;
+	int crtc_cntr = 0;
 	char name[40];
 
 	for_each_connected_output(display, output) {
@@ -617,6 +619,12 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
 
 			igt_output_set_crtc(data->output, data->crtc);
 
+			if (type == TEST_FILTER_SUSPEND && !data->all_crtcs && crtc->crtc_index != 0 &&
+						crtc->crtc_index != display->n_crtcs-1)
+					continue;
+
+			crtc_cntr++;
+
 			/*
 			 * FIXME: Joiner + CASF currently unsupported.
 			 * Remove this check once support is implemented.
@@ -751,6 +759,9 @@ static int opt_handler(int opt, int opt_index, void *_data)
 	case 'l':
 		data->limited = true;
 		break;
+	case 'c':
+		data->all_crtcs = true;
+		break;
 	case 'o':
 		data->all_outps = true;
 		break;
@@ -763,11 +774,12 @@ static int opt_handler(int opt, int opt_index, void *_data)
 
 static const char help_str[] =
 	"  --limited|-l\t\tLimit execution to 1 valid pipe-output combo\n"
-	"  --all-outputs|-o\t\tExtend suspend tests for all outputs\n";
+	"  --all-outputs|-o\t\tExtend suspend tests for all outputs\n"
+	"  --all-crtcs|-c\t\tExtend suspend tests for all crtcs\n";
 
 data_t data = {};
 
-int igt_main_args("lo", NULL, help_str, opt_handler, &data)
+int igt_main_args("loc", NULL, help_str, opt_handler, &data)
 {
 	igt_fixture() {
 		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
-- 
2.45.2


  parent reply	other threads:[~2026-06-29  9:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  9:07 [PATCH i-g-t v1 0/3] sharpness_filter: limit suspend Michał Grzelak
2026-06-29  9:07 ` [PATCH i-g-t v1 1/3] tests/sharpness_filter: fix typo Michał Grzelak
2026-06-29  9:07 ` [PATCH i-g-t v1 2/3] tests/sharpness_filter: limit #outputs used during suspend Michał Grzelak
2026-06-29 10:07   ` Jani Nikula
2026-06-29  9:07 ` Michał Grzelak [this message]
2026-06-29 10:08   ` [PATCH i-g-t v1 3/3] tests/sharpness_filter: limit #crtcs tested " Jani Nikula
2026-06-29 21:00 ` ✓ Xe.CI.BAT: success for sharpness_filter: limit suspend Patchwork
2026-06-29 21:13 ` ✓ i915.CI.BAT: " Patchwork
2026-06-30  5:49 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-30  8:39 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260629090740.2706320-4-michal.grzelak@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox