Re: [PATCH i-g-t v1 2/3] tests/sharpness_filter: limit #outputs used during suspend

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 29 Jun 2026, Michał Grzelak <michal.grzelak@intel.com> wrote:
> We are iterating through each connected output while testing suspend.
> This results in extended execution time, in turn leading to hitting CI
> enforced timeout. Limit number of used outputs by default to 3. Test
> each connected output when passing dedicated commandline parameter.
>
> Cc: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> ---
>  tests/intel/kms_sharpness_filter.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
> index 1575cde6f7..fc7074b1c7 100644
> --- a/tests/intel/kms_sharpness_filter.c
> +++ b/tests/intel/kms_sharpness_filter.c
> @@ -231,6 +231,7 @@ static const struct subtest_entry {
>  typedef struct {
>  	int drm_fd;
>  	bool limited;
> +	bool all_outps;

Useless abbreviation.

>  	struct igt_fb fb[4];
>  	igt_crtc_t *crtc;
>  	igt_display_t display;
> @@ -599,9 +600,15 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
>  	igt_display_t *display = &data->display;
>  	igt_output_t *output;
>  	igt_crtc_t *crtc;
> +	int outp_cntr = 0;

Ditto.

>  	char name[40];
>  
>  	for_each_connected_output(display, output) {
> +		if (type == TEST_FILTER_SUSPEND && !data->all_outps && outp_cntr > 3)
> +			continue;
> +
> +		outp_cntr++;
> +
>  		for_each_crtc(display, crtc) {
>  			igt_display_reset(display);
>  
> @@ -744,6 +751,9 @@ static int opt_handler(int opt, int opt_index, void *_data)
>  	case 'l':
>  		data->limited = true;
>  		break;
> +	case 'o':
> +		data->all_outps = true;
> +		break;
>  	default:
>  		return IGT_OPT_HANDLER_ERROR;
>  	}
> @@ -752,11 +762,12 @@ static int opt_handler(int opt, int opt_index, void *_data)
>  }
>  
>  static const char help_str[] =
> -	"  --limited|-l\t\tLimit execution to 1 valid pipe-output combo\n";
> +	"  --limited|-l\t\tLimit execution to 1 valid pipe-output combo\n"
> +	"  --all-outputs|-o\t\tExtend suspend tests for all outputs\n";
>  
>  data_t data = {};
>  
> -int igt_main_args("l", NULL, help_str, opt_handler, &data)
> +int igt_main_args("lo", NULL, help_str, opt_handler, &data)
>  {
>  	igt_fixture() {
>  		data.drm_fd = drm_open_driver_master(DRIVER_ANY);

-- 
Jani Nikula, Intel