Re: [PATCH i-g-t v1 3/3] tests/sharpness_filter: limit #crtcs tested during suspend

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 29 Jun 2026, Michał Grzelak <michal.grzelak@intel.com> wrote:
> We are iterating through each crtc while testing suspend. This results
> in extended execution time, in turn leading to hitting CI enforced
> timeout. Limit number of tested crtcs to first and last. Test each
> crtc when passing dedicated commandline parameter.
>
> Cc: Juha-Pekka Heikkilä <juhapekka.heikkila@gmail.com>
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> ---
>  tests/intel/kms_sharpness_filter.c | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
> index fc7074b1c7..ae700cb5b3 100644
> --- a/tests/intel/kms_sharpness_filter.c
> +++ b/tests/intel/kms_sharpness_filter.c
> @@ -231,6 +231,7 @@ static const struct subtest_entry {
>  typedef struct {
>  	int drm_fd;
>  	bool limited;
> +	bool all_crtcs;
>  	bool all_outps;
>  	struct igt_fb fb[4];
>  	igt_crtc_t *crtc;
> @@ -601,6 +602,7 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
>  	igt_output_t *output;
>  	igt_crtc_t *crtc;
>  	int outp_cntr = 0;
> +	int crtc_cntr = 0;
>  	char name[40];
>  
>  	for_each_connected_output(display, output) {
> @@ -617,6 +619,12 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
>  
>  			igt_output_set_crtc(data->output, data->crtc);
>  
> +			if (type == TEST_FILTER_SUSPEND && !data->all_crtcs && crtc->crtc_index != 0 &&
> +						crtc->crtc_index != display->n_crtcs-1)
> +					continue;
> +
> +			crtc_cntr++;

You're not using the value for anything.

> +
>  			/*
>  			 * FIXME: Joiner + CASF currently unsupported.
>  			 * Remove this check once support is implemented.
> @@ -751,6 +759,9 @@ static int opt_handler(int opt, int opt_index, void *_data)
>  	case 'l':
>  		data->limited = true;
>  		break;
> +	case 'c':
> +		data->all_crtcs = true;
> +		break;
>  	case 'o':
>  		data->all_outps = true;
>  		break;
> @@ -763,11 +774,12 @@ static int opt_handler(int opt, int opt_index, void *_data)
>  
>  static const char help_str[] =
>  	"  --limited|-l\t\tLimit execution to 1 valid pipe-output combo\n"
> -	"  --all-outputs|-o\t\tExtend suspend tests for all outputs\n";
> +	"  --all-outputs|-o\t\tExtend suspend tests for all outputs\n"
> +	"  --all-crtcs|-c\t\tExtend suspend tests for all crtcs\n";
>  
>  data_t data = {};
>  
> -int igt_main_args("lo", NULL, help_str, opt_handler, &data)
> +int igt_main_args("loc", NULL, help_str, opt_handler, &data)
>  {
>  	igt_fixture() {
>  		data.drm_fd = drm_open_driver_master(DRIVER_ANY);

-- 
Jani Nikula, Intel