[PATCH i-g-t v5 1/8] lib/igt_kms: clear colorop-changed flag after commit

[Melissa Wen <mwen@igalia.com>]

The userspace can update only currently active colorops or colorops that
will be activated or deactivated in the same commit. Active colorop
means a colorop that is in the chain of an active color pipeline, i.e.
the pipeline in plane COLOR_PIPELINE property.

Don't request colorop updates if there is no change in the atomic
commit. This fixes incorrect re-submission of property changes in
inactive colorops after a successful atomic commit.

Assisted-by: Claude:claude-opus-4-7
Tested-by: Alex Hung <alex.hung@amd.com>
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Signed-off-by: Melissa Wen <mwen@igalia.com>
---

v3:
- use uint32_t variable for igt_find_colorop (Alex H)
---
 lib/igt_kms.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 2d78e3bee..cd0a42840 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -4890,8 +4890,24 @@ display_commit_changed(igt_display_t *display, enum igt_commit_style s)
 				       plane) {
 			if (s == COMMIT_ATOMIC) {
 				int fd;
+				igt_colorop_t *colorop;
+
 				plane->changed = 0;
 
+				/* clear changed flags on every colorop in the assigned chain
+				 * so already-committed property values aren't re-emitted on
+				 * the next commit.
+				 */
+				colorop = plane->assigned_color_pipeline;
+				while (colorop) {
+					uint32_t next_val;
+
+					colorop->changed = 0;
+					next_val = igt_colorop_get_prop(display, colorop,
+									IGT_COLOROP_NEXT);
+					colorop = igt_find_colorop(display, next_val);
+				}
+
 				fd = plane->values[IGT_PLANE_IN_FENCE_FD];
 				if (fd != -1)
 					close(fd);
-- 
2.53.0