Re: [PATCH i-g-t v5 6/8] tests/kms_properties: check colorop properties on active color pipelines

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 9/2/2026 11:28 PM, Melissa Wen wrote:
> A colorop property can only be changed if its color pipeline is active,
> i.e. the colorop is in the chain of the color pipeline set in the plane
> COLOR_PIPELINE property. Set each color pipeline active before checking
> the properties of its colorops, and restore Bypass afterwards.
> 
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
> 
> v2:
> - detach different changes from a single commit (Chaitanya)
> v3:
> - move hunk to the previous commit (Chaitanya)
> v5:
> - add missing commit of bypass color pipeline
> ---
>   tests/kms_properties.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> index c55a271da..76aadd162 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -271,6 +271,9 @@ static void run_colorop_property_tests(igt_display_t *display,
>   		for (i = 0; i < plane->num_color_pipelines; ++i) {
>   			/* iterate over all colorops in pipeline*/
>   			colorop = plane->color_pipelines[i];
> +			igt_plane_set_color_pipeline(plane, colorop);
> +			igt_display_commit2(display, COMMIT_ATOMIC);
> +
>   			while (colorop) {
>   				igt_info("Testing colorop properties on %s.#%d.#%d-%s (output: %s)\n",
>   					  igt_crtc_name(crtc), plane->index,
> @@ -285,6 +288,9 @@ static void run_colorop_property_tests(igt_display_t *display,
>   			}
>   		}
>   
> +		igt_plane_set_color_pipeline(plane, NULL);
> +		igt_display_commit2(display, COMMIT_ATOMIC);
> +
>   		/* only the fb created above needs to go away here */
>   		if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
>   			igt_plane_set_fb(plane, NULL);

Come to think of it, this will also need a commit (To be added with 
patch 4?). Because we need one for igt_plane_set_fb(plane, NULL) to take 
effect.

We will end up with

igt_plane_set_color_pipeline(plane, NULL);

if (plane->type != DRM_PLANE_TYPE_PRIMARY)
     igt_plane_set_fb(plane, NULL);

igt_display_commit2(display, COMMIT_ATOMIC);

if (plane->type != DRM_PLANE_TYPE_PRIMARY)
     igt_remove_fb(display->drm_fd, &afb);

which is a bit ugly but may there is a better way.

==
Chaitanya