From: Melissa Wen <mwen@igalia.com>
To: Petri Latvala <adrinael@adrinael.net>,
Arkadiusz Hiler <arek@hiler.eu>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
Bhanuprakash Modem <bhanuprakash.modem@gmail.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Karthik B S <karthik.b.s@intel.com>
Cc: igt-dev@lists.freedesktop.org, kernel-dev@igalia.com,
Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
Alex Hung <alex.hung@amd.com>,
Swati Sharma <swati2.sharma@intel.com>,
John Harrison <John.Harrison@Igalia.com>,
Rodrigo Siqueira <siqueira@igalia.com>,
Simon Ser <contact@emersion.fr>, Xaver Hugl <xaver.hugl@kde.org>,
Harry Wentland <harry.wentland@amd.com>,
Uma Shankar <uma.shankar@intel.com>
Subject: [PATCH i-g-t v5 6/8] tests/kms_properties: check colorop properties on active color pipelines
Date: Wed, 2 Sep 2026 19:58:06 +0200 [thread overview]
Message-ID: <20260902180016.303482-7-mwen@igalia.com> (raw)
In-Reply-To: <20260902180016.303482-1-mwen@igalia.com>
A colorop property can only be changed if its color pipeline is active,
i.e. the colorop is in the chain of the color pipeline set in the plane
COLOR_PIPELINE property. Set each color pipeline active before checking
the properties of its colorops, and restore Bypass afterwards.
Signed-off-by: Melissa Wen <mwen@igalia.com>
---
v2:
- detach different changes from a single commit (Chaitanya)
v3:
- move hunk to the previous commit (Chaitanya)
v5:
- add missing commit of bypass color pipeline
---
tests/kms_properties.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index c55a271da..76aadd162 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -271,6 +271,9 @@ static void run_colorop_property_tests(igt_display_t *display,
for (i = 0; i < plane->num_color_pipelines; ++i) {
/* iterate over all colorops in pipeline*/
colorop = plane->color_pipelines[i];
+ igt_plane_set_color_pipeline(plane, colorop);
+ igt_display_commit2(display, COMMIT_ATOMIC);
+
while (colorop) {
igt_info("Testing colorop properties on %s.#%d.#%d-%s (output: %s)\n",
igt_crtc_name(crtc), plane->index,
@@ -285,6 +288,9 @@ static void run_colorop_property_tests(igt_display_t *display,
}
}
+ igt_plane_set_color_pipeline(plane, NULL);
+ igt_display_commit2(display, COMMIT_ATOMIC);
+
/* only the fb created above needs to go away here */
if (plane->type != DRM_PLANE_TYPE_PRIMARY) {
igt_plane_set_fb(plane, NULL);
--
2.53.0
next prev parent reply other threads:[~2026-09-02 18:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 17:58 [PATCH i-g-t v5 0/8] test/kms_colorop_helper: don't request colorop updates indefinitely Melissa Wen
2026-09-02 17:58 ` [PATCH i-g-t v5 1/8] lib/igt_kms: clear colorop-changed flag after commit Melissa Wen
2026-09-02 17:58 ` [PATCH i-g-t v5 2/8] tests/kms_colorop_helper: only check if a given enum value exists Melissa Wen
2026-09-02 17:58 ` [PATCH i-g-t v5 3/8] tests/kms_properties: don't check colorop if no plane color pipeline prop Melissa Wen
2026-09-02 17:58 ` [PATCH i-g-t v5 4/8] tests/kms_properties: give non-primary planes their own fb Melissa Wen
2026-09-02 17:58 ` [PATCH i-g-t v5 5/8] lib/igt_kms: extend igt_plane_set_color_pipeline to accept Bypass Melissa Wen
2026-09-09 7:54 ` Borah, Chaitanya Kumar
2026-09-02 17:58 ` Melissa Wen [this message]
2026-09-09 7:55 ` [PATCH i-g-t v5 6/8] tests/kms_properties: check colorop properties on active color pipelines Borah, Chaitanya Kumar
2026-09-02 17:58 ` [PATCH i-g-t v5 7/8] tests/intel/kms_color_pipeline: move driver-specific test to intel's folder Melissa Wen
2026-09-08 19:17 ` Sharma, Swati2
2026-09-09 7:56 ` Borah, Chaitanya Kumar
2026-09-02 17:58 ` [PATCH i-g-t v5 8/8] lib/igt_kms: add macros to iterate color pipelines and colorops Melissa Wen
2026-09-03 10:44 ` Jani Nikula
2026-09-09 8:31 ` Jani Nikula
2026-09-09 7:56 ` Borah, Chaitanya Kumar
2026-09-02 23:19 ` ✓ Xe.CI.BAT: success for test/kms_colorop_helper: don't request colorop updates indefinitely (rev3) Patchwork
2026-09-02 23:22 ` ✗ i915.CI.BAT: failure " Patchwork
2026-09-03 15:30 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902180016.303482-7-mwen@igalia.com \
--to=mwen@igalia.com \
--cc=John.Harrison@Igalia.com \
--cc=adrinael@adrinael.net \
--cc=alex.hung@amd.com \
--cc=arek@hiler.eu \
--cc=ashutosh.dixit@intel.com \
--cc=bhanuprakash.modem@gmail.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=contact@emersion.fr \
--cc=harry.wentland@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=karthik.b.s@intel.com \
--cc=kernel-dev@igalia.com \
--cc=siqueira@igalia.com \
--cc=swati2.sharma@intel.com \
--cc=uma.shankar@intel.com \
--cc=xaver.hugl@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox