Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] xe/shaders: remove explicit regioning and channel offsets
@ 2026-11-06 14:07 Andrzej Hajda
  2026-11-06 14:07 ` [PATCH v3 1/2] lib/shaders: " Andrzej Hajda
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Andrzej Hajda @ 2026-11-06 14:07 UTC (permalink / raw)
  To: igt-dev
  Cc: Kamil Konieczny, Zbigniew Kempczyński,
	Dominik Karol Piatkowski, Andrzej Hajda

There is no need to specify regioning and channel offset in
most cases. Default genisa values are:
- <0;1,0> for source region,
- <1> for destination region,
- M0 for channel offset.
The patch also enforces common formating for all asms:
- preprocessor instructions and predicates start from beginning of the line,
- instruction mnemonic starts from 1st tab,
- exec size follows mnemonic after one space,
- flag modifiers, if any, are placed after exec size,
- arguments starts from 3rd tab,
- args are tab aligned per shader - argN should be place at the same column

The changes do not affect produced binary code.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
Changes in v3:
- changed formating of args from single-space separated to tab aligned (Zbigniew)
- Link to v2: https://patch.msgid.link/20261028-remove_gpu_asm_annotations-v2-0-270a5878b2fc@intel.com

Changes in v2:
- split patch to lib and test parts, remove script change (Kamil)
- Link to v1: https://patch.msgid.link/20261027-remove_gpu_asm_annotations-v1-1-55a0fb61b96d@intel.com

---
Andrzej Hajda (2):
      lib/shaders: remove explicit regioning and channel offsets
      tests/intel/xe_prefetch_fault: remove explicit regioning and channel offsets

 lib/gpgpu_fill.c                                  | 100 ++++++++--------
 lib/gpgpu_fill.c.gen.iga64_codes.c                |   2 +-
 lib/gpgpu_shader.c                                | 132 +++++++++++-----------
 lib/gpgpu_shader.c.gen.iga64_codes.c              |   2 +-
 lib/iga64_macros.h                                |  58 +++++-----
 tests/intel/xe_prefetch_fault.c                   |  16 +--
 tests/intel/xe_prefetch_fault.c.gen.iga64_codes.c |   2 +-
 7 files changed, 156 insertions(+), 156 deletions(-)
---
base-commit: 45b7aef25da3a40ae4cc75442d7b8e6f9af1fb98
change-id: 20261027-remove_gpu_asm_annotations-94b7b32841dd

Best regards,
--  
Andrzej Hajda <andrzej.hajda@intel.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-11-09 15:40 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-06 14:07 [PATCH v3 0/2] xe/shaders: remove explicit regioning and channel offsets Andrzej Hajda
2026-11-06 14:07 ` [PATCH v3 1/2] lib/shaders: " Andrzej Hajda
2026-11-09 15:38   ` Zbigniew Kempczyński
2026-11-06 14:07 ` [PATCH v3 2/2] tests/intel/xe_prefetch_fault: " Andrzej Hajda
2026-11-09 15:39   ` Zbigniew Kempczyński
2026-11-06 18:49 ` ✓ Xe.CI.BAT: success for xe/shaders: remove explicit regioning and channel offsets (rev3) Patchwork
2026-11-06 19:27 ` ✓ i915.CI.BAT: " Patchwork
2026-11-07  4:14 ` ✗ i915.CI.Full: failure " Patchwork
2026-11-07 21:33 ` ✗ Xe.CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox