From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Andi Shyti <andi.shyti@intel.com>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v16 5/8] tests: gem_exec_basic: add engine discovery test
Date: Fri, 29 Mar 2019 12:41:48 +0000 [thread overview]
Message-ID: <42b9c840-b643-2249-cc79-3e8fa2eabf6a@linux.intel.com> (raw)
In-Reply-To: <20190329120648.GC1167@intel.intel>
On 29/03/2019 12:06, Andi Shyti wrote:
>>> + igt_subtest("exec-physical-engines-ctx") {
>>> + uint64_t ctx_id;
>>> + struct intel_execution_engine2 *e2;
>>> +
>>> + ctx_id = gem_context_create(fd);
>>
>> In this one you don't want a context. It creates a mismatch between execbuf
>> sent by gem_context_has_engine and a context which hasn't been configured to
>> use engine index addressing.
>
> Yes, I forgot to remove it... BTW, is this test needed at all? I
> added it just as a proposal.
In my opinion you can drop this patch since you use both new iterators
later in the series.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-29 12:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 19:21 [igt-dev] [RFC v16 0/8] new engine discovery interface Andi Shyti
2019-03-28 19:21 ` [igt-dev] [PATCH v16 1/8] lib/igt_gt: remove unnecessary argument Andi Shyti
2019-03-29 11:34 ` Tvrtko Ursulin
2019-03-28 19:22 ` [igt-dev] [PATCH v16 2/8] lib: ioctl_wrappers: reach engines by index as well Andi Shyti
2019-03-29 11:36 ` Tvrtko Ursulin
2019-03-29 11:59 ` Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 3/8] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 4/8] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-03-29 11:34 ` Tvrtko Ursulin
2019-03-29 12:05 ` Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 5/8] tests: gem_exec_basic: add engine discovery test Andi Shyti
2019-03-29 11:39 ` Tvrtko Ursulin
2019-03-29 12:06 ` Andi Shyti
2019-03-29 12:41 ` Tvrtko Ursulin [this message]
2019-03-29 23:36 ` Chris Wilson
2019-03-31 17:36 ` Andi Shyti
2019-03-31 17:42 ` Chris Wilson
2019-03-31 20:19 ` Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 6/8] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-03-29 12:22 ` Tvrtko Ursulin
2019-03-29 12:43 ` Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 7/8] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-03-29 12:33 ` Tvrtko Ursulin
2019-03-28 19:22 ` [igt-dev] [PATCH v16 8/8] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-03-29 12:40 ` Tvrtko Ursulin
2019-03-29 12:47 ` Andi Shyti
2019-03-29 12:56 ` Tvrtko Ursulin
2019-03-28 20:15 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-03-29 7:40 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42b9c840-b643-2249-cc79-3e8fa2eabf6a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=andi.shyti@intel.com \
--cc=andi@etezian.org \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox