public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi@etezian.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v16 5/8] tests: gem_exec_basic: add engine discovery test
Date: Sun, 31 Mar 2019 20:36:59 +0300	[thread overview]
Message-ID: <20190331173659.GA1149@jack.zhora.eu> (raw)
In-Reply-To: <155390256791.24691.6735236646369823020@skylake-alporthouse-com>

> > +       igt_subtest("exec-engines-ctx") {
> > +               uint64_t ctx_id;
> > +               struct intel_execution_engine2 *e2;
> > +
> > +               ctx_id = gem_context_create(fd);
> > +
> > +               for_each_context_engine(fd, ctx_id, e2)
> > +                       igt_assert(gem_context_has_engine(fd, ctx_id,
> > +                                                         e2->flags));
> > +
> > +               gem_context_destroy(fd, ctx_id);
> > +       }
> 
> Starting subtest: exec-engines-ctx
> (gem_exec_basic:17617) CRITICAL: Test assertion failure function __real_main117, file ../tests/i915/gem_exec_basic.c:146:
> (gem_exec_basic:17617) CRITICAL: Failed assertion: gem_context_has_engine(fd, ctx_id, e2->flags)
> Stack trace:
>   #0 ../lib/igt_core.c:1474 __igt_fail_assert()
>   #1 ../tests/i915/gem_exec_basic.c:144 __real_main117()
>   #2 ../tests/i915/gem_exec_basic.c:117 main()
>   #3 ../csu/libc-start.c:342 __libc_start_main()
>   #4 [_start+0x2a]
> Subtest exec-engines-ctx failed.
> **** DEBUG ****
> (gem_exec_basic:17617) CRITICAL: Test assertion failure function __real_main117, file ../tests/i915/gem_exec_basic.c:146:
> (gem_exec_basic:17617) CRITICAL: Failed assertion: gem_context_has_engine(fd, ctx_id, e2->flags)
> (gem_exec_basic:17617) igt_core-INFO: Stack trace:
> (gem_exec_basic:17617) igt_core-INFO:   #0 ../lib/igt_core.c:1474 __igt_fail_assert()
> (gem_exec_basic:17617) igt_core-INFO:   #1 ../tests/i915/gem_exec_basic.c:144 __real_main117()
> (gem_exec_basic:17617) igt_core-INFO:   #2 ../tests/i915/gem_exec_basic.c:117 main()
> (gem_exec_basic:17617) igt_core-INFO:   #3 ../csu/libc-start.c:342 __libc_start_main()
> (gem_exec_basic:17617) igt_core-INFO:   #4 [_start+0x2a]
> ****  END  ****
> 
> I'd say that is worth a little polishing on what the error might have
> been.

mmmhhh... how did you get it? I tested it on drm-tip kernel
(different versions), mainline kernel (different versions) and
Tvrtko's kernel and didn't get any failure.

All the patches were applied on latest igt until this one (to
make sure I didn't forget any dependency with future patches).

I executed it in loop several times and I have other tests on
top, I might have forgotten something.

Thanks for testing it,
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-03-31 17:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 19:21 [igt-dev] [RFC v16 0/8] new engine discovery interface Andi Shyti
2019-03-28 19:21 ` [igt-dev] [PATCH v16 1/8] lib/igt_gt: remove unnecessary argument Andi Shyti
2019-03-29 11:34   ` Tvrtko Ursulin
2019-03-28 19:22 ` [igt-dev] [PATCH v16 2/8] lib: ioctl_wrappers: reach engines by index as well Andi Shyti
2019-03-29 11:36   ` Tvrtko Ursulin
2019-03-29 11:59     ` Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 3/8] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 4/8] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-03-29 11:34   ` Tvrtko Ursulin
2019-03-29 12:05     ` Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 5/8] tests: gem_exec_basic: add engine discovery test Andi Shyti
2019-03-29 11:39   ` Tvrtko Ursulin
2019-03-29 12:06     ` Andi Shyti
2019-03-29 12:41       ` Tvrtko Ursulin
2019-03-29 23:36   ` Chris Wilson
2019-03-31 17:36     ` Andi Shyti [this message]
2019-03-31 17:42       ` Chris Wilson
2019-03-31 20:19         ` Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 6/8] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-03-29 12:22   ` Tvrtko Ursulin
2019-03-29 12:43     ` Andi Shyti
2019-03-28 19:22 ` [igt-dev] [PATCH v16 7/8] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-03-29 12:33   ` Tvrtko Ursulin
2019-03-28 19:22 ` [igt-dev] [PATCH v16 8/8] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-03-29 12:40   ` Tvrtko Ursulin
2019-03-29 12:47     ` Andi Shyti
2019-03-29 12:56       ` Tvrtko Ursulin
2019-03-28 20:15 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-03-29  7:40 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190331173659.GA1149@jack.zhora.eu \
    --to=andi@etezian.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox