* [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture
@ 2020-11-30 2:03 Arjun Melkaveri
2020-11-30 10:04 ` Tvrtko Ursulin
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Arjun Melkaveri @ 2020-11-30 2:03 UTC (permalink / raw)
To: arjun.melkaveri, igt-dev, tvrtko.ursulin
Added gem_require_mappable_ggtt to check mappable aperture.
This is to avoid any test crash that might happen
if mappable aperture is not avilable.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com>
---
tests/i915/gem_exec_reloc.c | 3 +++
tests/i915/gem_shrink.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/tests/i915/gem_exec_reloc.c b/tests/i915/gem_exec_reloc.c
index 8dcb24a6..596b1157 100644
--- a/tests/i915/gem_exec_reloc.c
+++ b/tests/i915/gem_exec_reloc.c
@@ -1217,6 +1217,7 @@ igt_main
if (!(f->flags & NORELOC)) {
igt_subtest_f("%srange%s",
f->basic ? "basic-" : "", f->name) {
+ gem_require_mappable_ggtt(fd);
igt_while_interruptible(f->flags & INTERRUPTIBLE)
basic_range(fd, f->flags);
}
@@ -1264,6 +1265,7 @@ igt_main
}
igt_subtest_with_dynamic("basic-spin") {
+
__for_each_physical_engine(fd, e) {
igt_dynamic_f("%s", e->name)
active_spin(fd, e->flags);
@@ -1278,6 +1280,7 @@ igt_main
}
igt_subtest_with_dynamic("basic-many-active") {
+ gem_require_mappable_ggtt(fd);
__for_each_physical_engine(fd, e) {
igt_dynamic_f("%s", e->name)
many_active(fd, e->flags);
diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c
index dba62c8f..094975af 100644
--- a/tests/i915/gem_shrink.c
+++ b/tests/i915/gem_shrink.c
@@ -432,6 +432,8 @@ igt_main
fd = drm_open_driver(DRIVER_INTEL);
igt_require_gem(fd);
+ gem_require_mappable_ggtt(fd);
+
/*
* Spawn enough processes to use all memory, but each only
* uses half the available mappable aperture ~128MiB.
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture 2020-11-30 2:03 [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture Arjun Melkaveri @ 2020-11-30 10:04 ` Tvrtko Ursulin 2020-11-30 10:12 ` Chris Wilson 2020-11-30 14:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2020-12-01 3:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2 siblings, 1 reply; 9+ messages in thread From: Tvrtko Ursulin @ 2020-11-30 10:04 UTC (permalink / raw) To: Arjun Melkaveri, igt-dev, tvrtko.ursulin On 30/11/2020 02:03, Arjun Melkaveri wrote: > Added gem_require_mappable_ggtt to check mappable aperture. > This is to avoid any test crash that might happen > if mappable aperture is not avilable. > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com> > --- > tests/i915/gem_exec_reloc.c | 3 +++ > tests/i915/gem_shrink.c | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/tests/i915/gem_exec_reloc.c b/tests/i915/gem_exec_reloc.c > index 8dcb24a6..596b1157 100644 > --- a/tests/i915/gem_exec_reloc.c > +++ b/tests/i915/gem_exec_reloc.c > @@ -1217,6 +1217,7 @@ igt_main > if (!(f->flags & NORELOC)) { > igt_subtest_f("%srange%s", > f->basic ? "basic-" : "", f->name) { > + gem_require_mappable_ggtt(fd); From the code and commit message it is not immediately obvious to me why basic_range needs the aperture, Chris? Answer to that will drive the solution. > igt_while_interruptible(f->flags & INTERRUPTIBLE) > basic_range(fd, f->flags); > } > @@ -1264,6 +1265,7 @@ igt_main > } > > igt_subtest_with_dynamic("basic-spin") { > + ! > __for_each_physical_engine(fd, e) { > igt_dynamic_f("%s", e->name) > active_spin(fd, e->flags); > @@ -1278,6 +1280,7 @@ igt_main > } > > igt_subtest_with_dynamic("basic-many-active") { > + gem_require_mappable_ggtt(fd); > __for_each_physical_engine(fd, e) { > igt_dynamic_f("%s", e->name) > many_active(fd, e->flags); Same for many_active - maybe tests should use ggtt size and not aperture, with some tweaks to make size/runtime sane? > diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c > index dba62c8f..094975af 100644 > --- a/tests/i915/gem_shrink.c > +++ b/tests/i915/gem_shrink.c > @@ -432,6 +432,8 @@ igt_main > fd = drm_open_driver(DRIVER_INTEL); > igt_require_gem(fd); > > + gem_require_mappable_ggtt(fd); > + > /* > * Spawn enough processes to use all memory, but each only > * uses half the available mappable aperture ~128MiB. > And for this one the same I think. Apart from the subtests using mmap-gtt other ones could probably be made work by calculating the working set in a different way. Possibly just use the ggtt size and skip tests which need aperture if no aperture. Chris would that be acceptable or there is a special reason to have N clients with each using an aperture sized amount of memory, to total RAM size? Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture 2020-11-30 10:04 ` Tvrtko Ursulin @ 2020-11-30 10:12 ` Chris Wilson 2020-11-30 12:09 ` Tvrtko Ursulin 0 siblings, 1 reply; 9+ messages in thread From: Chris Wilson @ 2020-11-30 10:12 UTC (permalink / raw) To: Arjun Melkaveri, Tvrtko Ursulin, igt-dev, tvrtko.ursulin Quoting Tvrtko Ursulin (2020-11-30 10:04:17) > > On 30/11/2020 02:03, Arjun Melkaveri wrote: > > Added gem_require_mappable_ggtt to check mappable aperture. > > This is to avoid any test crash that might happen > > if mappable aperture is not avilable. > > > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com> > > --- > > tests/i915/gem_exec_reloc.c | 3 +++ > > tests/i915/gem_shrink.c | 2 ++ > > 2 files changed, 5 insertions(+) > > > > diff --git a/tests/i915/gem_exec_reloc.c b/tests/i915/gem_exec_reloc.c > > index 8dcb24a6..596b1157 100644 > > --- a/tests/i915/gem_exec_reloc.c > > +++ b/tests/i915/gem_exec_reloc.c > > @@ -1217,6 +1217,7 @@ igt_main > > if (!(f->flags & NORELOC)) { > > igt_subtest_f("%srange%s", > > f->basic ? "basic-" : "", f->name) { > > + gem_require_mappable_ggtt(fd); > > From the code and commit message it is not immediately obvious to me > why basic_range needs the aperture, Chris? Answer to that will drive the > solution. It does not. > > > igt_while_interruptible(f->flags & INTERRUPTIBLE) > > basic_range(fd, f->flags); > > } > > @@ -1264,6 +1265,7 @@ igt_main > > } > > > > igt_subtest_with_dynamic("basic-spin") { > > + > > ! > > > __for_each_physical_engine(fd, e) { > > igt_dynamic_f("%s", e->name) > > active_spin(fd, e->flags); > > @@ -1278,6 +1280,7 @@ igt_main > > } > > > > igt_subtest_with_dynamic("basic-many-active") { > > + gem_require_mappable_ggtt(fd); > > __for_each_physical_engine(fd, e) { > > igt_dynamic_f("%s", e->name) > > many_active(fd, e->flags); > > Same for many_active - maybe tests should use ggtt size and not > aperture, with some tweaks to make size/runtime sane? It does not. This is somebody hacking over a major kernel bug. > > diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c > > index dba62c8f..094975af 100644 > > --- a/tests/i915/gem_shrink.c > > +++ b/tests/i915/gem_shrink.c > > @@ -432,6 +432,8 @@ igt_main > > fd = drm_open_driver(DRIVER_INTEL); > > igt_require_gem(fd); > > > > + gem_require_mappable_ggtt(fd); > > + > > /* > > * Spawn enough processes to use all memory, but each only > > * uses half the available mappable aperture ~128MiB. > > > > And for this one the same I think. Apart from the subtests using > mmap-gtt other ones could probably be made work by calculating the > working set in a different way. Possibly just use the ggtt size and skip > tests which need aperture if no aperture. Chris would that be acceptable > or there is a special reason to have N clients with each using an > aperture sized amount of memory, to total RAM size? shrink is system memory limits. -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture 2020-11-30 10:12 ` Chris Wilson @ 2020-11-30 12:09 ` Tvrtko Ursulin 2020-12-02 11:05 ` Melkaveri, Arjun 0 siblings, 1 reply; 9+ messages in thread From: Tvrtko Ursulin @ 2020-11-30 12:09 UTC (permalink / raw) To: Chris Wilson, Arjun Melkaveri, igt-dev, tvrtko.ursulin On 30/11/2020 10:12, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2020-11-30 10:04:17) >> On 30/11/2020 02:03, Arjun Melkaveri wrote: >>> Added gem_require_mappable_ggtt to check mappable aperture. >>> This is to avoid any test crash that might happen >>> if mappable aperture is not avilable. >>> >>> Cc: Chris Wilson <chris@chris-wilson.co.uk> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >>> Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com> >>> --- >>> tests/i915/gem_exec_reloc.c | 3 +++ >>> tests/i915/gem_shrink.c | 2 ++ >>> 2 files changed, 5 insertions(+) >>> >>> diff --git a/tests/i915/gem_exec_reloc.c b/tests/i915/gem_exec_reloc.c >>> index 8dcb24a6..596b1157 100644 >>> --- a/tests/i915/gem_exec_reloc.c >>> +++ b/tests/i915/gem_exec_reloc.c >>> @@ -1217,6 +1217,7 @@ igt_main >>> if (!(f->flags & NORELOC)) { >>> igt_subtest_f("%srange%s", >>> f->basic ? "basic-" : "", f->name) { >>> + gem_require_mappable_ggtt(fd); >> >> From the code and commit message it is not immediately obvious to me >> why basic_range needs the aperture, Chris? Answer to that will drive the >> solution. > > It does not. Okay, so the plan for this one should be to stop probing aperture size and instead probe the size of the address space in use. This will be ggtt on old gens and ppgtt on new ones. And to keep object count in check with regards to available backing store, if required (not sure right now). >> >>> igt_while_interruptible(f->flags & INTERRUPTIBLE) >>> basic_range(fd, f->flags); >>> } >>> @@ -1264,6 +1265,7 @@ igt_main >>> } >>> >>> igt_subtest_with_dynamic("basic-spin") { >>> + >> >> ! >> >>> __for_each_physical_engine(fd, e) { >>> igt_dynamic_f("%s", e->name) >>> active_spin(fd, e->flags); >>> @@ -1278,6 +1280,7 @@ igt_main >>> } >>> >>> igt_subtest_with_dynamic("basic-many-active") { >>> + gem_require_mappable_ggtt(fd); >>> __for_each_physical_engine(fd, e) { >>> igt_dynamic_f("%s", e->name) >>> many_active(fd, e->flags); >> >> Same for many_active - maybe tests should use ggtt size and not >> aperture, with some tweaks to make size/runtime sane? > > It does not. This is somebody hacking over a major kernel bug. Okay so same as above, don't probe aperture but address space size. > >>> diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c >>> index dba62c8f..094975af 100644 >>> --- a/tests/i915/gem_shrink.c >>> +++ b/tests/i915/gem_shrink.c >>> @@ -432,6 +432,8 @@ igt_main >>> fd = drm_open_driver(DRIVER_INTEL); >>> igt_require_gem(fd); >>> >>> + gem_require_mappable_ggtt(fd); >>> + >>> /* >>> * Spawn enough processes to use all memory, but each only >>> * uses half the available mappable aperture ~128MiB. >>> >> >> And for this one the same I think. Apart from the subtests using >> mmap-gtt other ones could probably be made work by calculating the >> working set in a different way. Possibly just use the ggtt size and skip >> tests which need aperture if no aperture. Chris would that be acceptable >> or there is a special reason to have N clients with each using an >> aperture sized amount of memory, to total RAM size? > > shrink is system memory limits. Yes, I was ignoring that aspect for now and focusing on the aperture size misuse. But yes, making gem_shrink falsely pass on dg1 is not what we really want. Probably make it explicitly use system memory objects once that API is available. Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture 2020-11-30 12:09 ` Tvrtko Ursulin @ 2020-12-02 11:05 ` Melkaveri, Arjun 2020-12-02 11:29 ` Chris Wilson 0 siblings, 1 reply; 9+ messages in thread From: Melkaveri, Arjun @ 2020-12-02 11:05 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: igt-dev, tvrtko.ursulin, Chris Wilson On Mon, Nov 30, 2020 at 12:09:10PM +0000, Tvrtko Ursulin wrote: > > On 30/11/2020 10:12, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2020-11-30 10:04:17) > > > On 30/11/2020 02:03, Arjun Melkaveri wrote: > > > > Added gem_require_mappable_ggtt to check mappable aperture. > > > > This is to avoid any test crash that might happen > > > > if mappable aperture is not avilable. > > > > > > > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > > > Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com> > > > > --- > > > > tests/i915/gem_exec_reloc.c | 3 +++ > > > > tests/i915/gem_shrink.c | 2 ++ > > > > 2 files changed, 5 insertions(+) > > > > > > > > diff --git a/tests/i915/gem_exec_reloc.c b/tests/i915/gem_exec_reloc.c > > > > index 8dcb24a6..596b1157 100644 > > > > --- a/tests/i915/gem_exec_reloc.c > > > > +++ b/tests/i915/gem_exec_reloc.c > > > > @@ -1217,6 +1217,7 @@ igt_main > > > > if (!(f->flags & NORELOC)) { > > > > igt_subtest_f("%srange%s", > > > > f->basic ? "basic-" : "", f->name) { > > > > + gem_require_mappable_ggtt(fd); > > > > > > From the code and commit message it is not immediately obvious to me > > > why basic_range needs the aperture, Chris? Answer to that will drive the > > > solution. > > > > It does not. > > Okay, so the plan for this one should be to stop probing aperture size and > instead probe the size of the address space in use. This will be ggtt on old > gens and ppgtt on new ones. And to keep object count in check with regards > to available backing store, if required (not sure right now). Let me know if this is okay #define MAX_47b ((1ull << 47)) // address range's most signifcant bit. const uint64_t max = (AT_LEAST_GEN(devid, 8) ? MAX_47b : gem_aperture_size(i915) / 2); instead of checking gem_require_mappable_ggtt in subtest . > > > > > > > > igt_while_interruptible(f->flags & INTERRUPTIBLE) > > > > basic_range(fd, f->flags); > > > > } > > > > @@ -1264,6 +1265,7 @@ igt_main > > > > } > > > > igt_subtest_with_dynamic("basic-spin") { > > > > + > > > > > > ! > > > > > > > __for_each_physical_engine(fd, e) { > > > > igt_dynamic_f("%s", e->name) > > > > active_spin(fd, e->flags); > > > > @@ -1278,6 +1280,7 @@ igt_main > > > > } > > > > igt_subtest_with_dynamic("basic-many-active") { > > > > + gem_require_mappable_ggtt(fd); > > > > __for_each_physical_engine(fd, e) { > > > > igt_dynamic_f("%s", e->name) > > > > many_active(fd, e->flags); > > > > > > Same for many_active - maybe tests should use ggtt size and not > > > aperture, with some tweaks to make size/runtime sane? > > > > It does not. This is somebody hacking over a major kernel bug. > > Okay so same as above, don't probe aperture but address space size. > > > > > > > diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c > > > > index dba62c8f..094975af 100644 > > > > --- a/tests/i915/gem_shrink.c > > > > +++ b/tests/i915/gem_shrink.c > > > > @@ -432,6 +432,8 @@ igt_main > > > > fd = drm_open_driver(DRIVER_INTEL); > > > > igt_require_gem(fd); > > > > + gem_require_mappable_ggtt(fd); > > > > + > > > > /* > > > > * Spawn enough processes to use all memory, but each only > > > > * uses half the available mappable aperture ~128MiB. > > > > > > > > > > And for this one the same I think. Apart from the subtests using > > > mmap-gtt other ones could probably be made work by calculating the > > > working set in a different way. Possibly just use the ggtt size and skip > > > tests which need aperture if no aperture. Chris would that be acceptable > > > or there is a special reason to have N clients with each using an > > > aperture sized amount of memory, to total RAM size? > > > > shrink is system memory limits. > > Yes, I was ignoring that aspect for now and focusing on the aperture size > misuse. But yes, making gem_shrink falsely pass on dg1 is not what we really > want. Probably make it explicitly use system memory objects once that API is > available. > > Regards, > > Tvrtko Any suggestion for this ? can we use gem_require_mappable_ggtt as all tests use size from gem_mappable_aperture_size. or can i modify code something like this #define MAX_32b ((1ull << 32)) alloc_size = AT_LEAST_GEN(intel_get_drm_devid(fd), 8) ? MAX_32b : gem_mappable_aperture_size(); alloc_size = alloc_size /2 Test would probabbly skip if estimated size is more than RAM + swap) -Arjun _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture 2020-12-02 11:05 ` Melkaveri, Arjun @ 2020-12-02 11:29 ` Chris Wilson 2020-12-02 15:17 ` Melkaveri, Arjun 0 siblings, 1 reply; 9+ messages in thread From: Chris Wilson @ 2020-12-02 11:29 UTC (permalink / raw) To: Melkaveri, Arjun, Tvrtko Ursulin; +Cc: igt-dev, tvrtko.ursulin Quoting Melkaveri, Arjun (2020-12-02 11:05:23) > On Mon, Nov 30, 2020 at 12:09:10PM +0000, Tvrtko Ursulin wrote: > > > > On 30/11/2020 10:12, Chris Wilson wrote: > > > Quoting Tvrtko Ursulin (2020-11-30 10:04:17) > > > > On 30/11/2020 02:03, Arjun Melkaveri wrote: > > > > > Added gem_require_mappable_ggtt to check mappable aperture. > > > > > This is to avoid any test crash that might happen > > > > > if mappable aperture is not avilable. > > > > > > > > > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > > > > Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com> > > > > > --- > > > > > tests/i915/gem_exec_reloc.c | 3 +++ > > > > > tests/i915/gem_shrink.c | 2 ++ > > > > > 2 files changed, 5 insertions(+) > > > > > > > > > > diff --git a/tests/i915/gem_exec_reloc.c b/tests/i915/gem_exec_reloc.c > > > > > index 8dcb24a6..596b1157 100644 > > > > > --- a/tests/i915/gem_exec_reloc.c > > > > > +++ b/tests/i915/gem_exec_reloc.c > > > > > @@ -1217,6 +1217,7 @@ igt_main > > > > > if (!(f->flags & NORELOC)) { > > > > > igt_subtest_f("%srange%s", > > > > > f->basic ? "basic-" : "", f->name) { > > > > > + gem_require_mappable_ggtt(fd); > > > > > > > > From the code and commit message it is not immediately obvious to me > > > > why basic_range needs the aperture, Chris? Answer to that will drive the > > > > solution. > > > > > > It does not. > > > > Okay, so the plan for this one should be to stop probing aperture size and > > instead probe the size of the address space in use. This will be ggtt on old > > gens and ppgtt on new ones. And to keep object count in check with regards > > to available backing store, if required (not sure right now). > Let me know if this is okay > #define MAX_47b ((1ull << 47)) // address range's most signifcant bit. > const uint64_t max = (AT_LEAST_GEN(devid, 8) ? MAX_47b : gem_aperture_size(i915) / 2); > instead of checking gem_require_mappable_ggtt in subtest . Where are you getting the impression that basic_range() uses the mappable aperture? > > > > > diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c > > > > > index dba62c8f..094975af 100644 > > > > > --- a/tests/i915/gem_shrink.c > > > > > +++ b/tests/i915/gem_shrink.c > > > > > @@ -432,6 +432,8 @@ igt_main > > > > > fd = drm_open_driver(DRIVER_INTEL); > > > > > igt_require_gem(fd); > > > > > + gem_require_mappable_ggtt(fd); > > > > > + > > > > > /* > > > > > * Spawn enough processes to use all memory, but each only > > > > > * uses half the available mappable aperture ~128MiB. > > > > > > > > > > > > > And for this one the same I think. Apart from the subtests using > > > > mmap-gtt other ones could probably be made work by calculating the > > > > working set in a different way. Possibly just use the ggtt size and skip > > > > tests which need aperture if no aperture. Chris would that be acceptable > > > > or there is a special reason to have N clients with each using an > > > > aperture sized amount of memory, to total RAM size? > > > > > > shrink is system memory limits. > > > > Yes, I was ignoring that aspect for now and focusing on the aperture size > > misuse. But yes, making gem_shrink falsely pass on dg1 is not what we really > > want. Probably make it explicitly use system memory objects once that API is > > available. > > > > Regards, > > > > Tvrtko > Any suggestion for this ? can we use gem_require_mappable_ggtt as all > tests use size from gem_mappable_aperture_size. or can i modify code > something like this > #define MAX_32b ((1ull << 32)) More conservative; use the 128MiB that I mention in the comments. The goal is to have many processes pushing the system to the edge so that there is plenty of contention on the shrinker. Being specifically a shrinker test, they should remain smem objects. -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture 2020-12-02 11:29 ` Chris Wilson @ 2020-12-02 15:17 ` Melkaveri, Arjun 0 siblings, 0 replies; 9+ messages in thread From: Melkaveri, Arjun @ 2020-12-02 15:17 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev, tvrtko.ursulin On Wed, Dec 02, 2020 at 11:29:11AM +0000, Chris Wilson wrote: > Quoting Melkaveri, Arjun (2020-12-02 11:05:23) > > On Mon, Nov 30, 2020 at 12:09:10PM +0000, Tvrtko Ursulin wrote: > > > > > > On 30/11/2020 10:12, Chris Wilson wrote: > > > > Quoting Tvrtko Ursulin (2020-11-30 10:04:17) > > > > > On 30/11/2020 02:03, Arjun Melkaveri wrote: > > > > > > Added gem_require_mappable_ggtt to check mappable aperture. > > > > > > This is to avoid any test crash that might happen > > > > > > if mappable aperture is not avilable. > > > > > > > > > > > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > > > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > > > > > Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com> > > > > > > --- > > > > > > tests/i915/gem_exec_reloc.c | 3 +++ > > > > > > tests/i915/gem_shrink.c | 2 ++ > > > > > > 2 files changed, 5 insertions(+) > > > > > > > > > > > > diff --git a/tests/i915/gem_exec_reloc.c b/tests/i915/gem_exec_reloc.c > > > > > > index 8dcb24a6..596b1157 100644 > > > > > > --- a/tests/i915/gem_exec_reloc.c > > > > > > +++ b/tests/i915/gem_exec_reloc.c > > > > > > @@ -1217,6 +1217,7 @@ igt_main > > > > > > if (!(f->flags & NORELOC)) { > > > > > > igt_subtest_f("%srange%s", > > > > > > f->basic ? "basic-" : "", f->name) { > > > > > > + gem_require_mappable_ggtt(fd); > > > > > > > > > > From the code and commit message it is not immediately obvious to me > > > > > why basic_range needs the aperture, Chris? Answer to that will drive the > > > > > solution. > > > > > > > > It does not. > > > > > > Okay, so the plan for this one should be to stop probing aperture size and > > > instead probe the size of the address space in use. This will be ggtt on old > > > gens and ppgtt on new ones. And to keep object count in check with regards > > > to available backing store, if required (not sure right now). > > Let me know if this is okay > > #define MAX_47b ((1ull << 47)) // address range's most signifcant bit. > > const uint64_t max = (AT_LEAST_GEN(devid, 8) ? MAX_47b : gem_aperture_size(i915) / 2); > > instead of checking gem_require_mappable_ggtt in subtest . > > Where are you getting the impression that basic_range() uses the > mappable aperture? my bad , i'll send patch only for gem_shrink that uses gem_require_mappable_ggtt. I was in doubt if aperture is not supported , gem_aperture_size would return 0 . something like on dg1. I got to know that gem_aperture_size, it would return gtt address space size. Will withdraw this changes . Thanks -Arjun > > > > > > > diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c > > > > > > index dba62c8f..094975af 100644 > > > > > > --- a/tests/i915/gem_shrink.c > > > > > > +++ b/tests/i915/gem_shrink.c > > > > > > @@ -432,6 +432,8 @@ igt_main > > > > > > fd = drm_open_driver(DRIVER_INTEL); > > > > > > igt_require_gem(fd); > > > > > > + gem_require_mappable_ggtt(fd); > > > > > > + > > > > > > /* > > > > > > * Spawn enough processes to use all memory, but each only > > > > > > * uses half the available mappable aperture ~128MiB. > > > > > > > > > > > > > > > > And for this one the same I think. Apart from the subtests using > > > > > mmap-gtt other ones could probably be made work by calculating the > > > > > working set in a different way. Possibly just use the ggtt size and skip > > > > > tests which need aperture if no aperture. Chris would that be acceptable > > > > > or there is a special reason to have N clients with each using an > > > > > aperture sized amount of memory, to total RAM size? > > > > > > > > shrink is system memory limits. > > > > > > Yes, I was ignoring that aspect for now and focusing on the aperture size > > > misuse. But yes, making gem_shrink falsely pass on dg1 is not what we really > > > want. Probably make it explicitly use system memory objects once that API is > > > available. > > > > > > Regards, > > > > > > Tvrtko > > Any suggestion for this ? can we use gem_require_mappable_ggtt as all > > tests use size from gem_mappable_aperture_size. or can i modify code > > something like this > > #define MAX_32b ((1ull << 32)) > > More conservative; use the 128MiB that I mention in the comments. > The goal is to have many processes pushing the system to the edge so > that there is plenty of contention on the shrinker. Being specifically a > shrinker test, they should remain smem objects. > -Chris Will modify this to use 128 MiB . Thanks Arjun _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture 2020-11-30 2:03 [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture Arjun Melkaveri 2020-11-30 10:04 ` Tvrtko Ursulin @ 2020-11-30 14:10 ` Patchwork 2020-12-01 3:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2020-11-30 14:10 UTC (permalink / raw) To: Arjun Melkaveri; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 5337 bytes --] == Series Details == Series: gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture URL : https://patchwork.freedesktop.org/series/84387/ State : success == Summary == CI Bug Log - changes from CI_DRM_9404 -> IGTPW_5238 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/index.html Known issues ------------ Here are the changes found in IGTPW_5238 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_close_race@basic-threads: - fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-bsw-kefka/igt@gem_close_race@basic-threads.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-bsw-kefka/igt@gem_close_race@basic-threads.html * igt@gem_mmap_gtt@basic: - fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-tgl-y/igt@gem_mmap_gtt@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-tgl-y/igt@gem_mmap_gtt@basic.html * igt@i915_module_load@reload: - fi-icl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-icl-u2/igt@i915_module_load@reload.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-icl-u2/igt@i915_module_load@reload.html - fi-kbl-soraka: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-kbl-soraka/igt@i915_module_load@reload.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-kbl-soraka/igt@i915_module_load@reload.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-bsw-n3050: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html #### Possible fixes #### * igt@core_hotunplug@unbind-rebind: - fi-kbl-7500u: [DMESG-WARN][11] -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-kbl-7500u/igt@core_hotunplug@unbind-rebind.html * igt@debugfs_test@read_all_entries: - fi-tgl-y: [DMESG-WARN][13] ([i915#402]) -> [PASS][14] +2 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-tgl-y/igt@debugfs_test@read_all_entries.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-tgl-y/igt@debugfs_test@read_all_entries.html * igt@i915_pm_rpm@module-reload: - fi-kbl-soraka: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-kbl-soraka/igt@i915_pm_rpm@module-reload.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-kbl-soraka/igt@i915_pm_rpm@module-reload.html * igt@kms_busy@basic@flip: - fi-tgl-y: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18] +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-tgl-y/igt@kms_busy@basic@flip.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-tgl-y/igt@kms_busy@basic@flip.html * igt@kms_chamelium@dp-crc-fast: - fi-cml-u2: [FAIL][19] ([i915#1161] / [i915#262]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-icl-u2: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (45 -> 39) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-blb-e6850 fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5876 -> IGTPW_5238 CI-20190529: 20190529 CI_DRM_9404: f515fa81d87ef367735d3a57a002fc72c8e55909 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_5238: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/index.html IGT_5876: cf2f41b3d3dfabaf3a4837062f996f3491a350b1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/index.html [-- Attachment #1.2: Type: text/html, Size: 6685 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture 2020-11-30 2:03 [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture Arjun Melkaveri 2020-11-30 10:04 ` Tvrtko Ursulin 2020-11-30 14:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2020-12-01 3:26 ` Patchwork 2 siblings, 0 replies; 9+ messages in thread From: Patchwork @ 2020-12-01 3:26 UTC (permalink / raw) To: Arjun Melkaveri; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 19502 bytes --] == Series Details == Series: gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture URL : https://patchwork.freedesktop.org/series/84387/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9404_full -> IGTPW_5238_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_5238_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_5238_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_5238_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-glk: NOTRUN -> [FAIL][1] +3 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-glk5/igt@gem_exec_reloc@basic-wide-active@bcs0.html Known issues ------------ Here are the changes found in IGTPW_5238_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_gttfill@all: - shard-glk: [PASS][2] -> [DMESG-WARN][3] ([i915#118] / [i915#95]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-glk1/igt@gem_exec_gttfill@all.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-glk7/igt@gem_exec_gttfill@all.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-hsw: [PASS][4] -> [FAIL][5] ([i915#2389]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-hsw6/igt@gem_exec_reloc@basic-many-active@rcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-hsw4/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][6] -> [SKIP][7] ([i915#2190]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-tglb3/igt@gem_huc_copy@huc-copy.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb6/igt@gem_huc_copy@huc-copy.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-tglb: [PASS][8] -> [INCOMPLETE][9] ([i915#1436] / [i915#1602] / [i915#1887] / [i915#2411] / [i915#456]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html - shard-apl: [PASS][10] -> [INCOMPLETE][11] ([i915#2635]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html - shard-iclb: [PASS][12] -> [INCOMPLETE][13] ([i915#1185]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-iclb8/igt@i915_suspend@fence-restore-tiled2untiled.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-iclb2/igt@i915_suspend@fence-restore-tiled2untiled.html - shard-kbl: [PASS][14] -> [INCOMPLETE][15] ([i915#155] / [i915#794]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-kbl2/igt@i915_suspend@fence-restore-tiled2untiled.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-kbl4/igt@i915_suspend@fence-restore-tiled2untiled.html - shard-hsw: [PASS][16] -> [INCOMPLETE][17] ([i915#2055] / [i915#2637]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-hsw4/igt@i915_suspend@fence-restore-tiled2untiled.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-hsw6/igt@i915_suspend@fence-restore-tiled2untiled.html - shard-glk: [PASS][18] -> [INCOMPLETE][19] ([i915#2199] / [i915#2635]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-glk3/igt@i915_suspend@fence-restore-tiled2untiled.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-glk1/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_big_fb@yf-tiled-32bpp-rotate-180: - shard-iclb: [PASS][20] -> [FAIL][21] ([i915#1119]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-iclb8/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-iclb5/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html * igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge: - shard-apl: [PASS][22] -> [DMESG-WARN][23] ([i915#1982]) +5 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-apl1/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-apl3/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html - shard-glk: [PASS][24] -> [DMESG-WARN][25] ([i915#1982]) +2 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-glk5/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-glk6/igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: [PASS][26] -> [FAIL][27] ([i915#72]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-varying-size: - shard-tglb: [PASS][28] -> [FAIL][29] ([i915#2346]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html * igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1: - shard-tglb: [PASS][30] -> [FAIL][31] ([i915#2122]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-tglb2/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb6/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc: - shard-kbl: [PASS][32] -> [DMESG-WARN][33] ([i915#1982]) +1 similar issue [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc: - shard-tglb: [PASS][34] -> [DMESG-WARN][35] ([i915#1982]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu: - shard-iclb: [PASS][36] -> [DMESG-WARN][37] ([i915#1982]) +1 similar issue [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html * igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c: - shard-hsw: [PASS][38] -> [DMESG-WARN][39] ([i915#1982]) +1 similar issue [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-hsw6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-hsw6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#109441]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@testdisplay: - shard-kbl: [PASS][42] -> [DMESG-WARN][43] ([i915#165] / [i915#78]) +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-kbl4/igt@testdisplay.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-kbl2/igt@testdisplay.html #### Possible fixes #### * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-glk: [FAIL][44] ([i915#2389]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-glk8/igt@gem_exec_reloc@basic-many-active@rcs0.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-glk6/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-hsw: [WARN][46] ([i915#1519]) -> [PASS][47] [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-hsw4/igt@i915_pm_rc6_residency@rc6-idle.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-hsw4/igt@i915_pm_rc6_residency@rc6-idle.html * {igt@kms_async_flips@alternate-sync-async-flip}: - shard-tglb: [FAIL][48] ([i915#2521]) -> [PASS][49] [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-tglb3/igt@kms_async_flips@alternate-sync-async-flip.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb3/igt@kms_async_flips@alternate-sync-async-flip.html * {igt@kms_async_flips@test-time-stamp}: - shard-tglb: [FAIL][50] ([i915#2597]) -> [PASS][51] [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-tglb8/igt@kms_async_flips@test-time-stamp.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb6/igt@kms_async_flips@test-time-stamp.html * igt@kms_big_fb@linear-8bpp-rotate-180: - shard-apl: [DMESG-WARN][52] ([i915#1982]) -> [PASS][53] +5 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-apl6/igt@kms_big_fb@linear-8bpp-rotate-180.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-apl6/igt@kms_big_fb@linear-8bpp-rotate-180.html * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-vga1-hdmi-a1: - shard-hsw: [FAIL][54] ([i915#2122]) -> [PASS][55] [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-hsw6/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-vga1-hdmi-a1.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-hsw4/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-vga1-hdmi-a1.html * igt@kms_flip@2x-plain-flip@ab-vga1-hdmi-a1: - shard-hsw: [DMESG-WARN][56] ([i915#1982]) -> [PASS][57] [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-hsw6/igt@kms_flip@2x-plain-flip@ab-vga1-hdmi-a1.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-hsw6/igt@kms_flip@2x-plain-flip@ab-vga1-hdmi-a1.html * igt@kms_frontbuffer_tracking@fbc-badstride: - shard-glk: [DMESG-WARN][58] ([i915#1982]) -> [PASS][59] +5 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-glk9/igt@kms_frontbuffer_tracking@fbc-badstride.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-glk1/igt@kms_frontbuffer_tracking@fbc-badstride.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc: - shard-tglb: [DMESG-WARN][60] ([i915#1982]) -> [PASS][61] +4 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt: - shard-iclb: [DMESG-WARN][62] ([i915#1982]) -> [PASS][63] [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-iclb3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-iclb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [SKIP][64] ([fdo#109441]) -> [PASS][65] +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_vblank@pipe-b-wait-forked-busy: - shard-kbl: [DMESG-WARN][66] ([i915#1982]) -> [PASS][67] +3 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-kbl1/igt@kms_vblank@pipe-b-wait-forked-busy.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-kbl2/igt@kms_vblank@pipe-b-wait-forked-busy.html * igt@perf_pmu@module-unload: - shard-apl: [DMESG-WARN][68] ([i915#1982] / [i915#262]) -> [PASS][69] [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-apl6/igt@perf_pmu@module-unload.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-apl3/igt@perf_pmu@module-unload.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][70] ([i915#1804] / [i915#2684]) -> [WARN][71] ([i915#2681] / [i915#2684]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc: - shard-apl: [DMESG-FAIL][72] ([fdo#108145] / [i915#1982]) -> [FAIL][73] ([fdo#108145] / [i915#265]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-apl3/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html * igt@runner@aborted: - shard-iclb: [FAIL][74] ([i915#2295] / [i915#2722]) -> ([FAIL][75], [FAIL][76]) ([i915#2295] / [i915#2722] / [i915#483]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-iclb4/igt@runner@aborted.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-iclb7/igt@runner@aborted.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-iclb2/igt@runner@aborted.html - shard-glk: ([FAIL][77], [FAIL][78]) ([i915#1814] / [i915#2295] / [i915#2722] / [k.org#202321]) -> ([FAIL][79], [FAIL][80]) ([i915#2295] / [i915#2722] / [k.org#202321]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-glk8/igt@runner@aborted.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-glk2/igt@runner@aborted.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-glk1/igt@runner@aborted.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-glk8/igt@runner@aborted.html - shard-tglb: [FAIL][81] ([i915#2295] / [i915#2722]) -> ([FAIL][82], [FAIL][83]) ([i915#1602] / [i915#2295] / [i915#2722]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9404/shard-tglb6/igt@runner@aborted.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb3/igt@runner@aborted.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/shard-tglb3/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [i915#1119]: https://gitlab.freedesktop.org/drm/intel/issues/1119 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#1887]: https://gitlab.freedesktop.org/drm/intel/issues/1887 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2199]: https://gitlab.freedesktop.org/drm/intel/issues/2199 [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597 [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262 [i915#2635]: https://gitlab.freedesktop.org/drm/intel/issues/2635 [i915#2637]: https://gitlab.freedesktop.org/drm/intel/issues/2637 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722 [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456 [i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78 [i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321 Participating hosts (10 -> 8) ------------------------------ Missing (2): pig-skl-6260u pig-glk-j5005 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5876 -> IGTPW_5238 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_9404: f515fa81d87ef367735d3a57a002fc72c8e55909 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_5238: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/index.html IGT_5876: cf2f41b3d3dfabaf3a4837062f996f3491a350b1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5238/index.html [-- Attachment #1.2: Type: text/html, Size: 23352 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-12-02 15:21 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-11-30 2:03 [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture Arjun Melkaveri 2020-11-30 10:04 ` Tvrtko Ursulin 2020-11-30 10:12 ` Chris Wilson 2020-11-30 12:09 ` Tvrtko Ursulin 2020-12-02 11:05 ` Melkaveri, Arjun 2020-12-02 11:29 ` Chris Wilson 2020-12-02 15:17 ` Melkaveri, Arjun 2020-11-30 14:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2020-12-01 3:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox