* [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access
@ 2023-03-20 14:36 Swati Sharma
2023-03-20 15:13 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Fix out-of-bound array access (rev5) Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Swati Sharma @ 2023-03-20 14:36 UTC (permalink / raw)
To: igt-dev; +Cc: Luca Coelho
With this fix we are solving 2 issues. Firstly, the
planes_scaling_combo() tests were leaving one scaler assigned
after running sub-test with two consecutive planes because
one scaler was getting reused in the next run. So with this fix
scaler is not reused since we won't have any common plane.
Secondly, when k == n_planes - 1, we were trying to access
planes[n_planes], which led to array out of bounds error. So, with
this fix, this issue is fixed too.
v2: -fix condition if n_planes is not even (JP)
Suggested-by: Luca Coelho <luciano.coelho@intel.com>
Suggested-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reported-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/kms_plane_scaling.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 3a6904afb..7feb45ca3 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -744,7 +744,7 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
igt_assert(0);
}
- for (int k = 0; k < display->pipes[pipe].n_planes; k++) {
+ for (int k = 0; k < display->pipes[pipe].n_planes - 1; k += 2) {
igt_plane_t *p1, *p2;
p1 = &display->pipes[pipe].planes[k];
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Fix out-of-bound array access (rev5) 2023-03-20 14:36 [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access Swati Sharma @ 2023-03-20 15:13 ` Patchwork 2023-03-20 18:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2023-03-20 15:13 UTC (permalink / raw) To: Swati Sharma; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 7115 bytes --] == Series Details == Series: tests/kms_plane_scaling: Fix out-of-bound array access (rev5) URL : https://patchwork.freedesktop.org/series/115274/ State : success == Summary == CI Bug Log - changes from CI_DRM_12883 -> IGTPW_8646 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/index.html Participating hosts (34 -> 36) ------------------------------ Additional (2): fi-kbl-soraka bat-atsm-1 Known issues ------------ Here are the changes found in IGTPW_8646 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@fbdev@eof: - bat-atsm-1: NOTRUN -> [SKIP][1] ([i915#2582]) +4 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@fbdev@eof.html * igt@gem_huc_copy@huc-copy: - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html * igt@gem_mmap@basic: - bat-atsm-1: NOTRUN -> [SKIP][4] ([i915#4083]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@gem_mmap@basic.html * igt@gem_tiled_fence_blits@basic: - bat-atsm-1: NOTRUN -> [SKIP][5] ([i915#4077]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html * igt@gem_tiled_pread_basic: - bat-atsm-1: NOTRUN -> [SKIP][6] ([i915#4079]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@gem_tiled_pread_basic.html * igt@i915_pm_rps@basic-api: - bat-atsm-1: NOTRUN -> [SKIP][7] ([i915#6621]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@i915_pm_rps@basic-api.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][8] ([i915#1886]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@i915_suspend@basic-s3-without-i915: - bat-atsm-1: NOTRUN -> [SKIP][9] ([i915#6645]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_addfb_basic@size-max: - bat-atsm-1: NOTRUN -> [SKIP][10] ([i915#6077]) +36 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@kms_addfb_basic@size-max.html * igt@kms_chamelium_frames@hdmi-crc-fast: - fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271]) +16 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html * igt@kms_cursor_legacy@basic-flip-after-cursor-atomic: - bat-atsm-1: NOTRUN -> [SKIP][12] ([i915#6078]) +19 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html * igt@kms_flip@basic-plain-flip: - bat-atsm-1: NOTRUN -> [SKIP][13] ([i915#6166]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@kms_flip@basic-plain-flip.html * igt@kms_force_connector_basic@prune-stale-modes: - bat-atsm-1: NOTRUN -> [SKIP][14] ([i915#6093]) +3 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_pipe_crc_basic@hang-read-crc: - bat-atsm-1: NOTRUN -> [SKIP][15] ([i915#1836]) +6 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@kms_pipe_crc_basic@hang-read-crc.html * igt@kms_prop_blob@basic: - bat-atsm-1: NOTRUN -> [SKIP][16] ([i915#7357]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@kms_prop_blob@basic.html * igt@kms_psr@sprite_plane_onoff: - bat-atsm-1: NOTRUN -> [SKIP][17] ([i915#1072]) +3 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html * igt@kms_setmode@basic-clone-single-crtc: - bat-atsm-1: NOTRUN -> [SKIP][18] ([i915#6094]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-fence-flip: - bat-atsm-1: NOTRUN -> [SKIP][19] ([fdo#109295] / [i915#6078]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@basic-fence-mmap: - bat-atsm-1: NOTRUN -> [SKIP][20] ([fdo#109295] / [i915#4077]) +1 similar issue [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@prime_vgem@basic-fence-mmap.html * igt@prime_vgem@basic-write: - bat-atsm-1: NOTRUN -> [SKIP][21] ([fdo#109295]) +3 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/bat-atsm-1/igt@prime_vgem@basic-write.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077 [i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078 [i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093 [i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094 [i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645 [i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7207 -> IGTPW_8646 CI-20190529: 20190529 CI_DRM_12883: 5619fa2b4a9b93019f6ca27a2f391fc39e152993 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_8646: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/index.html IGT_7207: 51001c91c367464da9e700e617fb712b3b1cecfd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/index.html [-- Attachment #2: Type: text/html, Size: 8635 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_scaling: Fix out-of-bound array access (rev5) 2023-03-20 14:36 [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access Swati Sharma 2023-03-20 15:13 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Fix out-of-bound array access (rev5) Patchwork @ 2023-03-20 18:19 ` Patchwork 2023-03-21 6:59 ` [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access Juha-Pekka Heikkila 2023-03-22 10:06 ` Luca Coelho 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2023-03-20 18:19 UTC (permalink / raw) To: Swati Sharma; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 26941 bytes --] == Series Details == Series: tests/kms_plane_scaling: Fix out-of-bound array access (rev5) URL : https://patchwork.freedesktop.org/series/115274/ State : success == Summary == CI Bug Log - changes from CI_DRM_12883_full -> IGTPW_8646_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/index.html Participating hosts (7 -> 7) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_8646_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@i915_pm_rpm@system-suspend-modeset: - {shard-dg1}: [PASS][1] -> [ABORT][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-dg1-12/igt@i915_pm_rpm@system-suspend-modeset.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-dg1-17/igt@i915_pm_rpm@system-suspend-modeset.html * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs: - {shard-rkl}: [SKIP][3] ([i915#1845] / [i915#4098]) -> [SKIP][4] +6 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-2/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-6/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs.html * igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs: - {shard-rkl}: [SKIP][5] ([i915#4098]) -> [SKIP][6] +4 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-6/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs.html * igt@kms_display_modes@extended-mode-basic: - {shard-dg1}: NOTRUN -> [SKIP][7] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-dg1-13/igt@kms_display_modes@extended-mode-basic.html * igt@kms_plane@plane-panning-top-left: - {shard-tglu}: NOTRUN -> [SKIP][8] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-tglu-9/igt@kms_plane@plane-panning-top-left.html * igt@kms_plane@plane-position-hole-dpms: - {shard-rkl}: NOTRUN -> [SKIP][9] +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-3/igt@kms_plane@plane-position-hole-dpms.html Known issues ------------ Here are the changes found in IGTPW_8646_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_userptr_blits@vma-merge: - shard-glk: NOTRUN -> [FAIL][10] ([i915#3318]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-glk1/igt@gem_userptr_blits@vma-merge.html * igt@gen9_exec_parse@allowed-all: - shard-apl: [PASS][11] -> [ABORT][12] ([i915#5566]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-apl6/igt@gen9_exec_parse@allowed-all.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-apl4/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_rps@reset: - shard-snb: [PASS][13] -> [INCOMPLETE][14] ([i915#7790]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-snb5/igt@i915_pm_rps@reset.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-snb4/igt@i915_pm_rps@reset.html * igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#3886]) +2 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-apl4/igt@kms_ccs@pipe-a-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc: - shard-glk: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#3886]) +1 similar issue [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-glk1/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271]) +81 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-apl1/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs.html * igt@kms_flip@flip-vs-suspend@b-dp1: - shard-apl: [PASS][18] -> [ABORT][19] ([i915#180]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-apl6/igt@kms_flip@flip-vs-suspend@b-dp1.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-apl7/igt@kms_flip@flip-vs-suspend@b-dp1.html * igt@kms_flip@plain-flip-fb-recreate@b-hdmi-a2: - shard-glk: [PASS][20] -> [FAIL][21] ([i915#2122]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-glk8/igt@kms_flip@plain-flip-fb-recreate@b-hdmi-a2.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-glk5/igt@kms_flip@plain-flip-fb-recreate@b-hdmi-a2.html * igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1: - shard-apl: NOTRUN -> [FAIL][22] ([i915#4573]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-apl1/igt@kms_plane_alpha_blend@alpha-opaque-fb@pipe-a-dp-1.html * igt@kms_psr2_sf@cursor-plane-move-continuous-sf: - shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#658]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-apl7/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html * igt@v3d/v3d_perfmon@destroy-invalid-perfmon: - shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271]) +28 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-glk8/igt@v3d/v3d_perfmon@destroy-invalid-perfmon.html #### Possible fixes #### * igt@fbdev@pan: - {shard-tglu}: [SKIP][25] ([i915#2582]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-10/igt@fbdev@pan.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-tglu-6/igt@fbdev@pan.html * igt@fbdev@read: - {shard-rkl}: [SKIP][27] ([i915#2582]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@fbdev@read.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-2/igt@fbdev@read.html * {igt@gem_barrier_race@remote-request@rcs0}: - {shard-rkl}: [ABORT][29] ([i915#8211]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-1/igt@gem_barrier_race@remote-request@rcs0.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-6/igt@gem_barrier_race@remote-request@rcs0.html - shard-glk: [ABORT][31] ([i915#8211]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-glk9/igt@gem_barrier_race@remote-request@rcs0.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-glk1/igt@gem_barrier_race@remote-request@rcs0.html * igt@gem_ctx_isolation@preservation-s3@bcs0: - {shard-rkl}: [FAIL][33] ([fdo#103375]) -> [PASS][34] +3 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-4/igt@gem_ctx_isolation@preservation-s3@bcs0.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-5/igt@gem_ctx_isolation@preservation-s3@bcs0.html * igt@gem_exec_fair@basic-none@vcs0: - {shard-rkl}: [FAIL][35] ([i915#2842]) -> [PASS][36] +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-4/igt@gem_exec_fair@basic-none@vcs0.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-5/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][37] ([i915#2842]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_reloc@basic-cpu-gtt-noreloc: - {shard-rkl}: [SKIP][39] ([i915#3281]) -> [PASS][40] +4 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-1/igt@gem_exec_reloc@basic-cpu-gtt-noreloc.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-5/igt@gem_exec_reloc@basic-cpu-gtt-noreloc.html * igt@gem_exec_schedule@pi-distinct-iova@vecs0: - shard-glk: [DMESG-WARN][41] ([i915#118]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-glk9/igt@gem_exec_schedule@pi-distinct-iova@vecs0.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-glk9/igt@gem_exec_schedule@pi-distinct-iova@vecs0.html * igt@gem_pwrite@basic-self: - {shard-rkl}: [SKIP][43] ([i915#3282]) -> [PASS][44] +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-2/igt@gem_pwrite@basic-self.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-5/igt@gem_pwrite@basic-self.html * igt@gen9_exec_parse@bb-chained: - {shard-rkl}: [SKIP][45] ([i915#2527]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-4/igt@gen9_exec_parse@bb-chained.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-5/igt@gen9_exec_parse@bb-chained.html * igt@i915_pm_dc@dc5-dpms: - {shard-rkl}: [FAIL][47] ([i915#7330]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@i915_pm_dc@dc5-dpms.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-5/igt@i915_pm_dc@dc5-dpms.html * {igt@i915_pm_dc@dc5-dpms-negative}: - {shard-tglu}: [SKIP][49] ([i915#8018]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-10/igt@i915_pm_dc@dc5-dpms-negative.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-tglu-8/igt@i915_pm_dc@dc5-dpms-negative.html * igt@i915_pm_dc@dc9-dpms: - {shard-rkl}: [SKIP][51] ([i915#3361]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@i915_pm_dc@dc9-dpms.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-3/igt@i915_pm_dc@dc9-dpms.html - shard-apl: [SKIP][53] ([fdo#109271]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-apl1/igt@i915_pm_dc@dc9-dpms.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-apl2/igt@i915_pm_dc@dc9-dpms.html * igt@i915_pm_rpm@pm-tiling: - {shard-rkl}: [SKIP][55] ([fdo#109308]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-2/igt@i915_pm_rpm@pm-tiling.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-6/igt@i915_pm_rpm@pm-tiling.html * igt@i915_suspend@fence-restore-untiled: - {shard-tglu}: [ABORT][57] ([i915#5122]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-9/igt@i915_suspend@fence-restore-untiled.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-tglu-3/igt@i915_suspend@fence-restore-untiled.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-apl: [FAIL][59] ([i915#2346]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-glk: [FAIL][61] ([i915#2346]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions: - {shard-tglu}: [SKIP][63] ([i915#1845]) -> [PASS][64] +20 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-10/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-tglu-6/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-suspend@c-dp1: - shard-apl: [ABORT][65] ([i915#180]) -> [PASS][66] +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-apl7/igt@kms_flip@flip-vs-suspend@c-dp1.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt: - {shard-tglu}: [SKIP][67] ([i915#1849]) -> [PASS][68] +3 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-10/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@psr-suspend: - {shard-rkl}: [SKIP][69] ([i915#1849] / [i915#4098]) -> [PASS][70] +7 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-suspend.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-suspend.html * igt@kms_properties@plane-properties-legacy: - {shard-rkl}: [SKIP][71] ([i915#1849]) -> [PASS][72] +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-2/igt@kms_properties@plane-properties-legacy.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-6/igt@kms_properties@plane-properties-legacy.html * igt@kms_psr@primary_mmap_gtt: - {shard-rkl}: [SKIP][73] ([i915#1072]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-4/igt@kms_psr@primary_mmap_gtt.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-6/igt@kms_psr@primary_mmap_gtt.html * igt@kms_vblank@pipe-b-accuracy-idle: - {shard-rkl}: [SKIP][75] ([i915#1845] / [i915#4098]) -> [PASS][76] +20 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-5/igt@kms_vblank@pipe-b-accuracy-idle.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-6/igt@kms_vblank@pipe-b-accuracy-idle.html * igt@kms_vblank@pipe-b-wait-forked-busy-hang: - {shard-tglu}: [SKIP][77] ([i915#1845] / [i915#7651]) -> [PASS][78] +19 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-tglu-9/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-tglu-3/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html * igt@perf_pmu@idle@rcs0: - {shard-rkl}: [FAIL][79] ([i915#4349]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-3/igt@perf_pmu@idle@rcs0.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-3/igt@perf_pmu@idle@rcs0.html * igt@prime_vgem@basic-fence-read: - {shard-rkl}: [SKIP][81] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12883/shard-rkl-4/igt@prime_vgem@basic-fence-read.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/shard-rkl-5/igt@prime_vgem@basic-fence-read.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528 [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936 [i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854 [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258 [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259 [i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334 [i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944 [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953 [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128 [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294 [i915#7330]: https://gitlab.freedesktop.org/drm/intel/issues/7330 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949 [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957 [i915#8018]: https://gitlab.freedesktop.org/drm/intel/issues/8018 [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152 [i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154 [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211 [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228 [i915#8282]: https://gitlab.freedesktop.org/drm/intel/issues/8282 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7207 -> IGTPW_8646 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_12883: 5619fa2b4a9b93019f6ca27a2f391fc39e152993 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_8646: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/index.html IGT_7207: 51001c91c367464da9e700e617fb712b3b1cecfd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8646/index.html [-- Attachment #2: Type: text/html, Size: 22097 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access 2023-03-20 14:36 [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access Swati Sharma 2023-03-20 15:13 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Fix out-of-bound array access (rev5) Patchwork 2023-03-20 18:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2023-03-21 6:59 ` Juha-Pekka Heikkila 2023-03-22 10:06 ` Luca Coelho 3 siblings, 0 replies; 7+ messages in thread From: Juha-Pekka Heikkila @ 2023-03-21 6:59 UTC (permalink / raw) To: Swati Sharma, igt-dev; +Cc: Luca Coelho Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> On 20.3.2023 16.36, Swati Sharma wrote: > With this fix we are solving 2 issues. Firstly, the > planes_scaling_combo() tests were leaving one scaler assigned > after running sub-test with two consecutive planes because > one scaler was getting reused in the next run. So with this fix > scaler is not reused since we won't have any common plane. > > Secondly, when k == n_planes - 1, we were trying to access > planes[n_planes], which led to array out of bounds error. So, with > this fix, this issue is fixed too. > > v2: -fix condition if n_planes is not even (JP) > > Suggested-by: Luca Coelho <luciano.coelho@intel.com> > Suggested-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > Reported-by: Luca Coelho <luciano.coelho@intel.com> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com> > --- > tests/kms_plane_scaling.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c > index 3a6904afb..7feb45ca3 100644 > --- a/tests/kms_plane_scaling.c > +++ b/tests/kms_plane_scaling.c > @@ -744,7 +744,7 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2, > igt_assert(0); > } > > - for (int k = 0; k < display->pipes[pipe].n_planes; k++) { > + for (int k = 0; k < display->pipes[pipe].n_planes - 1; k += 2) { > igt_plane_t *p1, *p2; > > p1 = &display->pipes[pipe].planes[k]; ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access 2023-03-20 14:36 [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access Swati Sharma ` (2 preceding siblings ...) 2023-03-21 6:59 ` [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access Juha-Pekka Heikkila @ 2023-03-22 10:06 ` Luca Coelho 2023-03-22 10:22 ` Swati Sharma 3 siblings, 1 reply; 7+ messages in thread From: Luca Coelho @ 2023-03-22 10:06 UTC (permalink / raw) To: Swati Sharma, igt-dev On Mon, 2023-03-20 at 20:06 +0530, Swati Sharma wrote: > With this fix we are solving 2 issues. Firstly, the > planes_scaling_combo() tests were leaving one scaler assigned > after running sub-test with two consecutive planes because > one scaler was getting reused in the next run. So with this fix > scaler is not reused since we won't have any common plane. > > Secondly, when k == n_planes - 1, we were trying to access > planes[n_planes], which led to array out of bounds error. So, with > this fix, this issue is fixed too. > > v2: -fix condition if n_planes is not even (JP) > > Suggested-by: Luca Coelho <luciano.coelho@intel.com> > Suggested-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > Reported-by: Luca Coelho <luciano.coelho@intel.com> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com> > --- > tests/kms_plane_scaling.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c > index 3a6904afb..7feb45ca3 100644 > --- a/tests/kms_plane_scaling.c > +++ b/tests/kms_plane_scaling.c > @@ -744,7 +744,7 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2, > igt_assert(0); > } > > - for (int k = 0; k < display->pipes[pipe].n_planes; k++) { > + for (int k = 0; k < display->pipes[pipe].n_planes - 1; k += 2) { > igt_plane_t *p1, *p2; > > p1 = &display->pipes[pipe].planes[k]; What will happen if we have only 1 plane? Shouldn't the test be skipped? It seems that the loop will just not run and the test result will be pass? -- Cheers, Luca. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access 2023-03-22 10:06 ` Luca Coelho @ 2023-03-22 10:22 ` Swati Sharma 2023-03-22 10:44 ` Luca Coelho 0 siblings, 1 reply; 7+ messages in thread From: Swati Sharma @ 2023-03-22 10:22 UTC (permalink / raw) To: Luca Coelho, igt-dev On 22-Mar-23 3:36 PM, Luca Coelho wrote: > On Mon, 2023-03-20 at 20:06 +0530, Swati Sharma wrote: >> With this fix we are solving 2 issues. Firstly, the >> planes_scaling_combo() tests were leaving one scaler assigned >> after running sub-test with two consecutive planes because >> one scaler was getting reused in the next run. So with this fix >> scaler is not reused since we won't have any common plane. >> >> Secondly, when k == n_planes - 1, we were trying to access >> planes[n_planes], which led to array out of bounds error. So, with >> this fix, this issue is fixed too. >> >> v2: -fix condition if n_planes is not even (JP) >> >> Suggested-by: Luca Coelho <luciano.coelho@intel.com> >> Suggested-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> >> Reported-by: Luca Coelho <luciano.coelho@intel.com> >> Signed-off-by: Swati Sharma <swati2.sharma@intel.com> >> --- >> tests/kms_plane_scaling.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c >> index 3a6904afb..7feb45ca3 100644 >> --- a/tests/kms_plane_scaling.c >> +++ b/tests/kms_plane_scaling.c >> @@ -744,7 +744,7 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2, >> igt_assert(0); >> } >> >> - for (int k = 0; k < display->pipes[pipe].n_planes; k++) { >> + for (int k = 0; k < display->pipes[pipe].n_planes - 1; k += 2) { >> igt_plane_t *p1, *p2; >> >> p1 = &display->pipes[pipe].planes[k]; > > What will happen if we have only 1 plane? Shouldn't the test be > skipped? It seems that the loop will just not run and the test result > will be pass? Right. Should we add igt_require(n_planes >=2)? With that if n_planes=1 test will SKIP. > > -- > Cheers, > Luca. -- ~Swati Sharma ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access 2023-03-22 10:22 ` Swati Sharma @ 2023-03-22 10:44 ` Luca Coelho 0 siblings, 0 replies; 7+ messages in thread From: Luca Coelho @ 2023-03-22 10:44 UTC (permalink / raw) To: Swati Sharma, igt-dev On Wed, 2023-03-22 at 15:52 +0530, Swati Sharma wrote: > > On 22-Mar-23 3:36 PM, Luca Coelho wrote: > > On Mon, 2023-03-20 at 20:06 +0530, Swati Sharma wrote: > > > With this fix we are solving 2 issues. Firstly, the > > > planes_scaling_combo() tests were leaving one scaler assigned > > > after running sub-test with two consecutive planes because > > > one scaler was getting reused in the next run. So with this fix > > > scaler is not reused since we won't have any common plane. > > > > > > Secondly, when k == n_planes - 1, we were trying to access > > > planes[n_planes], which led to array out of bounds error. So, with > > > this fix, this issue is fixed too. > > > > > > v2: -fix condition if n_planes is not even (JP) > > > > > > Suggested-by: Luca Coelho <luciano.coelho@intel.com> > > > Suggested-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > > > Reported-by: Luca Coelho <luciano.coelho@intel.com> > > > Signed-off-by: Swati Sharma <swati2.sharma@intel.com> > > > --- > > > tests/kms_plane_scaling.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c > > > index 3a6904afb..7feb45ca3 100644 > > > --- a/tests/kms_plane_scaling.c > > > +++ b/tests/kms_plane_scaling.c > > > @@ -744,7 +744,7 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2, > > > igt_assert(0); > > > } > > > > > > - for (int k = 0; k < display->pipes[pipe].n_planes; k++) { > > > + for (int k = 0; k < display->pipes[pipe].n_planes - 1; k += 2) { > > > igt_plane_t *p1, *p2; > > > > > > p1 = &display->pipes[pipe].planes[k]; > > > > What will happen if we have only 1 plane? Shouldn't the test be > > skipped? It seems that the loop will just not run and the test result > > will be pass? > Right. > Should we add igt_require(n_planes >=2)? > With that if n_planes=1 test will SKIP. > Yes, that sounds reasonable. -- Cheers, Luca. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-22 10:44 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-03-20 14:36 [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access Swati Sharma 2023-03-20 15:13 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: Fix out-of-bound array access (rev5) Patchwork 2023-03-20 18:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2023-03-21 6:59 ` [igt-dev] [PATCH i-g-t v2] tests/kms_plane_scaling: Fix out-of-bound array access Juha-Pekka Heikkila 2023-03-22 10:06 ` Luca Coelho 2023-03-22 10:22 ` Swati Sharma 2023-03-22 10:44 ` Luca Coelho
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox