[igt-dev] [PATCH i-g-t] tests/perf: adapt report timing delta acceptance for ICL

[igt-dev] [PATCH i-g-t] tests/perf: adapt report timing delta acceptance for ICL

[Lionel Landwerlin]

The behavior of the OA unit is a tiny bit different on ICL. It appears
to be a bit sloppier on the timings of its OA reports (missing the
deadline by one period quite often). Let's add an acceptance delta.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/perf.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/tests/perf.c b/tests/perf.c
index 6a6001d5..a92de221 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -1674,6 +1674,16 @@ static void load_helper_fini(void)
 		drm_intel_bufmgr_destroy(lh.bufmgr);
 }
 
+static bool expected_report_timing_delta(uint32_t delta, uint32_t expected_delta)
+{
+	/*
+	 * On ICL, the OA unit appears to be a bit more relaxed about
+	 * its timing for emitting OA reports (often missing the
+	 * deadline by 1 timestamp).
+	 */
+	return delta <= (expected_delta + 3);
+}
+
 static void
 test_oa_exponents(void)
 {
@@ -1774,9 +1784,9 @@ test_oa_exponents(void)
 			igt_debug("report%04i ts=%08x hw_id=0x%08x delta=%u %s\n", i,
 				  timer_reports[i].report[1],
 				  oa_report_get_ctx_id(timer_reports[i].report),
-				  delta, delta == expected_timestamp_delta ? "" : "******");
+				  delta, expected_report_timing_delta(delta,expected_timestamp_delta) ? "" : "******");
 
-			matches += expected_timestamp_delta <= delta;
+			matches += expected_report_timing_delta(delta,expected_timestamp_delta);
 		}
 
 		igt_debug("matches=%u/%u\n", matches, n_timer_reports - 1);
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/perf: adapt report timing delta acceptance for ICL

[Patchwork]

== Series Details ==

Series: tests/perf: adapt report timing delta acceptance for ICL
URL   : https://patchwork.freedesktop.org/series/50814/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4958 -> IGTPW_1934 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50814/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1934 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> DMESG-FAIL (fdo#103713)

    igt@kms_setmode@basic-clone-single-crtc:
      fi-snb-2520m:       PASS -> DMESG-WARN (fdo#103713)

    igt@pm_backlight@basic-brightness:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    igt@pm_rpm@basic-pci-d3-state:
      fi-skl-6600u:       FAIL (fdo#107707) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#107707 https://bugs.freedesktop.org/show_bug.cgi?id=107707
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718


== Participating hosts (48 -> 41) ==

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bwr-2160 fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4672 -> IGTPW_1934

  CI_DRM_4958: 9990e1665029dc2ef4a9c0632b8a2f516263e595 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1934: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1934/
  IGT_4672: 4497591d2572831a9f07fd9e48a2571bfcffe354 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1934/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/perf: adapt report timing delta acceptance for ICL

[Patchwork]

== Series Details ==

Series: tests/perf: adapt report timing delta acceptance for ICL
URL   : https://patchwork.freedesktop.org/series/50814/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4672_full -> IGTPW_1934_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1934_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1934_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50814/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1934_full:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1934_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_cursor_crc@cursor-128x42-random:
      shard-glk:          PASS -> FAIL (fdo#103232) +1

    igt@kms_cursor_crc@cursor-64x64-dpms:
      shard-kbl:          PASS -> FAIL (fdo#103232) +2
      shard-apl:          PASS -> FAIL (fdo#103232) +1

    igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
      shard-glk:          PASS -> DMESG-WARN (fdo#106538, fdo#105763) +1

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-apl:          PASS -> FAIL (fdo#103167) +2

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
      shard-glk:          PASS -> FAIL (fdo#103167)
      shard-kbl:          PASS -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
      shard-glk:          PASS -> DMESG-FAIL (fdo#106538)

    igt@kms_frontbuffer_tracking@fbc-tilingchange:
      shard-glk:          PASS -> INCOMPLETE (k.org#198133, fdo#103359)

    {igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max}:
      shard-glk:          PASS -> FAIL (fdo#108145)
      shard-kbl:          PASS -> FAIL (fdo#108145)
      shard-apl:          PASS -> FAIL (fdo#108145)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-glk:          PASS -> FAIL (fdo#103166) +1

    igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
      shard-apl:          PASS -> FAIL (fdo#103166)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          NOTRUN -> FAIL (fdo#103925)

    igt@pm_rpm@gem-execbuf-stress-extra-wait:
      shard-apl:          PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-apl:          FAIL (fdo#106641) -> PASS

    igt@kms_busy@extended-pageflip-hang-newfb-render-c:
      shard-glk:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_cursor_crc@cursor-256x256-sliding:
      shard-glk:          FAIL (fdo#103232) -> PASS +2

    igt@kms_cursor_crc@cursor-64x64-sliding:
      shard-apl:          FAIL (fdo#103232) -> PASS +1
      shard-kbl:          FAIL (fdo#103232) -> PASS

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-apl:          FAIL (fdo#103232, fdo#103191) -> PASS

    igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
      shard-hsw:          FAIL (fdo#105767) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
      shard-apl:          FAIL (fdo#103167) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
      shard-glk:          FAIL (fdo#103167) -> PASS +1

    igt@kms_plane@plane-position-covered-pipe-a-planes:
      shard-glk:          FAIL (fdo#103166) -> PASS +2

    {igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max}:
      shard-glk:          FAIL (fdo#108145) -> PASS +1
      shard-apl:          FAIL (fdo#108145) -> PASS
      shard-kbl:          FAIL (fdo#108145) -> PASS

    igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
      shard-apl:          FAIL (fdo#103166) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    
    ==== Warnings ====

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359) -> FAIL (fdo#103232)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (6 -> 5) ==

  Missing    (1): shard-skl 


== Build changes ==

    * IGT: IGT_4672 -> IGTPW_1934
    * Linux: CI_DRM_4952 -> CI_DRM_4958

  CI_DRM_4952: a62e43ba13605a478b22307ea1790d48aea029a6 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4958: 9990e1665029dc2ef4a9c0632b8a2f516263e595 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1934: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1934/
  IGT_4672: 4497591d2572831a9f07fd9e48a2571bfcffe354 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1934/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/perf: adapt report timing delta acceptance for ICL

[Souza, Jose]

On Wed, 2018-10-10 at 18:49 +0100, Lionel Landwerlin wrote:
> The behavior of the OA unit is a tiny bit different on ICL. It
> appears
> to be a bit sloppier on the timings of its OA reports (missing the
> deadline by one period quite often). Let's add an acceptance delta.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
>  tests/perf.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/perf.c b/tests/perf.c
> index 6a6001d5..a92de221 100644
> --- a/tests/perf.c
> +++ b/tests/perf.c
> @@ -1674,6 +1674,16 @@ static void load_helper_fini(void)
>  		drm_intel_bufmgr_destroy(lh.bufmgr);
>  }
>  
> +static bool expected_report_timing_delta(uint32_t delta, uint32_t
> expected_delta)
> +{
> +	/*
> +	 * On ICL, the OA unit appears to be a bit more relaxed about
> +	 * its timing for emitting OA reports (often missing the
> +	 * deadline by 1 timestamp).
> +	 */

Maybe only relax for ICL?

> +	return delta <= (expected_delta + 3);
> +}
> +
>  static void
>  test_oa_exponents(void)
>  {
> @@ -1774,9 +1784,9 @@ test_oa_exponents(void)
>  			igt_debug("report%04i ts=%08x hw_id=0x%08x
> delta=%u %s\n", i,
>  				  timer_reports[i].report[1],
>  				  oa_report_get_ctx_id(timer_reports[i]
> .report),
> -				  delta, delta ==
> expected_timestamp_delta ? "" : "******");
> +				  delta,
> expected_report_timing_delta(delta,expected_timestamp_delta) ? "" :
> "******");


Nitpick: s/delta,
expected_report_timing_delta(delta,expected_timestamp_delta) ? "" :
"******");/delta, expected_report_timing_delta(delta,
expected_timestamp_delta) ? "" : "******");

>  
> -			matches += expected_timestamp_delta <= delta;
> +			matches +=
> expected_report_timing_delta(delta,expected_timestamp_delta);
>  		}
>  
>  		igt_debug("matches=%u/%u\n", matches, n_timer_reports -
> 1);


I tested the patch with gen11 rendercopy and it worked, big thanks for
fixing it.

With the minor fixes above:
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

I saw that you subimited the 'libs: Adding rendercopy support for
gen11' separated and Kasia have reviewed but I think this one should be
merged first, maybe submited the second version of this PR with both
patches? 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/perf: adapt report timing delta acceptance for ICL

[Lionel Landwerlin]

On 13/10/2018 00:32, Souza, Jose wrote:
> On Wed, 2018-10-10 at 18:49 +0100, Lionel Landwerlin wrote:
>> The behavior of the OA unit is a tiny bit different on ICL. It
>> appears
>> to be a bit sloppier on the timings of its OA reports (missing the
>> deadline by one period quite often). Let's add an acceptance delta.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> ---
>>   tests/perf.c | 14 ++++++++++++--
>>   1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/perf.c b/tests/perf.c
>> index 6a6001d5..a92de221 100644
>> --- a/tests/perf.c
>> +++ b/tests/perf.c
>> @@ -1674,6 +1674,16 @@ static void load_helper_fini(void)
>>   		drm_intel_bufmgr_destroy(lh.bufmgr);
>>   }
>>   
>> +static bool expected_report_timing_delta(uint32_t delta, uint32_t
>> expected_delta)
>> +{
>> +	/*
>> +	 * On ICL, the OA unit appears to be a bit more relaxed about
>> +	 * its timing for emitting OA reports (often missing the
>> +	 * deadline by 1 timestamp).
>> +	 */
> Maybe only relax for ICL?
>
>> +	return delta <= (expected_delta + 3);
>> +}
>> +
>>   static void
>>   test_oa_exponents(void)
>>   {
>> @@ -1774,9 +1784,9 @@ test_oa_exponents(void)
>>   			igt_debug("report%04i ts=%08x hw_id=0x%08x
>> delta=%u %s\n", i,
>>   				  timer_reports[i].report[1],
>>   				  oa_report_get_ctx_id(timer_reports[i]
>> .report),
>> -				  delta, delta ==
>> expected_timestamp_delta ? "" : "******");
>> +				  delta,
>> expected_report_timing_delta(delta,expected_timestamp_delta) ? "" :
>> "******");
>
> Nitpick: s/delta,
> expected_report_timing_delta(delta,expected_timestamp_delta) ? "" :
> "******");/delta, expected_report_timing_delta(delta,
> expected_timestamp_delta) ? "" : "******");
>
>>   
>> -			matches += expected_timestamp_delta <= delta;
>> +			matches +=
>> expected_report_timing_delta(delta,expected_timestamp_delta);
>>   		}
>>   
>>   		igt_debug("matches=%u/%u\n", matches, n_timer_reports -
>> 1);
>
> I tested the patch with gen11 rendercopy and it worked, big thanks for
> fixing it.
>
> With the minor fixes above:
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> I saw that you subimited the 'libs: Adding rendercopy support for
> gen11' separated and Kasia have reviewed but I think this one should be
> merged first, maybe submited the second version of this PR with both
> patches?

Thanks, pushed with the changes you requested.

-
Lionel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev