Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/intel/xe_exec_reset: Add a vm_unbind after the stress test completes
@ 2025-01-08 22:54 Stuart Summers
  2025-01-08 23:38 ` Cavitt, Jonathan
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Stuart Summers @ 2025-01-08 22:54 UTC (permalink / raw)
  Cc: igt-dev, Stuart Summers

The test is submitting workloads in a tight loop and then
destroying the exec queue for each of these. There is a
potential that the GuC IDs could get used up during these
submissions and before a GT reset goes through. If that
happens, the subsequent submissions will essentially be
"lost" in that they aren't submitted to GuC and just wait
for a submission timeout to happen, at which point we do
a reset_async in the driver. What seems to be happening
however is these workloads are lingering beyond the
completion of the xe_exec_reset test. Then when the
reset_async eventually goes through, the submissions
from a next test can also hang (or possibly because
they too ran into the guc_id exhaustion case).

Add an explicit vm_unbind before destroying the VM
to give time for those submissions to complete
before the test ends.

https://gitlab.freedesktop.org/drm/xe/kernel/issues/4015

Signed-off-by: Stuart Summers <stuart.summers@intel.com>
---
 tests/intel/xe_exec_reset.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
index a3eaf8bbf..ca5566d11 100644
--- a/tests/intel/xe_exec_reset.c
+++ b/tests/intel/xe_exec_reset.c
@@ -645,6 +645,8 @@ static void submit_jobs(struct gt_thread_data *t)
 		xe_exec_queue_destroy(fd, exec.exec_queue_id);
 	}
 
+	xe_vm_unbind_sync(fd, vm, 0, addr, bo_size);
+
 	munmap(data, bo_size);
 	gem_close(fd, bo);
 	xe_vm_destroy(fd, vm);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-01-13 16:00 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-08 22:54 [PATCH i-g-t] tests/intel/xe_exec_reset: Add a vm_unbind after the stress test completes Stuart Summers
2025-01-08 23:38 ` Cavitt, Jonathan
2025-01-09 15:39   ` Summers, Stuart
2025-01-13 16:00     ` Summers, Stuart
2025-01-09  0:21 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-01-09  0:31 ` ✓ i915.CI.BAT: " Patchwork
2025-01-11  2:32 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-11  4:36 ` ✗ i915.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox