* [igt-dev] [PATCH i-g-t] intel_gpu_top: Fix frequency and rc6 counters
@ 2023-05-23 15:24 Tvrtko Ursulin
2023-05-23 22:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2023-05-23 15:24 UTC (permalink / raw)
To: igt-dev, Intel-gfx; +Cc: Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Need to reset aggregated counters before adding to them otherwise numbers
will grow endlessly.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: 3dadeff69d4a ("intel_gpu_top: Switch pmu_counter to use aggregated values")
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
tools/intel_gpu_top.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 4e49367a70c7..a89f13d46f11 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -710,6 +710,10 @@ static void pmu_sample(struct engines *engines)
engines->ts.prev = engines->ts.cur;
engines->ts.cur = pmu_read_multi(engines->fd, num_val, val);
+ engines->freq_req.val.cur = engines->freq_req.val.prev = 0;
+ engines->freq_act.val.cur = engines->freq_act.val.prev = 0;
+ engines->rc6.val.cur = engines->rc6.val.prev = 0;
+
for (i = 0; i < engines->num_gts; i++) {
update_sample(&engines->freq_req_gt[i], val);
engines->freq_req.val.cur += engines->freq_req_gt[i].val.cur;
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for intel_gpu_top: Fix frequency and rc6 counters 2023-05-23 15:24 [igt-dev] [PATCH i-g-t] intel_gpu_top: Fix frequency and rc6 counters Tvrtko Ursulin @ 2023-05-23 22:25 ` Patchwork 2023-05-24 11:24 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2023-05-24 16:37 ` [igt-dev] [PATCH i-g-t] " Umesh Nerlige Ramappa 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2023-05-23 22:25 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 5787 bytes --] == Series Details == Series: intel_gpu_top: Fix frequency and rc6 counters URL : https://patchwork.freedesktop.org/series/118228/ State : success == Summary == CI Bug Log - changes from CI_DRM_13180 -> IGTPW_9024 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/index.html Participating hosts (40 -> 38) ------------------------------ Missing (2): fi-kbl-soraka fi-snb-2520m Known issues ------------ Here are the changes found in IGTPW_9024 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_lmem_swapping@verify-random: - fi-cfl-8109u: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +3 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/fi-cfl-8109u/igt@gem_lmem_swapping@verify-random.html * igt@i915_selftest@live@execlists: - fi-bsw-nick: [PASS][2] -> [ABORT][3] ([i915#7913]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/fi-bsw-nick/igt@i915_selftest@live@execlists.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/fi-bsw-nick/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@gt_mocs: - bat-rpls-1: [PASS][4] -> [INCOMPLETE][5] ([i915#4983]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html * igt@i915_selftest@live@mman: - bat-rpls-2: [PASS][6] -> [TIMEOUT][7] ([i915#6794] / [i915#7392]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-rpls-2/igt@i915_selftest@live@mman.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/bat-rpls-2/igt@i915_selftest@live@mman.html * igt@kms_chamelium_frames@hdmi-crc-fast: - fi-cfl-8109u: NOTRUN -> [SKIP][8] ([fdo#109271]) +16 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/fi-cfl-8109u/igt@kms_chamelium_frames@hdmi-crc-fast.html * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence: - bat-dg2-11: NOTRUN -> [SKIP][9] ([i915#1845] / [i915#5354]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html * igt@kms_setmode@basic-clone-single-crtc: - fi-cfl-8109u: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4579]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/fi-cfl-8109u/igt@kms_setmode@basic-clone-single-crtc.html #### Possible fixes #### * igt@i915_selftest@live@hangcheck: - fi-skl-guc: [DMESG-WARN][11] ([i915#8073]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/fi-skl-guc/igt@i915_selftest@live@hangcheck.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/fi-skl-guc/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@requests: - {bat-mtlp-8}: [DMESG-FAIL][13] ([i915#8497]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-mtlp-8/igt@i915_selftest@live@requests.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/bat-mtlp-8/igt@i915_selftest@live@requests.html * igt@kms_busy@basic@flip: - fi-cfl-8109u: [INCOMPLETE][15] -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/fi-cfl-8109u/igt@kms_busy@basic@flip.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/fi-cfl-8109u/igt@kms_busy@basic@flip.html #### Warnings #### * igt@kms_setmode@basic-clone-single-crtc: - bat-rplp-1: [SKIP][17] ([i915#3555] / [i915#4579]) -> [ABORT][18] ([i915#4579] / [i915#8260]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794 [i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#8073]: https://gitlab.freedesktop.org/drm/intel/issues/8073 [i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189 [i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260 [i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7301 -> IGTPW_9024 CI-20190529: 20190529 CI_DRM_13180: e48bc7435824325de6a73fae68dc521e2be13960 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_9024: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/index.html IGT_7301: 4b388fa87e1281587e723ef864e466fe396c3381 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/index.html [-- Attachment #2: Type: text/html, Size: 6710 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for intel_gpu_top: Fix frequency and rc6 counters 2023-05-23 15:24 [igt-dev] [PATCH i-g-t] intel_gpu_top: Fix frequency and rc6 counters Tvrtko Ursulin 2023-05-23 22:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2023-05-24 11:24 ` Patchwork 2023-05-24 16:37 ` [igt-dev] [PATCH i-g-t] " Umesh Nerlige Ramappa 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2023-05-24 11:24 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 20403 bytes --] == Series Details == Series: intel_gpu_top: Fix frequency and rc6 counters URL : https://patchwork.freedesktop.org/series/118228/ State : success == Summary == CI Bug Log - changes from CI_DRM_13180_full -> IGTPW_9024_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/index.html Participating hosts (8 -> 7) ------------------------------ Missing (1): shard-rkl0 Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_9024_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@kms_cursor_legacy@single-move@pipe-d: - {shard-dg1}: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-dg1-14/igt@kms_cursor_legacy@single-move@pipe-d.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-dg1-13/igt@kms_cursor_legacy@single-move@pipe-d.html New tests --------- New tests have been introduced between CI_DRM_13180_full and IGTPW_9024_full: ### New IGT tests (9) ### * igt@gem_exec_schedule@reorder-wide@vcs1: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@absolute-wf_vblank@a-dp1: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@absolute-wf_vblank@b-dp1: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@absolute-wf_vblank@c-dp1: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@dpms-vs-vblank-race@a-vga1: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@dpms-vs-vblank-race@b-vga1: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@a-dp1: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@b-dp1: - Statuses : 1 pass(s) - Exec time: [0.0] s * igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@c-dp1: - Statuses : 1 pass(s) - Exec time: [0.0] s Known issues ------------ Here are the changes found in IGTPW_9024_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_barrier_race@remote-request@rcs0: - shard-apl: [PASS][3] -> [ABORT][4] ([i915#7461] / [i915#8211] / [i915#8234]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl6/igt@gem_barrier_race@remote-request@rcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl6/igt@gem_barrier_race@remote-request@rcs0.html - shard-glk: [PASS][5] -> [ABORT][6] ([i915#7461] / [i915#8211]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk2/igt@gem_barrier_race@remote-request@rcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-glk1/igt@gem_barrier_race@remote-request@rcs0.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [PASS][7] -> [FAIL][8] ([i915#2846]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk7/igt@gem_exec_fair@basic-deadline.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-glk2/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk2/igt@gem_exec_fair@basic-pace@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-glk8/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_lmem_swapping@basic: - shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl7/igt@gem_lmem_swapping@basic.html * igt@gen9_exec_parse@allowed-single: - shard-glk: [PASS][12] -> [ABORT][13] ([i915#5566]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk1/igt@gen9_exec_parse@allowed-single.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-glk1/igt@gen9_exec_parse@allowed-single.html * igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#3886]) +4 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-ccs-on-another-bo-yf_tiled_ccs: - shard-snb: NOTRUN -> [SKIP][15] ([fdo#109271]) +34 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-snb1/igt@kms_ccs@pipe-c-ccs-on-another-bo-yf_tiled_ccs.html * igt@kms_chamelium_hpd@hdmi-hpd-storm: - shard-apl: NOTRUN -> [SKIP][16] ([fdo#109271]) +34 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl7/igt@kms_chamelium_hpd@hdmi-hpd-storm.html * igt@kms_content_protection@uevent@pipe-a-dp-1: - shard-apl: NOTRUN -> [FAIL][17] ([i915#1339]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl2/igt@kms_content_protection@uevent@pipe-a-dp-1.html * igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1: - shard-apl: [PASS][18] -> [ABORT][19] ([i915#180]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl6/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-apl: [PASS][20] -> [FAIL][21] ([IGT#6] / [i915#2346]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt: - shard-apl: NOTRUN -> [SKIP][22] ([IGT#6] / [fdo#109271]) +27 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt.html * igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1: - shard-snb: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#4579]) +15 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-snb5/igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1.html * igt@kms_psr2_sf@overlay-plane-move-continuous-sf: - shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#658]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl6/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html * igt@kms_setmode@clone-exclusive-crtc: - shard-apl: NOTRUN -> [SKIP][25] ([IGT#6] / [fdo#109271] / [i915#4579]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl4/igt@kms_setmode@clone-exclusive-crtc.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-glk: [PASS][26] -> [INCOMPLETE][27] ([IGT#6]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk1/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-glk5/igt@kms_vblank@pipe-b-ts-continuation-suspend.html #### Possible fixes #### * igt@drm_fdinfo@most-busy-check-all@rcs0: - {shard-rkl}: [FAIL][28] ([i915#7742]) -> [PASS][29] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html * igt@gem_eio@kms: - {shard-dg1}: [FAIL][30] ([i915#5784]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-dg1-18/igt@gem_eio@kms.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-dg1-15/igt@gem_eio@kms.html * igt@gem_exec_fair@basic-flow@rcs0: - {shard-tglu}: [FAIL][32] ([i915#2842]) -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-tglu-9/igt@gem_exec_fair@basic-flow@rcs0.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-tglu-2/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - {shard-rkl}: [FAIL][34] ([i915#2842]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-rkl-1/igt@gem_exec_fair@basic-none@vcs0.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-rkl-7/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][36] ([i915#2842]) -> [PASS][37] [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gen9_exec_parse@allowed-single: - shard-apl: [ABORT][38] ([i915#5566]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl6/igt@gen9_exec_parse@allowed-single.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl1/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_dc@dc9-dpms: - shard-apl: [SKIP][40] ([fdo#109271]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl3/igt@i915_pm_dc@dc9-dpms.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl1/igt@i915_pm_dc@dc9-dpms.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a: - {shard-rkl}: [SKIP][42] ([i915#1937] / [i915#4579]) -> [PASS][43] [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-rkl-1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html * igt@i915_pm_rc6_residency@rc6-idle@vcs0: - {shard-dg1}: [FAIL][44] ([i915#3591]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-dg1-12/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html * igt@i915_selftest@perf@engine_cs: - shard-snb: [ABORT][46] ([i915#4528] / [i915#4579]) -> [PASS][47] [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-snb7/igt@i915_selftest@perf@engine_cs.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-snb2/igt@i915_selftest@perf@engine_cs.html * igt@kms_cursor_legacy@single-move@pipe-b: - {shard-rkl}: [INCOMPLETE][48] ([i915#8011]) -> [PASS][49] [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-rkl-7/igt@kms_cursor_legacy@single-move@pipe-b.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-rkl-1/igt@kms_cursor_legacy@single-move@pipe-b.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [FAIL][50] ([IGT#6] / [i915#4767]) -> [PASS][51] [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-suspend@a-dp1: - shard-apl: [ABORT][52] ([i915#180]) -> [PASS][53] [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl2/igt@kms_flip@flip-vs-suspend@a-dp1.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html * igt@kms_rotation_crc@primary-y-tiled-reflect-x-0: - {shard-rkl}: [ABORT][54] ([i915#7461] / [i915#8311]) -> [PASS][55] [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-rkl-6/igt@kms_rotation_crc@primary-y-tiled-reflect-x-0.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/shard-rkl-4/igt@kms_rotation_crc@primary-y-tiled-reflect-x-0.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880 [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975 [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011 [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211 [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213 [i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234 [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292 [i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311 [i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411 [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414 [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7301 -> IGTPW_9024 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_13180: e48bc7435824325de6a73fae68dc521e2be13960 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_9024: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/index.html IGT_7301: 4b388fa87e1281587e723ef864e466fe396c3381 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9024/index.html [-- Attachment #2: Type: text/html, Size: 17998 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] intel_gpu_top: Fix frequency and rc6 counters 2023-05-23 15:24 [igt-dev] [PATCH i-g-t] intel_gpu_top: Fix frequency and rc6 counters Tvrtko Ursulin 2023-05-23 22:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2023-05-24 11:24 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2023-05-24 16:37 ` Umesh Nerlige Ramappa 2023-05-24 16:44 ` Tvrtko Ursulin 2 siblings, 1 reply; 5+ messages in thread From: Umesh Nerlige Ramappa @ 2023-05-24 16:37 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx, Tvrtko Ursulin On Tue, May 23, 2023 at 04:24:07PM +0100, Tvrtko Ursulin wrote: >From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > >Need to reset aggregated counters before adding to them otherwise numbers >will grow endlessly. > >Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >Fixes: 3dadeff69d4a ("intel_gpu_top: Switch pmu_counter to use aggregated values") >Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com> >Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> >--- > tools/intel_gpu_top.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c >index 4e49367a70c7..a89f13d46f11 100644 >--- a/tools/intel_gpu_top.c >+++ b/tools/intel_gpu_top.c >@@ -710,6 +710,10 @@ static void pmu_sample(struct engines *engines) > engines->ts.prev = engines->ts.cur; > engines->ts.cur = pmu_read_multi(engines->fd, num_val, val); > >+ engines->freq_req.val.cur = engines->freq_req.val.prev = 0; >+ engines->freq_act.val.cur = engines->freq_act.val.prev = 0; >+ engines->rc6.val.cur = engines->rc6.val.prev = 0; >+ lgtm, Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com> Umesh > for (i = 0; i < engines->num_gts; i++) { > update_sample(&engines->freq_req_gt[i], val); > engines->freq_req.val.cur += engines->freq_req_gt[i].val.cur; >-- >2.39.2 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] intel_gpu_top: Fix frequency and rc6 counters 2023-05-24 16:37 ` [igt-dev] [PATCH i-g-t] " Umesh Nerlige Ramappa @ 2023-05-24 16:44 ` Tvrtko Ursulin 0 siblings, 0 replies; 5+ messages in thread From: Tvrtko Ursulin @ 2023-05-24 16:44 UTC (permalink / raw) To: Umesh Nerlige Ramappa; +Cc: igt-dev, Intel-gfx, Tvrtko Ursulin On 24/05/2023 17:37, Umesh Nerlige Ramappa wrote: > On Tue, May 23, 2023 at 04:24:07PM +0100, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> >> Need to reset aggregated counters before adding to them otherwise numbers >> will grow endlessly. >> >> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> Fixes: 3dadeff69d4a ("intel_gpu_top: Switch pmu_counter to use >> aggregated values") >> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com> >> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> >> --- >> tools/intel_gpu_top.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c >> index 4e49367a70c7..a89f13d46f11 100644 >> --- a/tools/intel_gpu_top.c >> +++ b/tools/intel_gpu_top.c >> @@ -710,6 +710,10 @@ static void pmu_sample(struct engines *engines) >> engines->ts.prev = engines->ts.cur; >> engines->ts.cur = pmu_read_multi(engines->fd, num_val, val); >> >> + engines->freq_req.val.cur = engines->freq_req.val.prev = 0; >> + engines->freq_act.val.cur = engines->freq_act.val.prev = 0; >> + engines->rc6.val.cur = engines->rc6.val.prev = 0; >> + > > lgtm, > > Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com> Pushed, thanks! Regards, Tvrtko ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-24 16:44 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-05-23 15:24 [igt-dev] [PATCH i-g-t] intel_gpu_top: Fix frequency and rc6 counters Tvrtko Ursulin 2023-05-23 22:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2023-05-24 11:24 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2023-05-24 16:37 ` [igt-dev] [PATCH i-g-t] " Umesh Nerlige Ramappa 2023-05-24 16:44 ` Tvrtko Ursulin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox