public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map
@ 2019-11-19 11:01 Venkata Sandeep Dhanalakota
  2019-11-19 11:01 ` [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: " Venkata Sandeep Dhanalakota
                   ` (4 more replies)
  0 siblings, 5 replies; 18+ messages in thread
From: Venkata Sandeep Dhanalakota @ 2019-11-19 11:01 UTC (permalink / raw)
  To: igt-dev

Since engines are now looked up based on context engine map,
context should be setup with engines before using in execbuf.

Fixes: 1a7f2e59 igt("gem_ctx_exec: use the gem_engine_topology"

Cc: Andi Shyti <andi.shyti@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
---
 tests/i915/gem_ctx_exec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
index 6c2cd922..2bf47cf2 100644
--- a/tests/i915/gem_ctx_exec.c
+++ b/tests/i915/gem_ctx_exec.c
@@ -132,6 +132,7 @@ static void invalid_context(int fd, const struct intel_execution_engine2 *e,
 	gem_execbuf(fd, &execbuf);
 
 	ctx = gem_context_create(fd);
+	gem_context_set_all_engines(fd, ctx);
 	i915_execbuffer2_set_context_id(execbuf, ctx);
 	gem_execbuf(fd, &execbuf);
 
-- 
2.21.0.5.gaeb582a983

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-19 11:01 [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map Venkata Sandeep Dhanalakota
@ 2019-11-19 11:01 ` Venkata Sandeep Dhanalakota
  2019-11-19 11:11   ` Chris Wilson
  2019-11-19 11:16   ` Tvrtko Ursulin
  2019-11-19 11:08 ` [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: " Chris Wilson
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 18+ messages in thread
From: Venkata Sandeep Dhanalakota @ 2019-11-19 11:01 UTC (permalink / raw)
  To: igt-dev

Since engines are now looked up based on context engine map,
context should be setup with engines before using in execbuf.

Fixes: a9998c23 igt("gem_exec_parallel: use the gem_engine_topology")

Cc: Andi Shyti <andi.shyti@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
---
 tests/i915/gem_exec_parallel.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_exec_parallel.c b/tests/i915/gem_exec_parallel.c
index 8a4482e5..56b26cf4 100644
--- a/tests/i915/gem_exec_parallel.c
+++ b/tests/i915/gem_exec_parallel.c
@@ -126,8 +126,10 @@ static void *thread(void *data)
 	execbuf.flags |= LOCAL_I915_EXEC_NO_RELOC;
 	if (t->gen < 6)
 		execbuf.flags |= I915_EXEC_SECURE;
-	if (t->flags & CONTEXTS)
+	if (t->flags & CONTEXTS) {
 		execbuf.rsvd1 = gem_context_create(fd);
+		gem_context_set_all_engines(fd, execbuf.rsvd1);
+	}
 
 	for (i = 0; i < 16; i++) {
 		obj[0].handle = t->scratch[i];
-- 
2.21.0.5.gaeb582a983

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map
  2019-11-19 11:01 [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map Venkata Sandeep Dhanalakota
  2019-11-19 11:01 ` [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: " Venkata Sandeep Dhanalakota
@ 2019-11-19 11:08 ` Chris Wilson
  2019-11-19 11:24   ` Tvrtko Ursulin
  2019-11-19 11:15 ` Tvrtko Ursulin
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 18+ messages in thread
From: Chris Wilson @ 2019-11-19 11:08 UTC (permalink / raw)
  To: Venkata Sandeep Dhanalakota, igt-dev

Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:16)
> Since engines are now looked up based on context engine map,
> context should be setup with engines before using in execbuf.
> 
> Fixes: 1a7f2e59 igt("gem_ctx_exec: use the gem_engine_topology"
> 
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
> ---
>  tests/i915/gem_ctx_exec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
> index 6c2cd922..2bf47cf2 100644
> --- a/tests/i915/gem_ctx_exec.c
> +++ b/tests/i915/gem_ctx_exec.c
> @@ -132,6 +132,7 @@ static void invalid_context(int fd, const struct intel_execution_engine2 *e,
>         gem_execbuf(fd, &execbuf);
>  
>         ctx = gem_context_create(fd);
> +       gem_context_set_all_engines(fd, ctx);

Irrelevant.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-19 11:01 ` [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: " Venkata Sandeep Dhanalakota
@ 2019-11-19 11:11   ` Chris Wilson
  2019-11-19 11:22     ` Tvrtko Ursulin
  2019-11-19 11:16   ` Tvrtko Ursulin
  1 sibling, 1 reply; 18+ messages in thread
From: Chris Wilson @ 2019-11-19 11:11 UTC (permalink / raw)
  To: Venkata Sandeep Dhanalakota, igt-dev

Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
> Since engines are now looked up based on context engine map,
> context should be setup with engines before using in execbuf.

Stop changing fundamental tests of legacy behaviour. If you want to
exercise new API, do so in parallel.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map
  2019-11-19 11:01 [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map Venkata Sandeep Dhanalakota
  2019-11-19 11:01 ` [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: " Venkata Sandeep Dhanalakota
  2019-11-19 11:08 ` [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: " Chris Wilson
@ 2019-11-19 11:15 ` Tvrtko Ursulin
  2019-11-19 11:57 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
  2019-11-19 16:40 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  4 siblings, 0 replies; 18+ messages in thread
From: Tvrtko Ursulin @ 2019-11-19 11:15 UTC (permalink / raw)
  To: Venkata Sandeep Dhanalakota, igt-dev


On 19/11/2019 11:01, Venkata Sandeep Dhanalakota wrote:
> Since engines are now looked up based on context engine map,
> context should be setup with engines before using in execbuf.
> 
> Fixes: 1a7f2e59 igt("gem_ctx_exec: use the gem_engine_topology"
> 
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
> ---
>   tests/i915/gem_ctx_exec.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
> index 6c2cd922..2bf47cf2 100644
> --- a/tests/i915/gem_ctx_exec.c
> +++ b/tests/i915/gem_ctx_exec.c
> @@ -132,6 +132,7 @@ static void invalid_context(int fd, const struct intel_execution_engine2 *e,
>   	gem_execbuf(fd, &execbuf);
>   
>   	ctx = gem_context_create(fd);
> +	gem_context_set_all_engines(fd, ctx);
>   	i915_execbuffer2_set_context_id(execbuf, ctx);
>   	gem_execbuf(fd, &execbuf);
>   
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-19 11:01 ` [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: " Venkata Sandeep Dhanalakota
  2019-11-19 11:11   ` Chris Wilson
@ 2019-11-19 11:16   ` Tvrtko Ursulin
  1 sibling, 0 replies; 18+ messages in thread
From: Tvrtko Ursulin @ 2019-11-19 11:16 UTC (permalink / raw)
  To: Venkata Sandeep Dhanalakota, igt-dev


On 19/11/2019 11:01, Venkata Sandeep Dhanalakota wrote:
> Since engines are now looked up based on context engine map,
> context should be setup with engines before using in execbuf.
> 
> Fixes: a9998c23 igt("gem_exec_parallel: use the gem_engine_topology")
> 
> Cc: Andi Shyti <andi.shyti@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
> ---
>   tests/i915/gem_exec_parallel.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_exec_parallel.c b/tests/i915/gem_exec_parallel.c
> index 8a4482e5..56b26cf4 100644
> --- a/tests/i915/gem_exec_parallel.c
> +++ b/tests/i915/gem_exec_parallel.c
> @@ -126,8 +126,10 @@ static void *thread(void *data)
>   	execbuf.flags |= LOCAL_I915_EXEC_NO_RELOC;
>   	if (t->gen < 6)
>   		execbuf.flags |= I915_EXEC_SECURE;
> -	if (t->flags & CONTEXTS)
> +	if (t->flags & CONTEXTS) {
>   		execbuf.rsvd1 = gem_context_create(fd);
> +		gem_context_set_all_engines(fd, execbuf.rsvd1);
> +	}
>   
>   	for (i = 0; i < 16; i++) {
>   		obj[0].handle = t->scratch[i];
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-19 11:11   ` Chris Wilson
@ 2019-11-19 11:22     ` Tvrtko Ursulin
  2019-11-19 11:36       ` Chris Wilson
  0 siblings, 1 reply; 18+ messages in thread
From: Tvrtko Ursulin @ 2019-11-19 11:22 UTC (permalink / raw)
  To: Chris Wilson, Venkata Sandeep Dhanalakota, igt-dev


On 19/11/2019 11:11, Chris Wilson wrote:
> Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
>> Since engines are now looked up based on context engine map,
>> context should be setup with engines before using in execbuf.
> 
> Stop changing fundamental tests of legacy behaviour. If you want to
> exercise new API, do so in parallel.

The test is already using the new api so as it stands there's a mismatch 
on engine flags and context - since it passes the engine flags to the 
thread, derived from a context with engine map, but the thread uses a 
legacy context. It has to be aligned for the intended engine to get 
exercised.

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map
  2019-11-19 11:08 ` [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: " Chris Wilson
@ 2019-11-19 11:24   ` Tvrtko Ursulin
  2019-11-19 11:35     ` Chris Wilson
  0 siblings, 1 reply; 18+ messages in thread
From: Tvrtko Ursulin @ 2019-11-19 11:24 UTC (permalink / raw)
  To: Chris Wilson, Venkata Sandeep Dhanalakota, igt-dev


On 19/11/2019 11:08, Chris Wilson wrote:
> Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:16)
>> Since engines are now looked up based on context engine map,
>> context should be setup with engines before using in execbuf.
>>
>> Fixes: 1a7f2e59 igt("gem_ctx_exec: use the gem_engine_topology"
>>
>> Cc: Andi Shyti <andi.shyti@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
>> ---
>>   tests/i915/gem_ctx_exec.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
>> index 6c2cd922..2bf47cf2 100644
>> --- a/tests/i915/gem_ctx_exec.c
>> +++ b/tests/i915/gem_ctx_exec.c
>> @@ -132,6 +132,7 @@ static void invalid_context(int fd, const struct intel_execution_engine2 *e,
>>          gem_execbuf(fd, &execbuf);
>>   
>>          ctx = gem_context_create(fd);
>> +       gem_context_set_all_engines(fd, ctx);
> 
> Irrelevant.

I guess it is a bit, but it completes the test conversion to be correct. 
You would want to split the legacy-vs-new engine selection in this one?

Regards,

Tvrtko


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map
  2019-11-19 11:24   ` Tvrtko Ursulin
@ 2019-11-19 11:35     ` Chris Wilson
  2019-11-19 11:41       ` Tvrtko Ursulin
  0 siblings, 1 reply; 18+ messages in thread
From: Chris Wilson @ 2019-11-19 11:35 UTC (permalink / raw)
  To: Tvrtko Ursulin, Venkata Sandeep Dhanalakota, igt-dev

Quoting Tvrtko Ursulin (2019-11-19 11:24:17)
> 
> On 19/11/2019 11:08, Chris Wilson wrote:
> > Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:16)
> >> Since engines are now looked up based on context engine map,
> >> context should be setup with engines before using in execbuf.
> >>
> >> Fixes: 1a7f2e59 igt("gem_ctx_exec: use the gem_engine_topology"
> >>
> >> Cc: Andi Shyti <andi.shyti@intel.com>
> >> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> >> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> >> Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
> >> ---
> >>   tests/i915/gem_ctx_exec.c | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
> >> index 6c2cd922..2bf47cf2 100644
> >> --- a/tests/i915/gem_ctx_exec.c
> >> +++ b/tests/i915/gem_ctx_exec.c
> >> @@ -132,6 +132,7 @@ static void invalid_context(int fd, const struct intel_execution_engine2 *e,
> >>          gem_execbuf(fd, &execbuf);
> >>   
> >>          ctx = gem_context_create(fd);
> >> +       gem_context_set_all_engines(fd, ctx);
> > 
> > Irrelevant.
> 
> I guess it is a bit, but it completes the test conversion to be correct. 
> You would want to split the legacy-vs-new engine selection in this one?

No, there shouldn't be a per-engine component to this test at all.
The way we have separated the context state is that it is akin to the
process state. Now whether or not the context has an engine is another
question (and answered elsewhere), the question is most certainly not
whether an engine has a context as is being asked here.
-Chris
 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-19 11:22     ` Tvrtko Ursulin
@ 2019-11-19 11:36       ` Chris Wilson
  2019-11-19 18:47         ` Venkata Sandeep Dhanalakota
  2019-11-20  9:13         ` Tvrtko Ursulin
  0 siblings, 2 replies; 18+ messages in thread
From: Chris Wilson @ 2019-11-19 11:36 UTC (permalink / raw)
  To: Tvrtko Ursulin, Venkata Sandeep Dhanalakota, igt-dev

Quoting Tvrtko Ursulin (2019-11-19 11:22:30)
> 
> On 19/11/2019 11:11, Chris Wilson wrote:
> > Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
> >> Since engines are now looked up based on context engine map,
> >> context should be setup with engines before using in execbuf.
> > 
> > Stop changing fundamental tests of legacy behaviour. If you want to
> > exercise new API, do so in parallel.
> 
> The test is already using the new api so as it stands there's a mismatch 
> on engine flags and context - since it passes the engine flags to the 
> thread, derived from a context with engine map, but the thread uses a 
> legacy context. It has to be aligned for the intended engine to get 
> exercised.

Then consider it a retrospective complaint for mucking up a basic test :-p
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map
  2019-11-19 11:35     ` Chris Wilson
@ 2019-11-19 11:41       ` Tvrtko Ursulin
  0 siblings, 0 replies; 18+ messages in thread
From: Tvrtko Ursulin @ 2019-11-19 11:41 UTC (permalink / raw)
  To: Chris Wilson, Venkata Sandeep Dhanalakota, igt-dev


On 19/11/2019 11:35, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-11-19 11:24:17)
>>
>> On 19/11/2019 11:08, Chris Wilson wrote:
>>> Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:16)
>>>> Since engines are now looked up based on context engine map,
>>>> context should be setup with engines before using in execbuf.
>>>>
>>>> Fixes: 1a7f2e59 igt("gem_ctx_exec: use the gem_engine_topology"
>>>>
>>>> Cc: Andi Shyti <andi.shyti@intel.com>
>>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>>>> Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
>>>> ---
>>>>    tests/i915/gem_ctx_exec.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
>>>> index 6c2cd922..2bf47cf2 100644
>>>> --- a/tests/i915/gem_ctx_exec.c
>>>> +++ b/tests/i915/gem_ctx_exec.c
>>>> @@ -132,6 +132,7 @@ static void invalid_context(int fd, const struct intel_execution_engine2 *e,
>>>>           gem_execbuf(fd, &execbuf);
>>>>    
>>>>           ctx = gem_context_create(fd);
>>>> +       gem_context_set_all_engines(fd, ctx);
>>>
>>> Irrelevant.
>>
>> I guess it is a bit, but it completes the test conversion to be correct.
>> You would want to split the legacy-vs-new engine selection in this one?
> 
> No, there shouldn't be a per-engine component to this test at all.
> The way we have separated the context state is that it is akin to the
> process state. Now whether or not the context has an engine is another
> question (and answered elsewhere), the question is most certainly not
> whether an engine has a context as is being asked here.

Okay, option 3, drop the per-engine nature of this subtest altogether.

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] test/i915: gem_ctx_exec: Fix for using context engine map
  2019-11-19 11:01 [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map Venkata Sandeep Dhanalakota
                   ` (2 preceding siblings ...)
  2019-11-19 11:15 ` Tvrtko Ursulin
@ 2019-11-19 11:57 ` Patchwork
  2019-11-19 16:40 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  4 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-11-19 11:57 UTC (permalink / raw)
  To: Venkata Sandeep Dhanalakota; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/2] test/i915: gem_ctx_exec: Fix for using context engine map
URL   : https://patchwork.freedesktop.org/series/69670/
State : success

== Summary ==

CI Bug Log - changes from IGT_5294 -> IGTPW_3724
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/index.html

Known issues
------------

  Here are the changes found in IGTPW_3724 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@i915_module_load@reload-with-fault-injection:
    - {fi-kbl-7560u}:     [INCOMPLETE][1] ([fdo#109964] / [fdo#112298]) -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/fi-kbl-7560u/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-bsw-nick:        [INCOMPLETE][3] ([fdo# 111542]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-icl-u2:          [FAIL][5] ([fdo#109483]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][7] ([fdo#111045] / [fdo#111096]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  * igt@kms_flip@basic-flip-vs-modeset:
    - fi-icl-dsi:         [INCOMPLETE][9] ([fdo#107713]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/fi-icl-dsi/igt@kms_flip@basic-flip-vs-modeset.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/fi-icl-dsi/igt@kms_flip@basic-flip-vs-modeset.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
  [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298


Participating hosts (50 -> 44)
------------------------------

  Missing    (6): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5294 -> IGTPW_3724

  CI-20190529: 20190529
  CI_DRM_7370: d2db945edccfe34bc3cc1d0accafac2036ad4e66 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3724: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/index.html
  IGT_5294: a70013186d3060cfd15d9640fd9a4c360d477c08 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] test/i915: gem_ctx_exec: Fix for using context engine map
  2019-11-19 11:01 [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map Venkata Sandeep Dhanalakota
                   ` (3 preceding siblings ...)
  2019-11-19 11:57 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
@ 2019-11-19 16:40 ` Patchwork
  4 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2019-11-19 16:40 UTC (permalink / raw)
  To: Venkata Sandeep Dhanalakota; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/2] test/i915: gem_ctx_exec: Fix for using context engine map
URL   : https://patchwork.freedesktop.org/series/69670/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5294_full -> IGTPW_3724_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3724_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3724_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3724_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_ctx_switch@all-heavy:
    - shard-iclb:         [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb5/igt@gem_ctx_switch@all-heavy.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb7/igt@gem_ctx_switch@all-heavy.html

  
Known issues
------------

  Here are the changes found in IGTPW_3724_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_busy@close-race:
    - shard-tglb:         [PASS][3] -> [INCOMPLETE][4] ([fdo#111747]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb7/igt@gem_busy@close-race.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb6/igt@gem_busy@close-race.html

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-apl:          [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +3 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-apl1/igt@gem_ctx_isolation@rcs0-s3.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-apl3/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_ctx_persistence@vcs1-hostile-preempt:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#109276] / [fdo#112080]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb1/igt@gem_ctx_persistence@vcs1-hostile-preempt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb8/igt@gem_ctx_persistence@vcs1-hostile-preempt.html

  * igt@gem_ctx_switch@vecs0:
    - shard-tglb:         [PASS][9] -> [INCOMPLETE][10] ([fdo#112093])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb5/igt@gem_ctx_switch@vecs0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb4/igt@gem_ctx_switch@vecs0.html

  * igt@gem_exec_parallel@basic:
    - shard-tglb:         [PASS][11] -> [INCOMPLETE][12] ([fdo#111887])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb1/igt@gem_exec_parallel@basic.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb6/igt@gem_exec_parallel@basic.html

  * igt@gem_exec_parallel@vcs1-fds:
    - shard-iclb:         [PASS][13] -> [SKIP][14] ([fdo#112080]) +10 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb4/igt@gem_exec_parallel@vcs1-fds.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb5/igt@gem_exec_parallel@vcs1-fds.html

  * igt@gem_exec_schedule@in-order-bsd:
    - shard-iclb:         [PASS][15] -> [SKIP][16] ([fdo#112146]) +2 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb3/igt@gem_exec_schedule@in-order-bsd.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html

  * igt@gem_exec_schedule@preempt-contexts-bsd2:
    - shard-iclb:         [PASS][17] -> [SKIP][18] ([fdo#109276]) +13 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb2/igt@gem_exec_schedule@preempt-contexts-bsd2.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb5/igt@gem_exec_schedule@preempt-contexts-bsd2.html

  * igt@gem_exec_suspend@basic-s0:
    - shard-tglb:         [PASS][19] -> [INCOMPLETE][20] ([fdo#111832])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb3/igt@gem_exec_suspend@basic-s0.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb3/igt@gem_exec_suspend@basic-s0.html

  * igt@gem_userptr_blits@map-fixed-invalidate-busy:
    - shard-snb:          [PASS][21] -> [DMESG-WARN][22] ([fdo#111870])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html

  * igt@i915_pm_rpm@modeset-stress-extra-wait:
    - shard-glk:          [PASS][23] -> [DMESG-WARN][24] ([fdo#105763] / [fdo#106538])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-glk2/igt@i915_pm_rpm@modeset-stress-extra-wait.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html

  * igt@i915_selftest@live_gt_timelines:
    - shard-tglb:         [PASS][25] -> [INCOMPLETE][26] ([fdo#111831])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb2/igt@i915_selftest@live_gt_timelines.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb6/igt@i915_selftest@live_gt_timelines.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-tglb:         [PASS][27] -> [INCOMPLETE][28] ([fdo#111850] / [fdo#112031])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb9/igt@kms_flip@flip-vs-suspend.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb8/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
    - shard-tglb:         [PASS][29] -> [FAIL][30] ([fdo#103167]) +3 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +3 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
    - shard-iclb:         [PASS][33] -> [DMESG-WARN][34] ([fdo#111764])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-render:
    - shard-iclb:         [PASS][35] -> [FAIL][36] ([fdo#103167]) +5 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-render.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbcpsr-suspend:
    - shard-tglb:         [PASS][37] -> [INCOMPLETE][38] ([fdo#111832] / [fdo#111850] / [fdo#111884])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - shard-tglb:         [PASS][39] -> [INCOMPLETE][40] ([fdo#111832] / [fdo#111850]) +2 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html

  * igt@kms_psr@psr2_cursor_plane_move:
    - shard-iclb:         [PASS][41] -> [SKIP][42] ([fdo#109441]) +2 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb6/igt@kms_psr@psr2_cursor_plane_move.html

  
#### Possible fixes ####

  * igt@gem_busy@busy-vcs1:
    - shard-iclb:         [SKIP][43] ([fdo#112080]) -> [PASS][44] +12 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb6/igt@gem_busy@busy-vcs1.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb4/igt@gem_busy@busy-vcs1.html

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +4 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-kbl1/igt@gem_ctx_isolation@rcs0-s3.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-kbl3/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_ctx_persistence@vcs1-mixed:
    - shard-iclb:         [SKIP][47] ([fdo#109276] / [fdo#112080]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb5/igt@gem_ctx_persistence@vcs1-mixed.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb1/igt@gem_ctx_persistence@vcs1-mixed.html

  * igt@gem_eio@in-flight-10ms:
    - shard-snb:          [FAIL][49] ([fdo#111946]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-snb1/igt@gem_eio@in-flight-10ms.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-snb5/igt@gem_eio@in-flight-10ms.html

  * igt@gem_eio@in-flight-suspend:
    - shard-tglb:         [INCOMPLETE][51] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb2/igt@gem_eio@in-flight-suspend.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb4/igt@gem_eio@in-flight-suspend.html

  * igt@gem_exec_balancer@smoke:
    - shard-tglb:         [INCOMPLETE][53] ([fdo#111593]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb3/igt@gem_exec_balancer@smoke.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb9/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_reuse@baggage:
    - shard-iclb:         [INCOMPLETE][55] ([fdo#107713] / [fdo#109100]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb7/igt@gem_exec_reuse@baggage.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb1/igt@gem_exec_reuse@baggage.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][57] ([fdo#112146]) -> [PASS][58] +4 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_exec_schedule@smoketest-all:
    - shard-tglb:         [INCOMPLETE][59] ([fdo#111855]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb4/igt@gem_exec_schedule@smoketest-all.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb3/igt@gem_exec_schedule@smoketest-all.html

  * igt@gem_userptr_blits@sync-unmap-after-close:
    - shard-hsw:          [DMESG-WARN][61] ([fdo#111870]) -> [PASS][62] +3 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-hsw1/igt@gem_userptr_blits@sync-unmap-after-close.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-hsw6/igt@gem_userptr_blits@sync-unmap-after-close.html

  * igt@gem_userptr_blits@sync-unmap-cycles:
    - shard-snb:          [DMESG-WARN][63] ([fdo#111870]) -> [PASS][64] +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-snb5/igt@gem_userptr_blits@sync-unmap-cycles.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-iclb:         [FAIL][65] ([fdo#111830 ]) -> [PASS][66] +1 similar issue
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_rpm@system-suspend-modeset:
    - shard-kbl:          [INCOMPLETE][67] ([fdo#103665] / [fdo#107807]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-kbl3/igt@i915_pm_rpm@system-suspend-modeset.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-kbl4/igt@i915_pm_rpm@system-suspend-modeset.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-tglb:         [INCOMPLETE][69] ([fdo#111832] / [fdo#111850]) -> [PASS][70] +3 similar issues
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb9/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_flip@dpms-vs-vblank-race-interruptible:
    - shard-apl:          [DMESG-WARN][71] -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-apl2/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-apl8/igt@kms_flip@dpms-vs-vblank-race-interruptible.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
    - shard-tglb:         [FAIL][73] ([fdo#103167]) -> [PASS][74] +1 similar issue
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
    - shard-iclb:         [FAIL][75] ([fdo#103167]) -> [PASS][76] +4 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][77] ([fdo#109441]) -> [PASS][78] +1 similar issue
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][79] ([fdo#99912]) -> [PASS][80]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-apl3/igt@kms_setmode@basic.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-apl4/igt@kms_setmode@basic.html

  * igt@prime_vgem@fence-wait-bsd2:
    - shard-iclb:         [SKIP][81] ([fdo#109276]) -> [PASS][82] +19 similar issues
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb7/igt@prime_vgem@fence-wait-bsd2.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html

  * igt@testdisplay:
    - shard-apl:          [DMESG-WARN][83] ([fdo#108566]) -> [PASS][84] +1 similar issue
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-apl2/igt@testdisplay.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-apl7/igt@testdisplay.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [FAIL][85] ([fdo#111329]) -> [SKIP][86] ([fdo#109276] / [fdo#112080]) +1 similar issue
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@gem_ctx_isolation@vcs2-clean:
    - shard-tglb:         [SKIP][87] ([fdo#111912] / [fdo#112080]) -> [SKIP][88] ([fdo#112080])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb2/igt@gem_ctx_isolation@vcs2-clean.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb9/igt@gem_ctx_isolation@vcs2-clean.html

  * igt@gem_eio@kms:
    - shard-snb:          [DMESG-WARN][89] ([fdo#111780 ] / [fdo#111781]) -> [INCOMPLETE][90] ([fdo#105411])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-snb5/igt@gem_eio@kms.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-snb2/igt@gem_eio@kms.html

  * igt@gem_exec_schedule@deep-render:
    - shard-tglb:         [FAIL][91] ([fdo#111646]) -> [INCOMPLETE][92] ([fdo#111671])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-tglb7/igt@gem_exec_schedule@deep-render.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-tglb2/igt@gem_exec_schedule@deep-render.html

  * igt@gem_userptr_blits@dmabuf-unsync:
    - shard-hsw:          [DMESG-WARN][93] ([fdo#111870]) -> [DMESG-WARN][94] ([fdo#110789] / [fdo#111870])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-hsw5/igt@gem_userptr_blits@dmabuf-unsync.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-hsw5/igt@gem_userptr_blits@dmabuf-unsync.html

  * igt@runner@aborted:
    - shard-iclb:         ([FAIL][95], [FAIL][96]) ([fdo#111093]) -> ([FAIL][97], [FAIL][98]) ([fdo#109263] / [fdo#110586] / [fdo#111093] / [k.org#203557])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb7/igt@runner@aborted.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5294/shard-iclb2/igt@runner@aborted.html
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb7/igt@runner@aborted.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/shard-iclb5/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#109263]: https://bugs.freedesktop.org/show_bug.cgi?id=109263
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110586]: https://bugs.freedesktop.org/show_bug.cgi?id=110586
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#111093]: https://bugs.freedesktop.org/show_bug.cgi?id=111093
  [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
  [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
  [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
  [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
  [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
  [fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
  [fdo#111780 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111780 
  [fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
  [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830 
  [fdo#111831]: https://bugs.freedesktop.org/show_bug.cgi?id=111831
  [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
  [fdo#11

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3724/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-19 11:36       ` Chris Wilson
@ 2019-11-19 18:47         ` Venkata Sandeep Dhanalakota
  2019-11-20  9:13         ` Tvrtko Ursulin
  1 sibling, 0 replies; 18+ messages in thread
From: Venkata Sandeep Dhanalakota @ 2019-11-19 18:47 UTC (permalink / raw)
  To: Chris Wilson, andi.shyti; +Cc: igt-dev

On 19/11/19 11:36, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-11-19 11:22:30)
> > 
> > On 19/11/2019 11:11, Chris Wilson wrote:
> > > Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
> > >> Since engines are now looked up based on context engine map,
> > >> context should be setup with engines before using in execbuf.
> > > 
> > > Stop changing fundamental tests of legacy behaviour. If you want to
> > > exercise new API, do so in parallel.
> > 
> > The test is already using the new api so as it stands there's a mismatch 
> > on engine flags and context - since it passes the engine flags to the 
> > thread, derived from a context with engine map, but the thread uses a 
> > legacy context. It has to be aligned for the intended engine to get 
> > exercised.
> 
> Then consider it a retrospective complaint for mucking up a basic test :-p
I've added Andy to thread(owner of orginal patch series). I'm wondering if we
should review the all tests which are adopted to use new API only and
have both legacy and new behaviour.

~Sandeep.
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-19 11:36       ` Chris Wilson
  2019-11-19 18:47         ` Venkata Sandeep Dhanalakota
@ 2019-11-20  9:13         ` Tvrtko Ursulin
  2019-11-20  9:35           ` Chris Wilson
  1 sibling, 1 reply; 18+ messages in thread
From: Tvrtko Ursulin @ 2019-11-20  9:13 UTC (permalink / raw)
  To: Chris Wilson, Venkata Sandeep Dhanalakota, igt-dev


On 19/11/2019 11:36, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-11-19 11:22:30)
>>
>> On 19/11/2019 11:11, Chris Wilson wrote:
>>> Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
>>>> Since engines are now looked up based on context engine map,
>>>> context should be setup with engines before using in execbuf.
>>>
>>> Stop changing fundamental tests of legacy behaviour. If you want to
>>> exercise new API, do so in parallel.
>>
>> The test is already using the new api so as it stands there's a mismatch
>> on engine flags and context - since it passes the engine flags to the
>> thread, derived from a context with engine map, but the thread uses a
>> legacy context. It has to be aligned for the intended engine to get
>> exercised.
> 
> Then consider it a retrospective complaint for mucking up a basic test :-p

He who works makes mistakes, or something like that. :)

Ack then to merge this one?

And engine dropping flavour of gem_ctx_exec/invalid-context to be sent 
later.

Regards,

Tvrtko

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-20  9:13         ` Tvrtko Ursulin
@ 2019-11-20  9:35           ` Chris Wilson
  2019-11-20 10:18             ` Tvrtko Ursulin
  0 siblings, 1 reply; 18+ messages in thread
From: Chris Wilson @ 2019-11-20  9:35 UTC (permalink / raw)
  To: Tvrtko Ursulin, Venkata Sandeep Dhanalakota, igt-dev

Quoting Tvrtko Ursulin (2019-11-20 09:13:48)
> 
> On 19/11/2019 11:36, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-11-19 11:22:30)
> >>
> >> On 19/11/2019 11:11, Chris Wilson wrote:
> >>> Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
> >>>> Since engines are now looked up based on context engine map,
> >>>> context should be setup with engines before using in execbuf.
> >>>
> >>> Stop changing fundamental tests of legacy behaviour. If you want to
> >>> exercise new API, do so in parallel.
> >>
> >> The test is already using the new api so as it stands there's a mismatch
> >> on engine flags and context - since it passes the engine flags to the
> >> thread, derived from a context with engine map, but the thread uses a
> >> legacy context. It has to be aligned for the intended engine to get
> >> exercised.
> > 
> > Then consider it a retrospective complaint for mucking up a basic test :-p
> 
> He who works makes mistakes, or something like that. :)
> 
> Ack then to merge this one?
> 
> And engine dropping flavour of gem_ctx_exec/invalid-context to be sent 
> later.

Ack.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-20  9:35           ` Chris Wilson
@ 2019-11-20 10:18             ` Tvrtko Ursulin
  2019-11-20 15:22               ` Venkata Sandeep Dhanalakota
  0 siblings, 1 reply; 18+ messages in thread
From: Tvrtko Ursulin @ 2019-11-20 10:18 UTC (permalink / raw)
  To: Chris Wilson, Venkata Sandeep Dhanalakota, igt-dev


On 20/11/2019 09:35, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-11-20 09:13:48)
>>
>> On 19/11/2019 11:36, Chris Wilson wrote:
>>> Quoting Tvrtko Ursulin (2019-11-19 11:22:30)
>>>>
>>>> On 19/11/2019 11:11, Chris Wilson wrote:
>>>>> Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
>>>>>> Since engines are now looked up based on context engine map,
>>>>>> context should be setup with engines before using in execbuf.
>>>>>
>>>>> Stop changing fundamental tests of legacy behaviour. If you want to
>>>>> exercise new API, do so in parallel.
>>>>
>>>> The test is already using the new api so as it stands there's a mismatch
>>>> on engine flags and context - since it passes the engine flags to the
>>>> thread, derived from a context with engine map, but the thread uses a
>>>> legacy context. It has to be aligned for the intended engine to get
>>>> exercised.
>>>
>>> Then consider it a retrospective complaint for mucking up a basic test :-p
>>
>> He who works makes mistakes, or something like that. :)
>>
>> Ack then to merge this one?
>>
>> And engine dropping flavour of gem_ctx_exec/invalid-context to be sent
>> later.
> 
> Ack.

Thanks, pushed!

Sandeep you can now rework gem_ctx_exec/invalid-context separately.

Regards,

Tvrtko

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: Fix for using context engine map
  2019-11-20 10:18             ` Tvrtko Ursulin
@ 2019-11-20 15:22               ` Venkata Sandeep Dhanalakota
  0 siblings, 0 replies; 18+ messages in thread
From: Venkata Sandeep Dhanalakota @ 2019-11-20 15:22 UTC (permalink / raw)
  To: Tvrtko Ursulin; +Cc: igt-dev

On 19/11/20 10:18, Tvrtko Ursulin wrote:
> 
> On 20/11/2019 09:35, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-11-20 09:13:48)
> > > 
> > > On 19/11/2019 11:36, Chris Wilson wrote:
> > > > Quoting Tvrtko Ursulin (2019-11-19 11:22:30)
> > > > > 
> > > > > On 19/11/2019 11:11, Chris Wilson wrote:
> > > > > > Quoting Venkata Sandeep Dhanalakota (2019-11-19 11:01:17)
> > > > > > > Since engines are now looked up based on context engine map,
> > > > > > > context should be setup with engines before using in execbuf.
> > > > > > 
> > > > > > Stop changing fundamental tests of legacy behaviour. If you want to
> > > > > > exercise new API, do so in parallel.
> > > > > 
> > > > > The test is already using the new api so as it stands there's a mismatch
> > > > > on engine flags and context - since it passes the engine flags to the
> > > > > thread, derived from a context with engine map, but the thread uses a
> > > > > legacy context. It has to be aligned for the intended engine to get
> > > > > exercised.
> > > > 
> > > > Then consider it a retrospective complaint for mucking up a basic test :-p
> > > 
> > > He who works makes mistakes, or something like that. :)
> > > 
> > > Ack then to merge this one?
> > > 
> > > And engine dropping flavour of gem_ctx_exec/invalid-context to be sent
> > > later.
> > 
> > Ack.
> 
> Thanks, pushed!
> 
> Sandeep you can now rework gem_ctx_exec/invalid-context separately.
> 

Thanks Tvrtko & Chris for Acking and pushing. I will rework the changes
needed for the to make invalid_context subtest independent of engines.

Thanks,
Sandeep
> Regards,
> 
> Tvrtko
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2019-11-20 15:22 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-19 11:01 [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: Fix for using context engine map Venkata Sandeep Dhanalakota
2019-11-19 11:01 ` [igt-dev] [PATCH i-g-t 2/2] test/i915: gem_exec_parallel: " Venkata Sandeep Dhanalakota
2019-11-19 11:11   ` Chris Wilson
2019-11-19 11:22     ` Tvrtko Ursulin
2019-11-19 11:36       ` Chris Wilson
2019-11-19 18:47         ` Venkata Sandeep Dhanalakota
2019-11-20  9:13         ` Tvrtko Ursulin
2019-11-20  9:35           ` Chris Wilson
2019-11-20 10:18             ` Tvrtko Ursulin
2019-11-20 15:22               ` Venkata Sandeep Dhanalakota
2019-11-19 11:16   ` Tvrtko Ursulin
2019-11-19 11:08 ` [igt-dev] [PATCH i-g-t 1/2] test/i915: gem_ctx_exec: " Chris Wilson
2019-11-19 11:24   ` Tvrtko Ursulin
2019-11-19 11:35     ` Chris Wilson
2019-11-19 11:41       ` Tvrtko Ursulin
2019-11-19 11:15 ` Tvrtko Ursulin
2019-11-19 11:57 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2019-11-19 16:40 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox