Re: [PATCH i-g-t v2 09/10] lib/intel_blt: Add render tilings and compression support helper

[Karolina Stolarek <karolina.stolarek@intel.com>]

On 26.04.2024 11:01, Zbigniew Kempczyński wrote:
> Add function which is similar to already existing blt supports_tiling()
> but returns tiling/compression capabilities of render engine.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>

> ---
>   lib/intel_blt.c | 29 +++++++++++++++++++++++++++++
>   lib/intel_blt.h |  1 +
>   2 files changed, 30 insertions(+)
> 
> diff --git a/lib/intel_blt.c b/lib/intel_blt.c
> index 946adc538b..a8433387d2 100644
> --- a/lib/intel_blt.c
> +++ b/lib/intel_blt.c
> @@ -495,6 +495,35 @@ bool blt_uses_extended_block_copy(int fd)
>   	return blt_cmd_has_property(cmds_info, XY_BLOCK_COPY, BLT_CMD_EXTENDED);
>   }
>   
> +/**
> + * render_supports_tiling
> + * @fd: drm fd
> + * @tiling: tiling format
> + * @compression: check tiling which will be compressed
> + *
> + * Check if render provided by @fd device supports @tiling format wrt
> + * @compression
> + *
> + * Returns:
> + * true if it does, false otherwise.
> + */
> +bool render_supports_tiling(int fd, enum blt_tiling_type tiling, bool compression)
> +{
> +	const struct intel_cmds_info *cmds_info = GET_CMDS_INFO(fd);
> +
> +	igt_assert(cmds_info);
> +
> +	if (!cmds_info->render_tilings) {
> +		igt_warn("Render tilings are not defined\n");
> +		return false;
> +	}
> +
> +	if (!compression)
> +		return cmds_info->render_tilings->supported_tiling & BIT(tiling);
> +
> +	return cmds_info->render_tilings->supported_compressed_tiling & BIT(tiling);
> +}
> +
>   /**
>    * blt_tiling_name:
>    * @tiling: tiling id
> diff --git a/lib/intel_blt.h b/lib/intel_blt.h
> index 6daf46aea4..edf75c0887 100644
> --- a/lib/intel_blt.h
> +++ b/lib/intel_blt.h
> @@ -211,6 +211,7 @@ bool blt_xy_src_copy_supports_tiling(int fd, enum blt_tiling_type tiling);
>   bool blt_block_copy_supports_compression(int fd);
>   bool blt_platform_has_flat_ccs_enabled(int fd);
>   bool blt_uses_extended_block_copy(int fd);
> +bool render_supports_tiling(int fd, enum blt_tiling_type tiling, bool compression);
>   
>   const char *blt_tiling_name(enum blt_tiling_type tiling);
>   int blt_tile_to_i915_tile(enum blt_tiling_type tiling);