public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/3] test/kms_chamelium: Start with disabling modeset
@ 2020-04-14  8:14 Arkadiusz Hiler
  2020-04-14  1:30 ` Kunal Joshi
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Arkadiusz Hiler @ 2020-04-14  8:14 UTC (permalink / raw)
  To: igt-dev; +Cc: Kunal Joshi

Doing disabling modeset from igt_display_require() is quite tricky, as
there are some tests that depend on the leftover mode set by fbcon in
order to work + PSR debugfs checks seem to behave a bit weird.

While those issues are being worked on let's do a disabling modeset
between igt_display_require() and chamelium_init() so port
auto-discovery works reliably on all configurations.

Issue: https://gitlab.freedesktop.org/drm/intel/issues/323
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 tests/kms_chamelium.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index e5cfa633..b7207ef9 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -2520,6 +2520,12 @@ igt_main
 		igt_display_require(&data.display, data.drm_fd);
 		igt_require(data.display.is_atomic);
 
+		/*
+		 * XXX: disabling modeset, can be removed when
+		 * igt_display_require will start doing this for us
+		 */
+		igt_display_commit2(&data.display, COMMIT_ATOMIC);
+
 		/* we need to initalize chamelium after igt_display_require */
 		data.chamelium = chamelium_init(data.drm_fd);
 		igt_require(data.chamelium);
-- 
2.24.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-04-15  9:10 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-14  8:14 [igt-dev] [PATCH i-g-t 1/3] test/kms_chamelium: Start with disabling modeset Arkadiusz Hiler
2020-04-14  1:30 ` Kunal Joshi
2020-04-14  8:14 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_chamelium: Issue disabling modeset when resetting state Arkadiusz Hiler
2020-04-14  8:14 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_chamelium: Test HPD for different mode handling scenarios Arkadiusz Hiler
2020-04-14 13:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/3] test/kms_chamelium: Start with disabling modeset Patchwork
2020-04-14 13:31   ` Arkadiusz Hiler
2020-04-14 15:23     ` Vudum, Lakshminarayana
2020-04-14 14:14 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-04-15  9:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox