Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v2] tests/kms_addfb_basic: Skip not relevant subtests for Xe
@ 2023-11-23 10:26 Jouni Högander
  2023-11-23 12:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 10+ messages in thread
From: Jouni Högander @ 2023-11-23 10:26 UTC (permalink / raw)
  To: igt-dev, kamil.konieczny, juhapekka.heikkila

Skip following tests for Xe:

tile-pitch-mismatch
addfb25-x-tiled-mismatch-legacy

They are not relevant for Xe as tiling information is not encoded into
backing object.

Skip following test for Xe

basic-y-tiled-legacy

As Xe supports y-tiled format on legacy addfb.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 tests/kms_addfb_basic.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index fc16b8814..426277422 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -396,7 +396,7 @@ static void pitch_tests(int fd)
 /**
  * SUBTEST: basic-%s-tiled-legacy
  * Description: Check if addfb2 and rmfb call works for basic %arg[1] test
- * Driver requirement: i915, xe
+ * Driver requirement: i915
  * Test category: functionality test
  * Functionality: kms_gem_interop, tiling
  * Mega feature: General Display Features
@@ -410,7 +410,7 @@ static void pitch_tests(int fd)
  *
  * SUBTEST: tile-pitch-mismatch
  * Description: Test that addfb2 call fails correctly for pitches mismatch
- * Driver requirement: i915, xe
+ * Driver requirement: i915
  * Test category: functionality test
  * Functionality: kms_gem_interop, tiling
  * Mega feature: General Display Features
@@ -478,8 +478,8 @@ static void tiling_tests(int fd)
 		igt_describe("Test that addfb2 call fails correctly for pitches mismatch");
 			f.pitches[0] = 512*4;
 		igt_subtest("tile-pitch-mismatch") {
-			if (is_i915_device(fd))
-				igt_require(gem_available_fences(fd) > 0);
+			igt_require_i915(fd);
+			igt_require(gem_available_fences(fd) > 0);
 
 			f.handles[0] = tiled_x_bo;
 			do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
@@ -488,12 +488,10 @@ static void tiling_tests(int fd)
 		igt_describe("Test that addfb2 call fails correctly for basic y-tiling test");
 		f.pitches[0] = 1024*4;
 		igt_subtest("basic-y-tiled-legacy") {
-			if (is_i915_device(fd)) {
-				igt_require(!gem_has_lmem(fd));
-				igt_require(gem_available_fences(fd) > 0);
-			} else {
-				igt_require(!xe_has_vram(fd));
-			}
+			igt_require_i915(fd);
+			igt_require(!gem_has_lmem(fd));
+			igt_require(gem_available_fences(fd) > 0);
+
 			f.handles[0] = tiled_y_bo;
 
 			do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
@@ -682,7 +680,7 @@ static void size_tests(int fd)
  *
  * SUBTEST: addfb25-x-tiled-mismatch-legacy
  * Description: Test that addfb2 call fails correctly for irrelevant x-tiling
- * Driver requirement: i915, xe
+ * Driver requirement: i915
  * Test category: functionality test
  * Functionality: kms_gem_interop, tiling
  * Mega feature: General Display Features
@@ -752,6 +750,7 @@ static void addfb25_tests(int fd)
 
 		igt_describe("Test that addfb2 call fails correctly for irrelevant x-tiling");
 		igt_subtest("addfb25-x-tiled-mismatch-legacy") {
+			igt_require_i915(fd);
 			f.modifier[0] = DRM_FORMAT_MOD_LINEAR;
 			do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
 		}
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-11-25  7:18 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-23 10:26 [igt-dev] [PATCH i-g-t v2] tests/kms_addfb_basic: Skip not relevant subtests for Xe Jouni Högander
2023-11-23 12:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-11-23 13:03   ` Hogander, Jouni
2023-11-24  8:12     ` Illipilli, TejasreeX
2023-11-23 12:37 ` [igt-dev] [PATCH i-g-t v2] " Juha-Pekka Heikkila
2023-11-23 13:12 ` Kamil Konieczny
2023-11-23 14:40   ` Hogander, Jouni
2023-11-23 13:39 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
2023-11-23 16:53 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-11-25  7:18 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox