Re: [igt-dev] [PATCH i-g-t 24/25] gem_wsim: Discover engines

From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Andi Shyti <andi.shyti@intel.com>
Cc: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 24/25] gem_wsim: Discover engines
Date: Fri, 17 May 2019 14:05:38 +0100	[thread overview]
Message-ID: <86c71e9e-0fc7-8e52-098a-c059b2c9db3f@linux.intel.com> (raw)
In-Reply-To: <20190517130221.GA2428@intel.intel>

On 17/05/2019 14:02, Andi Shyti wrote:
>>>> +static void query_engines(void)
>>>> +{
>>>> +	struct i915_engine_class_instance *engines;
>>>> +	unsigned int num;
>>>> +
>>>> +	if (__engines_queried)
>>>> +		return;
>>>> +
>>>> +	__engines_queried = true;
>>>> +
>>>> +	if (!has_query(fd) || !has_engine_query(fd)) {
> 
> [...]
> 
>>>> +		unsigned int num_bsd = gem_has_bsd(fd) + gem_has_bsd2(fd);
>>>> +		unsigned int i = 0;
>>>> +
>>>> +		igt_assert(num);
>>>> +
>>>> +		num = 1 + num_bsd;
>>>
>>> did you mean the above two lines swapped?
>>
>> No, I want to avoid running on platforms with no vcs engines since no one
>> ever tested gem_wsim there.
> 
> but you are asserting on 'num' while num is not initialized.

True, my bad. Where are compiler warnings when you need them.

> so that I guess it should first be
> 
> 	num = 1 + num_bsd;
> 
> and then
> 
> 	igt_assert(num);
> 
> right?

I just want igt_assert(num_bsd).

Regards,

Tvrtko

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev