Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Lionel G Landwerlin <lionel.g.landwerlin@intel.com>
Subject: Re: [igt-dev] [PATCH 2/5] i915/perf: Add tests for mapped OA buffer
Date: Tue, 24 Aug 2021 12:18:51 -0700	[thread overview]
Message-ID: <871r6i1wis.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20210824185842.GB18188@unerlige-ril-10.165.21.208>

On Tue, 24 Aug 2021 11:58:42 -0700, Umesh Nerlige Ramappa wrote:
>
> >> +/**
> >> + * OA buffer size and offset.
> >> + *
> >> + * OA output buffer
> >> + *   type: 0
> >> + *   flags: mbz
> >> + *
> >> + *   After querying the info, pass (size,offset) to mmap(),
> >> + *
> >> + *   mmap(0, info.size, PROT_READ, MAP_PRIVATE, perf_fd, info.offset).
> >> + *
> >> + *   Note that only a private (not shared between processes, or across fork())
> >> + *   read-only mmapping is allowed.
> >> + *
> >> + *   Userspace must treat the incoming data as tainted, but it conforms to the OA
> >
> > What does tainted mean?
>
> I'd assume the data is changing as OA buffer reports are captured. I can
> change the comment to say that instead of tainted.

Changing is again ambiguous, I think we could just say something like:

HW is continually writing data to the mapped OA buffer and it conforms to
the OA format as specified by user config. The buffer provides reports that
have OA counters - A, B and C.

  reply	other threads:[~2021-08-24 19:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03 20:07 [igt-dev] [PATCH 1/5] i915/perf: add tests for triggered OA reports Umesh Nerlige Ramappa
2021-08-03 20:07 ` [igt-dev] [PATCH 2/5] i915/perf: Add tests for mapped OA buffer Umesh Nerlige Ramappa
2021-08-23 21:31   ` Dixit, Ashutosh
2021-08-24 18:58     ` Umesh Nerlige Ramappa
2021-08-24 19:18       ` Dixit, Ashutosh [this message]
2021-08-03 20:07 ` [igt-dev] [PATCH 3/5] lib/i915/perf: Add new record for mmaped " Umesh Nerlige Ramappa
2021-08-03 20:07 ` [igt-dev] [PATCH 4/5] tools/i915-perf: Add mmapped OA buffer support to i915-perf-recorder Umesh Nerlige Ramappa
2021-08-24  1:05   ` Dixit, Ashutosh
2021-08-24 19:14     ` Umesh Nerlige Ramappa
2021-08-24  1:45   ` Dixit, Ashutosh
2021-08-26 23:57     ` Umesh Nerlige Ramappa
2021-08-24  3:50   ` Dixit, Ashutosh
2021-08-24 18:50     ` Umesh Nerlige Ramappa
2021-08-24 19:40       ` Dixit, Ashutosh
2021-08-24 20:03         ` Dixit, Ashutosh
2021-08-03 20:07 ` [igt-dev] [PATCH 5/5] tools/i915-perf: Add a command to trigger a report in OA buffer Umesh Nerlige Ramappa
2021-08-03 20:39 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/5] i915/perf: add tests for triggered OA reports Patchwork
2021-08-03 23:21 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2021-08-04 20:13 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-08-30 19:33 [igt-dev] [PATCH 1/5] " Umesh Nerlige Ramappa
2021-08-30 19:33 ` [igt-dev] [PATCH 2/5] i915/perf: Add tests for mapped OA buffer Umesh Nerlige Ramappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r6i1wis.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox