From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: imre.deak@intel.com
Cc: igt-dev@lists.freedesktop.org,
Vanshidhar Konda <vanshidhar.r.konda@intel.com>
Subject: Re: [igt-dev] [PATCH v2 3/8] tests/kms_available_modes_crc: Don't set tiling for framebuffer
Date: Tue, 11 Feb 2020 14:35:48 -0800 [thread overview]
Message-ID: <8736bgwy4b.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200211204202.GB929@ideak-desk.fi.intel.com>
On Tue, 11 Feb 2020 12:42:02 -0800, Imre Deak wrote:
> On Tue, Feb 11, 2020 at 12:15:57PM -0800, Dixit, Ashutosh wrote:
> > On Mon, 10 Feb 2020 18:31:03 -0800, Imre Deak wrote:
> > I think there are still the following remaining issues with this patch:
> >
> > 1. 33cc93c8 has introduced a gem_require_mappable_ggtt() skipping the
> > entire test. That should probably be removed as part of this patch?
> >
> > 2. do_write() has a gem_mmap__gtt() which should be converted to
> > device_coherent()?
>
> That's a good point, we'll need to use another way to write the test
> image to the FB and stop skipping the test. However I think this patch
> is still valid on its own, and the above things can be done as a
> follow-up.
OK, you have a R-b on the patch anyway.
> > 3. This is sort of optional but in my view there is an inconsistency here
> > which should be addressed:
> >
> > The original test was actually using a tiled object and using the tiling
> > available in the aperture/gtt to write to the object. Through this patch
> > we have essentially removed the tiling on the object. However, we are
> > continuing to use LOCAL_I915_FORMAT_MOD_X_TILED in setup_fb(). It just
> > happens that because we are filling in a single value the modifier is
> > immaterial.
>
> It's not immaterial, the display will scan out an X tiled FB.
I am aware of it, what I meant was only because it is a solid color, if we
write assuming it is untiled whereas the scan out will assume tiled, the
output on the display will still look right.
> > Shouldn't this be made consistent? Either
> >
> > (a) we should change the modifier to LOCAL_DRM_FORMAT_MOD_NONE, or
> >
> > (b) if we are going to use the tiled modifer we should assume the object
> > is really tiled and use the blitter or rendercopy to write to the
> > object.
>
> The test just solid fills the FB and we don't need to do that in a pixel
> line-by-line order.
>
> > I guess (a) is simpler to do.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-11 22:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 2:31 [igt-dev] [PATCH v2 1/8] lib/igt_draw: Refactor get_tiling calls Imre Deak
2020-02-11 2:31 ` [igt-dev] [PATCH v2 2/8] tests/kms_frontbuffer_tracking: Skip set tiling calls if not supported Imre Deak
2020-02-11 2:31 ` [igt-dev] [PATCH v2 3/8] tests/kms_available_modes_crc: Don't set tiling for framebuffer Imre Deak
2020-02-11 20:15 ` Dixit, Ashutosh
2020-02-11 20:42 ` Imre Deak
2020-02-11 22:35 ` Dixit, Ashutosh [this message]
2020-02-11 2:31 ` [igt-dev] [PATCH v2 4/8] tests/kms_draw_crc: Skip GTT subtests on platforms w/o aperture Imre Deak
2020-02-12 0:17 ` Dixit, Ashutosh
2020-02-12 2:41 ` Dixit, Ashutosh
2020-02-12 2:49 ` Dixit, Ashutosh
2020-02-11 2:31 ` [igt-dev] [PATCH v2 5/8] tests/kms_draw_crc: Fix generating reference CRCs " Imre Deak
2020-02-11 15:34 ` Matt Roper
2020-02-12 0:29 ` Dixit, Ashutosh
2020-02-12 10:23 ` Imre Deak
2020-02-12 16:57 ` Imre Deak
2020-02-12 21:50 ` [igt-dev] [PATCH v3 " Imre Deak
2020-02-13 4:20 ` Dixit, Ashutosh
2020-02-13 8:09 ` Imre Deak
2020-02-11 2:31 ` [igt-dev] [PATCH v2 6/8] tests/kms_frontbuffer_tracking: Skip GTT subtests " Imre Deak
2020-02-11 15:45 ` Matt Roper
2020-02-11 15:53 ` Imre Deak
2020-02-12 5:45 ` Dixit, Ashutosh
2020-02-12 17:01 ` Imre Deak
2020-02-12 21:50 ` [igt-dev] [PATCH v3 " Imre Deak
2020-02-13 4:34 ` Dixit, Ashutosh
2020-02-11 2:31 ` [igt-dev] [PATCH v2 7/8] lib/igt_draw: Fix igt_draw_fill_fb() " Imre Deak
2020-02-12 3:48 ` Dixit, Ashutosh
2020-02-12 21:50 ` [igt-dev] [PATCH v3 " Imre Deak
2020-02-13 4:22 ` Dixit, Ashutosh
2020-02-11 2:31 ` [igt-dev] [PATCH v2 8/8] lib/igt_fb: Make sure tiled YUV framebuffers are fully cleared Imre Deak
2020-02-11 3:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls Patchwork
2020-02-11 15:33 ` [igt-dev] [PATCH v2 1/8] " Matt Roper
2020-02-12 16:46 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [v2,1/8] " Patchwork
2020-02-13 8:26 ` Imre Deak
2020-02-12 22:36 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls (rev4) Patchwork
2020-02-15 17:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736bgwy4b.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=vanshidhar.r.konda@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox