From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH v3 7/8] lib/igt_draw: Fix igt_draw_fill_fb() on platforms w/o aperture
Date: Wed, 12 Feb 2020 20:22:11 -0800 [thread overview]
Message-ID: <87h7zvunf0.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200212215036.27407-3-imre.deak@intel.com>
On Wed, 12 Feb 2020 13:50:36 -0800, Imre Deak wrote:
>
> Draw through a WC mapping on platforms w/o a GTT aperture.
>
> v2:
> - Use WC instead of CPU mapping. (Ashutosh)
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com> (v1)
> ---
> lib/igt_draw.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index fa8ab5620..f2340127f 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -728,6 +728,8 @@ void igt_draw_rect_fb(int fd, drm_intel_bufmgr *bufmgr,
> */
> void igt_draw_fill_fb(int fd, struct igt_fb *fb, uint32_t color)
> {
> - igt_draw_rect_fb(fd, NULL, NULL, fb, IGT_DRAW_MMAP_GTT,
> + igt_draw_rect_fb(fd, NULL, NULL, fb,
> + gem_has_mappable_ggtt(fd) ? IGT_DRAW_MMAP_GTT :
> + IGT_DRAW_MMAP_WC,
> 0, 0, fb->width, fb->height, color);
Not sure if the conditional switch between GTT and WC is really needed. For
example, __gem_mmap__device_coherent() unconditionally prefers WC over
GTT. In any case:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-13 4:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 2:31 [igt-dev] [PATCH v2 1/8] lib/igt_draw: Refactor get_tiling calls Imre Deak
2020-02-11 2:31 ` [igt-dev] [PATCH v2 2/8] tests/kms_frontbuffer_tracking: Skip set tiling calls if not supported Imre Deak
2020-02-11 2:31 ` [igt-dev] [PATCH v2 3/8] tests/kms_available_modes_crc: Don't set tiling for framebuffer Imre Deak
2020-02-11 20:15 ` Dixit, Ashutosh
2020-02-11 20:42 ` Imre Deak
2020-02-11 22:35 ` Dixit, Ashutosh
2020-02-11 2:31 ` [igt-dev] [PATCH v2 4/8] tests/kms_draw_crc: Skip GTT subtests on platforms w/o aperture Imre Deak
2020-02-12 0:17 ` Dixit, Ashutosh
2020-02-12 2:41 ` Dixit, Ashutosh
2020-02-12 2:49 ` Dixit, Ashutosh
2020-02-11 2:31 ` [igt-dev] [PATCH v2 5/8] tests/kms_draw_crc: Fix generating reference CRCs " Imre Deak
2020-02-11 15:34 ` Matt Roper
2020-02-12 0:29 ` Dixit, Ashutosh
2020-02-12 10:23 ` Imre Deak
2020-02-12 16:57 ` Imre Deak
2020-02-12 21:50 ` [igt-dev] [PATCH v3 " Imre Deak
2020-02-13 4:20 ` Dixit, Ashutosh
2020-02-13 8:09 ` Imre Deak
2020-02-11 2:31 ` [igt-dev] [PATCH v2 6/8] tests/kms_frontbuffer_tracking: Skip GTT subtests " Imre Deak
2020-02-11 15:45 ` Matt Roper
2020-02-11 15:53 ` Imre Deak
2020-02-12 5:45 ` Dixit, Ashutosh
2020-02-12 17:01 ` Imre Deak
2020-02-12 21:50 ` [igt-dev] [PATCH v3 " Imre Deak
2020-02-13 4:34 ` Dixit, Ashutosh
2020-02-11 2:31 ` [igt-dev] [PATCH v2 7/8] lib/igt_draw: Fix igt_draw_fill_fb() " Imre Deak
2020-02-12 3:48 ` Dixit, Ashutosh
2020-02-12 21:50 ` [igt-dev] [PATCH v3 " Imre Deak
2020-02-13 4:22 ` Dixit, Ashutosh [this message]
2020-02-11 2:31 ` [igt-dev] [PATCH v2 8/8] lib/igt_fb: Make sure tiled YUV framebuffers are fully cleared Imre Deak
2020-02-11 3:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls Patchwork
2020-02-11 15:33 ` [igt-dev] [PATCH v2 1/8] " Matt Roper
2020-02-12 16:46 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [v2,1/8] " Patchwork
2020-02-13 8:26 ` Imre Deak
2020-02-12 22:36 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/8] lib/igt_draw: Refactor get_tiling calls (rev4) Patchwork
2020-02-15 17:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7zvunf0.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=imre.deak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox