Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib: Fix interface descriptor fills
@ 2020-07-03 11:23 Mika Kuoppala
  2020-07-03 11:35 ` Zbigniew Kempczyński
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Mika Kuoppala @ 2020-07-03 11:23 UTC (permalink / raw)
  To: igt-dev; +Cc: Chris Wilson

For gen8+ we need to increment the pointer for interface
descriptor size amount. Otherwise the next indirect item
introduced will overwrite our descriptor.

Apparently this has not caused much havoc as interface
descs has been the last item.

Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 lib/gpu_cmds.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 417253a7..81156d25 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -363,6 +363,8 @@ gen8_fill_interface_descriptor(struct intel_bb *ibb,
 
 	idd->desc6.num_threads_in_tg = 1;
 
+	intel_bb_ptr_add(ibb, sizeof(*idd));
+
 	return offset;
 }
 
@@ -399,6 +401,8 @@ gen11_fill_interface_descriptor(struct intel_bb *ibb,
 
 	idd->desc6.num_threads_in_tg = 1;
 
+	intel_bb_ptr_add(ibb, sizeof(*idd));
+
 	return offset;
 }
 
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-07-03 14:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-03 11:23 [igt-dev] [PATCH i-g-t] lib: Fix interface descriptor fills Mika Kuoppala
2020-07-03 11:35 ` Zbigniew Kempczyński
2020-07-03 12:21 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-07-03 14:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-07-03 14:50   ` Mika Kuoppala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox