Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state
@ 2020-04-07  8:31 Chris Wilson
  2020-04-07  8:33 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 14+ messages in thread
From: Chris Wilson @ 2020-04-07  8:31 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Chris Wilson

Include the reason why we are dumping the task state (test timeout) in
the kmsg log prior to the task state. Hopefully this helps when reading
the dump.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
 runner/executor.c | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/runner/executor.c b/runner/executor.c
index 1b69f9c57..25e3187a3 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -678,9 +678,20 @@ static bool sysrq(char cmd)
 	return success;
 }
 
-static void show_kernel_task_state(void)
+static const char *show_kernel_task_state(const char *msg)
 {
+	int fd;
+
+	fd = open("/dev/kmsg", O_WRONlY);
+	if (fd != -1) {
+		write(fd, "<4>[IGT] ", 7);
+		write(fd, msg, strlen(msg));
+		close(fd);
+	}
+
 	sysrq('t');
+
+	return msg;
 }
 
 static const char *need_to_timeout(struct settings *settings,
@@ -725,16 +736,12 @@ static const char *need_to_timeout(struct settings *settings,
 		return "Killing the test because the kernel is tainted.\n";
 
 	if (settings->per_test_timeout != 0 &&
-	    time_since_subtest > settings->per_test_timeout) {
-		show_kernel_task_state();
-		return "Per-test timeout exceeded. Killing the current test with SIGQUIT.\n";
-	}
+	    time_since_subtest > settings->per_test_timeout)
+		return show_kernel_task_state("Per-test timeout exceeded. Killing the current test with SIGQUIT.\n");
 
 	if (settings->inactivity_timeout != 0 &&
-	    time_since_activity > settings->inactivity_timeout) {
-		show_kernel_task_state();
-		return "Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n";
-	}
+	    time_since_activity > settings->inactivity_timeout)
+		return show_kernel_task_state("Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n");
 
 	return NULL;
 }
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [igt-dev] ✗ Fi.CI.BUILD: failure for runner: Show why we dump the task state
  2020-04-07  8:31 [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state Chris Wilson
@ 2020-04-07  8:33 ` Patchwork
  2020-04-07  8:34 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-04-07  8:33 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: runner: Show why we dump the task state
URL   : https://patchwork.freedesktop.org/series/75599/
State : failure

== Summary ==

IGT patchset build failed on latest successful build
9c582425d6b4fc1de9fc2ffc8015cc6f0a0d3e98 i915/i915_hangman: Drop last reference to bygone 'i915_error_state'

[357/408] Linking target tools/intel_display_poller.
[358/408] Linking target tools/intel_forcewaked.
[359/408] Linking target tools/intel_gpu_time.
[360/408] Linking target tools/intel_gpu_frequency.
[361/408] Linking target tools/intel_firmware_decode.
[362/408] Linking target tools/intel_gtt.
[363/408] Linking target tools/intel_guc_logger.
[364/408] Linking target tools/intel_lid.
[365/408] Linking target tools/intel_infoframes.
[366/408] Linking target tools/intel_panel_fitter.
[367/408] Linking target tools/dpcd_reg.
[368/408] Linking target tools/intel_opregion_decode.
[369/408] Linking target tools/intel_reg_checker.
[370/408] Linking target tools/intel_residency.
[371/408] Linking target tools/intel_stepping.
[372/408] Linking target tools/intel_vbt_decode.
[373/408] Linking target tools/intel_watermark.
[374/408] Linking target tools/intel_gem_info.
[375/408] Linking target tools/intel_gvtg_test.
[376/408] Linking target tools/lsgpu.
[377/408] Linking target tools/intel_dump_decode.
[378/408] Linking target tools/intel_error_decode.
[379/408] Linking target tools/intel_l3_parity.
[380/408] Linking target tools/intel_perf_counters.
[381/408] Linking target tools/intel_framebuffer_dump.
[382/408] Linking target tools/intel_dp_compliance.
[383/408] Linking target tools/i915-perf/i915-perf-configs.
[384/408] Linking target tools/intel_reg.
[385/408] Linking target tools/amd_hdmi_compliance.
[386/408] Linking target tools/i915-perf/i915-perf-recorder.
[387/408] Linking target tools/i915-perf/i915-perf-reader.
[388/408] Linking target runner/testdata/successtest.
[389/408] Linking target tools/null_state_gen/intel_null_state_gen.
[390/408] Linking target runner/testdata/no-subtests.
[391/408] Linking target runner/testdata/abort-fixture.
[392/408] Linking target runner/testdata/skippers.
[393/408] Linking target runner/testdata/dynamic.
[394/408] Linking target runner/testdata/abort.
[395/408] Linking target runner/testdata/abort-dynamic.
[396/408] Linking target runner/testdata/abort-simple.
[397/408] Compiling C object 'runner/runner@@igt_runner@sta/executor.c.o'.
FAILED: runner/runner@@igt_runner@sta/executor.c.o 
ccache cc -Irunner/runner@@igt_runner@sta -Irunner -I../runner -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/json-c -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/home/cidrm/kernel_headers/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -DHAVE_OPING=1  -MD -MQ 'runner/runner@@igt_runner@sta/executor.c.o' -MF 'runner/runner@@igt_runner@sta/executor.c.o.d' -o 'runner/runner@@igt_runner@sta/executor.c.o' -c ../runner/executor.c
../runner/executor.c: In function ‘show_kernel_task_state’:
../runner/executor.c:685:25: error: ‘O_WRONlY’ undeclared (first use in this function); did you mean ‘O_WRONLY’?
  fd = open("/dev/kmsg", O_WRONlY);
                         ^~~~~~~~
                         O_WRONLY
../runner/executor.c:685:25: note: each undeclared identifier is reported only once for each function it appears in
ninja: build stopped: subcommand failed.

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state
  2020-04-07  8:31 [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state Chris Wilson
  2020-04-07  8:33 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
@ 2020-04-07  8:34 ` Chris Wilson
  2020-04-07  8:35 ` Chris Wilson
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 14+ messages in thread
From: Chris Wilson @ 2020-04-07  8:34 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala

Quoting Chris Wilson (2020-04-07 09:31:05)
> Include the reason why we are dumping the task state (test timeout) in
> the kmsg log prior to the task state. Hopefully this helps when reading
> the dump.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
>  runner/executor.c | 25 ++++++++++++++++---------
>  1 file changed, 16 insertions(+), 9 deletions(-)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index 1b69f9c57..25e3187a3 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -678,9 +678,20 @@ static bool sysrq(char cmd)
>         return success;
>  }
>  
> -static void show_kernel_task_state(void)
> +static const char *show_kernel_task_state(const char *msg)
>  {
> +       int fd;
> +
> +       fd = open("/dev/kmsg", O_WRONlY);

Yeah, I haven't had coffee.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state
  2020-04-07  8:31 [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state Chris Wilson
  2020-04-07  8:33 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
  2020-04-07  8:34 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2020-04-07  8:35 ` Chris Wilson
  2020-04-07  8:42   ` Jani Nikula
  2020-04-07  9:55   ` Petri Latvala
  2020-04-07  8:42 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (4 subsequent siblings)
  7 siblings, 2 replies; 14+ messages in thread
From: Chris Wilson @ 2020-04-07  8:35 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Chris Wilson

Include the reason why we are dumping the task state (test timeout) in
the kmsg log prior to the task state. Hopefully this helps when reading
the dump.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
 runner/executor.c | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/runner/executor.c b/runner/executor.c
index 1b69f9c57..7061b28d3 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -678,9 +678,20 @@ static bool sysrq(char cmd)
 	return success;
 }
 
-static void show_kernel_task_state(void)
+static const char *show_kernel_task_state(const char *msg)
 {
+	int fd;
+
+	fd = open("/dev/kmsg", O_WRONLY);
+	if (fd != -1) {
+		write(fd, "<4>[IGT] ", 7);
+		write(fd, msg, strlen(msg));
+		close(fd);
+	}
+
 	sysrq('t');
+
+	return msg;
 }
 
 static const char *need_to_timeout(struct settings *settings,
@@ -725,16 +736,12 @@ static const char *need_to_timeout(struct settings *settings,
 		return "Killing the test because the kernel is tainted.\n";
 
 	if (settings->per_test_timeout != 0 &&
-	    time_since_subtest > settings->per_test_timeout) {
-		show_kernel_task_state();
-		return "Per-test timeout exceeded. Killing the current test with SIGQUIT.\n";
-	}
+	    time_since_subtest > settings->per_test_timeout)
+		return show_kernel_task_state("Per-test timeout exceeded. Killing the current test with SIGQUIT.\n");
 
 	if (settings->inactivity_timeout != 0 &&
-	    time_since_activity > settings->inactivity_timeout) {
-		show_kernel_task_state();
-		return "Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n";
-	}
+	    time_since_activity > settings->inactivity_timeout)
+		return show_kernel_task_state("Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n");
 
 	return NULL;
 }
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state
  2020-04-07  8:35 ` Chris Wilson
@ 2020-04-07  8:42   ` Jani Nikula
  2020-04-07  8:43     ` Chris Wilson
  2020-04-07  9:55   ` Petri Latvala
  1 sibling, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2020-04-07  8:42 UTC (permalink / raw)
  To: Chris Wilson, igt-dev; +Cc: Petri Latvala, Chris Wilson

On Tue, 07 Apr 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Include the reason why we are dumping the task state (test timeout) in
> the kmsg log prior to the task state. Hopefully this helps when reading
> the dump.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
>  runner/executor.c | 25 ++++++++++++++++---------
>  1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/runner/executor.c b/runner/executor.c
> index 1b69f9c57..7061b28d3 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -678,9 +678,20 @@ static bool sysrq(char cmd)
>  	return success;
>  }
>  
> -static void show_kernel_task_state(void)
> +static const char *show_kernel_task_state(const char *msg)
>  {
> +	int fd;
> +
> +	fd = open("/dev/kmsg", O_WRONLY);
> +	if (fd != -1) {
> +		write(fd, "<4>[IGT] ", 7);
> +		write(fd, msg, strlen(msg));
> +		close(fd);
> +	}
> +

igt_kmsg(KMSG_WARNING "%s\n", msg);

BR,
Jani.


>  	sysrq('t');
> +
> +	return msg;
>  }
>  
>  static const char *need_to_timeout(struct settings *settings,
> @@ -725,16 +736,12 @@ static const char *need_to_timeout(struct settings *settings,
>  		return "Killing the test because the kernel is tainted.\n";
>  
>  	if (settings->per_test_timeout != 0 &&
> -	    time_since_subtest > settings->per_test_timeout) {
> -		show_kernel_task_state();
> -		return "Per-test timeout exceeded. Killing the current test with SIGQUIT.\n";
> -	}
> +	    time_since_subtest > settings->per_test_timeout)
> +		return show_kernel_task_state("Per-test timeout exceeded. Killing the current test with SIGQUIT.\n");
>  
>  	if (settings->inactivity_timeout != 0 &&
> -	    time_since_activity > settings->inactivity_timeout) {
> -		show_kernel_task_state();
> -		return "Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n";
> -	}
> +	    time_since_activity > settings->inactivity_timeout)
> +		return show_kernel_task_state("Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n");
>  
>  	return NULL;
>  }

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [igt-dev] ✗ GitLab.Pipeline: warning for runner: Show why we dump the task state
  2020-04-07  8:31 [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state Chris Wilson
                   ` (2 preceding siblings ...)
  2020-04-07  8:35 ` Chris Wilson
@ 2020-04-07  8:42 ` Patchwork
  2020-04-07  9:27 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Show why we dump the task state (rev2) Patchwork
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-04-07  8:42 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: runner: Show why we dump the task state
URL   : https://patchwork.freedesktop.org/series/75599/
State : warning

== Summary ==

Did not get list of undocumented tests for this run, something is wrong!

Other than that, pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/129291 for the overview.

build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2206781):
  [351/384] Linking target runner/testdata/abort.
  [352/384] Linking target runner/testdata/abort-dynamic.
  [353/384] Linking target runner/testdata/abort-fixture.
  [354/384] Compiling C object 'runner/527aa9f@@igt_runner@sta/executor.c.o'.
  FAILED: runner/527aa9f@@igt_runner@sta/executor.c.o 
  cc -Irunner/527aa9f@@igt_runner@sta -Irunner -I../runner -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/json-c -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC  -MD -MQ 'runner/527aa9f@@igt_runner@sta/executor.c.o' -MF 'runner/527aa9f@@igt_runner@sta/executor.c.o.d' -o 'runner/527aa9f@@igt_runner@sta/executor.c.o' -c ../runner/executor.c
  ../runner/executor.c: In function ‘show_kernel_task_state’:
  ../runner/executor.c:685:25: error: ‘O_WRONlY’ undeclared (first use in this function); did you mean ‘O_WRONLY’?
    fd = open("/dev/kmsg", O_WRONlY);
                           ^~~~~~~~
                           O_WRONLY
  ../runner/executor.c:685:25: note: each undeclared identifier is reported only once for each function it appears in
  ninja: build stopped: subcommand failed.
  section_end:1586248483:build_script
  section_start:1586248483:after_script
  section_end:1586248485:after_script
  section_start:1586248485:upload_artifacts_on_failure
  section_end:1586248486:upload_artifacts_on_failure
  ERROR: Job failed: exit code 1
  

build:tests-debian-meson-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2206784):
  [16/23] Linking target tools/null_state_gen/intel_null_state_gen.
  [17/23] Compiling C object 'runner/527aa9f@@igt_runner@sta/executor.c.o'.
  FAILED: runner/527aa9f@@igt_runner@sta/executor.c.o 
  /usr/bin/aarch64-linux-gnu-gcc -Irunner/527aa9f@@igt_runner@sta -Irunner -I../runner -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/json-c -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC  -MD -MQ 'runner/527aa9f@@igt_runner@sta/executor.c.o' -MF 'runner/527aa9f@@igt_runner@sta/executor.c.o.d' -o 'runner/527aa9f@@igt_runner@sta/executor.c.o' -c ../runner/executor.c
  ../runner/executor.c: In function ‘show_kernel_task_state’:
  ../runner/executor.c:685:25: error: ‘O_WRONlY’ undeclared (first use in this function); did you mean ‘O_WRONLY’?
    fd = open("/dev/kmsg", O_WRONlY);
                           ^~~~~~~~
                           O_WRONLY
  ../runner/executor.c:685:25: note: each undeclared identifier is reported only once for each function it appears in
  ninja: build stopped: subcommand failed.
  section_end:1586248457:build_script
  section_start:1586248457:after_script
  Running after_script
  section_end:1586248459:after_script
  section_start:1586248459:upload_artifacts_on_failure
  Uploading artifacts for failed job
  section_end:1586248461:upload_artifacts_on_failure
  ERROR: Job failed: exit code 1
  

build:tests-debian-meson-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2206783):
  [10/17] Linking target tools/i915-perf/i915-perf-reader.
  [11/17] Compiling C object 'runner/527aa9f@@igt_runner@sta/executor.c.o'.
  FAILED: runner/527aa9f@@igt_runner@sta/executor.c.o 
  /usr/bin/arm-linux-gnueabihf-gcc -Irunner/527aa9f@@igt_runner@sta -Irunner -I../runner -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/json-c -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC  -MD -MQ 'runner/527aa9f@@igt_runner@sta/executor.c.o' -MF 'runner/527aa9f@@igt_runner@sta/executor.c.o.d' -o 'runner/527aa9f@@igt_runner@sta/executor.c.o' -c ../runner/executor.c
  ../runner/executor.c: In function ‘show_kernel_task_state’:
  ../runner/executor.c:685:25: error: ‘O_WRONlY’ undeclared (first use in this function); did you mean ‘O_WRONLY’?
    fd = open("/dev/kmsg", O_WRONlY);
                           ^~~~~~~~
                           O_WRONLY
  ../runner/executor.c:685:25: note: each undeclared identifier is reported only once for each function it appears in
  ninja: build stopped: subcommand failed.
  section_end:1586248466:build_script
  section_start:1586248466:after_script
  Running after_script
  section_end:1586248467:after_script
  section_start:1586248467:upload_artifacts_on_failure
  Uploading artifacts for failed job
  section_end:1586248469:upload_artifacts_on_failure
  ERROR: Job failed: exit code 1
  

build:tests-debian-meson-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2206785):
  [18/36] Linking target tools/i915-perf/i915-perf-configs.
  [19/36] Linking target tools/i915-perf/i915-perf-recorder.
  [20/36] Linking target tools/i915-perf/i915-perf-reader.
  [21/36] Linking target tools/null_state_gen/intel_null_state_gen.
  [22/36] Compiling C object 'runner/527aa9f@@igt_runner@sta/executor.c.o'.
  FAILED: runner/527aa9f@@igt_runner@sta/executor.c.o 
  /usr/bin/mips-linux-gnu-gcc -Irunner/527aa9f@@igt_runner@sta -Irunner -I../runner -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/json-c -I/usr/include/glib-2.0 -I/usr/lib/mips-linux-gnu/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC  -MD -MQ 'runner/527aa9f@@igt_runner@sta/executor.c.o' -MF 'runner/527aa9f@@igt_runner@sta/executor.c.o.d' -o 'runner/527aa9f@@igt_runner@sta/executor.c.o' -c ../runner/executor.c
  ../runner/executor.c: In function ‘show_kernel_task_state’:
  ../runner/executor.c:685:25: error: ‘O_WRONlY’ undeclared (first use in this function)
    fd = open("/dev/kmsg", O_WRONlY);
                           ^~~~~~~~
  ../runner/executor.c:685:25: note: each undeclared identifier is reported only once for each function it appears in
  ninja: build stopped: subcommand failed.
  section_end:1586248433:build_script
  section_start:1586248433:after_script
  section_end:1586248434:after_script
  section_start:1586248434:upload_artifacts_on_failure
  section_end:1586248436:upload_artifacts_on_failure
  ERROR: Job failed: exit code 1
  

build:tests-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2206777):
  [1/388] Generating version.h with a custom command.
  [2/33] Linking target benchmarks/gem_wsim.
  [3/33] Linking target tools/intel_reg.
  [4/33] Compiling C object 'runner/527aa9f@@igt_runner@sta/executor.c.o'.
  FAILED: runner/527aa9f@@igt_runner@sta/executor.c.o 
  cc -Irunner/527aa9f@@igt_runner@sta -Irunner -I../runner -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/json-c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -MD -MQ 'runner/527aa9f@@igt_runner@sta/executor.c.o' -MF 'runner/527aa9f@@igt_runner@sta/executor.c.o.d' -o 'runner/527aa9f@@igt_runner@sta/executor.c.o' -c ../runner/executor.c
  ../runner/executor.c: In function ‘show_kernel_task_state’:
  ../runner/executor.c:685:25: error: ‘O_WRONlY’ undeclared (first use in this function); did you mean ‘O_WRONLY’?
    685 |  fd = open("/dev/kmsg", O_WRONlY);
        |                         ^~~~~~~~
        |                         O_WRONLY
  ../runner/executor.c:685:25: note: each undeclared identifier is reported only once for each function it appears in
  ninja: build stopped: subcommand failed.
  section_end:1586248435:build_script
  section_start:1586248435:after_script
  section_end:1586248437:after_script
  section_start:1586248437:upload_artifacts_on_failure
  section_end:1586248439:upload_artifacts_on_failure
  ERROR: Job failed: exit code 1
  

build:tests-fedora-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2206780):
  [10/34] Linking target tools/i915-perf/i915-perf-recorder.
  [11/34] Linking target tools/i915-perf/i915-perf-reader.
  [12/34] Linking target runner/testdata/abort-fixture.
  [13/34] Compiling C object 'runner/527aa9f@@igt_runner@sta/executor.c.o'.
  FAILED: runner/527aa9f@@igt_runner@sta/executor.c.o 
  clang -Irunner/527aa9f@@igt_runner@sta -Irunner -I../runner -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/json-c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -MD -MQ 'runner/527aa9f@@igt_runner@sta/executor.c.o' -MF 'runner/527aa9f@@igt_runner@sta/executor.c.o.d' -o 'runner/527aa9f@@igt_runner@sta/executor.c.o' -c ../runner/executor.c
  ../runner/executor.c:685:25: error: use of undeclared identifier 'O_WRONlY'
          fd = open("/dev/kmsg", O_WRONlY);
                                 ^
  1 error generated.
  ninja: build stopped: subcommand failed.
  section_end:1586248470:build_script
  section_start:1586248470:after_script
  Running after_script
  section_end:1586248471:after_script
  section_start:1586248471:upload_artifacts_on_failure
  Uploading artifacts for failed job
  section_end:1586248472:upload_artifacts_on_failure
  ERROR: Job failed: exit code 1
  

build:tests-fedora-no-libunwind has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2206778):
  [11/54] Linking target tools/intel_reg.
  [12/54] Linking target tools/intel_gpu_top.
  [13/54] Linking target tools/i915-perf/i915-perf-recorder.
  [14/54] Compiling C object 'runner/527aa9f@@igt_runner@sta/executor.c.o'.
  FAILED: runner/527aa9f@@igt_runner@sta/executor.c.o 
  cc -Irunner/527aa9f@@igt_runner@sta -Irunner -I../runner -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/libunwind -I/usr/include/json-c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC -MD -MQ 'runner/527aa9f@@igt_runner@sta/executor.c.o' -MF 'runner/527aa9f@@igt_runner@sta/executor.c.o.d' -o 'runner/527aa9f@@igt_runner@sta/executor.c.o' -c ../runner/executor.c
  ../runner/executor.c: In function ‘show_kernel_task_state’:
  ../runner/executor.c:685:25: error: ‘O_WRONlY’ undeclared (first use in this function); did you mean ‘O_WRONLY’?
    685 |  fd = open("/dev/kmsg", O_WRONlY);
        |                         ^~~~~~~~
        |                         O_WRONLY
  ../runner/executor.c:685:25: note: each undeclared identifier is reported only once for each function it appears in
  ninja: build stopped: subcommand failed.
  section_end:1586248437:build_script
  section_start:1586248437:after_script
  section_end:1586248438:after_script
  section_start:1586248438:upload_artifacts_on_failure
  section_end:1586248440:upload_artifacts_on_failure
  ERROR: Job failed: exit code 1
  

build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2206779):
  [352/389] Linking target runner/testdata/abort-dynamic.
  [353/389] Linking target runner/testdata/abort-simple.
  [354/389] Linking target runner/testdata/abort-fixture.
  [355/389] Compiling C object 'runner/runner@@igt_runner@sta/executor.c.o'.
  FAILED: runner/runner@@igt_runner@sta/executor.c.o 
  cc -Irunner/runner@@igt_runner@sta -Irunner -I../runner -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/usr/include/json-c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-address-of-packed-member -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -fPIC  -MD -MQ 'runner/runner@@igt_runner@sta/executor.c.o' -MF 'runner/runner@@igt_runner@sta/executor.c.o.d' -o 'runner/runner@@igt_runner@sta/executor.c.o' -c ../runner/executor.c
  ../runner/executor.c: In function ‘show_kernel_task_state’:
  ../runner/executor.c:685:25: error: ‘O_WRONlY’ undeclared (first use in this function); did you mean ‘O_WRONLY’?
    685 |  fd = open("/dev/kmsg", O_WRONlY);
        |                         ^~~~~~~~
        |                         O_WRONLY
  ../runner/executor.c:685:25: note: each undeclared identifier is reported only once for each function it appears in
  ninja: build stopped: subcommand failed.
  section_end:1586248473:build_script
  section_start:1586248473:after_script
  section_end:1586248475:after_script
  section_start:1586248475:upload_artifacts_on_failure
  section_end:1586248477:upload_artifacts_on_failure
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/129291
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state
  2020-04-07  8:42   ` Jani Nikula
@ 2020-04-07  8:43     ` Chris Wilson
  2020-04-07  9:51       ` Jani Nikula
  0 siblings, 1 reply; 14+ messages in thread
From: Chris Wilson @ 2020-04-07  8:43 UTC (permalink / raw)
  To: Jani Nikula, igt-dev; +Cc: Petri Latvala

Quoting Jani Nikula (2020-04-07 09:42:01)
> On Tue, 07 Apr 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Include the reason why we are dumping the task state (test timeout) in
> > the kmsg log prior to the task state. Hopefully this helps when reading
> > the dump.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > ---
> >  runner/executor.c | 25 ++++++++++++++++---------
> >  1 file changed, 16 insertions(+), 9 deletions(-)
> >
> > diff --git a/runner/executor.c b/runner/executor.c
> > index 1b69f9c57..7061b28d3 100644
> > --- a/runner/executor.c
> > +++ b/runner/executor.c
> > @@ -678,9 +678,20 @@ static bool sysrq(char cmd)
> >       return success;
> >  }
> >  
> > -static void show_kernel_task_state(void)
> > +static const char *show_kernel_task_state(const char *msg)
> >  {
> > +     int fd;
> > +
> > +     fd = open("/dev/kmsg", O_WRONLY);
> > +     if (fd != -1) {
> > +             write(fd, "<4>[IGT] ", 7);
> > +             write(fd, msg, strlen(msg));
> > +             close(fd);
> > +     }
> > +
> 
> igt_kmsg(KMSG_WARNING "%s\n", msg);

We're outside of libigt.so
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for runner: Show why we dump the task state (rev2)
  2020-04-07  8:31 [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state Chris Wilson
                   ` (3 preceding siblings ...)
  2020-04-07  8:42 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
@ 2020-04-07  9:27 ` Patchwork
  2020-04-07 10:07 ` [igt-dev] [PATCH i-g-t v2] runner: Show why we dump the task state Chris Wilson
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-04-07  9:27 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: runner: Show why we dump the task state (rev2)
URL   : https://patchwork.freedesktop.org/series/75599/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8264 -> IGTPW_4420
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4420/index.html

Known issues
------------

  Here are the changes found in IGTPW_4420 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-tgl-y:           [FAIL][1] ([i915#1158]) -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4420/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_selftest@live@hangcheck:
    - fi-icl-y:           [INCOMPLETE][3] ([i915#1580]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-icl-y/igt@i915_selftest@live@hangcheck.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4420/fi-icl-y/igt@i915_selftest@live@hangcheck.html

  
  [i915#1158]: https://gitlab.freedesktop.org/drm/intel/issues/1158
  [i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580


Participating hosts (53 -> 46)
------------------------------

  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5573 -> IGTPW_4420

  CI-20190529: 20190529
  CI_DRM_8264: e0104585f880a64d4a9b40803cf4fb51ab499f7c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4420: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4420/index.html
  IGT_5573: 9c582425d6b4fc1de9fc2ffc8015cc6f0a0d3e98 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4420/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state
  2020-04-07  8:43     ` Chris Wilson
@ 2020-04-07  9:51       ` Jani Nikula
  0 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2020-04-07  9:51 UTC (permalink / raw)
  To: Chris Wilson, igt-dev; +Cc: Petri Latvala

On Tue, 07 Apr 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-04-07 09:42:01)
>> On Tue, 07 Apr 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > Include the reason why we are dumping the task state (test timeout) in
>> > the kmsg log prior to the task state. Hopefully this helps when reading
>> > the dump.
>> >
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: Petri Latvala <petri.latvala@intel.com>
>> > ---
>> >  runner/executor.c | 25 ++++++++++++++++---------
>> >  1 file changed, 16 insertions(+), 9 deletions(-)
>> >
>> > diff --git a/runner/executor.c b/runner/executor.c
>> > index 1b69f9c57..7061b28d3 100644
>> > --- a/runner/executor.c
>> > +++ b/runner/executor.c
>> > @@ -678,9 +678,20 @@ static bool sysrq(char cmd)
>> >       return success;
>> >  }
>> >  
>> > -static void show_kernel_task_state(void)
>> > +static const char *show_kernel_task_state(const char *msg)
>> >  {
>> > +     int fd;
>> > +
>> > +     fd = open("/dev/kmsg", O_WRONLY);
>> > +     if (fd != -1) {
>> > +             write(fd, "<4>[IGT] ", 7);
>> > +             write(fd, msg, strlen(msg));
>> > +             close(fd);
>> > +     }
>> > +
>> 
>> igt_kmsg(KMSG_WARNING "%s\n", msg);
>
> We're outside of libigt.so

Quoting yourself, "Yeah, I haven't had coffee."

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state
  2020-04-07  8:35 ` Chris Wilson
  2020-04-07  8:42   ` Jani Nikula
@ 2020-04-07  9:55   ` Petri Latvala
  2020-04-07  9:58     ` Chris Wilson
  1 sibling, 1 reply; 14+ messages in thread
From: Petri Latvala @ 2020-04-07  9:55 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

On Tue, Apr 07, 2020 at 09:35:33AM +0100, Chris Wilson wrote:
> Include the reason why we are dumping the task state (test timeout) in
> the kmsg log prior to the task state. Hopefully this helps when reading
> the dump.

Thanks, hopefully this will reduce the amount of times I hear "look, I
found evidence, there's a task dump in dmesg, must be caused by it"...


> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
>  runner/executor.c | 25 ++++++++++++++++---------
>  1 file changed, 16 insertions(+), 9 deletions(-)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index 1b69f9c57..7061b28d3 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -678,9 +678,20 @@ static bool sysrq(char cmd)
>  	return success;
>  }
>  
> -static void show_kernel_task_state(void)
> +static const char *show_kernel_task_state(const char *msg)
>  {
> +	int fd;
> +
> +	fd = open("/dev/kmsg", O_WRONLY);
> +	if (fd != -1) {
> +		write(fd, "<4>[IGT] ", 7);

Either replace this 7 with the correct 8 or a strlen call.

Reviewed-by: Petri Latvala <petri.latvala@intel.com>


> +		write(fd, msg, strlen(msg));
> +		close(fd);
> +	}
> +
>  	sysrq('t');
> +
> +	return msg;
>  }
>  
>  static const char *need_to_timeout(struct settings *settings,
> @@ -725,16 +736,12 @@ static const char *need_to_timeout(struct settings *settings,
>  		return "Killing the test because the kernel is tainted.\n";
>  
>  	if (settings->per_test_timeout != 0 &&
> -	    time_since_subtest > settings->per_test_timeout) {
> -		show_kernel_task_state();
> -		return "Per-test timeout exceeded. Killing the current test with SIGQUIT.\n";
> -	}
> +	    time_since_subtest > settings->per_test_timeout)
> +		return show_kernel_task_state("Per-test timeout exceeded. Killing the current test with SIGQUIT.\n");
>  
>  	if (settings->inactivity_timeout != 0 &&
> -	    time_since_activity > settings->inactivity_timeout) {
> -		show_kernel_task_state();
> -		return "Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n";
> -	}
> +	    time_since_activity > settings->inactivity_timeout)
> +		return show_kernel_task_state("Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n");
>  
>  	return NULL;
>  }
> -- 
> 2.26.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state
  2020-04-07  9:55   ` Petri Latvala
@ 2020-04-07  9:58     ` Chris Wilson
  0 siblings, 0 replies; 14+ messages in thread
From: Chris Wilson @ 2020-04-07  9:58 UTC (permalink / raw)
  To: Petri Latvala; +Cc: igt-dev

Quoting Petri Latvala (2020-04-07 10:55:45)
> On Tue, Apr 07, 2020 at 09:35:33AM +0100, Chris Wilson wrote:
> > Include the reason why we are dumping the task state (test timeout) in
> > the kmsg log prior to the task state. Hopefully this helps when reading
> > the dump.
> 
> Thanks, hopefully this will reduce the amount of times I hear "look, I
> found evidence, there's a task dump in dmesg, must be caused by it"...
> 
> 
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > ---
> >  runner/executor.c | 25 ++++++++++++++++---------
> >  1 file changed, 16 insertions(+), 9 deletions(-)
> > 
> > diff --git a/runner/executor.c b/runner/executor.c
> > index 1b69f9c57..7061b28d3 100644
> > --- a/runner/executor.c
> > +++ b/runner/executor.c
> > @@ -678,9 +678,20 @@ static bool sysrq(char cmd)
> >       return success;
> >  }
> >  
> > -static void show_kernel_task_state(void)
> > +static const char *show_kernel_task_state(const char *msg)
> >  {
> > +     int fd;
> > +
> > +     fd = open("/dev/kmsg", O_WRONLY);
> > +     if (fd != -1) {
> > +             write(fd, "<4>[IGT] ", 7);
> 
> Either replace this 7 with the correct 8 or a strlen call.

Pesky political correctness gone too far!
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [igt-dev] [PATCH i-g-t v2] runner: Show why we dump the task state
  2020-04-07  8:31 [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state Chris Wilson
                   ` (4 preceding siblings ...)
  2020-04-07  9:27 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Show why we dump the task state (rev2) Patchwork
@ 2020-04-07 10:07 ` Chris Wilson
  2020-04-07 10:41 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Show why we dump the task state (rev3) Patchwork
  2020-04-07 16:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  7 siblings, 0 replies; 14+ messages in thread
From: Chris Wilson @ 2020-04-07 10:07 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Chris Wilson

Include the reason why we are dumping the task state (test timeout) in
the kmsg log prior to the task state. Hopefully this helps when reading
the dump.

v2: Use asprintf to combine the strings into one to avoid error prone
manual string handling and enjoy one single write() into the kmsg.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
---
 runner/executor.c | 38 +++++++++++++++++++++++++++++---------
 1 file changed, 29 insertions(+), 9 deletions(-)

diff --git a/runner/executor.c b/runner/executor.c
index 1b69f9c57..64ebe9616 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -27,6 +27,9 @@
 #include "executor.h"
 #include "output_strings.h"
 
+#define KMSG_HEADER "[IGT] "
+#define KMSG_WARN "<4>"
+
 static struct {
 	int *fds;
 	size_t num_dogs;
@@ -678,9 +681,30 @@ static bool sysrq(char cmd)
 	return success;
 }
 
-static void show_kernel_task_state(void)
+static void kmsg_log(const char *prefix, const char *msg)
 {
+	char *str = NULL;
+	int len, fd;
+
+	len = asprintf(&str, "%s%s%s", prefix, KMSG_HEADER, msg);
+	if (!str)
+		return;
+
+	fd = open("/dev/kmsg", O_WRONLY);
+	if (fd != -1) {
+		write(fd, str, len);
+		close(fd);
+	}
+
+	free(str);
+}
+
+static const char *show_kernel_task_state(const char *msg)
+{
+	kmsg_log(KMSG_WARN, msg);
 	sysrq('t');
+
+	return msg;
 }
 
 static const char *need_to_timeout(struct settings *settings,
@@ -725,16 +749,12 @@ static const char *need_to_timeout(struct settings *settings,
 		return "Killing the test because the kernel is tainted.\n";
 
 	if (settings->per_test_timeout != 0 &&
-	    time_since_subtest > settings->per_test_timeout) {
-		show_kernel_task_state();
-		return "Per-test timeout exceeded. Killing the current test with SIGQUIT.\n";
-	}
+	    time_since_subtest > settings->per_test_timeout)
+		return show_kernel_task_state("Per-test timeout exceeded. Killing the current test with SIGQUIT.\n");
 
 	if (settings->inactivity_timeout != 0 &&
-	    time_since_activity > settings->inactivity_timeout) {
-		show_kernel_task_state();
-		return "Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n";
-	}
+	    time_since_activity > settings->inactivity_timeout)
+		return show_kernel_task_state("Inactivity timeout exceeded. Killing the current test with SIGQUIT.\n");
 
 	return NULL;
 }
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for runner: Show why we dump the task state (rev3)
  2020-04-07  8:31 [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state Chris Wilson
                   ` (5 preceding siblings ...)
  2020-04-07 10:07 ` [igt-dev] [PATCH i-g-t v2] runner: Show why we dump the task state Chris Wilson
@ 2020-04-07 10:41 ` Patchwork
  2020-04-07 16:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-04-07 10:41 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: runner: Show why we dump the task state (rev3)
URL   : https://patchwork.freedesktop.org/series/75599/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8264 -> IGTPW_4422
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/index.html

Known issues
------------

  Here are the changes found in IGTPW_4422 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-tgl-y:           [FAIL][1] ([i915#1158]) -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_selftest@live@hangcheck:
    - fi-icl-y:           [INCOMPLETE][3] ([i915#1580]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-icl-y/igt@i915_selftest@live@hangcheck.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/fi-icl-y/igt@i915_selftest@live@hangcheck.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1158]: https://gitlab.freedesktop.org/drm/intel/issues/1158
  [i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580
  [i915#460]: https://gitlab.freedesktop.org/drm/intel/issues/460


Participating hosts (53 -> 46)
------------------------------

  Additional (1): fi-kbl-7560u 
  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-8700k fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5573 -> IGTPW_4422

  CI-20190529: 20190529
  CI_DRM_8264: e0104585f880a64d4a9b40803cf4fb51ab499f7c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4422: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/index.html
  IGT_5573: 9c582425d6b4fc1de9fc2ffc8015cc6f0a0d3e98 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for runner: Show why we dump the task state (rev3)
  2020-04-07  8:31 [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state Chris Wilson
                   ` (6 preceding siblings ...)
  2020-04-07 10:41 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Show why we dump the task state (rev3) Patchwork
@ 2020-04-07 16:38 ` Patchwork
  7 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-04-07 16:38 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: runner: Show why we dump the task state (rev3)
URL   : https://patchwork.freedesktop.org/series/75599/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8264_full -> IGTPW_4422_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/index.html

Known issues
------------

  Here are the changes found in IGTPW_4422_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gen9_exec_parse@allowed-all:
    - shard-glk:          [PASS][1] -> [DMESG-WARN][2] ([i915#716])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk6/igt@gen9_exec_parse@allowed-all.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-glk1/igt@gen9_exec_parse@allowed-all.html
    - shard-kbl:          [PASS][3] -> [DMESG-WARN][4] ([i915#716])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl2/igt@gen9_exec_parse@allowed-all.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl1/igt@gen9_exec_parse@allowed-all.html

  * igt@i915_pm_rpm@fences-dpms:
    - shard-hsw:          [PASS][5] -> [SKIP][6] ([fdo#109271])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-hsw7/igt@i915_pm_rpm@fences-dpms.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-hsw1/igt@i915_pm_rpm@fences-dpms.html
    - shard-glk:          [PASS][7] -> [SKIP][8] ([fdo#109271])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk1/igt@i915_pm_rpm@fences-dpms.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-glk8/igt@i915_pm_rpm@fences-dpms.html
    - shard-tglb:         [PASS][9] -> [SKIP][10] ([i915#1316] / [i915#579])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-tglb3/igt@i915_pm_rpm@fences-dpms.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-tglb7/igt@i915_pm_rpm@fences-dpms.html
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([i915#1316] / [i915#579])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb6/igt@i915_pm_rpm@fences-dpms.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-iclb7/igt@i915_pm_rpm@fences-dpms.html

  * igt@kms_big_fb@linear-32bpp-rotate-0:
    - shard-kbl:          [PASS][13] -> [FAIL][14] ([i915#1119] / [i915#93] / [i915#95])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl2/igt@kms_big_fb@linear-32bpp-rotate-0.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl2/igt@kms_big_fb@linear-32bpp-rotate-0.html
    - shard-apl:          [PASS][15] -> [FAIL][16] ([i915#1119] / [i915#95])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl3/igt@kms_big_fb@linear-32bpp-rotate-0.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl3/igt@kms_big_fb@linear-32bpp-rotate-0.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
    - shard-kbl:          [PASS][17] -> [FAIL][18] ([i915#54] / [i915#93] / [i915#95])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [PASS][19] -> [INCOMPLETE][20] ([i915#155])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-apl:          [PASS][21] -> [DMESG-WARN][22] ([i915#180])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
    - shard-hsw:          [PASS][23] -> [FAIL][24] ([i915#57])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html

  * igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
    - shard-apl:          [PASS][25] -> [FAIL][26] ([i915#1566] / [i915#95])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html

  * igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
    - shard-glk:          [PASS][27] -> [FAIL][28] ([i915#52] / [i915#54]) +3 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk3/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-glk1/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [PASS][29] -> [DMESG-WARN][30] ([i915#180] / [i915#95])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible:
    - shard-kbl:          [PASS][31] -> [INCOMPLETE][32] ([i915#1297] / [i915#600])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl4/igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl6/igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible.html
    - shard-apl:          [PASS][33] -> [INCOMPLETE][34] ([i915#1297])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl2/igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl7/igt@kms_flip@flip-vs-dpms-off-vs-modeset-interruptible.html

  * igt@kms_flip_tiling@flip-changes-tiling:
    - shard-apl:          [PASS][35] -> [FAIL][36] ([i915#95])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl8/igt@kms_flip_tiling@flip-changes-tiling.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl3/igt@kms_flip_tiling@flip-changes-tiling.html
    - shard-kbl:          [PASS][37] -> [FAIL][38] ([i915#699] / [i915#93] / [i915#95])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl6/igt@kms_flip_tiling@flip-changes-tiling.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl2/igt@kms_flip_tiling@flip-changes-tiling.html

  * igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant:
    - shard-kbl:          [PASS][39] -> [FAIL][40] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl7/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl7/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
    - shard-apl:          [PASS][41] -> [FAIL][42] ([fdo#108145] / [i915#265] / [i915#95])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-glk:          [PASS][43] -> [FAIL][44] ([i915#899])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-glk5/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_prime@basic-crc:
    - shard-apl:          [PASS][45] -> [FAIL][46] ([i915#1031] / [i915#95])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl7/igt@kms_prime@basic-crc.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl8/igt@kms_prime@basic-crc.html
    - shard-kbl:          [PASS][47] -> [FAIL][48] ([i915#1031] / [i915#93] / [i915#95])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl4/igt@kms_prime@basic-crc.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl4/igt@kms_prime@basic-crc.html

  * igt@kms_psr@psr2_cursor_mmap_cpu:
    - shard-iclb:         [PASS][49] -> [SKIP][50] ([fdo#109441]) +2 similar issues
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html

  
#### Possible fixes ####

  * {igt@gem_ctx_isolation@preservation-s3@rcs0}:
    - shard-apl:          [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +4 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl6/igt@gem_ctx_isolation@preservation-s3@rcs0.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl6/igt@gem_ctx_isolation@preservation-s3@rcs0.html

  * igt@gem_exec_balancer@hang:
    - shard-tglb:         [FAIL][53] ([i915#1277]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-tglb6/igt@gem_exec_balancer@hang.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-tglb8/igt@gem_exec_balancer@hang.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-hsw:          [FAIL][55] ([i915#1516]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-hsw1/igt@i915_pm_rc6_residency@rc6-idle.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-hsw1/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@i915_selftest@live@blt:
    - shard-snb:          [DMESG-FAIL][57] ([i915#1409]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-snb4/igt@i915_selftest@live@blt.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-snb1/igt@i915_selftest@live@blt.html

  * igt@kms_color@pipe-a-ctm-green-to-red:
    - shard-kbl:          [FAIL][59] ([i915#129]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl4/igt@kms_color@pipe-a-ctm-green-to-red.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl3/igt@kms_color@pipe-a-ctm-green-to-red.html
    - shard-apl:          [FAIL][61] ([i915#129]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl2/igt@kms_color@pipe-a-ctm-green-to-red.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl4/igt@kms_color@pipe-a-ctm-green-to-red.html

  * igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen:
    - shard-kbl:          [FAIL][63] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][65] ([fdo#109349]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
    - shard-glk:          [FAIL][67] ([i915#52] / [i915#54]) -> [PASS][68] +5 similar issues
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk3/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-glk6/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-kbl:          [DMESG-WARN][69] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@2x-plain-flip-ts-check:
    - shard-glk:          [FAIL][71] ([i915#34]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk5/igt@kms_flip@2x-plain-flip-ts-check.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-apl:          [FAIL][73] ([i915#79]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl4/igt@kms_flip@flip-vs-expired-vblank.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl2/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-kbl:          [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +2 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - shard-kbl:          [FAIL][77] ([i915#53] / [i915#93] / [i915#95]) -> [PASS][78]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
    - shard-apl:          [FAIL][79] ([i915#53] / [i915#95]) -> [PASS][80]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-snb:          [DMESG-WARN][81] ([i915#42]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-snb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-snb4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  * igt@kms_plane_lowres@pipe-a-tiling-none:
    - shard-kbl:          [DMESG-WARN][83] ([i915#165] / [i915#78]) -> [PASS][84]
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl2/igt@kms_plane_lowres@pipe-a-tiling-none.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl1/igt@kms_plane_lowres@pipe-a-tiling-none.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [SKIP][85] ([fdo#109441]) -> [PASS][86] +1 similar issue
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_setmode@basic:
    - shard-hsw:          [FAIL][87] ([i915#31]) -> [PASS][88]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-hsw8/igt@kms_setmode@basic.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-hsw6/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - shard-kbl:          [INCOMPLETE][89] ([i915#155]) -> [PASS][90]
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html

  * {igt@perf@blocking-parameterized}:
    - shard-iclb:         [FAIL][91] ([i915#1542]) -> [PASS][92]
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb8/igt@perf@blocking-parameterized.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-iclb1/igt@perf@blocking-parameterized.html
    - shard-hsw:          [FAIL][93] ([i915#1542]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-hsw6/igt@perf@blocking-parameterized.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-hsw4/igt@perf@blocking-parameterized.html

  * igt@perf@gen12-mi-rpc:
    - shard-tglb:         [FAIL][95] ([i915#1085]) -> [PASS][96]
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-tglb7/igt@perf@gen12-mi-rpc.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-tglb3/igt@perf@gen12-mi-rpc.html

  
#### Warnings ####

  * igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
    - shard-apl:          [FAIL][97] ([fdo#108145] / [i915#265]) -> [FAIL][98] ([fdo#108145] / [i915#265] / [i915#95]) +1 similar issue
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-apl6/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
    - shard-kbl:          [FAIL][99] ([fdo#108145] / [i915#265]) -> [FAIL][100] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl7/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html

  * igt@runner@aborted:
    - shard-kbl:          [FAIL][101] ([i915#1423] / [i915#92]) -> ([FAIL][102], [FAIL][103]) ([i915#1423] / [i915#716] / [i915#92])
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl3/igt@runner@aborted.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl1/igt@runner@aborted.html
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/shard-kbl7/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [i915#1031]: https://gitlab.freedesktop.org/drm/intel/issues/1031
  [i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
  [i915#1119]: https://gitlab.freedesktop.org/drm/intel/issues/1119
  [i915#1277]: https://gitlab.freedesktop.org/drm/intel/issues/1277
  [i915#129]: https://gitlab.freedesktop.org/drm/intel/issues/129
  [i915#1297]: https://gitlab.freedesktop.org/drm/intel/issues/1297
  [i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316
  [i915#1409]: https://gitlab.freedesktop.org/drm/intel/issues/1409
  [i915#1423]: https://gitlab.freedesktop.org/drm/intel/issues/1423
  [i915#1516]: https://gitlab.freedesktop.org/drm/intel/issues/1516
  [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#1566]: https://gitlab.freedesktop.org/drm/intel/issues/1566
  [i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
  [i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
  [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
  [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57
  [i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
  [i915#600]: https://gitlab.freedesktop.org/drm/intel/issues/600
  [i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
  [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
  [i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
  [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
  [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (10 -> 8)
------------------------------

  Missing    (2): pig-skl-6260u pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5573 -> IGTPW_4422
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_8264: e0104585f880a64d4a9b40803cf4fb51ab499f7c @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4422: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/index.html
  IGT_5573: 9c582425d6b4fc1de9fc2ffc8015cc6f0a0d3e98 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4422/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-04-07 16:38 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-07  8:31 [igt-dev] [PATCH i-g-t] runner: Show why we dump the task state Chris Wilson
2020-04-07  8:33 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
2020-04-07  8:34 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2020-04-07  8:35 ` Chris Wilson
2020-04-07  8:42   ` Jani Nikula
2020-04-07  8:43     ` Chris Wilson
2020-04-07  9:51       ` Jani Nikula
2020-04-07  9:55   ` Petri Latvala
2020-04-07  9:58     ` Chris Wilson
2020-04-07  8:42 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2020-04-07  9:27 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Show why we dump the task state (rev2) Patchwork
2020-04-07 10:07 ` [igt-dev] [PATCH i-g-t v2] runner: Show why we dump the task state Chris Wilson
2020-04-07 10:41 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Show why we dump the task state (rev3) Patchwork
2020-04-07 16:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox