[igt-dev] [PATCH i-g-t] tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable

[igt-dev] [PATCH i-g-t] tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable

[Antonio Argenziano]

The gtt tests try to verify that a gtt mapped area can be used as an
sseu pointer so it wouldn't make sense to run those when gtt mapping is
not available.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
---
 tests/i915/gem_ctx_sseu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/i915/gem_ctx_sseu.c b/tests/i915/gem_ctx_sseu.c
index 38dc584b..8b014b30 100644
--- a/tests/i915/gem_ctx_sseu.c
+++ b/tests/i915/gem_ctx_sseu.c
@@ -374,6 +374,8 @@ test_ggtt_args(int fd)
 	};
 	uint32_t bo;
 
+	gem_require_mappable_ggtt(fd);
+
 	bo = gem_create(fd, 4096);
 	arg.value = to_user_pointer(gem_mmap__gtt(fd, bo, 4096,
 						  PROT_READ | PROT_WRITE));
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable

[Patchwork]

== Series Details ==

Series: tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable
URL   : https://patchwork.freedesktop.org/series/72801/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7847 -> IGTPW_4051
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_4051 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_4051, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_4051:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_gt_contexts:
    - fi-ilk-650:         [PASS][1] -> [DMESG-FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-ilk-650/igt@i915_selftest@live_gt_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-ilk-650/igt@i915_selftest@live_gt_contexts.html

  
Known issues
------------

  Here are the changes found in IGTPW_4051 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-tgl-y:           [PASS][3] -> [FAIL][4] ([CI#94])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_getparams_basic@basic-subslice-total:
    - fi-tgl-y:           [PASS][5] -> [DMESG-WARN][6] ([CI#94] / [i915#402]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html

  * igt@i915_selftest@live_active:
    - fi-whl-u:           [PASS][7] -> [DMESG-FAIL][8] ([i915#666])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-whl-u/igt@i915_selftest@live_active.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-whl-u/igt@i915_selftest@live_active.html

  * igt@i915_selftest@live_blt:
    - fi-ivb-3770:        [PASS][9] -> [DMESG-FAIL][10] ([i915#725])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-ivb-3770/igt@i915_selftest@live_blt.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-ivb-3770/igt@i915_selftest@live_blt.html

  
#### Possible fixes ####

  * igt@gem_close_race@basic-threads:
    - fi-byt-n2820:       [TIMEOUT][11] ([fdo#112271] / [i915#1084] / [i915#816]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-byt-n2820/igt@gem_close_race@basic-threads.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-byt-n2820/igt@gem_close_race@basic-threads.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [FAIL][13] ([i915#178]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live_execlists:
    - fi-icl-y:           [DMESG-FAIL][15] ([fdo#108569]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-icl-y/igt@i915_selftest@live_execlists.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-icl-y/igt@i915_selftest@live_execlists.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-guc:         [INCOMPLETE][17] ([fdo#106070] / [i915#424]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_flip@basic-flip-vs-wf_vblank:
    - fi-bwr-2160:        [FAIL][19] ([i915#34]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-bwr-2160/igt@kms_flip@basic-flip-vs-wf_vblank.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-bwr-2160/igt@kms_flip@basic-flip-vs-wf_vblank.html

  * igt@prime_self_import@basic-llseek-bad:
    - fi-tgl-y:           [DMESG-WARN][21] ([CI#94] / [i915#402]) -> [PASS][22] +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html

  
#### Warnings ####

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [DMESG-FAIL][23] ([i915#725]) -> [DMESG-FAIL][24] ([i915#563])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7847/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/fi-hsw-4770/igt@i915_selftest@live_blt.html

  
  [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
  [fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
  [i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178
  [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
  [i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
  [i915#666]: https://gitlab.freedesktop.org/drm/intel/issues/666
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816


Participating hosts (47 -> 46)
------------------------------

  Additional (5): fi-hsw-peppy fi-bdw-gvtdvm fi-kbl-7500u fi-gdg-551 fi-elk-e7500 
  Missing    (6): fi-icl-1065g7 fi-bxt-dsi fi-hsw-4200u fi-bsw-cyan fi-kbl-7560u fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5407 -> IGTPW_4051

  CI-20190529: 20190529
  CI_DRM_7847: 2515f8cc5d56f8791232dc6b077a370658d4cecf @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4051: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/index.html
  IGT_5407: a9d69f51dadbcbc53527671f87572d05c3370cba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4051/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable

[Dixit, Ashutosh]

On Thu, 30 Jan 2020 16:39:15 -0800, Antonio Argenziano wrote:
>
> The gtt tests try to verify that a gtt mapped area can be used as an
> sseu pointer so it wouldn't make sense to run those when gtt mapping is
> not available.
>
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> ---
>  tests/i915/gem_ctx_sseu.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/i915/gem_ctx_sseu.c b/tests/i915/gem_ctx_sseu.c
> index 38dc584b..8b014b30 100644
> --- a/tests/i915/gem_ctx_sseu.c
> +++ b/tests/i915/gem_ctx_sseu.c
> @@ -374,6 +374,8 @@ test_ggtt_args(int fd)
>	};
>	uint32_t bo;
>
> +	gem_require_mappable_ggtt(fd);
> +
>	bo = gem_create(fd, 4096);
>	arg.value = to_user_pointer(gem_mmap__gtt(fd, bo, 4096,
>						  PROT_READ | PROT_WRITE));
> --
> 2.21.0

Assuming no issues of memory leaks here:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Otherwise this is better?

diff --git a/tests/i915/gem_ctx_sseu.c b/tests/i915/gem_ctx_sseu.c
index 38dc584bc..2add20c97 100644
--- a/tests/i915/gem_ctx_sseu.c
+++ b/tests/i915/gem_ctx_sseu.c
@@ -528,8 +528,10 @@ igt_main
                igt_subtest("invalid-sseu")
                        test_invalid_sseu(fd);

-               igt_subtest("ggtt-args")
+               igt_subtest("ggtt-args") {
+                       gem_require_mappable_ggtt(fd);
                        test_ggtt_args(fd);
+               }

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_ctx_sseu: Skip gtt tests if mappable aperture unavailable

[Antonio Argenziano]

On 30/01/20 21:18, Dixit, Ashutosh wrote:
> On Thu, 30 Jan 2020 16:39:15 -0800, Antonio Argenziano wrote:
>>
>> The gtt tests try to verify that a gtt mapped area can be used as an
>> sseu pointer so it wouldn't make sense to run those when gtt mapping is
>> not available.
>>
>> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
>> ---
>>   tests/i915/gem_ctx_sseu.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/i915/gem_ctx_sseu.c b/tests/i915/gem_ctx_sseu.c
>> index 38dc584b..8b014b30 100644
>> --- a/tests/i915/gem_ctx_sseu.c
>> +++ b/tests/i915/gem_ctx_sseu.c
>> @@ -374,6 +374,8 @@ test_ggtt_args(int fd)
>> 	};
>> 	uint32_t bo;
>>
>> +	gem_require_mappable_ggtt(fd);
>> +
>> 	bo = gem_create(fd, 4096);
>> 	arg.value = to_user_pointer(gem_mmap__gtt(fd, bo, 4096,
>> 						  PROT_READ | PROT_WRITE));
>> --
>> 2.21.0
> 
> Assuming no issues of memory leaks here:
> 
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> 
> Otherwise this is better?

No strong preference for me.

Antonio

> 
> diff --git a/tests/i915/gem_ctx_sseu.c b/tests/i915/gem_ctx_sseu.c
> index 38dc584bc..2add20c97 100644
> --- a/tests/i915/gem_ctx_sseu.c
> +++ b/tests/i915/gem_ctx_sseu.c
> @@ -528,8 +528,10 @@ igt_main
>                  igt_subtest("invalid-sseu")
>                          test_invalid_sseu(fd);
> 
> -               igt_subtest("ggtt-args")
> +               igt_subtest("ggtt-args") {
> +                       gem_require_mappable_ggtt(fd);
>                          test_ggtt_args(fd);
> +               }
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev