Re: [PATCH i-g-t v5 1/5] tools: Rename tools/gputop to tools/gputop.src

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 23 Jan 2026 07:18:06 -0800, Kamil Konieczny wrote:
>
> Hi Dixit,,
> On 2026-01-23 at 05:52:07 -0800, Dixit, Ashutosh wrote:
> > On Fri, 23 Jan 2026 05:45:28 -0800, Kamil Konieczny wrote:
> > >
> > > Hi Soham,
> > > On 2026-01-22 at 14:15:22 +0530, Soham Purkait wrote:
> > >
> > > I guess it is v6, not v5?
> > >
> > > > The GPUTOP source directory is renamed to gputop.src
> > >
> > > s/GPUTOP/gputop/
> > > > under tools/ path.
> > >
> > > imho here a little more explanation why, like:
> > >
> > > to compile binary into build/tools/gputop file.
> > >
> > > This could be done at merge (unless another version is
> > > needed).
> > >
> > > LGTM
> > > Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> > >
> > > Regards,
> > > Kamil
> > >
> > > >
> > > > v1:
> > > >  - Add meson build files accordingly to generate
> > > >    the binary under tools. (Kamil)
> > > >
> > > > Signed-off-by: Soham Purkait <soham.purkait@intel.com>
> > > > ---
> > > >  tools/{ => gputop.src}/gputop.c          |  0
> >
> > Can't we name the directory 'gputop' if we are moving gputop.c into the
> > directory.
> >
> > tools/gputop/ looks better than tools/gputop.src, fwiw.
> >
>
> While we can do it, I like to have build binary in
> build/tools/gputop
> not
> build/tools/gputop/gputop

We can't thave the binary in build/tools/gputop if the source is in
build/tools/gputop/ ?

gputop.src is fine if it can't be done, just thought I'll mention it.

>
> This folder could have other name, is 'gpu_top' good?
>
> Regards,
> Kamil
>
> >
> > > >  tools/gputop.src/meson.build             |  1 +
> > > >  tools/{gputop => gputop.src}/utils.c     |  0
> > > >  tools/{gputop => gputop.src}/utils.h     |  0
> > > >  tools/{gputop => gputop.src}/xe_gputop.c |  0
> > > >  tools/{gputop => gputop.src}/xe_gputop.h |  0
> > > >  tools/meson.build                        | 11 ++++++-----
> > > >  7 files changed, 7 insertions(+), 5 deletions(-)
> > > >  rename tools/{ => gputop.src}/gputop.c (100%)
> > > >  create mode 100644 tools/gputop.src/meson.build
> > > >  rename tools/{gputop => gputop.src}/utils.c (100%)
> > > >  rename tools/{gputop => gputop.src}/utils.h (100%)
> > > >  rename tools/{gputop => gputop.src}/xe_gputop.c (100%)
> > > >  rename tools/{gputop => gputop.src}/xe_gputop.h (100%)
> > > >
> > > > diff --git a/tools/gputop.c b/tools/gputop.src/gputop.c
> > > > similarity index 100%
>
> [cut]