Re: [PATCH i-g-t v5 1/5] tools: Rename tools/gputop to tools/gputop.src

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 23 Jan 2026 05:45:28 -0800, Kamil Konieczny wrote:
>
> Hi Soham,
> On 2026-01-22 at 14:15:22 +0530, Soham Purkait wrote:
>
> I guess it is v6, not v5?
>
> > The GPUTOP source directory is renamed to gputop.src
>
> s/GPUTOP/gputop/
> > under tools/ path.
>
> imho here a little more explanation why, like:
>
> to compile binary into build/tools/gputop file.
>
> This could be done at merge (unless another version is
> needed).
>
> LGTM
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
> Regards,
> Kamil
>
> >
> > v1:
> >  - Add meson build files accordingly to generate
> >    the binary under tools. (Kamil)
> >
> > Signed-off-by: Soham Purkait <soham.purkait@intel.com>
> > ---
> >  tools/{ => gputop.src}/gputop.c          |  0

Can't we name the directory 'gputop' if we are moving gputop.c into the
directory.

tools/gputop/ looks better than tools/gputop.src, fwiw.


> >  tools/gputop.src/meson.build             |  1 +
> >  tools/{gputop => gputop.src}/utils.c     |  0
> >  tools/{gputop => gputop.src}/utils.h     |  0
> >  tools/{gputop => gputop.src}/xe_gputop.c |  0
> >  tools/{gputop => gputop.src}/xe_gputop.h |  0
> >  tools/meson.build                        | 11 ++++++-----
> >  7 files changed, 7 insertions(+), 5 deletions(-)
> >  rename tools/{ => gputop.src}/gputop.c (100%)
> >  create mode 100644 tools/gputop.src/meson.build
> >  rename tools/{gputop => gputop.src}/utils.c (100%)
> >  rename tools/{gputop => gputop.src}/utils.h (100%)
> >  rename tools/{gputop => gputop.src}/xe_gputop.c (100%)
> >  rename tools/{gputop => gputop.src}/xe_gputop.h (100%)
> >
> > diff --git a/tools/gputop.c b/tools/gputop.src/gputop.c
> > similarity index 100%
> > rename from tools/gputop.c
> > rename to tools/gputop.src/gputop.c
> > diff --git a/tools/gputop.src/meson.build b/tools/gputop.src/meson.build
> > new file mode 100644
> > index 000000000..ec39f4c7a
> > --- /dev/null
> > +++ b/tools/gputop.src/meson.build
> > @@ -0,0 +1 @@
> > +gputop_src = files('gputop.c')
> > diff --git a/tools/gputop/utils.c b/tools/gputop.src/utils.c
> > similarity index 100%
> > rename from tools/gputop/utils.c
> > rename to tools/gputop.src/utils.c
> > diff --git a/tools/gputop/utils.h b/tools/gputop.src/utils.h
> > similarity index 100%
> > rename from tools/gputop/utils.h
> > rename to tools/gputop.src/utils.h
> > diff --git a/tools/gputop/xe_gputop.c b/tools/gputop.src/xe_gputop.c
> > similarity index 100%
> > rename from tools/gputop/xe_gputop.c
> > rename to tools/gputop.src/xe_gputop.c
> > diff --git a/tools/gputop/xe_gputop.h b/tools/gputop.src/xe_gputop.h
> > similarity index 100%
> > rename from tools/gputop/xe_gputop.h
> > rename to tools/gputop.src/xe_gputop.h
> > diff --git a/tools/meson.build b/tools/meson.build
> > index 8185ba160..521607a4c 100644
> > --- a/tools/meson.build
> > +++ b/tools/meson.build
> > @@ -70,11 +70,6 @@ if libudev.found()
> >		   install : true)
> >  endif
> >
> > -executable('gputop', 'gputop.c',
> > -           install : true,
> > -           install_rpath : bindir_rpathdir,
> > -           dependencies : [lib_igt_drm_clients,lib_igt_drm_fdinfo,lib_igt_profiling,math])
> > -
> >  intel_l3_parity_src = [ 'intel_l3_parity.c', 'intel_l3_udev_listener.c' ]
> >  executable('intel_l3_parity', sources : intel_l3_parity_src,
> >	   dependencies : tool_deps,
> > @@ -123,3 +118,9 @@ endif
> >  subdir('i915-perf')
> >  subdir('xe-perf')
> >  subdir('null_state_gen')
> > +
> > +subdir('gputop.src')
> > +executable('gputop', sources : gputop_src,
> > +	   install : true,
> > +	   install_rpath : bindir_rpathdir,
> > +	   dependencies : [lib_igt_drm_clients,lib_igt_drm_fdinfo,lib_igt_profiling,math],)
> > --
> > 2.34.1
> >