Re: [PATCH i-g-t 03/27] tools/intel_vbt_decode: Dump MIPI config for the correct panel

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 07 Jun 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Currently dump_mipi_config() just dumps the data for the same
> panel index six times. Actually dump the data for each of the
> six possible panels as intended.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Whoops,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  tools/intel_vbt_decode.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 40c05fbadacb..cee1d5196a9a 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -2016,12 +2016,9 @@ static void dump_mipi_config(struct context *context,
>  	const struct bdb_mipi_config *start = block_data(block);
>  
>  	for (int i = 0; i < ARRAY_SIZE(start->config); i++) {
> -		const struct mipi_config *config =
> -			&start->config[context->panel_type];
> -		const struct mipi_pps_data *pps =
> -			&start->pps[context->panel_type];
> -		const struct edp_pwm_delays *pwm_delays =
> -			&start->pwm_delays[context->panel_type];
> +		const struct mipi_config *config = &start->config[i];
> +		const struct mipi_pps_data *pps = &start->pps[i];
> +		const struct edp_pwm_delays *pwm_delays = &start->pwm_delays[i];
>  
>  		if (!dump_panel(context, i))
>  			continue;

-- 
Jani Nikula, Intel