Re: [PATCH i-g-t 02/14] tests/intel/xe_oa: Add first tests

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 01 Jul 2024 12:47:45 -0700, Umesh Nerlige Ramappa wrote:
>
> > +	[XE_OA_FORMAT_PEC36u64_G1_4_G2_32] = {
> > +		"PEC36u64_G1_4_G2_32_G2", .size = 320,
> > +		.oa_type = DRM_XE_OA_FMT_TYPE_PEC,
> > +		.report_hdr_64bit = true,
> > +		.counter_select = 4,
> > +		.counter_size = 1,
> > +		.bc_report = 0 },
> > +};
>
> I think we should do away with the per platform arrays and instead do
> something similar to what the KMD does - have a platform mask or something
> because really the same format does not have a new definition for another
> platform. It should just indicate what platforms the format is supported
> on. Maybe please create an issue to track this and we can look at it later
> sometime.

Thanks Umesh, yup it's a good idea. I have created an issue about this.

>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Thanks.
--
Ashutosh