* [igt-dev] [PATCH i-g-t] Fix IGT Warnings due to dynamic subtest inclusion
@ 2020-11-10 4:55 nidhi1.gupta
2020-11-10 5:16 ` Dixit, Ashutosh
0 siblings, 1 reply; 3+ messages in thread
From: nidhi1.gupta @ 2020-11-10 4:55 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
From: Nidhi Gupta <nidhi1.gupta@intel.com>
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/kms_atomic_interruptible.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
index 27bb6a2b..f98023ca 100644
--- a/tests/kms_atomic_interruptible.c
+++ b/tests/kms_atomic_interruptible.c
@@ -288,7 +288,9 @@ igt_main
for_each_pipe_with_valid_output(&display, pipe, output) {
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_legacy_modeset, DRM_PLANE_TYPE_PRIMARY);
+ {
break;
+ }
}
}
@@ -296,7 +298,9 @@ igt_main
for_each_pipe_with_valid_output(&display, pipe, output) {
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_atomic_modeset, DRM_PLANE_TYPE_PRIMARY);
+ {
break;
+ }
}
}
@@ -304,7 +308,9 @@ igt_main
for_each_pipe_with_valid_output(&display, pipe, output) {
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_legacy_dpms, DRM_PLANE_TYPE_PRIMARY);
+ {
break;
+ }
}
}
@@ -312,7 +318,9 @@ igt_main
for_each_pipe_with_valid_output(&display, pipe, output) {
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_pageflip, DRM_PLANE_TYPE_PRIMARY);
+ {
break;
+ }
}
}
@@ -320,7 +328,9 @@ igt_main
for_each_pipe_with_valid_output(&display, pipe, output) {
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_setcursor, DRM_PLANE_TYPE_CURSOR);
+ {
break;
+ }
}
}
@@ -328,7 +338,9 @@ igt_main
for_each_pipe_with_valid_output(&display, pipe, output) {
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_setplane, DRM_PLANE_TYPE_PRIMARY);
+ {
break;
+ }
}
}
@@ -336,7 +348,9 @@ igt_main
for_each_pipe_with_valid_output(&display, pipe, output) {
igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
run_plane_test(&display, pipe, output, test_setplane, DRM_PLANE_TYPE_CURSOR);
+ {
break;
+ }
}
}
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [igt-dev] [PATCH i-g-t] Fix IGT Warnings due to dynamic subtest inclusion
2020-11-10 4:55 [igt-dev] [PATCH i-g-t] Fix IGT Warnings due to dynamic subtest inclusion nidhi1.gupta
@ 2020-11-10 5:16 ` Dixit, Ashutosh
2020-11-10 5:36 ` Zbigniew Kempczyński
0 siblings, 1 reply; 3+ messages in thread
From: Dixit, Ashutosh @ 2020-11-10 5:16 UTC (permalink / raw)
To: petri.latvala; +Cc: igt-dev, nidhi1.gupta
On Mon, 09 Nov 2020 20:55:10 -0800, <nidhi1.gupta@intel.com> wrote:
>
> From: Nidhi Gupta <nidhi1.gupta@intel.com>
>
> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> ---
> tests/kms_atomic_interruptible.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
> index 27bb6a2b..f98023ca 100644
> --- a/tests/kms_atomic_interruptible.c
> +++ b/tests/kms_atomic_interruptible.c
> @@ -288,7 +288,9 @@ igt_main
> for_each_pipe_with_valid_output(&display, pipe, output) {
> igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
> run_plane_test(&display, pipe, output, test_legacy_modeset, DRM_PLANE_TYPE_PRIMARY);
> + {
> break;
> + }
> }
Are we trying to break after the first call to run_plane_test() here? In
that case why are we using a for loop (for_each_pipe_with_valid_output)? I
am not sure if igt_subtest_with_dynamic/igt_dynamic_f combinations can take
a break statement, this code pattern is certainly not used elsewhere.
So the patch does fix the warnings (which is a relief) but otherwise I
don't know if it makes sense. If not, I'd say revert the previous patch and
do it a different way.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [igt-dev] [PATCH i-g-t] Fix IGT Warnings due to dynamic subtest inclusion
2020-11-10 5:16 ` Dixit, Ashutosh
@ 2020-11-10 5:36 ` Zbigniew Kempczyński
0 siblings, 0 replies; 3+ messages in thread
From: Zbigniew Kempczyński @ 2020-11-10 5:36 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: igt-dev, nidhi1.gupta, petri.latvala
On Mon, Nov 09, 2020 at 09:16:01PM -0800, Dixit, Ashutosh wrote:
> On Mon, 09 Nov 2020 20:55:10 -0800, <nidhi1.gupta@intel.com> wrote:
> >
> > From: Nidhi Gupta <nidhi1.gupta@intel.com>
> >
> > Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
> > ---
> > tests/kms_atomic_interruptible.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c
> > index 27bb6a2b..f98023ca 100644
> > --- a/tests/kms_atomic_interruptible.c
> > +++ b/tests/kms_atomic_interruptible.c
> > @@ -288,7 +288,9 @@ igt_main
> > for_each_pipe_with_valid_output(&display, pipe, output) {
> > igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe))
> > run_plane_test(&display, pipe, output, test_legacy_modeset, DRM_PLANE_TYPE_PRIMARY);
> > + {
> > break;
> > + }
> > }
>
> Are we trying to break after the first call to run_plane_test() here? In
> that case why are we using a for loop (for_each_pipe_with_valid_output)? I
> am not sure if igt_subtest_with_dynamic/igt_dynamic_f combinations can take
> a break statement, this code pattern is certainly not used elsewhere.
>
> So the patch does fix the warnings (which is a relief) but otherwise I
> don't know if it makes sense. If not, I'd say revert the previous patch and
> do it a different way.
IMO patch doesn't makes sense. @Nidhi - please decide which "for" loop you
want to break and resend.
--
Zbigneiw
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-10 5:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-10 4:55 [igt-dev] [PATCH i-g-t] Fix IGT Warnings due to dynamic subtest inclusion nidhi1.gupta
2020-11-10 5:16 ` Dixit, Ashutosh
2020-11-10 5:36 ` Zbigniew Kempczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox