Re: [PATCH i-g-t] lib/xe/oa: Add support for 192B_MPEC8LL_NOA16 OAM format

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 15 Apr 2026 21:31:23 -0700, Shekhar Chauhan wrote:
>
> > @@ -875,6 +875,30 @@ void intel_xe_perf_accumulate_reports(struct intel_xe_perf_accumulator *acc,
> >			break;
> >   +	case XE_OAM_FORMAT_MPEC8u64_B8_C8:
> > +		/* 64 bit timestamp */
> > +		if (perf->devinfo.oa_timestamp_shift >= 0)
> > +			deltas[idx++] += (end64[1] - start64[1]) << perf->devinfo.oa_timestamp_shift;
> > +		else
> > +			deltas[idx++] += (end64[1] - start64[1]) >> (-perf->devinfo.oa_timestamp_shift);
> > +
> > +		/* 64 bit clock */
> > +		deltas[idx++] += end64[3] - start64[3];
> > +
> > +		/* 8x 64bit MPEC counters */
> > +		for (i = 0; i < 8; i++)
> > +			deltas[idx++] += end64[4 + i] - start64[4 + i];
> > +
> > +
> I feel the below increments are wrong. The added format is of 64bit.
> > /* 8x 32bit B counters */
> > +		for (i = 0; i < 8; i++)
> > +			accumulate_uint32(start + 16 + i, end + 16 + i, deltas + idx++);
> This should be "accumulate_uint32(start + 24 + i, end + 24 + i, deltas +
> idx++);"
> > +
> > +		/* 8x 32bit C counters */
> > +		for (i = 0; i < 8; i++)
> > +			accumulate_uint32(start + 24 + i, end + 24 + i, deltas + idx++);
>
> And this, "accumulate_uint32(start + 32 + i, end + 32 + i, deltas + idx++);"
>
> I'm still new to this, so I can be wrong. Maybe help me understand. Other
> than this, patch looks fine to me.

Good catch, fixed in v2. Thanks!