public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode
@ 2019-07-20  1:37 Dhinakaran Pandiyan
  2019-07-20  1:37 ` [igt-dev] [PATCH i-g-t 2/2] tools/vbt_decode: Fix PSR2 decoded training pattern duration Dhinakaran Pandiyan
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Dhinakaran Pandiyan @ 2019-07-20  1:37 UTC (permalink / raw)
  To: igt-dev; +Cc: Dhinakaran Pandiyan

The bit field corresponding to PSR1 training patterns used to be
platform agnostic. But, for VBT versions above 205 on gen9+, the values
map to hardware supported duration. The only exception being BXT, which
follows the legacy mapping.

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 tools/intel_vbt_decode.c | 37 ++++++++++++++++++++++++++++++-------
 1 file changed, 30 insertions(+), 7 deletions(-)

diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index 3b9006f5..ea64eee2 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -945,14 +945,20 @@ static void dump_psr(struct context *context,
 	const struct bdb_psr *psr_block = block->data;
 	int i;
 	uint32_t psr2_tp_time;
+	const char *bxt_str = "$VBT_BROXTON";
+	bool is_bxt;
 
 	/* The same block ID was used for something else before? */
 	if (context->bdb->version < 165)
 		return;
 
+	is_bxt = !strncmp((char *)context->vbt->signature, bxt_str,
+			  strlen(bxt_str));
 	psr2_tp_time = psr_block->psr2_tp2_tp3_wakeup_time;
+
 	for (i = 0; i < 16; i++) {
 		const struct psr_table *psr = &psr_block->psr_table[i];
+		static const uint16_t psr1_tp_times[] = {500, 100, 2500, 0};
 
 		if (i != context->panel_type && !context->dump_all_panel_types)
 			continue;
@@ -979,16 +985,33 @@ static void dump_psr(struct context *context,
 			break;
 		}
 
-		printf("\t\tIdle frames to for PSR enable: %d\n",
+		printf("\t\tIdle frames to wait for PSR enable: %d\n",
 		       psr->idle_frames);
 
-		printf("\t\tTP1 wakeup time: %d usec (0x%x)\n",
-		       psr->tp1_wakeup_time * 100,
-		       psr->tp1_wakeup_time);
 
-		printf("\t\tTP2/TP3 wakeup time: %d usec (0x%x)\n",
-		       psr->tp2_tp3_wakeup_time * 100,
-		       psr->tp2_tp3_wakeup_time);
+		if (is_bxt || context->bdb->version < 205)
+			printf("\t\tTP1 wakeup time: %d usec (0x%x)\n",
+			       psr->tp1_wakeup_time * 100,
+			       psr->tp1_wakeup_time);
+		else if (psr->tp1_wakeup_time <= 2)
+			printf("\t\tTP1 wakeup time: %d usec (0x%x)\n",
+			       psr1_tp_times[psr->tp1_wakeup_time],
+			       psr->tp1_wakeup_time);
+		else
+			printf("\t\tTP1 wakeup time invalid (0x%x)",
+			       psr->tp1_wakeup_time);
+
+		if (is_bxt || context->bdb->version < 205)
+			printf("\t\tTP2/TP3 wakeup time: %d usec (0x%x)\n",
+			       psr->tp2_tp3_wakeup_time * 100,
+			       psr->tp2_tp3_wakeup_time);
+		else if (psr->tp2_tp3_wakeup_time <= 2)
+			printf("\t\tTP2/TP3 wakeup time: %d usec (0x%x)\n",
+			       psr1_tp_times[psr->tp2_tp3_wakeup_time],
+			       psr->tp2_tp3_wakeup_time);
+		else
+			printf("\t\tTP2/3 wakeup time invalid (0x%x)",
+			       psr->tp2_tp3_wakeup_time);
 
 		if (context->bdb->version >= 226) {
 			int index;
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] [PATCH i-g-t 2/2] tools/vbt_decode: Fix PSR2 decoded training pattern duration
  2019-07-20  1:37 [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Dhinakaran Pandiyan
@ 2019-07-20  1:37 ` Dhinakaran Pandiyan
  2019-07-20  3:14 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode Patchwork
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Dhinakaran Pandiyan @ 2019-07-20  1:37 UTC (permalink / raw)
  To: igt-dev; +Cc: Dhinakaran Pandiyan

Noticed that I introduced a typo, the value corresponding 0x3 in the PSR2
TP2/TP3 field is 50us not 5us.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 tools/intel_vbt_decode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index ea64eee2..4af944cd 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -1015,7 +1015,7 @@ static void dump_psr(struct context *context,
 
 		if (context->bdb->version >= 226) {
 			int index;
-			static const uint16_t psr2_tp_times[] = {500, 100, 2500, 5};
+			static const uint16_t psr2_tp_times[] = {500, 100, 2500, 50};
 
 			index = (psr2_tp_time >> (i * 2)) & 0x3;
 			printf("\t\tPSR2 TP2/TP3 wakeup time: %d usec (0x%x)\n",
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode
  2019-07-20  1:37 [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Dhinakaran Pandiyan
  2019-07-20  1:37 ` [igt-dev] [PATCH i-g-t 2/2] tools/vbt_decode: Fix PSR2 decoded training pattern duration Dhinakaran Pandiyan
@ 2019-07-20  3:14 ` Patchwork
  2019-07-29 23:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode (rev2) Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-07-20  3:14 UTC (permalink / raw)
  To: Dhinakaran Pandiyan; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode
URL   : https://patchwork.freedesktop.org/series/63958/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5105 -> IGTPW_3282
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3282 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3282, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/63958/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3282:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-icl-u2:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5105/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3282/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html

  
Known issues
------------

  Here are the changes found in IGTPW_3282 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_create@basic:
    - fi-icl-u3:          [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5105/fi-icl-u3/igt@gem_ctx_create@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3282/fi-icl-u3/igt@gem_ctx_create@basic.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][5] -> [FAIL][6] ([fdo#109485])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5105/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3282/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       [INCOMPLETE][7] ([fdo#107718]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5105/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3282/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html

  * igt@i915_selftest@live_contexts:
    - fi-skl-iommu:       [INCOMPLETE][9] ([fdo#111050]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5105/fi-skl-iommu/igt@i915_selftest@live_contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3282/fi-skl-iommu/igt@i915_selftest@live_contexts.html

  * igt@kms_chamelium@dp-edid-read:
    - fi-kbl-7500u:       [WARN][11] ([fdo#109483]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5105/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3282/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html

  
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
  [fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050


Participating hosts (52 -> 47)
------------------------------

  Additional (1): fi-skl-lmem 
  Missing    (6): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_5105 -> IGTPW_3282

  CI_DRM_6515: a9fbb0055257ca5040e81c155212609c1bd6dc0e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3282: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3282/
  IGT_5105: c77beecef80ec6a19d24347ed1a423805ac8a535 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3282/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode (rev2)
  2019-07-20  1:37 [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Dhinakaran Pandiyan
  2019-07-20  1:37 ` [igt-dev] [PATCH i-g-t 2/2] tools/vbt_decode: Fix PSR2 decoded training pattern duration Dhinakaran Pandiyan
  2019-07-20  3:14 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode Patchwork
@ 2019-07-29 23:50 ` Patchwork
  2019-07-30  9:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2019-07-31 13:10 ` [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Jani Nikula
  4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-07-29 23:50 UTC (permalink / raw)
  To: Dhinakaran Pandiyan; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode (rev2)
URL   : https://patchwork.freedesktop.org/series/63958/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6576 -> IGTPW_3307
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/63958/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3307 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_module_load@reload:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/fi-icl-u3/igt@i915_module_load@reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/fi-icl-u3/igt@i915_module_load@reload.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u2:          [PASS][3] -> [FAIL][4] ([fdo#103167])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@kms_busy@basic-flip-a:
    - fi-kbl-7567u:       [SKIP][5] ([fdo#109271] / [fdo#109278]) -> [PASS][6] +2 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/fi-kbl-7567u/igt@kms_busy@basic-flip-a.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-icl-u2:          [FAIL][7] ([fdo#109483]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
    - fi-kbl-7500u:       [FAIL][9] ([fdo#109485]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
  [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566


Participating hosts (51 -> 45)
------------------------------

  Missing    (6): fi-icl-u4 fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5115 -> IGTPW_3307

  CI-20190529: 20190529
  CI_DRM_6576: 4040b4c4ab647422d82100c8b091d34b6a82f572 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3307: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/
  IGT_5115: 21be7a02ac8a8ff46b561c36a69e4dd5a0c2938b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode (rev2)
  2019-07-20  1:37 [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Dhinakaran Pandiyan
                   ` (2 preceding siblings ...)
  2019-07-29 23:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode (rev2) Patchwork
@ 2019-07-30  9:41 ` Patchwork
  2019-07-31 13:10 ` [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Jani Nikula
  4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-07-30  9:41 UTC (permalink / raw)
  To: Dhinakaran Pandiyan; +Cc: igt-dev

== Series Details ==

Series: series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode (rev2)
URL   : https://patchwork.freedesktop.org/series/63958/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6576_full -> IGTPW_3307_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/63958/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_3307_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_flip@basic-flip-vs-wf_vblank:
    - shard-hsw:          [PASS][1] -> [INCOMPLETE][2] ([fdo#103540]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-hsw8/igt@kms_flip@basic-flip-vs-wf_vblank.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-hsw8/igt@kms_flip@basic-flip-vs-wf_vblank.html

  * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
    - shard-iclb:         [PASS][3] -> [FAIL][4] ([fdo#103167]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
    - shard-iclb:         [PASS][5] -> [INCOMPLETE][6] ([fdo#107713])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff.html

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#109642] / [fdo#111068])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-iclb2/igt@kms_psr2_su@page_flip.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-iclb6/igt@kms_psr2_su@page_flip.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#109441])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_vblank@pipe-b-ts-continuation-suspend:
    - shard-kbl:          [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-kbl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          [DMESG-WARN][13] ([fdo#108566]) -> [PASS][14] +6 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-kbl3/igt@gem_ctx_isolation@rcs0-s3.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-kbl3/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [SKIP][15] ([fdo#110854]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-iclb6/igt@gem_exec_balancer@smoke.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-iclb2/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_suspend@basic-s3:
    - shard-snb:          [DMESG-WARN][17] ([fdo#110684] / [fdo#111115]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-snb6/igt@gem_exec_suspend@basic-s3.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-snb6/igt@gem_exec_suspend@basic-s3.html

  * igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque:
    - shard-kbl:          [FAIL][19] ([fdo#103232]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          [FAIL][21] ([fdo#105363]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-hsw:          [INCOMPLETE][23] ([fdo#103540]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-hsw7/igt@kms_flip@flip-vs-suspend.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-hsw8/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
    - shard-iclb:         [FAIL][25] ([fdo#103167]) -> [PASS][26] +3 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-stridechange:
    - shard-glk:          [FAIL][27] ([fdo#103167]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-glk3/igt@kms_frontbuffer_tracking@fbc-stridechange.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-glk2/igt@kms_frontbuffer_tracking@fbc-stridechange.html
    - shard-apl:          [FAIL][29] ([fdo#103167]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-apl5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-apl6/igt@kms_frontbuffer_tracking@fbc-stridechange.html
    - shard-kbl:          [FAIL][31] ([fdo#103167]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-stridechange.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-stridechange.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-apl:          [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +4 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-apl5/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [SKIP][35] ([fdo#109441]) -> [PASS][36] +2 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-iclb2/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][37] ([fdo#99912]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-apl2/igt@kms_setmode@basic.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-apl4/igt@kms_setmode@basic.html

  * igt@kms_vblank@pipe-c-wait-forked-busy-hang:
    - shard-iclb:         [INCOMPLETE][39] ([fdo#107713]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-iclb7/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-iclb3/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html

  * igt@prime_busy@wait-hang-vebox:
    - shard-glk:          [DMESG-WARN][41] ([fdo#111256]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-glk7/igt@prime_busy@wait-hang-vebox.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-glk8/igt@prime_busy@wait-hang-vebox.html

  
#### Warnings ####

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][43] ([fdo#108566]) -> [INCOMPLETE][44] ([fdo#103665])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6576/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110684]: https://bugs.freedesktop.org/show_bug.cgi?id=110684
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111115]: https://bugs.freedesktop.org/show_bug.cgi?id=111115
  [fdo#111256]: https://bugs.freedesktop.org/show_bug.cgi?id=111256
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5115 -> IGTPW_3307
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_6576: 4040b4c4ab647422d82100c8b091d34b6a82f572 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3307: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/
  IGT_5115: 21be7a02ac8a8ff46b561c36a69e4dd5a0c2938b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3307/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode
  2019-07-20  1:37 [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Dhinakaran Pandiyan
                   ` (3 preceding siblings ...)
  2019-07-30  9:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-07-31 13:10 ` Jani Nikula
  4 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2019-07-31 13:10 UTC (permalink / raw)
  To: Dhinakaran Pandiyan, igt-dev; +Cc: Dhinakaran Pandiyan

On Fri, 19 Jul 2019, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote:
> The bit field corresponding to PSR1 training patterns used to be
> platform agnostic. But, for VBT versions above 205 on gen9+, the values
> map to hardware supported duration. The only exception being BXT, which
> follows the legacy mapping.
>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  tools/intel_vbt_decode.c | 37 ++++++++++++++++++++++++++++++-------
>  1 file changed, 30 insertions(+), 7 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 3b9006f5..ea64eee2 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -945,14 +945,20 @@ static void dump_psr(struct context *context,
>  	const struct bdb_psr *psr_block = block->data;
>  	int i;
>  	uint32_t psr2_tp_time;
> +	const char *bxt_str = "$VBT_BROXTON";

I don't think you can trust that. IS_BROXTON(context->devid) might be
more reliable. *shrug*.

BR,
Jani.


> +	bool is_bxt;
>  
>  	/* The same block ID was used for something else before? */
>  	if (context->bdb->version < 165)
>  		return;
>  
> +	is_bxt = !strncmp((char *)context->vbt->signature, bxt_str,
> +			  strlen(bxt_str));
>  	psr2_tp_time = psr_block->psr2_tp2_tp3_wakeup_time;
> +
>  	for (i = 0; i < 16; i++) {
>  		const struct psr_table *psr = &psr_block->psr_table[i];
> +		static const uint16_t psr1_tp_times[] = {500, 100, 2500, 0};
>  
>  		if (i != context->panel_type && !context->dump_all_panel_types)
>  			continue;
> @@ -979,16 +985,33 @@ static void dump_psr(struct context *context,
>  			break;
>  		}
>  
> -		printf("\t\tIdle frames to for PSR enable: %d\n",
> +		printf("\t\tIdle frames to wait for PSR enable: %d\n",
>  		       psr->idle_frames);
>  
> -		printf("\t\tTP1 wakeup time: %d usec (0x%x)\n",
> -		       psr->tp1_wakeup_time * 100,
> -		       psr->tp1_wakeup_time);
>  
> -		printf("\t\tTP2/TP3 wakeup time: %d usec (0x%x)\n",
> -		       psr->tp2_tp3_wakeup_time * 100,
> -		       psr->tp2_tp3_wakeup_time);
> +		if (is_bxt || context->bdb->version < 205)
> +			printf("\t\tTP1 wakeup time: %d usec (0x%x)\n",
> +			       psr->tp1_wakeup_time * 100,
> +			       psr->tp1_wakeup_time);
> +		else if (psr->tp1_wakeup_time <= 2)
> +			printf("\t\tTP1 wakeup time: %d usec (0x%x)\n",
> +			       psr1_tp_times[psr->tp1_wakeup_time],
> +			       psr->tp1_wakeup_time);
> +		else
> +			printf("\t\tTP1 wakeup time invalid (0x%x)",
> +			       psr->tp1_wakeup_time);
> +
> +		if (is_bxt || context->bdb->version < 205)
> +			printf("\t\tTP2/TP3 wakeup time: %d usec (0x%x)\n",
> +			       psr->tp2_tp3_wakeup_time * 100,
> +			       psr->tp2_tp3_wakeup_time);
> +		else if (psr->tp2_tp3_wakeup_time <= 2)
> +			printf("\t\tTP2/TP3 wakeup time: %d usec (0x%x)\n",
> +			       psr1_tp_times[psr->tp2_tp3_wakeup_time],
> +			       psr->tp2_tp3_wakeup_time);
> +		else
> +			printf("\t\tTP2/3 wakeup time invalid (0x%x)",
> +			       psr->tp2_tp3_wakeup_time);
>  
>  		if (context->bdb->version >= 226) {
>  			int index;

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-07-31 13:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-20  1:37 [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Dhinakaran Pandiyan
2019-07-20  1:37 ` [igt-dev] [PATCH i-g-t 2/2] tools/vbt_decode: Fix PSR2 decoded training pattern duration Dhinakaran Pandiyan
2019-07-20  3:14 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode Patchwork
2019-07-29 23:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode (rev2) Patchwork
2019-07-30  9:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-07-31 13:10 ` [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox