[igt-dev] [v2 0/5] Add multi-gt support for RC6 residency test

[igt-dev] [v2 0/5] Add multi-gt support for RC6 residency test

[Sujaritha Sundaresan]

Add multi-gt support for the i915_pm_rc6_residency test

v2: Clean up igt_sysfs_get_u32 calls in rc6_accuracy
    and drpc patches (Riana)

Sujaritha Sundaresan (5):
  tests/intel: Add multi-gt support for rc6-idle test
  tests/intel: Add multi-gt support for rc6-fence test
  tests/intel: Add multi-gt support for rc6-accuracy test
  tests/intel: Print drpc info for rc6_residency test
  HAX: Add rc6 residency to fast-feedback.testlist

 tests/intel-ci/fast-feedback.testlist |   4 +
 tests/intel/i915_pm_rc6_residency.c   | 130 ++++++++++++++++----------
 2 files changed, 87 insertions(+), 47 deletions(-)

-- 
2.25.1

[igt-dev] [v2 1/5] tests/intel: Add multi-gt support for rc6-idle test

[Sujaritha Sundaresan]

Adding multi-gt support for the rc6-idle subtest

Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
 tests/intel/i915_pm_rc6_residency.c | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
index b266680ac..57ac5c721 100644
--- a/tests/intel/i915_pm_rc6_residency.c
+++ b/tests/intel/i915_pm_rc6_residency.c
@@ -376,7 +376,7 @@ static void kill_children(int sig)
 	signal(sig, old);
 }
 
-static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags)
+static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, unsigned int gt)
 {
 	const int64_t duration_ns = SLEEP_DURATION * (int64_t)NSEC_PER_SEC;
 	const int tolerance = 20; /* Some RC6 is better than none! */
@@ -397,7 +397,7 @@ static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags)
 	struct igt_power gpu;
 	int fd;
 
-	fd = open_pmu(i915, I915_PMU_RC6_RESIDENCY);
+	fd = open_pmu(i915, __I915_PMU_RC6_RESIDENCY(gt));
 	igt_drop_caches_set(i915, DROP_IDLE);
 	igt_require(__pmu_wait_for_rc6(fd));
 	igt_power_open(i915, &gpu, "gpu");
@@ -558,6 +558,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
 igt_main
 {
 	int i915 = -1;
+	unsigned int dirfd, gt;
 	const intel_ctx_t *ctx;
 
 	/* Use drm_open_driver to verify device existence */
@@ -572,11 +573,15 @@ igt_main
 		igt_require_gem(i915);
 		gem_quiescent_gpu(i915);
 
-		for_each_ctx_engine(i915, ctx, e) {
-			if (e->instance == 0) {
-				igt_dynamic_f("%s", e->name)
-					rc6_idle(i915, ctx->id, e->flags);
+		i915_for_each_gt(i915, dirfd, gt) {
+			ctx = intel_ctx_create_for_gt(i915, gt);
+			for_each_ctx_engine(i915, ctx, e) {
+				if (e->instance == 0) {
+					igt_dynamic_f("gt%u-%s", gt, e->name)
+						rc6_idle(i915, ctx->id, e->flags, gt);
+				}
 			}
+			intel_ctx_destroy(i915, ctx);
 		}
 	}
 
@@ -626,7 +631,6 @@ igt_main
 	}
 
 	igt_fixture {
-		intel_ctx_destroy(i915, ctx);
 		drm_close_driver(i915);
 	}
 }
-- 
2.25.1

[igt-dev] [v2 2/5] tests/intel: Add multi-gt support for rc6-fence test

[Sujaritha Sundaresan]

Add multi-gt support for the rc6-fence subtest.

Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
 tests/intel/i915_pm_rc6_residency.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
index 57ac5c721..5dc785792 100644
--- a/tests/intel/i915_pm_rc6_residency.c
+++ b/tests/intel/i915_pm_rc6_residency.c
@@ -471,12 +471,13 @@ static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, unsigned int gt)
 	}
 }
 
-static void rc6_fence(int i915, const intel_ctx_t *ctx)
+static void rc6_fence(int i915, unsigned int gt)
 {
 	const int64_t duration_ns = SLEEP_DURATION * (int64_t)NSEC_PER_SEC;
 	const int tolerance = 20; /* Some RC6 is better than none! */
 	const unsigned int gen = intel_gen(intel_get_drm_devid(i915));
 	const struct intel_execution_engine2 *e;
+	const intel_ctx_t *ctx;
 	struct power_sample sample[2];
 	unsigned long slept;
 	uint64_t rc6, ts[2], ahnd;
@@ -485,7 +486,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
 
 	igt_require_sw_sync();
 
-	fd = open_pmu(i915, I915_PMU_RC6_RESIDENCY);
+	fd = open_pmu(i915, __I915_PMU_RC6_RESIDENCY(gt));
 	igt_drop_caches_set(i915, DROP_IDLE);
 	igt_require(__pmu_wait_for_rc6(fd));
 	igt_power_open(i915, &gpu, "gpu");
@@ -509,6 +510,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
 	assert_within_epsilon(rc6, ts[1] - ts[0], 5);
 
 	/* Submit but delay execution, we should be idle and conserving power */
+	ctx = intel_ctx_create_for_gt(i915, gt);
 	ahnd = get_reloc_ahnd(i915, ctx->id);
 	for_each_ctx_engine(i915, ctx, e) {
 		igt_spin_t *spin;
@@ -550,6 +552,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
 		gem_quiescent_gpu(i915);
 	}
 	put_ahnd(ahnd);
+	intel_ctx_destroy(i915, ctx);
 
 	igt_power_close(&gpu);
 	close(fd);
@@ -585,11 +588,13 @@ igt_main
 		}
 	}
 
-	igt_subtest("rc6-fence") {
+	igt_subtest_with_dynamic("rc6-fence") {
 		igt_require_gem(i915);
 		gem_quiescent_gpu(i915);
 
-		rc6_fence(i915, ctx);
+		i915_for_each_gt(i915, dirfd, gt)
+			igt_dynamic_f("gt%u", gt)
+				rc6_fence(i915, gt);
 	}
 
 	igt_subtest_group {
-- 
2.25.1

[igt-dev] [v2 3/5] tests/intel: Add multi-gt support for rc6-accuracy test

[Sujaritha Sundaresan]

Add multi-gt support for rc6-accuracy subtest.

Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
 tests/intel/i915_pm_rc6_residency.c | 48 ++++++++++++++---------------
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
index 5dc785792..6e491f270 100644
--- a/tests/intel/i915_pm_rc6_residency.c
+++ b/tests/intel/i915_pm_rc6_residency.c
@@ -82,23 +82,19 @@ static unsigned long get_rc6_enabled_mask(void)
 	return enabled;
 }
 
-static bool has_rc6_residency(const char *name)
+static bool has_rc6_residency(int dirfd, enum i915_attr_id id)
 {
 	unsigned long residency;
-	char path[128];
 
-	sprintf(path, "power/%s_residency_ms", name);
-	return igt_sysfs_scanf(sysfs, path, "%lu", &residency) == 1;
+	return igt_sysfs_rps_scanf(dirfd, id, "%lu", &residency) == 1;
 }
 
-static unsigned long read_rc6_residency(const char *name)
+static unsigned long read_rc6_residency(int dirfd, enum i915_attr_id id)
 {
 	unsigned long residency;
-	char path[128];
 
 	residency = 0;
-	sprintf(path, "power/%s_residency_ms", name);
-	igt_assert(igt_sysfs_scanf(sysfs, path, "%lu", &residency) == 1);
+	igt_assert(igt_sysfs_rps_scanf(dirfd, id, "%lu", &residency) == 1);
 	return residency;
 }
 
@@ -125,28 +121,28 @@ static unsigned long gettime_ms(void)
 	return ts.tv_sec * 1000 + ts.tv_nsec / 1000000;
 }
 
-static void read_residencies(int devid, unsigned int mask,
+static void read_residencies(int devid, int dirfd, unsigned int mask,
 			     struct residencies *res)
 {
 	res->duration = gettime_ms();
 
 	if (mask & RC6_ENABLED)
-		res->rc6 = read_rc6_residency("rc6");
+		res->rc6 = read_rc6_residency(dirfd, RC6_RESIDENCY_MS);
 
 	if ((mask & RC6_ENABLED) &&
 	    (IS_VALLEYVIEW(devid) || IS_CHERRYVIEW(devid)))
-		res->media_rc6 = read_rc6_residency("media_rc6");
+		res->media_rc6 = read_rc6_residency(dirfd, MEDIA_RC6_RESIDENCY_MS);
 
 	if (mask & RC6P_ENABLED)
-		res->rc6p = read_rc6_residency("rc6p");
+		res->rc6p = read_rc6_residency(dirfd, RC6P_RESIDENCY_MS);
 
 	if (mask & RC6PP_ENABLED)
-		res->rc6pp = read_rc6_residency("rc6pp");
+		res->rc6pp = read_rc6_residency(dirfd, RC6PP_RESIDENCY_MS);
 
 	res->duration += (gettime_ms() - res->duration) / 2;
 }
 
-static void measure_residencies(int devid, unsigned int mask,
+static void measure_residencies(int devid, int dirfd, unsigned int mask,
 				struct residencies *res)
 {
 	struct residencies start = { };
@@ -158,13 +154,13 @@ static void measure_residencies(int devid, unsigned int mask,
 	 * measurement, since the valid counter range is different on
 	 * different platforms and so fixing it up would be non-trivial.
 	 */
-	read_residencies(devid, mask, &end);
+	read_residencies(devid, dirfd, mask, &end);
 	igt_debug("time=%d: rc6=(%d, %d), rc6p=%d, rc6pp=%d\n",
 		  end.duration, end.rc6, end.media_rc6, end.rc6p, end.rc6pp);
 	for (retry = 0; retry < 2; retry++) {
 		start = end;
 		sleep(SLEEP_DURATION);
-		read_residencies(devid, mask, &end);
+		read_residencies(devid, dirfd, mask, &end);
 
 		igt_debug("time=%d: rc6=(%d, %d), rc6p=%d, rc6pp=%d\n",
 			  end.duration,
@@ -196,7 +192,7 @@ static void measure_residencies(int devid, unsigned int mask,
 	res->rc6 += res->rc6p;
 }
 
-static bool wait_for_rc6(void)
+static bool wait_for_rc6(int dirfd)
 {
 	struct timespec tv = {};
 	unsigned long start, now;
@@ -205,11 +201,11 @@ static bool wait_for_rc6(void)
 	usleep(160 * 1000);
 
 	/* Then poll for RC6 to start ticking */
-	now = read_rc6_residency("rc6");
+	now = read_rc6_residency(dirfd, RC6_RESIDENCY_MS);
 	do {
 		start = now;
 		usleep(5000);
-		now = read_rc6_residency("rc6");
+		now = read_rc6_residency(dirfd, RC6_RESIDENCY_MS);
 		if (now - start > 1)
 			return true;
 	} while (!igt_seconds_elapsed(&tv));
@@ -605,21 +601,23 @@ igt_main
 			devid = intel_get_drm_devid(i915);
 			sysfs = igt_sysfs_open(i915);
 
-			igt_require(has_rc6_residency("rc6"));
+			igt_require(has_rc6_residency(dirfd, RC6_RESIDENCY_MS));
 
 			/* Make sure rc6 counters are running */
 			igt_drop_caches_set(i915, DROP_IDLE);
-			igt_require(wait_for_rc6());
+			igt_require(wait_for_rc6(dirfd));
 
 			rc6_enabled = get_rc6_enabled_mask();
 			igt_require(rc6_enabled & RC6_ENABLED);
 		}
 
 		igt_subtest("rc6-accuracy") {
-			struct residencies res;
+			for_each_sysfs_gt_dirfd(i915, dirfd, gt) {
+				struct residencies res;
 
-			measure_residencies(devid, rc6_enabled, &res);
-			residency_accuracy(res.rc6, res.duration, "rc6");
+				measure_residencies(devid, dirfd, rc6_enabled, &res);
+				residency_accuracy(res.rc6, res.duration, "rc6");
+			}
 		}
 
 		igt_subtest("media-rc6-accuracy") {
@@ -627,7 +625,7 @@ igt_main
 
 			igt_require(IS_VALLEYVIEW(devid) || IS_CHERRYVIEW(devid));
 
-			measure_residencies(devid, rc6_enabled, &res);
+			measure_residencies(devid, sysfs, rc6_enabled, &res);
 			residency_accuracy(res.media_rc6, res.duration, "media_rc6");
 		}
 
-- 
2.25.1

[igt-dev] [v2 4/5] tests/intel: Print drpc info for rc6_residency test

[Sujaritha Sundaresan]

Add drpc debug info for the rc6_residency test.

Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
 tests/intel/i915_pm_rc6_residency.c | 51 ++++++++++++++++++++++-------
 1 file changed, 40 insertions(+), 11 deletions(-)

diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
index 6e491f270..0288158fd 100644
--- a/tests/intel/i915_pm_rc6_residency.c
+++ b/tests/intel/i915_pm_rc6_residency.c
@@ -36,6 +36,7 @@
 #include "i915/gem.h"
 #include "i915/gem_create.h"
 #include "igt.h"
+#include "igt_debugfs.h"
 #include "igt_perf.h"
 #include "igt_power.h"
 #include "igt_sysfs.h"
@@ -230,14 +231,27 @@ static uint64_t pmu_read_single(int fd)
 	return __pmu_read_single(fd, NULL);
 }
 
-#define __assert_within_epsilon(x, ref, tol_up, tol_down) \
-	igt_assert_f((x) <= (ref) * (1.0 + (tol_up)/100.) && \
-		     (x) >= (ref) * (1.0 - (tol_down)/100.), \
-		     "'%s' != '%s' (%.3g not within +%d%%/-%d%% tolerance of %.3g)\n",\
-		     #x, #ref, (double)(x), (tol_up), (tol_down), (double)(ref))
+#define __assert_within_epsilon(x, ref, tol_up, tol_down, debug_data) \
+	igt_assert_f((double)(x) <= (1.0 + (tol_up)) * (double)(ref) && \
+		     (double)(x) >= (1.0 - (tol_down)) * (double)(ref), \
+		     "'%s' != '%s' (%f not within +%.1f%%/-%.1f%% tolerance of %f)\n %s\n",\
+		     #x, #ref, (double)(x), \
+		     (tol_up) * 100.0, (tol_down) * 100.0, \
+		     (double)(ref), debug_data)
 
-#define assert_within_epsilon(x, ref, tolerance) \
-	__assert_within_epsilon(x, ref, tolerance, tolerance)
+#define assert_within_epsilon(x, ref, tolerance, debug_data) \
+	__assert_within_epsilon(x, ref, tolerance, tolerance, debug_data)
+
+char *drpc;
+
+static char *get_drpc(int i915, int gt_id)
+{
+	int gt_dir;
+
+	gt_dir = igt_debugfs_gt_dir(i915, gt_id);
+	igt_assert(gt_dir != -1);
+	return igt_sysfs_get(gt_dir, "drpc");
+}
 
 static bool __pmu_wait_for_rc6(int fd)
 {
@@ -414,7 +428,9 @@ static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, unsigned int gt)
 			"Total energy used while idle: %.1fmJ (%.1fmW)\n",
 			idle, (idle * 1e9) / slept);
 	}
-	assert_within_epsilon(rc6, ts[1] - ts[0], 5);
+	drpc = get_drpc(i915, gt);
+
+	assert_within_epsilon(rc6, ts[1] - ts[0], 5, drpc);
 
 	done = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
 
@@ -450,7 +466,12 @@ static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, unsigned int gt)
 		igt_assert(cycles >= SLEEP_DURATION);
 
 		/* While very nearly idle, expect full RC6 */
-		assert_within_epsilon(rc6, ts[1] - ts[0], tolerance);
+		drpc = get_drpc(i915, gt);
+
+		assert_within_epsilon(rc6, ts[1] - ts[0], tolerance, drpc);
+
+		free(drpc);
+		drpc = NULL;
 	}
 
 	munmap(done, 4096);
@@ -503,7 +524,9 @@ static void rc6_fence(int i915, unsigned int gt)
 			"Total energy used while idle: %.1fmJ (%.1fmW)\n",
 			idle, (idle * 1e9) / slept);
 	}
-	assert_within_epsilon(rc6, ts[1] - ts[0], 5);
+	drpc = get_drpc(i915, gt);
+
+	assert_within_epsilon(rc6, ts[1] - ts[0], 5, drpc);
 
 	/* Submit but delay execution, we should be idle and conserving power */
 	ctx = intel_ctx_create_for_gt(i915, gt);
@@ -544,8 +567,13 @@ static void rc6_fence(int i915, unsigned int gt)
 
 		close(timeline);
 
-		assert_within_epsilon(rc6, ts[1] - ts[0], tolerance);
+		drpc = get_drpc(i915, gt);
+
+		assert_within_epsilon(rc6, ts[1] - ts[0], tolerance, drpc);
 		gem_quiescent_gpu(i915);
+
+		free(drpc);
+		drpc = NULL;
 	}
 	put_ahnd(ahnd);
 	intel_ctx_destroy(i915, ctx);
@@ -634,6 +662,7 @@ igt_main
 	}
 
 	igt_fixture {
+		free(drpc);
 		drm_close_driver(i915);
 	}
 }
-- 
2.25.1

[igt-dev] [v2 5/5] HAX: Add rc6 residency to fast-feedback.testlist

[Sujaritha Sundaresan]

Add the rc6 residency test to fast-feedback.testlist

Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index c252e2cf0..a5861203f 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -54,6 +54,10 @@ igt@i915_getparams_basic@basic-eu-total
 igt@i915_getparams_basic@basic-subslice-total
 igt@i915_hangman@error-state-basic
 igt@i915_pciid
+igt@i915_pm_rc6_residency@media-rc6-accuracy
+igt@i915_pm_rc6_residency@rc6-accuracy
+igt@i915_pm_rc6_residency@rc6-fence
+igt@i915_pm_rc6_residency@rc6-idle
 igt@kms_addfb_basic@addfb25-4-tiled
 igt@kms_addfb_basic@addfb25-bad-modifier
 igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-- 
2.25.1

[igt-dev] ✓ CI.xeBAT: success for Add multi-gt support for RC6 residency test (rev5)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 6306 bytes --]

== Series Details ==

Series: Add multi-gt support for RC6 residency test (rev5)
URL   : https://patchwork.freedesktop.org/series/126169/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7580_BAT -> XEIGTPW_10149_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (2 -> 4)
------------------------------

  Additional (2): bat-dg2-oem2 bat-adlp-7 

Known issues
------------

  Here are the changes found in XEIGTPW_10149_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - bat-dg2-oem2:       NOTRUN -> [SKIP][1] ([Intel XE#623])
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - bat-dg2-oem2:       NOTRUN -> [SKIP][2] ([Intel XE#624])
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@kms_addfb_basic@basic-y-tiled-legacy.html
    - bat-adlp-7:         NOTRUN -> [FAIL][3] ([Intel XE#609]) +2 other tests fail
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-adlp-7/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  * igt@kms_addfb_basic@tile-pitch-mismatch:
    - bat-dg2-oem2:       NOTRUN -> [FAIL][4] ([Intel XE#609]) +1 other test fail
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@kms_addfb_basic@tile-pitch-mismatch.html

  * igt@kms_dsc@dsc-basic:
    - bat-dg2-oem2:       NOTRUN -> [SKIP][5] ([Intel XE#423])
   [5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@kms_dsc@dsc-basic.html
    - bat-adlp-7:         NOTRUN -> [SKIP][6] ([Intel XE#423])
   [6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-adlp-7/igt@kms_dsc@dsc-basic.html

  * igt@kms_force_connector_basic@prune-stale-modes:
    - bat-dg2-oem2:       NOTRUN -> [SKIP][7] ([i915#5274])
   [7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@kms_force_connector_basic@prune-stale-modes.html

  * igt@kms_frontbuffer_tracking@basic:
    - bat-dg2-oem2:       NOTRUN -> [FAIL][8] ([Intel XE#608])
   [8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@kms_frontbuffer_tracking@basic.html
    - bat-adlp-7:         NOTRUN -> [DMESG-FAIL][9] ([Intel XE#282] / [i915#2017])
   [9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12:
    - bat-dg2-oem2:       NOTRUN -> [FAIL][10] ([Intel XE#400] / [Intel XE#616]) +2 other tests fail
   [10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12.html

  * igt@kms_psr@primary_page_flip:
    - bat-dg2-oem2:       NOTRUN -> [SKIP][11] ([Intel XE#535]) +2 other tests skip
   [11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@kms_psr@primary_page_flip.html

  * igt@xe_compute@compute-square:
    - bat-dg2-oem2:       NOTRUN -> [SKIP][12] ([Intel XE#672])
   [12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@xe_compute@compute-square.html

  * igt@xe_evict@evict-beng-small-external:
    - bat-adlp-7:         NOTRUN -> [SKIP][13] ([Intel XE#261] / [Intel XE#688]) +15 other tests skip
   [13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-adlp-7/igt@xe_evict@evict-beng-small-external.html

  * igt@xe_exec_fault_mode@many-basic:
    - bat-dg2-oem2:       NOTRUN -> [SKIP][14] ([Intel XE#288]) +17 other tests skip
   [14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@xe_exec_fault_mode@many-basic.html

  * igt@xe_huc_copy@huc_copy:
    - bat-dg2-oem2:       NOTRUN -> [SKIP][15] ([Intel XE#255])
   [15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-dg2-oem2/igt@xe_huc_copy@huc_copy.html

  * igt@xe_live_ktest@migrate:
    - bat-adlp-7:         NOTRUN -> [INCOMPLETE][16] ([Intel XE#753])
   [16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-adlp-7/igt@xe_live_ktest@migrate.html

  * igt@xe_mmap@vram:
    - bat-adlp-7:         NOTRUN -> [SKIP][17] ([Intel XE#263])
   [17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/bat-adlp-7/igt@xe_mmap@vram.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [Intel XE#255]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/255
  [Intel XE#261]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/261
  [Intel XE#263]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/263
  [Intel XE#282]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/282
  [Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
  [Intel XE#400]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/400
  [Intel XE#423]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/423
  [Intel XE#524]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/524
  [Intel XE#535]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/535
  [Intel XE#608]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/608
  [Intel XE#609]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/609
  [Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
  [Intel XE#623]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/623
  [Intel XE#624]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/624
  [Intel XE#672]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/672
  [Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
  [Intel XE#753]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/753
  [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
  [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274


Build changes
-------------

  * IGT: IGT_7580 -> IGTPW_10149

  IGTPW_10149: 10149
  IGT_7580: 847ee1e7d365e2fb08bf4198d3bf5ee8a852649f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-481-7a0da606f1fcf4b59d7164419f1ccd1c48d366af: 7a0da606f1fcf4b59d7164419f1ccd1c48d366af

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10149/index.html

[-- Attachment #2: Type: text/html, Size: 7315 bytes --]

[igt-dev] ✗ Fi.CI.BAT: failure for Add multi-gt support for RC6 residency test (rev5)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 25308 bytes --]

== Series Details ==

Series: Add multi-gt support for RC6 residency test (rev5)
URL   : https://patchwork.freedesktop.org/series/126169/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13853 -> IGTPW_10149
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_10149 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_10149, please notify your bug team (lgci.bug.filing@intel.com) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/index.html

Participating hosts (32 -> 34)
------------------------------

  Additional (3): fi-hsw-4770 bat-dg2-9 bat-mtlp-8 
  Missing    (1): fi-kbl-soraka 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_10149:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rc6_residency@media-rc6-accuracy:
    - bat-rplp-1:         NOTRUN -> [SKIP][1] +1 other test skip
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-rplp-1/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - fi-rkl-11600:       NOTRUN -> [SKIP][2] +1 other test skip
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-rkl-11600/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - bat-adls-5:         NOTRUN -> [SKIP][3] +1 other test skip
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-adls-5/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - bat-atsm-1:         NOTRUN -> [SKIP][4] +1 other test skip
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-atsm-1/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - bat-jsl-3:          NOTRUN -> [SKIP][5] +1 other test skip
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-jsl-3/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - bat-dg2-9:          NOTRUN -> [SKIP][6] +1 other test skip
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - bat-adlp-11:        NOTRUN -> [SKIP][7] +1 other test skip
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-adlp-11/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - bat-adln-1:         NOTRUN -> [SKIP][8] +1 other test skip
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-adln-1/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][9] +1 other test skip
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - bat-adlm-1:         NOTRUN -> [SKIP][10] +1 other test skip
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-adlm-1/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][11] +1 other test skip
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-tgl-1115g4/igt@i915_pm_rc6_residency@media-rc6-accuracy.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - bat-adlp-6:         NOTRUN -> [SKIP][12] +1 other test skip
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-adlp-6/igt@i915_pm_rc6_residency@rc6-accuracy.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][13] +1 other test skip
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-6/igt@i915_pm_rc6_residency@rc6-accuracy.html
    - bat-adlp-9:         NOTRUN -> [SKIP][14] +1 other test skip
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-adlp-9/igt@i915_pm_rc6_residency@rc6-accuracy.html
    - bat-dg2-11:         NOTRUN -> [SKIP][15] +1 other test skip
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-11/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * {igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0} (NEW):
    - bat-atsm-1:         NOTRUN -> [FAIL][16] +4 other tests fail
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-atsm-1/igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0.html
    - fi-skl-guc:         NOTRUN -> [WARN][17]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-skl-guc/igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0.html
    - fi-cfl-8109u:       NOTRUN -> [WARN][18]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-cfl-8109u/igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0.html
    - fi-kbl-guc:         NOTRUN -> [WARN][19]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-kbl-guc/igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_pm_rc6_residency@media-rc6-accuracy:
    - {bat-dg2-14}:       NOTRUN -> [SKIP][20] +1 other test skip
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-14/igt@i915_pm_rc6_residency@media-rc6-accuracy.html

  
New tests
---------

  New tests have been introduced between CI_DRM_13853 and IGTPW_10149:

### New IGT tests (9) ###

  * igt@i915_pm_rc6_residency@rc6-fence@gt0:
    - Statuses : 29 pass(s) 4 skip(s)
    - Exec time: [0.0] s

  * igt@i915_pm_rc6_residency@rc6-fence@gt1:
    - Statuses : 2 pass(s)
    - Exec time: [0.0] s

  * igt@i915_pm_rc6_residency@rc6-idle@gt0-bcs0:
    - Statuses : 1 fail(s) 28 pass(s)
    - Exec time: [0.0] s

  * igt@i915_pm_rc6_residency@rc6-idle@gt0-ccs0:
    - Statuses : 1 fail(s) 5 pass(s)
    - Exec time: [0.0] s

  * igt@i915_pm_rc6_residency@rc6-idle@gt0-rcs0:
    - Statuses : 1 fail(s) 28 pass(s) 4 skip(s)
    - Exec time: [0.0] s

  * igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0:
    - Statuses : 1 fail(s) 23 pass(s) 2 skip(s) 3 warn(s)
    - Exec time: [0.0] s

  * igt@i915_pm_rc6_residency@rc6-idle@gt0-vecs0:
    - Statuses : 1 fail(s) 25 pass(s)
    - Exec time: [0.0] s

  * igt@i915_pm_rc6_residency@rc6-idle@gt1-vcs0:
    - Statuses : 2 pass(s)
    - Exec time: [0.0] s

  * igt@i915_pm_rc6_residency@rc6-idle@gt1-vecs0:
    - Statuses : 2 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_10149 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@basic-hwmon:
    - bat-mtlp-8:         NOTRUN -> [SKIP][21] ([i915#9318])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@debugfs_test@basic-hwmon.html

  * igt@gem_lmem_swapping@verify-random:
    - bat-mtlp-8:         NOTRUN -> [SKIP][22] ([i915#4613]) +3 other tests skip
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@gem_lmem_swapping@verify-random.html

  * igt@gem_mmap@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][23] ([i915#4083])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@gem_mmap@basic.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][24] ([i915#4083])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@gem_mmap@basic.html

  * igt@gem_mmap_gtt@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][25] ([i915#4077]) +2 other tests skip
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@gem_mmap_gtt@basic.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][26] ([i915#4077]) +3 other tests skip
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@gem_mmap_gtt@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][27] ([i915#4079]) +1 other test skip
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@gem_render_tiled_blits@basic.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][28] ([i915#4079]) +1 other test skip
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@gem_render_tiled_blits@basic.html

  * igt@i915_pm_rc6_residency@media-rc6-accuracy:
    - fi-cfl-8700k:       NOTRUN -> [SKIP][29] ([fdo#109271]) +1 other test skip
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-cfl-8700k/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - fi-bsw-nick:        NOTRUN -> [SKIP][30] ([fdo#109271]) +1 other test skip
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-bsw-nick/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - fi-cfl-guc:         NOTRUN -> [SKIP][31] ([fdo#109271]) +1 other test skip
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-cfl-guc/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - fi-kbl-x1275:       NOTRUN -> [SKIP][32] ([fdo#109271]) +1 other test skip
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-kbl-x1275/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - fi-cfl-8109u:       NOTRUN -> [SKIP][33] ([fdo#109271]) +1 other test skip
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-cfl-8109u/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - fi-ivb-3770:        NOTRUN -> [SKIP][34] ([fdo#109271]) +1 other test skip
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-ivb-3770/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
    - fi-kbl-guc:         NOTRUN -> [SKIP][35] ([fdo#109271]) +1 other test skip
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-kbl-guc/igt@i915_pm_rc6_residency@media-rc6-accuracy.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - fi-blb-e6850:       NOTRUN -> [SKIP][36] ([fdo#109271]) +3 other tests skip
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-blb-e6850/igt@i915_pm_rc6_residency@rc6-accuracy.html
    - fi-skl-6600u:       NOTRUN -> [SKIP][37] ([fdo#109271]) +1 other test skip
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-skl-6600u/igt@i915_pm_rc6_residency@rc6-accuracy.html
    - fi-apl-guc:         NOTRUN -> [SKIP][38] ([fdo#109271]) +1 other test skip
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-apl-guc/igt@i915_pm_rc6_residency@rc6-accuracy.html
    - fi-pnv-d510:        NOTRUN -> [SKIP][39] ([fdo#109271]) +3 other tests skip
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-pnv-d510/igt@i915_pm_rc6_residency@rc6-accuracy.html
    - fi-glk-j4005:       NOTRUN -> [SKIP][40] ([fdo#109271]) +1 other test skip
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-glk-j4005/igt@i915_pm_rc6_residency@rc6-accuracy.html
    - fi-skl-guc:         NOTRUN -> [SKIP][41] ([fdo#109271]) +1 other test skip
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-skl-guc/igt@i915_pm_rc6_residency@rc6-accuracy.html
    - fi-kbl-7567u:       NOTRUN -> [SKIP][42] ([fdo#109271]) +1 other test skip
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-kbl-7567u/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * {igt@i915_pm_rc6_residency@rc6-idle@gt0-rcs0} (NEW):
    - fi-ilk-650:         NOTRUN -> [SKIP][43] ([fdo#109271]) +4 other tests skip
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-ilk-650/igt@i915_pm_rc6_residency@rc6-idle@gt0-rcs0.html

  * {igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0} (NEW):
    - fi-elk-e7500:       NOTRUN -> [SKIP][44] ([fdo#109271]) +4 other tests skip
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-elk-e7500/igt@i915_pm_rc6_residency@rc6-idle@gt0-vcs0.html

  * igt@i915_pm_rps@basic-api:
    - bat-dg2-9:          NOTRUN -> [SKIP][45] ([i915#6621])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@i915_pm_rps@basic-api.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][46] ([i915#6621])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@i915_pm_rps@basic-api.html

  * igt@i915_suspend@basic-s3-without-i915:
    - bat-mtlp-8:         NOTRUN -> [SKIP][47] ([i915#6645])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][48] ([i915#5190])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
    - fi-hsw-4770:        NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#5190])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][50] ([i915#5190])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][51] ([i915#4215] / [i915#5190])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][52] ([i915#4212]) +8 other tests skip
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
    - bat-dg2-9:          NOTRUN -> [SKIP][53] ([i915#4212]) +6 other tests skip
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html

  * igt@kms_addfb_basic@tile-pitch-mismatch:
    - bat-dg2-9:          NOTRUN -> [SKIP][54] ([i915#4212] / [i915#5608])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][55] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][56] ([i915#4213]) +1 other test skip
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_dsc@dsc-basic:
    - bat-mtlp-8:         NOTRUN -> [SKIP][57] ([i915#3555] / [i915#3840] / [i915#9159])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@kms_dsc@dsc-basic.html

  * igt@kms_flip@basic-flip-vs-modeset@c-dp5:
    - bat-adlp-11:        [PASS][58] -> [DMESG-FAIL][59] ([i915#6868])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/bat-adlp-11/igt@kms_flip@basic-flip-vs-modeset@c-dp5.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-adlp-11/igt@kms_flip@basic-flip-vs-modeset@c-dp5.html

  * igt@kms_flip@basic-flip-vs-modeset@d-dp5:
    - bat-adlp-11:        [PASS][60] -> [FAIL][61] ([i915#6121])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/bat-adlp-11/igt@kms_flip@basic-flip-vs-modeset@d-dp5.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-adlp-11/igt@kms_flip@basic-flip-vs-modeset@d-dp5.html

  * igt@kms_flip@basic-flip-vs-wf_vblank:
    - bat-adlp-11:        NOTRUN -> [SKIP][62] ([i915#3637])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-adlp-11/igt@kms_flip@basic-flip-vs-wf_vblank.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-dg2-9:          NOTRUN -> [SKIP][63] ([fdo#109285])
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][64] ([fdo#109285])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_force_connector_basic@prune-stale-modes:
    - bat-dg2-9:          NOTRUN -> [SKIP][65] ([i915#5274])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][66] ([i915#5274])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@kms_force_connector_basic@prune-stale-modes.html

  * igt@kms_hdmi_inject@inject-audio:
    - fi-kbl-guc:         [PASS][67] -> [FAIL][68] ([IGT#3])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1:
    - fi-hsw-4770:        NOTRUN -> [SKIP][69] ([fdo#109271]) +14 other tests skip
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
    - bat-dg2-11:         NOTRUN -> [SKIP][70] ([i915#1845] / [i915#9197]) +3 other tests skip
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html

  * igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-vga-1:
    - fi-hsw-4770:        NOTRUN -> [DMESG-WARN][71] ([i915#8841]) +6 other tests dmesg-warn
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-hsw-4770/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-vga-1.html

  * igt@kms_psr@sprite_plane_onoff:
    - bat-dg2-9:          NOTRUN -> [SKIP][72] ([i915#1072]) +3 other tests skip
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@kms_psr@sprite_plane_onoff.html
    - fi-hsw-4770:        NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#1072]) +3 other tests skip
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-dg2-9:          NOTRUN -> [SKIP][74] ([i915#3555] / [i915#4098])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][75] ([i915#3555] / [i915#8809])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-flip:
    - bat-dg2-9:          NOTRUN -> [SKIP][76] ([i915#3708])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html

  * igt@prime_vgem@basic-fence-mmap:
    - bat-dg2-9:          NOTRUN -> [SKIP][77] ([i915#3708] / [i915#4077]) +1 other test skip
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html
    - bat-mtlp-8:         NOTRUN -> [SKIP][78] ([i915#3708] / [i915#4077]) +1 other test skip
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@prime_vgem@basic-fence-mmap.html

  * igt@prime_vgem@basic-fence-read:
    - bat-mtlp-8:         NOTRUN -> [SKIP][79] ([i915#3708]) +2 other tests skip
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-write:
    - bat-dg2-9:          NOTRUN -> [SKIP][80] ([i915#3291] / [i915#3708]) +2 other tests skip
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-dg2-9/igt@prime_vgem@basic-write.html

  
#### Possible fixes ####

  * igt@i915_module_load@reload:
    - fi-apl-guc:         [DMESG-WARN][81] ([i915#180] / [i915#1982] / [i915#8585]) -> [PASS][82] +1 other test pass
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/fi-apl-guc/igt@i915_module_load@reload.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-apl-guc/igt@i915_module_load@reload.html

  * igt@i915_pm_rpm@module-reload:
    - fi-apl-guc:         [DMESG-WARN][83] ([i915#180] / [i915#8585]) -> [PASS][84] +3 other tests pass
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/fi-apl-guc/igt@i915_pm_rpm@module-reload.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-apl-guc/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live@reset:
    - fi-apl-guc:         [DMESG-WARN][85] -> [PASS][86] +36 other tests pass
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/fi-apl-guc/igt@i915_selftest@live@reset.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-apl-guc/igt@i915_selftest@live@reset.html

  * igt@i915_suspend@basic-s2idle-without-i915:
    - fi-cfl-8109u:       [ABORT][87] ([i915#8213]) -> [PASS][88]
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html

  * igt@kms_addfb_basic@addfb25-4-tiled:
    - fi-apl-guc:         [DMESG-WARN][89] ([i915#8585]) -> [PASS][90] +40 other tests pass
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/fi-apl-guc/igt@kms_addfb_basic@addfb25-4-tiled.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-apl-guc/igt@kms_addfb_basic@addfb25-4-tiled.html

  * igt@kms_flip@basic-flip-vs-dpms@c-dp1:
    - fi-apl-guc:         [DMESG-WARN][91] ([i915#180] / [i915#8585] / [i915#8703]) -> [PASS][92] +36 other tests pass
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/fi-apl-guc/igt@kms_flip@basic-flip-vs-dpms@c-dp1.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-apl-guc/igt@kms_flip@basic-flip-vs-dpms@c-dp1.html

  * igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1:
    - fi-apl-guc:         [DMESG-WARN][93] ([i915#180] / [i915#1982] / [i915#8585] / [i915#8703]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/fi-apl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/fi-apl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1.html

  * igt@kms_psr@sprite_plane_onoff:
    - bat-jsl-3:          [SKIP][95] -> [PASS][96] +3 other tests pass
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13853/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
  [i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
  [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
  [i915#8585]: https://gitlab.freedesktop.org/drm/intel/issues/8585
  [i915#8703]: https://gitlab.freedesktop.org/drm/intel/issues/8703
  [i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
  [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
  [i915#9159]: https://gitlab.freedesktop.org/drm/intel/issues/9159
  [i915#9197]: https://gitlab.freedesktop.org/drm/intel/issues/9197
  [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7580 -> IGTPW_10149

  CI-20190529: 20190529
  CI_DRM_13853: 26b8362ceb8f25d54c0dc0f7f4806696b87885f5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_10149: 10149
  IGT_7580: 847ee1e7d365e2fb08bf4198d3bf5ee8a852649f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10149/index.html

[-- Attachment #2: Type: text/html, Size: 31201 bytes --]

Re: [igt-dev] [v2 1/5] tests/intel: Add multi-gt support for rc6-idle test

[Riana Tauro]

On 11/9/2023 4:30 PM, Sujaritha Sundaresan wrote:
> Adding multi-gt support for the rc6-idle subtest
> 
> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Looks good to me

Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> ---
>   tests/intel/i915_pm_rc6_residency.c | 18 +++++++++++-------
>   1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
> index b266680ac..57ac5c721 100644
> --- a/tests/intel/i915_pm_rc6_residency.c
> +++ b/tests/intel/i915_pm_rc6_residency.c
> @@ -376,7 +376,7 @@ static void kill_children(int sig)
>   	signal(sig, old);
>   }
>   
> -static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags)
> +static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, unsigned int gt)
>   {
>   	const int64_t duration_ns = SLEEP_DURATION * (int64_t)NSEC_PER_SEC;
>   	const int tolerance = 20; /* Some RC6 is better than none! */
> @@ -397,7 +397,7 @@ static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags)
>   	struct igt_power gpu;
>   	int fd;
>   
> -	fd = open_pmu(i915, I915_PMU_RC6_RESIDENCY);
> +	fd = open_pmu(i915, __I915_PMU_RC6_RESIDENCY(gt));
>   	igt_drop_caches_set(i915, DROP_IDLE);
>   	igt_require(__pmu_wait_for_rc6(fd));
>   	igt_power_open(i915, &gpu, "gpu");
> @@ -558,6 +558,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
>   igt_main
>   {
>   	int i915 = -1;
> +	unsigned int dirfd, gt;
>   	const intel_ctx_t *ctx;
>   
>   	/* Use drm_open_driver to verify device existence */
> @@ -572,11 +573,15 @@ igt_main
>   		igt_require_gem(i915);
>   		gem_quiescent_gpu(i915);
>   
> -		for_each_ctx_engine(i915, ctx, e) {
> -			if (e->instance == 0) {
> -				igt_dynamic_f("%s", e->name)
> -					rc6_idle(i915, ctx->id, e->flags);
> +		i915_for_each_gt(i915, dirfd, gt) {
> +			ctx = intel_ctx_create_for_gt(i915, gt);
> +			for_each_ctx_engine(i915, ctx, e) {
> +				if (e->instance == 0) {
> +					igt_dynamic_f("gt%u-%s", gt, e->name)
> +						rc6_idle(i915, ctx->id, e->flags, gt);
> +				}
>   			}
> +			intel_ctx_destroy(i915, ctx);
>   		}
>   	}
>   
> @@ -626,7 +631,6 @@ igt_main
>   	}
>   
>   	igt_fixture {
> -		intel_ctx_destroy(i915, ctx);
>   		drm_close_driver(i915);
>   	}
>   }

Re: [igt-dev] [v2 1/5] tests/intel: Add multi-gt support for rc6-idle test

[Riana Tauro]

Hi Suja

On 11/9/2023 4:30 PM, Sujaritha Sundaresan wrote:
> Adding multi-gt support for the rc6-idle subtest
> 
> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> ---
>   tests/intel/i915_pm_rc6_residency.c | 18 +++++++++++-------
>   1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
> index b266680ac..57ac5c721 100644
> --- a/tests/intel/i915_pm_rc6_residency.c
> +++ b/tests/intel/i915_pm_rc6_residency.c
> @@ -376,7 +376,7 @@ static void kill_children(int sig)
>   	signal(sig, old);
>   }
>   
> -static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags)
> +static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, unsigned int gt)
>   {
>   	const int64_t duration_ns = SLEEP_DURATION * (int64_t)NSEC_PER_SEC;
>   	const int tolerance = 20; /* Some RC6 is better than none! */
> @@ -397,7 +397,7 @@ static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags)
>   	struct igt_power gpu;
>   	int fd;
>   
> -	fd = open_pmu(i915, I915_PMU_RC6_RESIDENCY);
> +	fd = open_pmu(i915, __I915_PMU_RC6_RESIDENCY(gt));
>   	igt_drop_caches_set(i915, DROP_IDLE);
>   	igt_require(__pmu_wait_for_rc6(fd));
>   	igt_power_open(i915, &gpu, "gpu");
> @@ -558,6 +558,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
>   igt_main
>   {
>   	int i915 = -1;
> +	unsigned int dirfd, gt;
>   	const intel_ctx_t *ctx;
>   
There is
ctx = intel_ctx_create_all_physical(i915);
in fixture. Please remove that as it is duplicate

Thanks
Riana
>   	/* Use drm_open_driver to verify device existence */
> @@ -572,11 +573,15 @@ igt_main
>   		igt_require_gem(i915);
>   		gem_quiescent_gpu(i915);
>   
> -		for_each_ctx_engine(i915, ctx, e) {
> -			if (e->instance == 0) {
> -				igt_dynamic_f("%s", e->name)
> -					rc6_idle(i915, ctx->id, e->flags);
> +		i915_for_each_gt(i915, dirfd, gt) {
> +			ctx = intel_ctx_create_for_gt(i915, gt);
> +			for_each_ctx_engine(i915, ctx, e) {
> +				if (e->instance == 0) {
> +					igt_dynamic_f("gt%u-%s", gt, e->name)
> +						rc6_idle(i915, ctx->id, e->flags, gt);
> +				}
>   			}
> +			intel_ctx_destroy(i915, ctx);
>   		}
>   	}
>   
> @@ -626,7 +631,6 @@ igt_main
>   	}
>   
>   	igt_fixture {
> -		intel_ctx_destroy(i915, ctx);
>   		drm_close_driver(i915);
>   	}
>   }

Re: [igt-dev] [v2 2/5] tests/intel: Add multi-gt support for rc6-fence test

[Riana Tauro]

On 11/9/2023 4:30 PM, Sujaritha Sundaresan wrote:
> Add multi-gt support for the rc6-fence subtest.
> 
> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
LGTM.

Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> ---
>   tests/intel/i915_pm_rc6_residency.c | 13 +++++++++----
>   1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
> index 57ac5c721..5dc785792 100644
> --- a/tests/intel/i915_pm_rc6_residency.c
> +++ b/tests/intel/i915_pm_rc6_residency.c
> @@ -471,12 +471,13 @@ static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, unsigned int gt)
>   	}
>   }
>   
> -static void rc6_fence(int i915, const intel_ctx_t *ctx)
> +static void rc6_fence(int i915, unsigned int gt)
>   {
>   	const int64_t duration_ns = SLEEP_DURATION * (int64_t)NSEC_PER_SEC;
>   	const int tolerance = 20; /* Some RC6 is better than none! */
>   	const unsigned int gen = intel_gen(intel_get_drm_devid(i915));
>   	const struct intel_execution_engine2 *e;
> +	const intel_ctx_t *ctx;
>   	struct power_sample sample[2];
>   	unsigned long slept;
>   	uint64_t rc6, ts[2], ahnd;
> @@ -485,7 +486,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
>   
>   	igt_require_sw_sync();
>   
> -	fd = open_pmu(i915, I915_PMU_RC6_RESIDENCY);
> +	fd = open_pmu(i915, __I915_PMU_RC6_RESIDENCY(gt));
>   	igt_drop_caches_set(i915, DROP_IDLE);
>   	igt_require(__pmu_wait_for_rc6(fd));
>   	igt_power_open(i915, &gpu, "gpu");
> @@ -509,6 +510,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
>   	assert_within_epsilon(rc6, ts[1] - ts[0], 5);
>   
>   	/* Submit but delay execution, we should be idle and conserving power */
> +	ctx = intel_ctx_create_for_gt(i915, gt);
>   	ahnd = get_reloc_ahnd(i915, ctx->id);
>   	for_each_ctx_engine(i915, ctx, e) {
>   		igt_spin_t *spin;
> @@ -550,6 +552,7 @@ static void rc6_fence(int i915, const intel_ctx_t *ctx)
>   		gem_quiescent_gpu(i915);
>   	}
>   	put_ahnd(ahnd);
> +	intel_ctx_destroy(i915, ctx);
>   
>   	igt_power_close(&gpu);
>   	close(fd);
> @@ -585,11 +588,13 @@ igt_main
>   		}
>   	}
>   
> -	igt_subtest("rc6-fence") {
> +	igt_subtest_with_dynamic("rc6-fence") {
>   		igt_require_gem(i915);
>   		gem_quiescent_gpu(i915);
>   
> -		rc6_fence(i915, ctx);
> +		i915_for_each_gt(i915, dirfd, gt)
> +			igt_dynamic_f("gt%u", gt)
> +				rc6_fence(i915, gt);
>   	}
>   
>   	igt_subtest_group {

Re: [igt-dev] [v2 4/5] tests/intel: Print drpc info for rc6_residency test

[Riana Tauro]

Hi Suja

On 11/9/2023 4:30 PM, Sujaritha Sundaresan wrote:
> Add drpc debug info for the rc6_residency test.
Add more details on why drpc debug is needed in commit message.

Also add version history to the patch
> 
> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> ---
>   tests/intel/i915_pm_rc6_residency.c | 51 ++++++++++++++++++++++-------
>   1 file changed, 40 insertions(+), 11 deletions(-)
> 
> diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
> index 6e491f270..0288158fd 100644
> --- a/tests/intel/i915_pm_rc6_residency.c
> +++ b/tests/intel/i915_pm_rc6_residency.c
> @@ -36,6 +36,7 @@
>   #include "i915/gem.h"
>   #include "i915/gem_create.h"
>   #include "igt.h"
> +#include "igt_debugfs.h"
>   #include "igt_perf.h"
>   #include "igt_power.h"
>   #include "igt_sysfs.h"
> @@ -230,14 +231,27 @@ static uint64_t pmu_read_single(int fd)
>   	return __pmu_read_single(fd, NULL);
>   }
>   
> -#define __assert_within_epsilon(x, ref, tol_up, tol_down) \
> -	igt_assert_f((x) <= (ref) * (1.0 + (tol_up)/100.) && \
> -		     (x) >= (ref) * (1.0 - (tol_down)/100.), \
> -		     "'%s' != '%s' (%.3g not within +%d%%/-%d%% tolerance of %.3g)\n",\
> -		     #x, #ref, (double)(x), (tol_up), (tol_down), (double)(ref))
> +#define __assert_within_epsilon(x, ref, tol_up, tol_down, debug_data) \
> +	igt_assert_f((double)(x) <= (1.0 + (tol_up)) * (double)(ref) && \
> +		     (double)(x) >= (1.0 - (tol_down)) * (double)(ref), \
> +		     "'%s' != '%s' (%f not within +%.1f%%/-%.1f%% tolerance of %f)\n %s\n",\
> +		     #x, #ref, (double)(x), \
> +		     (tol_up) * 100.0, (tol_down) * 100.0, \
> +		     (double)(ref), debug_data)
>   
> -#define assert_within_epsilon(x, ref, tolerance) \
> -	__assert_within_epsilon(x, ref, tolerance, tolerance)
> +#define assert_within_epsilon(x, ref, tolerance, debug_data) \
> +	__assert_within_epsilon(x, ref, tolerance, tolerance, debug_data)
> +
> +char *drpc;
Move this to the top of the file

Thanks
Riana
> +
> +static char *get_drpc(int i915, int gt_id)
> +{
> +	int gt_dir;
> +
> +	gt_dir = igt_debugfs_gt_dir(i915, gt_id);
> +	igt_assert(gt_dir != -1);
> +	return igt_sysfs_get(gt_dir, "drpc");
> +}
>   
>   static bool __pmu_wait_for_rc6(int fd)
>   {
> @@ -414,7 +428,9 @@ static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, unsigned int gt)
>   			"Total energy used while idle: %.1fmJ (%.1fmW)\n",
>   			idle, (idle * 1e9) / slept);
>   	}
> -	assert_within_epsilon(rc6, ts[1] - ts[0], 5);
> +	drpc = get_drpc(i915, gt);
> +
> +	assert_within_epsilon(rc6, ts[1] - ts[0], 5, drpc);
>   
>   	done = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
>   
> @@ -450,7 +466,12 @@ static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, unsigned int gt)
>   		igt_assert(cycles >= SLEEP_DURATION);
>   
>   		/* While very nearly idle, expect full RC6 */
> -		assert_within_epsilon(rc6, ts[1] - ts[0], tolerance);
> +		drpc = get_drpc(i915, gt);
> +
> +		assert_within_epsilon(rc6, ts[1] - ts[0], tolerance, drpc);
> +
> +		free(drpc);
> +		drpc = NULL;
>   	}
>   
>   	munmap(done, 4096);
> @@ -503,7 +524,9 @@ static void rc6_fence(int i915, unsigned int gt)
>   			"Total energy used while idle: %.1fmJ (%.1fmW)\n",
>   			idle, (idle * 1e9) / slept);
>   	}
> -	assert_within_epsilon(rc6, ts[1] - ts[0], 5);
> +	drpc = get_drpc(i915, gt);
> +
> +	assert_within_epsilon(rc6, ts[1] - ts[0], 5, drpc);
>   
>   	/* Submit but delay execution, we should be idle and conserving power */
>   	ctx = intel_ctx_create_for_gt(i915, gt);
> @@ -544,8 +567,13 @@ static void rc6_fence(int i915, unsigned int gt)
>   
>   		close(timeline);
>   
> -		assert_within_epsilon(rc6, ts[1] - ts[0], tolerance);
> +		drpc = get_drpc(i915, gt);
> +
> +		assert_within_epsilon(rc6, ts[1] - ts[0], tolerance, drpc);
>   		gem_quiescent_gpu(i915);
> +
> +		free(drpc);
> +		drpc = NULL;
>   	}
>   	put_ahnd(ahnd);
>   	intel_ctx_destroy(i915, ctx);
> @@ -634,6 +662,7 @@ igt_main
>   	}
>   
>   	igt_fixture {
> +		free(drpc);
>   		drm_close_driver(i915);
>   	}
>   }

Re: [igt-dev] [v2 4/5] tests/intel: Print drpc info for rc6_residency test

[Sundaresan, Sujaritha]

On 11/10/2023 7:31 PM, Riana Tauro wrote:
> Hi Suja
>
> On 11/9/2023 4:30 PM, Sujaritha Sundaresan wrote:
>> Add drpc debug info for the rc6_residency test.
> Add more details on why drpc debug is needed in commit message.
>
> Also add version history to the patch
Sure will do
>>
>> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
>> ---
>>   tests/intel/i915_pm_rc6_residency.c | 51 ++++++++++++++++++++++-------
>>   1 file changed, 40 insertions(+), 11 deletions(-)
>>
>> diff --git a/tests/intel/i915_pm_rc6_residency.c 
>> b/tests/intel/i915_pm_rc6_residency.c
>> index 6e491f270..0288158fd 100644
>> --- a/tests/intel/i915_pm_rc6_residency.c
>> +++ b/tests/intel/i915_pm_rc6_residency.c
>> @@ -36,6 +36,7 @@
>>   #include "i915/gem.h"
>>   #include "i915/gem_create.h"
>>   #include "igt.h"
>> +#include "igt_debugfs.h"
>>   #include "igt_perf.h"
>>   #include "igt_power.h"
>>   #include "igt_sysfs.h"
>> @@ -230,14 +231,27 @@ static uint64_t pmu_read_single(int fd)
>>       return __pmu_read_single(fd, NULL);
>>   }
>>   -#define __assert_within_epsilon(x, ref, tol_up, tol_down) \
>> -    igt_assert_f((x) <= (ref) * (1.0 + (tol_up)/100.) && \
>> -             (x) >= (ref) * (1.0 - (tol_down)/100.), \
>> -             "'%s' != '%s' (%.3g not within +%d%%/-%d%% tolerance of 
>> %.3g)\n",\
>> -             #x, #ref, (double)(x), (tol_up), (tol_down), 
>> (double)(ref))
>> +#define __assert_within_epsilon(x, ref, tol_up, tol_down, debug_data) \
>> +    igt_assert_f((double)(x) <= (1.0 + (tol_up)) * (double)(ref) && \
>> +             (double)(x) >= (1.0 - (tol_down)) * (double)(ref), \
>> +             "'%s' != '%s' (%f not within +%.1f%%/-%.1f%% tolerance 
>> of %f)\n %s\n",\
>> +             #x, #ref, (double)(x), \
>> +             (tol_up) * 100.0, (tol_down) * 100.0, \
>> +             (double)(ref), debug_data)
>>   -#define assert_within_epsilon(x, ref, tolerance) \
>> -    __assert_within_epsilon(x, ref, tolerance, tolerance)
>> +#define assert_within_epsilon(x, ref, tolerance, debug_data) \
>> +    __assert_within_epsilon(x, ref, tolerance, tolerance, debug_data)
>> +
>> +char *drpc;
> Move this to the top of the file
>
> Thanks
> Riana

Just the definition ? I'm assuming the asserts can stay as is ?

Thanks

Suja

>> +
>> +static char *get_drpc(int i915, int gt_id)
>> +{
>> +    int gt_dir;
>> +
>> +    gt_dir = igt_debugfs_gt_dir(i915, gt_id);
>> +    igt_assert(gt_dir != -1);
>> +    return igt_sysfs_get(gt_dir, "drpc");
>> +}
>>     static bool __pmu_wait_for_rc6(int fd)
>>   {
>> @@ -414,7 +428,9 @@ static void rc6_idle(int i915, uint32_t ctx_id, 
>> uint64_t flags, unsigned int gt)
>>               "Total energy used while idle: %.1fmJ (%.1fmW)\n",
>>               idle, (idle * 1e9) / slept);
>>       }
>> -    assert_within_epsilon(rc6, ts[1] - ts[0], 5);
>> +    drpc = get_drpc(i915, gt);
>> +
>> +    assert_within_epsilon(rc6, ts[1] - ts[0], 5, drpc);
>>         done = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
>>   @@ -450,7 +466,12 @@ static void rc6_idle(int i915, uint32_t 
>> ctx_id, uint64_t flags, unsigned int gt)
>>           igt_assert(cycles >= SLEEP_DURATION);
>>             /* While very nearly idle, expect full RC6 */
>> -        assert_within_epsilon(rc6, ts[1] - ts[0], tolerance);
>> +        drpc = get_drpc(i915, gt);
>> +
>> +        assert_within_epsilon(rc6, ts[1] - ts[0], tolerance, drpc);
>> +
>> +        free(drpc);
>> +        drpc = NULL;
>>       }
>>         munmap(done, 4096);
>> @@ -503,7 +524,9 @@ static void rc6_fence(int i915, unsigned int gt)
>>               "Total energy used while idle: %.1fmJ (%.1fmW)\n",
>>               idle, (idle * 1e9) / slept);
>>       }
>> -    assert_within_epsilon(rc6, ts[1] - ts[0], 5);
>> +    drpc = get_drpc(i915, gt);
>> +
>> +    assert_within_epsilon(rc6, ts[1] - ts[0], 5, drpc);
>>         /* Submit but delay execution, we should be idle and 
>> conserving power */
>>       ctx = intel_ctx_create_for_gt(i915, gt);
>> @@ -544,8 +567,13 @@ static void rc6_fence(int i915, unsigned int gt)
>>             close(timeline);
>>   -        assert_within_epsilon(rc6, ts[1] - ts[0], tolerance);
>> +        drpc = get_drpc(i915, gt);
>> +
>> +        assert_within_epsilon(rc6, ts[1] - ts[0], tolerance, drpc);
>>           gem_quiescent_gpu(i915);
>> +
>> +        free(drpc);
>> +        drpc = NULL;
>>       }
>>       put_ahnd(ahnd);
>>       intel_ctx_destroy(i915, ctx);
>> @@ -634,6 +662,7 @@ igt_main
>>       }
>>         igt_fixture {
>> +        free(drpc);
>>           drm_close_driver(i915);
>>       }
>>   }

Re: [igt-dev] [v2 1/5] tests/intel: Add multi-gt support for rc6-idle test

[Sundaresan, Sujaritha]

On 11/10/2023 7:20 PM, Riana Tauro wrote:
> Hi Suja
>
> On 11/9/2023 4:30 PM, Sujaritha Sundaresan wrote:
>> Adding multi-gt support for the rc6-idle subtest
>>
>> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
>> ---
>>   tests/intel/i915_pm_rc6_residency.c | 18 +++++++++++-------
>>   1 file changed, 11 insertions(+), 7 deletions(-)
>>
>> diff --git a/tests/intel/i915_pm_rc6_residency.c 
>> b/tests/intel/i915_pm_rc6_residency.c
>> index b266680ac..57ac5c721 100644
>> --- a/tests/intel/i915_pm_rc6_residency.c
>> +++ b/tests/intel/i915_pm_rc6_residency.c
>> @@ -376,7 +376,7 @@ static void kill_children(int sig)
>>       signal(sig, old);
>>   }
>>   -static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags)
>> +static void rc6_idle(int i915, uint32_t ctx_id, uint64_t flags, 
>> unsigned int gt)
>>   {
>>       const int64_t duration_ns = SLEEP_DURATION * 
>> (int64_t)NSEC_PER_SEC;
>>       const int tolerance = 20; /* Some RC6 is better than none! */
>> @@ -397,7 +397,7 @@ static void rc6_idle(int i915, uint32_t ctx_id, 
>> uint64_t flags)
>>       struct igt_power gpu;
>>       int fd;
>>   -    fd = open_pmu(i915, I915_PMU_RC6_RESIDENCY);
>> +    fd = open_pmu(i915, __I915_PMU_RC6_RESIDENCY(gt));
>>       igt_drop_caches_set(i915, DROP_IDLE);
>>       igt_require(__pmu_wait_for_rc6(fd));
>>       igt_power_open(i915, &gpu, "gpu");
>> @@ -558,6 +558,7 @@ static void rc6_fence(int i915, const intel_ctx_t 
>> *ctx)
>>   igt_main
>>   {
>>       int i915 = -1;
>> +    unsigned int dirfd, gt;
>>       const intel_ctx_t *ctx;
> There is
> ctx = intel_ctx_create_all_physical(i915);
> in fixture. Please remove that as it is duplicate
>
> Thanks
> Riana

Fixed.

Thanks

Suja

>>       /* Use drm_open_driver to verify device existence */
>> @@ -572,11 +573,15 @@ igt_main
>>           igt_require_gem(i915);
>>           gem_quiescent_gpu(i915);
>>   -        for_each_ctx_engine(i915, ctx, e) {
>> -            if (e->instance == 0) {
>> -                igt_dynamic_f("%s", e->name)
>> -                    rc6_idle(i915, ctx->id, e->flags);
>> +        i915_for_each_gt(i915, dirfd, gt) {
>> +            ctx = intel_ctx_create_for_gt(i915, gt);
>> +            for_each_ctx_engine(i915, ctx, e) {
>> +                if (e->instance == 0) {
>> +                    igt_dynamic_f("gt%u-%s", gt, e->name)
>> +                        rc6_idle(i915, ctx->id, e->flags, gt);
>> +                }
>>               }
>> +            intel_ctx_destroy(i915, ctx);
>>           }
>>       }
>>   @@ -626,7 +631,6 @@ igt_main
>>       }
>>         igt_fixture {
>> -        intel_ctx_destroy(i915, ctx);
>>           drm_close_driver(i915);
>>       }
>>   }

Re: [igt-dev] [v2 4/5] tests/intel: Print drpc info for rc6_residency test

[Riana Tauro]

On 11/13/2023 9:11 AM, Sundaresan, Sujaritha wrote:
> 
> On 11/10/2023 7:31 PM, Riana Tauro wrote:
>> Hi Suja
>>
>> On 11/9/2023 4:30 PM, Sujaritha Sundaresan wrote:
>>> Add drpc debug info for the rc6_residency test.
>> Add more details on why drpc debug is needed in commit message.
>>
>> Also add version history to the patch
> Sure will do
>>>
>>> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
>>> ---
>>>   tests/intel/i915_pm_rc6_residency.c | 51 ++++++++++++++++++++++-------
>>>   1 file changed, 40 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/tests/intel/i915_pm_rc6_residency.c 
>>> b/tests/intel/i915_pm_rc6_residency.c
>>> index 6e491f270..0288158fd 100644
>>> --- a/tests/intel/i915_pm_rc6_residency.c
>>> +++ b/tests/intel/i915_pm_rc6_residency.c
>>> @@ -36,6 +36,7 @@
>>>   #include "i915/gem.h"
>>>   #include "i915/gem_create.h"
>>>   #include "igt.h"
>>> +#include "igt_debugfs.h"
>>>   #include "igt_perf.h"
>>>   #include "igt_power.h"
>>>   #include "igt_sysfs.h"
>>> @@ -230,14 +231,27 @@ static uint64_t pmu_read_single(int fd)
>>>       return __pmu_read_single(fd, NULL);
>>>   }
>>>   -#define __assert_within_epsilon(x, ref, tol_up, tol_down) \
>>> -    igt_assert_f((x) <= (ref) * (1.0 + (tol_up)/100.) && \
>>> -             (x) >= (ref) * (1.0 - (tol_down)/100.), \
>>> -             "'%s' != '%s' (%.3g not within +%d%%/-%d%% tolerance of 
>>> %.3g)\n",\
>>> -             #x, #ref, (double)(x), (tol_up), (tol_down), 
>>> (double)(ref))
>>> +#define __assert_within_epsilon(x, ref, tol_up, tol_down, debug_data) \
>>> +    igt_assert_f((double)(x) <= (1.0 + (tol_up)) * (double)(ref) && \
>>> +             (double)(x) >= (1.0 - (tol_down)) * (double)(ref), \
>>> +             "'%s' != '%s' (%f not within +%.1f%%/-%.1f%% tolerance 
>>> of %f)\n %s\n",\
>>> +             #x, #ref, (double)(x), \
>>> +             (tol_up) * 100.0, (tol_down) * 100.0, \
>>> +             (double)(ref), debug_data)
>>>   -#define assert_within_epsilon(x, ref, tolerance) \
>>> -    __assert_within_epsilon(x, ref, tolerance, tolerance)
>>> +#define assert_within_epsilon(x, ref, tolerance, debug_data) \
>>> +    __assert_within_epsilon(x, ref, tolerance, tolerance, debug_data)
>>> +
>>> +char *drpc;
>> Move this to the top of the file
>>
>> Thanks
>> Riana
> 
> Just the definition ? I'm assuming the asserts can stay as is ?

Yes just the definition
> 
> Thanks
> 
> Suja
> 
>>> +
>>> +static char *get_drpc(int i915, int gt_id)
>>> +{
>>> +    int gt_dir;
>>> +
>>> +    gt_dir = igt_debugfs_gt_dir(i915, gt_id);
>>> +    igt_assert(gt_dir != -1);
>>> +    return igt_sysfs_get(gt_dir, "drpc");
>>> +}
>>>     static bool __pmu_wait_for_rc6(int fd)
>>>   {
>>> @@ -414,7 +428,9 @@ static void rc6_idle(int i915, uint32_t ctx_id, 
>>> uint64_t flags, unsigned int gt)
>>>               "Total energy used while idle: %.1fmJ (%.1fmW)\n",
>>>               idle, (idle * 1e9) / slept);
>>>       }
>>> -    assert_within_epsilon(rc6, ts[1] - ts[0], 5);
>>> +    drpc = get_drpc(i915, gt);
>>> +
>>> +    assert_within_epsilon(rc6, ts[1] - ts[0], 5, drpc);
>>>         done = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
>>>   @@ -450,7 +466,12 @@ static void rc6_idle(int i915, uint32_t 
>>> ctx_id, uint64_t flags, unsigned int gt)
>>>           igt_assert(cycles >= SLEEP_DURATION);
>>>             /* While very nearly idle, expect full RC6 */
>>> -        assert_within_epsilon(rc6, ts[1] - ts[0], tolerance);
>>> +        drpc = get_drpc(i915, gt);
>>> +
>>> +        assert_within_epsilon(rc6, ts[1] - ts[0], tolerance, drpc);
>>> +
>>> +        free(drpc);
>>> +        drpc = NULL;
>>>       }
>>>         munmap(done, 4096);
>>> @@ -503,7 +524,9 @@ static void rc6_fence(int i915, unsigned int gt)
>>>               "Total energy used while idle: %.1fmJ (%.1fmW)\n",
>>>               idle, (idle * 1e9) / slept);
>>>       }
>>> -    assert_within_epsilon(rc6, ts[1] - ts[0], 5);
>>> +    drpc = get_drpc(i915, gt);
>>> +
>>> +    assert_within_epsilon(rc6, ts[1] - ts[0], 5, drpc);
>>>         /* Submit but delay execution, we should be idle and 
>>> conserving power */
>>>       ctx = intel_ctx_create_for_gt(i915, gt);
>>> @@ -544,8 +567,13 @@ static void rc6_fence(int i915, unsigned int gt)
>>>             close(timeline);
>>>   -        assert_within_epsilon(rc6, ts[1] - ts[0], tolerance);
>>> +        drpc = get_drpc(i915, gt);
>>> +
>>> +        assert_within_epsilon(rc6, ts[1] - ts[0], tolerance, drpc);
>>>           gem_quiescent_gpu(i915);
>>> +
>>> +        free(drpc);
>>> +        drpc = NULL;
>>>       }
>>>       put_ahnd(ahnd);
>>>       intel_ctx_destroy(i915, ctx);
>>> @@ -634,6 +662,7 @@ igt_main
>>>       }
>>>         igt_fixture {
>>> +        free(drpc);
>>>           drm_close_driver(i915);
>>>       }
>>>   }