Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/intel/intel_sysfs_debugfs: Remove xe-gt
@ 2025-04-10  9:03 Peter Senna Tschudin
  2025-04-10  9:30 ` Bernatowicz, Marcin
                   ` (11 more replies)
  0 siblings, 12 replies; 18+ messages in thread
From: Peter Senna Tschudin @ 2025-04-10  9:03 UTC (permalink / raw)
  To: igt-dev
  Cc: Peter Senna Tschudin, marcin.bernatowicz, matthew.brost,
	pravalika.gurram, kamil.konieczny

The intel_sysfs_debugfs test now includes functionality to read all Xe
debugfs files, making the older xe-gt test redundant. Additionally,
xe-gt causes issues when testing Virtual Functions (VFs) in SR-IOV
setups, as some of the debugfs files it expects are not present for VFs.

Rather than extending the overlapping and problematic xe-gt, this commit
removes it entirely.

Cc: marcin.bernatowicz@intel.com
Cc: matthew.brost@intel.com
Cc: pravalika.gurram@intel.com
Cc: kamil.konieczny@linux.intel.com
Signed-off-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
---
 tests/intel/intel_sysfs_debugfs.c | 66 -------------------------------
 1 file changed, 66 deletions(-)

diff --git a/tests/intel/intel_sysfs_debugfs.c b/tests/intel/intel_sysfs_debugfs.c
index 6beb94109..431934aee 100644
--- a/tests/intel/intel_sysfs_debugfs.c
+++ b/tests/intel/intel_sysfs_debugfs.c
@@ -322,63 +322,6 @@ xe_test_base(int fd, struct drm_xe_query_config *config)
 	xe_validate_entries(fd, "", expected_files, ARRAY_SIZE(expected_files));
 }
 
-/**
- * SUBTEST: xe-gt
- * Description: Check all gt debugfs devnodes
- * TODO: add support for ``force_reset`` entries
- */
-static void
-xe_test_gt(int fd, int gt_id)
-{
-	char name[256];
-	static const char * const expected_files[] = {
-		"uc",
-		"steering",
-		"topology",
-		"sa_info",
-		"hw_engines",
-		"pat",
-		"mocs",
-//		"force_reset"
-		"ggtt",
-		"register-save-restore",
-		"workarounds",
-		"default_lrc_rcs",
-		"default_lrc_ccs",
-		"default_lrc_bcs",
-		"default_lrc_vcs",
-		"default_lrc_vecs",
-		"hwconfig"
-
-	};
-	static const char * const expected_files_uc[] = {
-		"huc_info",
-		"guc_log",
-		"guc_info",
-//		"guc_ct_selftest"
-	};
-
-	for (int i = 0; i < ARRAY_SIZE(expected_files); i++) {
-		sprintf(name, "gt%d/%s", gt_id, expected_files[i]);
-		igt_assert(igt_debugfs_exists(fd, name, O_RDONLY));
-		if (igt_debugfs_is_dir(fd, expected_files[i], gt_id))
-			continue;
-		igt_debugfs_dump(fd, name);
-	}
-
-	for (int i = 0; i < ARRAY_SIZE(expected_files_uc); i++) {
-		sprintf(name, "gt%d/uc/%s", gt_id, expected_files_uc[i]);
-		igt_assert(igt_debugfs_exists(fd, name, O_RDONLY));
-		igt_debugfs_dump(fd, name);
-	}
-
-	sprintf(name, "/gt%d", gt_id);
-	xe_validate_entries(fd, name, expected_files, ARRAY_SIZE(expected_files));
-
-	sprintf(name, "/gt%d/uc", gt_id);
-	xe_validate_entries(fd, name, expected_files_uc, ARRAY_SIZE(expected_files_uc));
-}
-
 /**
  * SUBTEST: xe-forcewake
  * Description: Check forcewake debugfs devnode
@@ -475,15 +418,6 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 			xe_test_base(fd, xe_config(fd));
 		}
 
-		igt_describe("Check all gt debugfs devnodes");
-		igt_subtest("xe-gt") {
-			xe_for_each_gt(fd, gt) {
-				snprintf(devnode, sizeof(devnode), "gt%d", gt);
-				igt_require(igt_debugfs_exists(fd, devnode, O_RDONLY));
-				xe_test_gt(fd, gt);
-			}
-		}
-
 		igt_describe("Check forcewake debugfs devnode");
 		igt_subtest("xe-forcewake") {
 			xe_test_forcewake(fd);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2025-04-16  4:55 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-10  9:03 [PATCH i-g-t] tests/intel/intel_sysfs_debugfs: Remove xe-gt Peter Senna Tschudin
2025-04-10  9:30 ` Bernatowicz, Marcin
2025-04-10 10:22 ` ✓ i915.CI.BAT: success for " Patchwork
2025-04-10 10:40 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-10 17:09 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-10 17:22   ` Peter Senna Tschudin
2025-04-11  5:43     ` Ravali, JupallyX
2025-04-10 18:11 ` [PATCH i-g-t] " Kamil Konieczny
2025-04-11  7:35   ` Peter Senna Tschudin
2025-04-11  8:01   ` Bernatowicz, Marcin
2025-04-15  9:04     ` Kamil Konieczny
2025-04-11  5:09 ` ✓ i915.CI.Full: success for " Patchwork
2025-04-15  9:25 ` [PATCH i-g-t] " Kamil Konieczny
2025-04-15 10:05 ` Peter Senna Tschudin
2025-04-15 20:52 ` ✓ i915.CI.BAT: success for tests/intel/intel_sysfs_debugfs: Remove xe-gt (rev2) Patchwork
2025-04-15 21:22 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-16  3:41 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-16  4:55 ` ✗ Xe.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox