Re: [PATCH i-g-t 2/3] lib/igt_psr: add support for PR selective update

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Mon, 2024-02-19 at 22:03 +0530, Kunal Joshi wrote:
> adapt to kmd changes to support PR selective update
> https://patchwork.freedesktop.org/patch/575163/?series=128193&rev=3
> 
> v2: "PSR2 selective fetch: enable" valid for both cases (Jouni)
> v3: use check_psr2_support (Jouni)
> v4: split patches (Jouni)
> v5: drop changes on psr2_sel_fetch_to_psr1 and *_restore (Jouni)
> 
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Cc: Animesh Manna <animesh.manna@intel.com>
> Cc: Arun R Murthy <arun.r.murthy@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  lib/igt_psr.c | 20 ++++++++++++++------
>  lib/igt_psr.h |  2 +-
>  2 files changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index cad8cce05..6008b73a6 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -41,7 +41,7 @@ bool psr_disabled_check(int debugfs_fd)
>         return strstr(buf, "PSR mode: disabled\n");
>  }
>  
> -bool psr2_selective_fetch_check(int debugfs_fd, igt_output_t
> *output)
> +bool selective_fetch_check(int debugfs_fd, igt_output_t *output)
>  {
>         char buf[PSR_STATUS_MAX_LEN];
>         char debugfs_file[128] = {0};
> @@ -248,7 +248,9 @@ bool psr_sink_support(int device, int debugfs_fd,
> enum psr_mode mode, igt_output
>                        (strstr(line, "PSR = yes") &&
>                        (strstr(line, "[0x03]") || strstr(line,
> "[0x04]")));
>         case PR_MODE:
> -               return strstr(line, "Panel Replay = yes");
> +               return strstr(line, "Panel Replay = yes, Panel Replay
> Selective Update = no");
> +       case PR_MODE_SEL_FETCH:
> +               return strstr(line, "Panel Replay = yes, Panel Replay
> Selective Update = yes");
>         default:
>                 igt_assert_f(false, "Invalid psr mode\n");
>                 return false;
> @@ -317,7 +319,7 @@ bool i915_psr2_selective_fetch_check(int drm_fd,
> igt_output_t *output)
>                 return false;
>  
>         debugfs_fd = igt_debugfs_dir(drm_fd);
> -       ret = psr2_selective_fetch_check(debugfs_fd, output);
> +       ret = selective_fetch_check(debugfs_fd, output);
>         close(debugfs_fd);
>  
>         return ret;
> @@ -343,7 +345,11 @@ bool i915_psr2_sel_fetch_to_psr1(int drm_fd,
> igt_output_t *output)
>                 return ret;
>  
>         debugfs_fd = igt_debugfs_dir(drm_fd);
> -       if (psr2_selective_fetch_check(debugfs_fd, output)) {
> +       if (selective_fetch_check(debugfs_fd, output)) {
> +               /*
> +                * With below we switch to PSR1 incase of PSR and
> +                * Panel Replay Full Frame update in case of Panel
> Replay.
> +                */
>                 psr_set(drm_fd, debugfs_fd, PSR_MODE_1, output);
>                 ret = true;
>         }
> @@ -389,11 +395,13 @@ enum psr_mode psr_get_mode(int debugfs_fd,
> igt_output_t *output)
>  
>         if (strstr(buf, "Panel Replay Enabled"))
>                 return PR_MODE;
> +       else if (strstr(buf, "Panel Replay Selective Update
> Enabled"))
> +               return PR_MODE_SEL_FETCH;
>         else if (strstr(buf, "PSR2 selective fetch: enabled"))
>                 return PSR_MODE_2_SEL_FETCH;
> -       else if (strstr(buf, "PSR2 enabled"))
> +       else if (strstr(buf, "PSR2"))
>                 return PSR_MODE_2;
> -       else if (strstr(buf, "PSR1 enabled"))
> +       else if (strstr(buf, "PSR1"))
>                 return PSR_MODE_1;
>  
>         return PSR_DISABLED;
> diff --git a/lib/igt_psr.h b/lib/igt_psr.h
> index 372bef2b2..e8595fd8c 100644
> --- a/lib/igt_psr.h
> +++ b/lib/igt_psr.h
> @@ -46,7 +46,7 @@ enum fbc_mode {
>  };
>  
>  bool psr_disabled_check(int debugfs_fd);
> -bool psr2_selective_fetch_check(int debugfs_fd, igt_output_t
> *output);
> +bool selective_fetch_check(int debugfs_fd, igt_output_t *output);
>  bool psr_wait_entry(int debugfs_fd, enum psr_mode mode, igt_output_t
> *output);
>  bool psr_wait_update(int debugfs_fd, enum psr_mode mode,
> igt_output_t *output);
>  bool psr_long_wait_update(int debugfs_fd, enum psr_mode mode,
> igt_output_t *output);