public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH 1/2][V4] tests/kms_universal_plane: Enable gen9_test_pipe for all devices
@ 2022-09-03 17:48 Alex Hung
  2022-09-03 17:48 ` [igt-dev] [PATCH 2/2][V4] tests/kms_universal_plane: Skip offscreen test for universal API Alex Hung
                   ` (8 more replies)
  0 siblings, 9 replies; 12+ messages in thread
From: Alex Hung @ 2022-09-03 17:48 UTC (permalink / raw)
  To: igt-dev; +Cc: markyacoub

This subtest runs on non-i915 devices, and let's make it generic by
removing igt_require_intel and renaming it.

Signed-off-by: Alex Hung <alex.hung@amd.com>
Reviewed-by: Mark Yacoub <markyacoub@chromium.org>
---
 tests/kms_universal_plane.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
index 3cb6d704..9eab1a57 100644
--- a/tests/kms_universal_plane.c
+++ b/tests/kms_universal_plane.c
@@ -699,15 +699,14 @@ gen9_test_fini(gen9_test_t *test, igt_output_t *output)
  * windowing)
  */
 static void
-gen9_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
+pageflip_win_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
 {
 	gen9_test_t test = { .data = data };
 	igt_plane_t *primary;
 
 	int ret = 0;
 
-	igt_require_intel(data->drm_fd);
-	igt_skip_on(data->display_ver < 9);
+	igt_skip_on(is_i915_device(data->drm_fd) && data->display_ver < 9);
 	igt_require_pipe(&data->display, pipe);
 
 	igt_output_set_pipe(output, pipe);
@@ -787,10 +786,10 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
 			cursor_leak_test_pipe(data, pipe, output);
 
 	igt_describe("Check if pageflip succeeds in windowed setting");
-	igt_subtest_f("universal-plane-gen9-features-pipe-%s",
+	igt_subtest_f("universal-plane-pageflip-windowed-pipe-%s",
 		      kmstest_pipe_name(pipe))
 		for_each_valid_output_on_pipe(&data->display, pipe, output)
-			gen9_test_pipe(data, pipe, output);
+			pageflip_win_test_pipe(data, pipe, output);
 }
 
 static data_t data;
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-11-11 10:33 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-03 17:48 [igt-dev] [PATCH 1/2][V4] tests/kms_universal_plane: Enable gen9_test_pipe for all devices Alex Hung
2022-09-03 17:48 ` [igt-dev] [PATCH 2/2][V4] tests/kms_universal_plane: Skip offscreen test for universal API Alex Hung
2022-09-06 13:50   ` Mark Yacoub
2022-11-11 10:33   ` Ville Syrjälä
2022-09-03 18:34 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [1/2,V4] tests/kms_universal_plane: Enable gen9_test_pipe for all devices Patchwork
2022-09-03 22:50 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [1/2,V4] tests/kms_universal_plane: Enable gen9_test_pipe for all devices (rev2) Patchwork
2022-09-04  8:06 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-09-04  9:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-05  5:35 ` Patchwork
2022-09-05  6:18 ` Patchwork
2022-09-06  6:14 ` Patchwork
2022-09-06  7:01 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox