From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 20/23] lib/i915/perf: implement report accumulation for new format
Date: Tue, 20 Sep 2022 13:02:54 -0700 [thread overview]
Message-ID: <YyocbkpwzTuf/7ep@unerlige-ril> (raw)
In-Reply-To: <20220823183036.5270-21-umesh.nerlige.ramappa@intel.com>
On Tue, Aug 23, 2022 at 06:30:33PM +0000, Umesh Nerlige Ramappa wrote:
>From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
>Available on XEHPSDV+.
>
>Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Thanks,
Umesh
>---
> lib/i915/perf.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
>diff --git a/lib/i915/perf.c b/lib/i915/perf.c
>index 2f24cbd8..d004313f 100644
>--- a/lib/i915/perf.c
>+++ b/lib/i915/perf.c
>@@ -676,6 +676,39 @@ void intel_perf_accumulate_reports(struct intel_perf_accumulator *acc,
> memset(acc, 0, sizeof(*acc));
>
> switch (oa_format) {
>+ case I915_OA_FORMAT_A24u40_A14u32_B8_C8:
>+ accumulate_uint32(start + 1, end + 1, deltas + idx++); /* timestamp */
>+ accumulate_uint32(start + 3, end + 3, deltas + idx++); /* clock */
>+
>+ /* 4x 32bit A0-3 counters... */
>+ for (i = 0; i < 4; i++)
>+ accumulate_uint32(start + 4 + i, end + 4 + i, deltas + idx++);
>+
>+ /* 20x 40bit A4-23 counters... */
>+ for (i = 0; i < 20; i++)
>+ accumulate_uint40(i + 4, start, end, deltas + idx++);
>+
>+ /* 4x 32bit A24-27 counters... */
>+ for (i = 0; i < 4; i++)
>+ accumulate_uint32(start + 28 + i, end + 28 + i, deltas + idx++);
>+
>+ /* 4x 40bit A28-31 counters... */
>+ for (i = 0; i < 4; i++)
>+ accumulate_uint40(i + 28, start, end, deltas + idx++);
>+
>+ /* 5x 32bit A32-36 counters... */
>+ for (i = 0; i < 5; i++)
>+ accumulate_uint32(start + 36 + i, end + 36 + i, deltas + idx++);
>+
>+ /* 1x 32bit A37 counter... */
>+ accumulate_uint32(start + 46, end + 46, deltas + idx++);
>+
>+ /* 8x 32bit B counters + 8x 32bit C counters... */
>+ for (i = 0; i < 16; i++)
>+ accumulate_uint32(start + 48 + i, end + 48 + i, deltas + idx++);
>+ break;
>+
>+ case I915_OAR_FORMAT_A32u40_A4u32_B8_C8:
> case I915_OA_FORMAT_A32u40_A4u32_B8_C8:
> accumulate_uint32(start + 1, end + 1, deltas + idx++); /* timestamp */
> accumulate_uint32(start + 3, end + 3, deltas + idx++); /* clock */
>--
>2.25.1
>
next prev parent reply other threads:[~2022-09-20 20:03 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 18:30 [igt-dev] [PATCH i-g-t 00/23] Add DG2 OA test Umesh Nerlige Ramappa
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 01/23] i915/perf: Check regularly if we are done reading reports Umesh Nerlige Ramappa
2022-09-06 12:49 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 02/23] i915/perf: Fix OA short_reads test Umesh Nerlige Ramappa
2022-09-06 12:50 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 03/23] i915/perf: Check return value from getparam Umesh Nerlige Ramappa
2022-09-06 12:52 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 04/23] i915/perf: Limit sseu-config tests for gen11 Umesh Nerlige Ramappa
2022-09-06 12:53 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 05/23] i915/perf: Bump timestamp tolerance for DG1 Umesh Nerlige Ramappa
2022-09-06 13:06 ` Lionel Landwerlin
2022-09-06 19:30 ` Umesh Nerlige Ramappa
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 06/23] i915/perf: Account for OA sampling interval in polling test Umesh Nerlige Ramappa
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 07/23] i915/perf: Add support for 64-bit counters Umesh Nerlige Ramappa
2022-09-06 13:05 ` Lionel Landwerlin
2022-09-06 19:37 ` Umesh Nerlige Ramappa
2022-09-06 20:02 ` Lionel Landwerlin
2022-09-06 20:58 ` Umesh Nerlige Ramappa
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 08/23] i915/perf: Define OA report types Umesh Nerlige Ramappa
2022-09-06 13:08 ` Lionel Landwerlin
2022-09-06 19:28 ` Umesh Nerlige Ramappa
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 09/23] i915/perf: Use ARRAY_SIZE consistently for num_properties Umesh Nerlige Ramappa
2022-09-06 13:10 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 10/23] i915/perf: Use gt in perf tests and lib Umesh Nerlige Ramappa
2022-09-06 13:13 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 11/23] i915/perf: Explicitly state rendercopy needs for a test Umesh Nerlige Ramappa
2022-09-06 13:26 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 12/23] i915/perf: Skip tests that use rendercopy Umesh Nerlige Ramappa
2022-09-06 13:28 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 13/23] i915/perf: Add OA formats for DG2 Umesh Nerlige Ramappa
2022-09-06 13:30 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 14/23] i915/perf: Add a test for non-power-of-2 oa reports Umesh Nerlige Ramappa
2022-09-06 14:08 ` Lionel Landwerlin
2022-09-20 19:28 ` Umesh Nerlige Ramappa
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 15/23] i915/perf: Fix CS timestamp vs OA timstamp mismatch Umesh Nerlige Ramappa
2022-09-06 13:36 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 16/23] i915/perf: Treat ticks as 64 bit Umesh Nerlige Ramappa
2022-09-06 14:08 ` Lionel Landwerlin
2022-09-06 18:56 ` Umesh Nerlige Ramappa
2022-09-06 19:06 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 17/23] i915/perf: Treat timestamp as 64 bit value Umesh Nerlige Ramappa
2022-09-06 14:16 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 18/23] i915/perf: Fix DG2 A0 report header Umesh Nerlige Ramappa
2022-09-06 14:17 ` Lionel Landwerlin
2022-09-06 18:37 ` Umesh Nerlige Ramappa
2022-09-06 18:54 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 19/23] i915/perf: Wait longer for rc6 residency in DG2 Umesh Nerlige Ramappa
2022-09-06 14:18 ` Lionel Landwerlin
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 20/23] lib/i915/perf: implement report accumulation for new format Umesh Nerlige Ramappa
2022-09-06 14:21 ` Lionel Landwerlin
2022-09-20 20:02 ` Umesh Nerlige Ramappa [this message]
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 21/23] lib/i915/perf: fixup conversion script for XEHPSDV Umesh Nerlige Ramappa
2022-09-20 20:03 ` Umesh Nerlige Ramappa
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 22/23] lib/i915/perf: make warning message more helpful Umesh Nerlige Ramappa
2022-09-20 20:04 ` Umesh Nerlige Ramappa
2022-08-23 18:30 ` [igt-dev] [PATCH i-g-t 23/23] lib/i915/perf: Add DG2 metrics Umesh Nerlige Ramappa
2022-09-20 23:11 ` Umesh Nerlige Ramappa
2022-08-23 20:30 ` [igt-dev] [PATCH i-g-t 18/23] i915/perf: Fix DG2 A0 report header Umesh Nerlige Ramappa
2022-09-06 14:23 ` Lionel Landwerlin
2022-09-06 18:33 ` Umesh Nerlige Ramappa
2022-08-23 21:00 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Add DG2 OA test Patchwork
2022-08-24 9:33 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Add DG2 OA test (rev2) Patchwork
2022-08-24 9:58 ` Petri Latvala
2022-08-24 13:08 ` [igt-dev] ✓ Fi.CI.BAT: success for Add DG2 OA test (rev3) Patchwork
2022-08-25 20:33 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-08-22 23:56 [igt-dev] [PATCH i-g-t 00/23] Add DG2 OA test Umesh Nerlige Ramappa
2022-08-22 23:56 ` [igt-dev] [PATCH i-g-t 20/23] lib/i915/perf: implement report accumulation for new format Umesh Nerlige Ramappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyocbkpwzTuf/7ep@unerlige-ril \
--to=umesh.nerlige.ramappa@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox