[PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count

[PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Preemption is not happening and getting failed at the check for long
kernel with current WMTP loop count. So, increasing the loop count.

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 lib/intel_compute.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/intel_compute.c b/lib/intel_compute.c
index 28149db53..76d435794 100644
--- a/lib/intel_compute.c
+++ b/lib/intel_compute.c
@@ -52,7 +52,7 @@
  * WMTP - Walker Mid Thread Preemption
  */
 #define TGP_long_kernel_loop_count		10
-#define WMTP_long_kernel_loop_count		1000000
+#define WMTP_long_kernel_loop_count		1500000
 
 struct bo_dict_entry {
 	uint64_t addr;
-- 
2.34.1

✓ Xe.CI.BAT: success for lib/intel_compute.c : Increase WMTP loop count

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

== Series Details ==

Series: lib/intel_compute.c : Increase WMTP loop count
URL   : https://patchwork.freedesktop.org/series/146706/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_8281_BAT -> XEIGTPW_12826_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (9 -> 9)
------------------------------

  No changes in participating hosts


Changes
-------

  No changes found


Build changes
-------------

  * IGT: IGT_8281 -> IGTPW_12826
  * Linux: xe-2842-9be2a7099019ef52d17cbc2b3e6ba15cd638ec2c -> xe-2844-9a42bdcde0f77b2c1e947e283cc3b267b1ce2056

  IGTPW_12826: 12826
  IGT_8281: 18c445bea641c03b637d7ed5bc3bd120b5d83b2a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-2842-9be2a7099019ef52d17cbc2b3e6ba15cd638ec2c: 9be2a7099019ef52d17cbc2b3e6ba15cd638ec2c
  xe-2844-9a42bdcde0f77b2c1e947e283cc3b267b1ce2056: 9a42bdcde0f77b2c1e947e283cc3b267b1ce2056

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_12826/index.html

[-- Attachment #2: Type: text/html, Size: 1629 bytes --]

✗ i915.CI.BAT: failure for lib/intel_compute.c : Increase WMTP loop count

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5743 bytes --]

== Series Details ==

Series: lib/intel_compute.c : Increase WMTP loop count
URL   : https://patchwork.freedesktop.org/series/146706/
State : failure

== Summary ==

CI Bug Log - changes from IGT_8281 -> IGTPW_12826
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_12826 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_12826, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/index.html

Participating hosts (41 -> 40)
------------------------------

  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_12826:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live:
    - bat-mtlp-8:         [PASS][1] -> [INCOMPLETE][2] +1 other test incomplete
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-mtlp-8/igt@i915_selftest@live.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-mtlp-8/igt@i915_selftest@live.html

  * igt@i915_selftest@live@hangcheck:
    - bat-twl-1:          [PASS][3] -> [INCOMPLETE][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-twl-1/igt@i915_selftest@live@hangcheck.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-twl-1/igt@i915_selftest@live@hangcheck.html

  * igt@kms_chamelium_edid@dp-edid-read:
    - bat-dg2-13:         [PASS][5] -> [FAIL][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-dg2-13/igt@kms_chamelium_edid@dp-edid-read.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-dg2-13/igt@kms_chamelium_edid@dp-edid-read.html

  * igt@kms_chamelium_edid@hdmi-edid-read:
    - bat-dg2-13:         [PASS][7] -> [ABORT][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-dg2-13/igt@kms_chamelium_edid@hdmi-edid-read.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-dg2-13/igt@kms_chamelium_edid@hdmi-edid-read.html

  
Known issues
------------

  Here are the changes found in IGTPW_12826 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live:
    - bat-twl-1:          [PASS][9] -> [INCOMPLETE][10] ([i915#13761] / [i915#13776])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-twl-1/igt@i915_selftest@live.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-twl-1/igt@i915_selftest@live.html
    - bat-twl-2:          [PASS][11] -> [INCOMPLETE][12] ([i915#12445] / [i915#13776])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-twl-2/igt@i915_selftest@live.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-twl-2/igt@i915_selftest@live.html

  * igt@i915_selftest@live@evict:
    - bat-twl-2:          [PASS][13] -> [INCOMPLETE][14] ([i915#12445])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-twl-2/igt@i915_selftest@live@evict.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-twl-2/igt@i915_selftest@live@evict.html

  
#### Possible fixes ####

  * igt@dmabuf@all-tests:
    - bat-apl-1:          [INCOMPLETE][15] ([i915#12904]) -> [PASS][16] +1 other test pass
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-apl-1/igt@dmabuf@all-tests.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-apl-1/igt@dmabuf@all-tests.html

  * igt@i915_selftest@live@late_gt_pm:
    - fi-cfl-8109u:       [DMESG-WARN][17] ([i915#13735]) -> [PASS][18] +132 other tests pass
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html

  * igt@i915_selftest@live@workarounds:
    - bat-arls-5:         [DMESG-FAIL][19] ([i915#12061]) -> [PASS][20] +1 other test pass
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-arls-5/igt@i915_selftest@live@workarounds.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-arls-5/igt@i915_selftest@live@workarounds.html
    - bat-arls-6:         [DMESG-FAIL][21] ([i915#12061]) -> [PASS][22] +1 other test pass
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8281/bat-arls-6/igt@i915_selftest@live@workarounds.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/bat-arls-6/igt@i915_selftest@live@workarounds.html

  
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#12445]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12445
  [i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
  [i915#13735]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13735
  [i915#13761]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13761
  [i915#13776]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13776


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_8281 -> IGTPW_12826
  * Linux: CI_DRM_16309 -> CI_DRM_16311

  CI-20190529: 20190529
  CI_DRM_16309: 9be2a7099019ef52d17cbc2b3e6ba15cd638ec2c @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_16311: 9a42bdcde0f77b2c1e947e283cc3b267b1ce2056 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_12826: 12826
  IGT_8281: 18c445bea641c03b637d7ed5bc3bd120b5d83b2a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_12826/index.html

[-- Attachment #2: Type: text/html, Size: 6824 bytes --]

Re: [PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count

[Francois Dugast]

Hi Priyanka,

On Tue, Mar 25, 2025 at 10:59:01AM +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Preemption is not happening and getting failed at the check for long
> kernel with current WMTP loop count. So, increasing the loop count.
> 
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
>  lib/intel_compute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 28149db53..76d435794 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -52,7 +52,7 @@
>   * WMTP - Walker Mid Thread Preemption
>   */
>  #define TGP_long_kernel_loop_count		10
> -#define WMTP_long_kernel_loop_count		1000000
> +#define WMTP_long_kernel_loop_count		1500000

I am still observing sporadic issues in compute-preempt-many with this
new value, but not with 2000000.

Francois

>  
>  struct bo_dict_entry {
>  	uint64_t addr;
> -- 
> 2.34.1
> 

RE: [PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count

[Dandamudi, Priyanka]

> -----Original Message-----
> From: Dugast, Francois <francois.dugast@intel.com>
> Sent: 25 March 2025 02:22 PM
> To: Dandamudi, Priyanka <priyanka.dandamudi@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count
> 
> Hi Priyanka,
> 
> On Tue, Mar 25, 2025 at 10:59:01AM +0530, priyanka.dandamudi@intel.com
> wrote:
> > From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> >
> > Preemption is not happening and getting failed at the check for long
> > kernel with current WMTP loop count. So, increasing the loop count.
> >
> > Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> > ---
> >  lib/intel_compute.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/intel_compute.c b/lib/intel_compute.c index
> > 28149db53..76d435794 100644
> > --- a/lib/intel_compute.c
> > +++ b/lib/intel_compute.c
> > @@ -52,7 +52,7 @@
> >   * WMTP - Walker Mid Thread Preemption
> >   */
> >  #define TGP_long_kernel_loop_count		10
> > -#define WMTP_long_kernel_loop_count		1000000
> > +#define WMTP_long_kernel_loop_count		1500000
> 
> I am still observing sporadic issues in compute-preempt-many with this new
> value, but not with 2000000.
Will send it with 2000000, but not sure if this can increase the Ci run time.
> 
> Francois
> 
> >
> >  struct bo_dict_entry {
> >  	uint64_t addr;
> > --
> > 2.34.1
> >

Re: [PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count

[Kamil Konieczny]

Hi priyanka.dandamudi,
On 2025-03-25 at 10:59:01 +0530, priyanka.dandamudi@intel.com wrote:

please improve subject a little:
[PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count
s/.c :/:/

into:
[PATCH i-g-t] lib/intel_compute: Increase WMTP loop count

Regards,
Kamil

> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Preemption is not happening and getting failed at the check for long
> kernel with current WMTP loop count. So, increasing the loop count.
> 
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
>  lib/intel_compute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 28149db53..76d435794 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -52,7 +52,7 @@
>   * WMTP - Walker Mid Thread Preemption
>   */
>  #define TGP_long_kernel_loop_count		10
> -#define WMTP_long_kernel_loop_count		1000000
> +#define WMTP_long_kernel_loop_count		1500000
>  
>  struct bo_dict_entry {
>  	uint64_t addr;
> -- 
> 2.34.1
> 

[PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Preemption is not happening and getting failed at the check for long
kernel with current WMTP loop count. So, increasing the loop count.

v2: Increase loop count to 2000000 to avoid sporadic failures.

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 lib/intel_compute.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/intel_compute.c b/lib/intel_compute.c
index 28149db53..9dbb38709 100644
--- a/lib/intel_compute.c
+++ b/lib/intel_compute.c
@@ -52,7 +52,7 @@
  * WMTP - Walker Mid Thread Preemption
  */
 #define TGP_long_kernel_loop_count		10
-#define WMTP_long_kernel_loop_count		1000000
+#define WMTP_long_kernel_loop_count		2000000
 
 struct bo_dict_entry {
 	uint64_t addr;
-- 
2.34.1

Re: [PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count

[Francois Dugast]

On Tue, Mar 25, 2025 at 07:28:17PM +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Preemption is not happening and getting failed at the check for long
> kernel with current WMTP loop count. So, increasing the loop count.
> 
> v2: Increase loop count to 2000000 to avoid sporadic failures.
> 
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

LGTM but let's make sure we get CI results before merging.

Also, please see Kamil's comment regarding the commit message.

With that:
    Reviewed-by: Francois Dugast <francois.dugast@intel.com>

Francois

> ---
>  lib/intel_compute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 28149db53..9dbb38709 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -52,7 +52,7 @@
>   * WMTP - Walker Mid Thread Preemption
>   */
>  #define TGP_long_kernel_loop_count		10
> -#define WMTP_long_kernel_loop_count		1000000
> +#define WMTP_long_kernel_loop_count		2000000
>  
>  struct bo_dict_entry {
>  	uint64_t addr;
> -- 
> 2.34.1
>