Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane: require GAMMA_LUT property for legacy_lut tests
@ 2023-04-24 17:24 Maíra Canal
  2023-04-24 17:44 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Maíra Canal @ 2023-04-24 17:24 UTC (permalink / raw)
  To: Melissa Wen, Petri Latvala, Kamil Konieczny, Juha-Pekka Heikkila; +Cc: igt-dev

Currently, the tests pixel-format and pixel-format-source-clamping
fail for drivers that doesn't have the IGT_CRTC_GAMMA_LUT property,
as they are not able to complete drmModeCrtcSetGamma() successfully.
Therefore, require the IGT_CRTC_GAMMA_LUT property before running the
tests. This way the tests can skip gracefully for drivers without
this property.

Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 tests/kms_plane.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 62aee9ad..a0e4e80f 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -451,6 +451,8 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
 	uint16_t *lut;
 	int i, lut_size;
 
+	igt_require(igt_pipe_obj_has_prop(pipe_obj, IGT_CRTC_GAMMA_LUT));
+
 	crtc = drmModeGetCrtc(data->drm_fd, pipe_obj->crtc_id);
 	lut_size = crtc->gamma_size;
 	drmModeFreeCrtc(crtc);
@@ -474,6 +476,8 @@ static bool set_c8_legacy_lut(data_t *data, enum pipe pipe,
 	uint16_t *r, *g, *b;
 	int i, lut_size;
 
+	igt_require(igt_pipe_obj_has_prop(pipe_obj, IGT_CRTC_GAMMA_LUT));
+
 	crtc = drmModeGetCrtc(data->drm_fd, pipe_obj->crtc_id);
 	lut_size = crtc->gamma_size;
 	drmModeFreeCrtc(crtc);
-- 
2.40.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-04-24 21:39 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-24 17:24 [igt-dev] [PATCH i-g-t] tests/kms_plane: require GAMMA_LUT property for legacy_lut tests Maíra Canal
2023-04-24 17:44 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2023-04-24 18:06 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-04-24 18:18 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2023-04-24 20:57   ` Maíra Canal
2023-04-24 21:22     ` Ville Syrjälä
2023-04-24 21:39 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox