Re: [PATCH i-g-t v2 14/14] tests/gem_draw: Test igt_draw without kms

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Oct 22, 2024 at 06:30:47PM +0200, Kamil Konieczny wrote:
> Hi Ville,
> On 2024-10-11 at 13:43:54 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> 
> This is intel specific so please use it in subject:
> 
> tests/intel/gem_draw: Test without kms
> 
> > kms_draw_crc is our only way to confirm that igt_draw
> > linear<->tiled conversion routines are correct. That may
> > not cover every case as we could be hitting display
> > specific limitations that prevent testing everything.
> > 
> > Introduce a new gem_draw test case that compares igt_draw
> > mmap/pwrite methods against GTT mmaps. This will verify that
> > the software conversion routines match the hardware (de)tiling
> > peformed via the fenced region.
> > 
> > TODO: could verify against blt/rendercopy
> >       when gtt mmaps are not available...
> > 
> > v2: Drop the "driver requirement: i915" to make it past
> >     the documentation build scripts
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  tests/intel/gem_draw.c | 233 +++++++++++++++++++++++++++++++++++++++++
> >  tests/meson.build      |   1 +
> >  2 files changed, 234 insertions(+)
> >  create mode 100644 tests/intel/gem_draw.c
> > 
> > diff --git a/tests/intel/gem_draw.c b/tests/intel/gem_draw.c
> > new file mode 100644
> > index 000000000000..86df7c33ff2d
> > --- /dev/null
> > +++ b/tests/intel/gem_draw.c
> > @@ -0,0 +1,233 @@
> > +// SPDX-License-Identifier: MIT
> > +/*
> > + * Copyright © 2024 Intel Corporation
> > + */
> > +
> > +/**
> > + * TEST: gem draw
> > + * Category: GEM
> > + * Description: Tests whether the igt_draw library actually works.
> > + * Functionality: tiling
> 
> Add here 'Mega feature:'

I have no idea what that is.

-- 
Ville Syrjälä
Intel