Re: [PATCH i-g-t 07/14] lib/igt_draw: Add 64bpp support to the XY_FAST_COLOR_BLT path

[Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>]

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 4.10.2024 13.41, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> XY_FAST_COLOR_BLT supports 64bpp natively. Simply enable it.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>   lib/igt_draw.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_draw.c b/lib/igt_draw.c
> index 93924ece8250..2312a0c71030 100644
> --- a/lib/igt_draw.c
> +++ b/lib/igt_draw.c
> @@ -789,7 +789,8 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
>   			blt_cmd_depth = 2 << 19;
>   			break;
>   		case 64:
> -			/* Not used or supported yet */
> +			blt_cmd_depth = 3 << 19;
> +			break;
>   		default:
>   			igt_assert(false);
>   		}
> @@ -824,7 +825,7 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
>   					   dst->addr.offset);
>   		intel_bb_out(ibb, 0);	/* TODO: Pass down enough info for target memory hint */
>   		intel_bb_out(ibb, color);
> -		intel_bb_out(ibb, 0);	/* 64 bit color */
> +		intel_bb_out(ibb, color >> 32);	/* 64 bit color */
>   		intel_bb_out(ibb, 0);	/* 96 bit color */
>   		intel_bb_out(ibb, 0);	/* 128 bit color */
>   		intel_bb_out(ibb, 0);	/* clear address */