Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] lib/amd: check output has hpd before trigger hotplug
@ 2024-03-21  2:03 Alex Hung
  2024-03-21  2:03 ` [PATCH 2/2] tests/amdgpu/amd_vrr_range: Skip on unsupported connector types Alex Hung
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Alex Hung @ 2024-03-21  2:03 UTC (permalink / raw)
  To: igt-dev; +Cc: rodrigo.siqueira, harry.wentland, hersenxs.wu, Alex Hung

With commit ff1d9a601 writeback connector will be enabled and it has no
hotplug capability. As a result, this function always fails for such
cases. This is fixed by checking HDP in advance.

Signed-off-by: Alex Hung <alex.hung@amd.com>
---
 lib/igt_amd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/igt_amd.c b/lib/igt_amd.c
index d0b53c08a..623883dbc 100644
--- a/lib/igt_amd.c
+++ b/lib/igt_amd.c
@@ -799,6 +799,9 @@ int igt_amd_trigger_hotplug(int drm_fd, char *connector_name)
         int wr_len;
         const char *enable_hpd = "1";
 
+	if (!igt_amd_output_has_hpd(drm_fd, connector_name))
+		return 0;
+
         fd = igt_debugfs_connector_dir(drm_fd, connector_name, O_RDONLY);
         igt_assert(fd >= 0);
         hpd_fd = openat(fd, DEBUGFS_HPD_TRIGGER, O_WRONLY);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-03-22 11:10 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-21  2:03 [PATCH 1/2] lib/amd: check output has hpd before trigger hotplug Alex Hung
2024-03-21  2:03 ` [PATCH 2/2] tests/amdgpu/amd_vrr_range: Skip on unsupported connector types Alex Hung
2024-03-21 13:59   ` Harry Wentland
2024-03-21  3:30 ` ✓ CI.xeBAT: success for series starting with [1/2] lib/amd: check output has hpd before trigger hotplug Patchwork
2024-03-21  3:42 ` ✓ Fi.CI.BAT: " Patchwork
2024-03-21 13:56 ` [PATCH 1/2] " Harry Wentland
2024-03-22  1:11 ` ✗ Fi.CI.IGT: failure for series starting with [1/2] " Patchwork
2024-03-22 11:10   ` Kamil Konieczny
2024-03-22  3:29 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] lib/amd: check output has hpd before trigger hotplug (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox